NodeFunction::getNode() - Code Metrics - Inspection of "Cleanup" - nicoSWD/php-rule-parser - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e2bb59...e124f5 )

by Nico

created 2017-10-17 20:37 UTC

NodeFunction::getNode() A

↳ Parent: NodeFunction

Complexity

Conditions	3
Paths	3

Size

Total Lines	22
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	22
ccs	12
cts	12
cp	1
rs	9.2
c	0
b	0
f	0
cc	3
eloc	12
nc	3
nop	0
crap	3

<?php

declare(strict_types=1);

/**
 * @license     http://opensource.org/licenses/mit-license.php MIT
 * @link        https://github.com/nicoSWD
 * @author      Nicolas Oelgart <[email protected]>
 */
namespace nicoSWD\Rules\AST\Nodes;

use nicoSWD\Rules\Core\CallableFunction;
use nicoSWD\Rules\Exceptions\ParserException;
use nicoSWD\Rules\Tokens\BaseToken;

final class NodeFunction extends BaseNode
{
    public function getNode(): BaseToken
    {
        $current = $this->ast->getStack()->current();
        $function = $this->resolveFunctionName($current);
        $class = $this->resolveClassName($function);

        if (!class_exists($class)) {
            return $this->ast->parser->getFunction($function)->call($this, ...$this->getArguments());
        }

        /** @var CallableFunction $instance */
        $instance = new $class($current);

        if ($instance->getName() !== $function) {
            throw new ParserException(sprintf(
                '%s is not defined',
                $function
            ));
        }

        return $instance->call(...$this->getArguments());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    private function resolveClassName(string $class): string
    {
        return '\nicoSWD\Rules\Core\Functions\\' . ucfirst($class);
    }

    private function resolveFunctionName(BaseToken $token): string
    {
        return rtrim($token->getValue(), " \r\n(");
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		/**
6		* @license http://opensource.org/licenses/mit-license.php MIT
7		* @link https://github.com/nicoSWD
8		* @author Nicolas Oelgart <[email protected]>
9		*/
10		namespace nicoSWD\Rules\AST\Nodes;
11
12		use nicoSWD\Rules\Core\CallableFunction;
13		use nicoSWD\Rules\Exceptions\ParserException;
14		use nicoSWD\Rules\Tokens\BaseToken;
15
16		final class NodeFunction extends BaseNode
17		{
18	30	public function getNode(): BaseToken
19		{
20	30	$current = $this->ast->getStack()->current();
21	30	$function = $this->resolveFunctionName($current);
22	30	$class = $this->resolveClassName($function);
23
24	30	if (!class_exists($class)) {
25	6	return $this->ast->parser->getFunction($function)->call($this, ...$this->getArguments());
26		}
27
28		/** @var CallableFunction $instance */
29	24	$instance = new $class($current);
30
31	24	if ($instance->getName() !== $function) {
32	2	throw new ParserException(sprintf(
33	2	'%s is not defined',
34	2	$function
35		));
36		}
37
38	22	return $instance->call(...$this->getArguments());
		0 ignored issues – show Documentation introduced 2017-01-29 20:38 UTC by Report Bug Copy Issue Report `$this->getArguments()` is of type `object<nicoSWD\Rules\AST\TokenCollection>`, but the function expects a `object<nicoSWD\Rules\Tokens\BaseToken>\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
39		}
40
41	30	private function resolveClassName(string $class): string
42		{
43	30	return '\nicoSWD\Rules\Core\Functions\\' . ucfirst($class);
44		}
45
46	30	private function resolveFunctionName(BaseToken $token): string
47		{
48	30	return rtrim($token->getValue(), " \r\n(");
49		}
50		}
51

nicoSWD / php-rule-parser

Push — master ( e2bb59...e124f5 )

NodeFunction::getNode() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like