NodeFunction::getNode() - Code Metrics - Inspection of "PHP7-master" - nicoSWD/php-rule-parser - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#4)

by Nico

created 2017-01-29 20:48 UTC

NodeFunction::getNode() B

↳ Parent: NodeFunction

Complexity

Conditions	4
Paths	4

Size

Total Lines	29
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	14
CRAP Score	4

Importance

Changes

Metric	Value
dl	0
loc	29
ccs	14
cts	14
cp	1
rs	8.5806
c	0
b	0
f	0
cc	4
eloc	16
nc	4
nop	0
crap	4

<?php

/**
 * @license     http://opensource.org/licenses/mit-license.php MIT
 * @link        https://github.com/nicoSWD
 * @author      Nicolas Oelgart <[email protected]>
 */
declare(strict_types=1);

namespace nicoSWD\Rules\AST\Nodes;

use nicoSWD\Rules\Core\CallableFunction;
use nicoSWD\Rules\Exceptions\ParserException;
use nicoSWD\Rules\Tokens\BaseToken;

final class NodeFunction extends BaseNode
{
    /**
     * @throws ParserException
     */
    public function getNode() : BaseToken
    {
        $current = $this->ast->getStack()->current();
        $function = $this->resolveFunctionName($current);
        $class = $this->resolveClassName($function);

        if (!class_exists($class)) {
            if (!$userFunction = $this->ast->parser->getFunction($function)) {
                throw new ParserException(sprintf(
                    '%s is not defined',
                    $function
                ));
            }

            return $userFunction->call($this, ...$this->getArguments());
        }

        /** @var CallableFunction $instance */
        $instance = new $class($current);

        if ($instance->getName() !== $function) {
            throw new ParserException(sprintf(
                '%s is not defined',
                $function
            ));
        }

        return $instance->call(...$this->getArguments());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    private function resolveClassName(string $class) : string
    {
        return '\nicoSWD\Rules\Core\Functions\\' . ucfirst($class);
    }

    private function resolveFunctionName(BaseToken $token) : string
    {
        return rtrim($token->getValue(), " \r\n(");
    }
}


1		<?php
2
3		/**
4		* @license http://opensource.org/licenses/mit-license.php MIT
5		* @link https://github.com/nicoSWD
6		* @author Nicolas Oelgart <[email protected]>
7		*/
8		declare(strict_types=1);
9
10		namespace nicoSWD\Rules\AST\Nodes;
11
12		use nicoSWD\Rules\Core\CallableFunction;
13		use nicoSWD\Rules\Exceptions\ParserException;
14		use nicoSWD\Rules\Tokens\BaseToken;
15
16		final class NodeFunction extends BaseNode
17		{
18		/**
19		* @throws ParserException
20		*/
21		public function getNode() : BaseToken
22		{
23		$current = $this->ast->getStack()->current();
24		$function = $this->resolveFunctionName($current);
25	22	$class = $this->resolveClassName($function);
26
27	22	if (!class_exists($class)) {
28	22	if (!$userFunction = $this->ast->parser->getFunction($function)) {
29	22	throw new ParserException(sprintf(
30		'%s is not defined',
31	22	$function
32	2	));
33	2	}
34
35	2	return $userFunction->call($this, ...$this->getArguments());
36		}
37
38		/** @var CallableFunction $instance */
39	20	$instance = new $class($current);
40
41	20	if ($instance->getName() !== $function) {
42	2	throw new ParserException(sprintf(
43	2	'%s is not defined',
44		$function
45	2	));
46		}
47
48	18	return $instance->call(...$this->getArguments());
		0 ignored issues – show Documentation introduced 2017-01-29 20:38 UTC by Report Bug Copy Issue Report `$this->getArguments()` is of type `object<nicoSWD\Rules\AST\TokenCollection>`, but the function expects a `object<nicoSWD\Rules\Tokens\BaseToken>\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
49		}
50
51		private function resolveClassName(string $class) : string
52		{
53		return '\nicoSWD\Rules\Core\Functions\\' . ucfirst($class);
54		}
55
56		private function resolveFunctionName(BaseToken $token) : string
57		{
58		return rtrim($token->getValue(), " \r\n(");
59		}
60		}
61

nicoSWD / php-rule-parser

Pull Request — master (#4)

NodeFunction::getNode() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like