HomeController::__construct() - Code Metrics - Inspection of "Merge pull request #15 from micheleorselli/fix_scr..." - niclasleonbock/hacktoberfest-status - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 06396b...c3acb5 )

by Niclas Leon

created 2017-10-07 16:27 UTC

HomeController::__construct() A

↳ Parent: HomeController

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	1
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php

namespace App\Http\Controllers;

use Auth;
use App\Hacktoberfest\GitHub\PullRequestChecker;

class HomeController extends Controller
{
    /**
     * Instance of the 'pull request checker'.
     */
    protected $checker;

    /**
     * Create a new controller instance.
     *
     * @param PullRequestChecker $checker
     * @internal param PullRequestChecker $prChecker
     */
    public function __construct(PullRequestChecker $checker)
    {
        $this->checker = $checker;
    }

    /**
     * Display the current status if the user already signed in via GitHubs' OAuth API.
     * Display some infotext and the sign in button otherwise.
     *
     * @return Illuminate\View\View

     */
    public function index()
    {
        if (Auth::check()) {
            $user = Auth::user();

            $prs = $this->checker->getQualifiedPullRequests($user);

            return view('status', [

                'user' => $user,
                'prs' => $prs
            ]);
        }

        return view('index');

    }
}


1			<?php
2
3			namespace App\Http\Controllers;
4
5			use Auth;
6			use App\Hacktoberfest\GitHub\PullRequestChecker;
7
8			class HomeController extends Controller
9			{
10			/**
11			* Instance of the 'pull request checker'.
12			*/
13			protected $checker;
14
15			/**
16			* Create a new controller instance.
17			*
18			* @param PullRequestChecker $checker
19			* @internal param PullRequestChecker $prChecker
20			*/
21			public function __construct(PullRequestChecker $checker)
22			{
23			$this->checker = $checker;
24			}
25
26			/**
27			* Display the current status if the user already signed in via GitHubs' OAuth API.
28			* Display some infotext and the sign in button otherwise.
29			*
30			* @return Illuminate\View\View
			0 ignored issues – show Bug introduced 2017-10-07 16:25 UTC by Report Bug Copy Issue Report The type `App\Http\Controllers\Illuminate\View\View` was not found. Did you mean `Illuminate\View\View`? If so, make sure to prefix the type with `\`. Loading history...
31			*/
32			public function index()
33			{
34			if (Auth::check()) {
35			$user = Auth::user();
36
37			$prs = $this->checker->getQualifiedPullRequests($user);
38
39			return view('status', [
			0 ignored issues – show Bug Best Practice introduced 2017-10-07 16:25 UTC by Report Bug Copy Issue Report The expression `return view('status', ar... $user, 'prs' => $prs))` returns the type `Illuminate\View\View` which is incompatible with the documented return type `App\Http\Controllers\Illuminate\View\View`. Loading history...
40			'user' => $user,
41			'prs' => $prs
42			]);
43			}
44
45			return view('index');
			0 ignored issues – show Bug Best Practice introduced 2017-10-07 16:25 UTC by Report Bug Copy Issue Report The expression `return view('index')` returns the type `Illuminate\View\View` which is incompatible with the documented return type `App\Http\Controllers\Illuminate\View\View`. Loading history...
46			}
47			}
48

niclasleonbock / hacktoberfest-status

Push — develop ( 06396b...c3acb5 )

HomeController::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like