Completed
Push — master ( c88f25...77d6c6 )
by Nicholas
01:02
created

Lookup   A

Complexity

Total Complexity 11

Size/Duplication

Total Lines 112
Duplicated Lines 18.75 %

Coupling/Cohesion

Components 1
Dependencies 0

Importance

Changes 0
Metric Value
wmc 11
lcom 1
cbo 0
dl 21
loc 112
rs 10
c 0
b 0
f 0

8 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 7 2
A Verify() 0 16 1
A CityState() 10 10 1
A CityStateMultiple() 0 14 2
A ZipCode() 0 13 1
A Track() 0 9 1
A TrackMultiple() 11 11 2
A GetRate() 0 18 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace Nickcheek\USPSLookup;
4
5
class Lookup
6
{
7
8
	protected  $user;
9
10
	public function __construct($user = '')
11
	{
12
		$this->user = $user;
13
		if($user == ''){
14
			$this->user = env('USPS');
15
		}
16
	}
17
18
    public function Verify($address,$address2,$city,$state,$zip)
19
    {
20
	    $Address = new \SimpleXMLElement("<AddressValidateRequest></AddressValidateRequest>");
21
		$Address->addAttribute('USERID', $this->user);
22
		$Address->addChild('Revision','1');
23
		$add = $Address->addChild('Address');
24
		$add->addAttribute('ID', '0');
25
		$add->addChild('Address1',$address);
26
		$add->addChild('Address2',$address2);
27
		$add->addChild('City',$city);
28
		$add->addChild('State',$state);
29
		$add->addChild('Zip5',$zip);
30
		$add->addChild('Zip4');
31
		$url = 'http://production.shippingapis.com/ShippingAPITest.dll?API=Verify&XML='.$Address->asXML();
32
		return simplexml_load_file($url);
33
	}
34
35 View Code Duplication
	public function CityState($zip)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
36
    {
37
	    $CityState = new \SimpleXMLElement("<CityStateLookupRequest></CityStateLookupRequest>");
38
		$CityState->addAttribute('USERID', $this->user);
39
		$ZipCode = $CityState->addChild('ZipCode');
40
		$ZipCode->addAttribute('ID', '0');
41
		$ZipCode->addChild('Zip5',$zip);
42
		$url = 'http://production.shippingapis.com/ShippingAPITest.dll?API=CityStateLookup&XML='.$CityState->asXML();
43
		return simplexml_load_file($url);
44
	}
45
46
	public function CityStateMultiple($zip)
47
    {
48
	    $CityState = new \SimpleXMLElement("<CityStateLookupRequest></CityStateLookupRequest>");
49
		$CityState->addAttribute('USERID', $this->user);
50
51
		foreach($zip as $k=>$z){
52
			$ZipCode = $CityState->addChild('ZipCode');
53
			$ZipCode->addAttribute('ID', $k);
54
			$ZipCode->addChild('Zip5',$z);
55
		}
56
57
		$url = 'http://production.shippingapis.com/ShippingAPITest.dll?API=CityStateLookup&XML='.$CityState->asXML();
58
		return simplexml_load_file($url);
59
	}
60
61
	public function ZipCode($address,$address2,$city,$state)
62
	{
63
		$Address = new \SimpleXMLElement("<ZipCodeLookupRequest></ZipCodeLookupRequest>");
64
		$Address->addAttribute('USERID', $this->user);
65
		$add = $Address->addChild('Address');
66
		$add->addAttribute('ID', '0');
67
		$add->addChild('Address1',$address);
68
		$add->addChild('Address2',$address2);
69
		$add->addChild('City',$city);
70
		$add->addChild('State',$state);
71
		$url = 'http://production.shippingapis.com/ShippingAPITest.dll?API=ZipCodeLookup&XML='.$Address->asXML();
72
		return simplexml_load_file($url);
73
	}
74
75
	public function Track($trackingnumber)
76
	{
77
		$track = new \SimpleXMLElement("<TrackRequest></TrackRequest>");
78
		$track->addAttribute('USERID', $this->user);
79
		$pack = $track->addChild('TrackID');
80
		$pack->addAttribute('ID', $trackingnumber);
81
		$url = 'https://secure.shippingapis.com/ShippingAPI.dll?API=TrackV2&XML='.$track->asXML();
82
		return simplexml_load_file($url);
83
	}
84
85 View Code Duplication
	public function TrackMultiple($trackingarray)
86
	{
87
		$mtrack = new \SimpleXMLElement("<TrackRequest></TrackRequest>");
88
		$mtrack->addAttribute('USERID', $this->user);
89
		foreach($trackingarray as $trackingnumber){
90
			$pack = $mtrack->addChild('TrackID');
91
			$pack->addAttribute('ID', $trackingnumber);
92
		}
93
		$url = 'https://secure.shippingapis.com/ShippingAPI.dll?API=TrackV2&XML='.$mtrack->asXML();
94
		return simplexml_load_file($url);
95
	}
96
97
	public  function GetRate($to,$from,$pounds,$ounces,$service)
98
	{
99
		$rate = new \SimpleXMLElement("<RateV4Request></RateV4Request>");
100
		$rate->addAttribute('USERID', $this->user);
101
		$rate->addChild("Revision",'2');
102
		$pack = $rate->addChild('Package');
103
		$pack->addAttribute('ID','0');
104
		$pack->addChild('Service',$service);
105
		$pack->addChild('ZipOrigination',$from);
106
		$pack->addChild('ZipDestination',$to);
107
		$pack->addChild('Pounds',$pounds);
108
		$pack->addChild('Ounces',$ounces);
109
		$pack->addChild('Container','VARIABLE');
110
		$pack->addChild('Size','Regular');
111
112
		$url = 'https://secure.shippingapis.com/ShippingAPI.dll?API=RateV4&XML='.$rate->asXML();
113
		return simplexml_load_file($url);
114
	}
115
116
}
117