NULLRepository::getByCodepoints() - Code Metrics - Inspection of "Hack to get PhpSpec working with PHP7 removed." - nick-jones/php-ucd - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ff3008...d4aa5e )

by Nicholas

created 2016-02-02 17:28 UTC

NULLRepository::getByCodepoints() A

↳ Parent: NULLRepository

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php

namespace UCD\Infrastructure\Repository\CharacterRepository;

use UCD\Unicode\Character;
use UCD\Unicode\Character\Collection as CharacterCollection;
use UCD\Unicode\Codepoint;
use UCD\Unicode\Character\Repository\CharacterNotFoundException;
use UCD\Unicode\Character\WritableRepository;
use UCD\Unicode\Character\Repository;

class NULLRepository implements WritableRepository
{
    use Repository\Capability\Notify;
    use Repository\Capability\BlockSearchByIteration;

    /**
     * {@inheritDoc}
     */
    public function getByCodepoint(Codepoint $codepoint)
    {
        throw CharacterNotFoundException::withCodepoint($codepoint);
    }

    /**
     * {@inheritDoc}
     */
    public function getByCodepoints(Codepoint\Collection $codepoints)
    {
        return Character\Collection::fromArray([]);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * {@inheritDoc}
     */
    public function addMany(CharacterCollection $characters)
    {
        $this->notify();
    }

    /**
     * {@inheritDoc}
     */
    public function getAll()
    {
        return CharacterCollection::fromArray([]);
    }

    /**
     * {@inheritDoc}
     */
    public function count()
    {
        return 0;
    }
}

1			<?php
2
3			namespace UCD\Infrastructure\Repository\CharacterRepository;
4
5			use UCD\Unicode\Character;
6			use UCD\Unicode\Character\Collection as CharacterCollection;
7			use UCD\Unicode\Codepoint;
8			use UCD\Unicode\Character\Repository\CharacterNotFoundException;
9			use UCD\Unicode\Character\WritableRepository;
10			use UCD\Unicode\Character\Repository;
11
12			class NULLRepository implements WritableRepository
13			{
14			use Repository\Capability\Notify;
15			use Repository\Capability\BlockSearchByIteration;
16
17			/**
18			* {@inheritDoc}
19			*/
20			public function getByCodepoint(Codepoint $codepoint)
21			{
22			throw CharacterNotFoundException::withCodepoint($codepoint);
23			}
24
25			/**
26			* {@inheritDoc}
27			*/
28			public function getByCodepoints(Codepoint\Collection $codepoints)
29			{
30			return Character\Collection::fromArray([]);
			0 ignored issues – show Bug Best Practice introduced 2016-02-02 17:31 UTC by Report Bug Copy Issue Report The return type of `return \UCD\Unicode\Char...on::fromArray(array());` (`UCD\Unicode\Character\Collection`) is incompatible with the return type declared by the interface `UCD\Unicode\Character\Repository::getByCodepoints` of type `UCD\Unicode\CodepointAssigned[]`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
31			}
32
33			/**
34			* {@inheritDoc}
35			*/
36			public function addMany(CharacterCollection $characters)
37			{
38			$this->notify();
39			}
40
41			/**
42			* {@inheritDoc}
43			*/
44			public function getAll()
45			{
46			return CharacterCollection::fromArray([]);
47			}
48
49			/**
50			* {@inheritDoc}
51			*/
52			public function count()
53			{
54			return 0;
55			}
56			}

nick-jones / php-ucd

GitHub Access Token became invalid

Push — master ( ff3008...d4aa5e )

NULLRepository::getByCodepoints() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like