AggregatorRelay::getAllRanges() - Code Metrics - Inspection of "Added methods to resolve characters residing in a..." - nick-jones/php-ucd - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 61bf69...3a1917 )

by Nicholas

created 2016-02-05 18:16 UTC

AggregatorRelay::getAllRanges() A

↳ Parent: AggregatorRelay

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	10
rs	9.4285
cc	2
eloc	5
nc	2
nop	0

<?php

namespace UCD\Unicode\Codepoint;

use UCD\Exception\InvalidArgumentException;

use UCD\Unicode\Codepoint\Aggregator\Factory;
use UCD\Unicode\Codepoint\AggregatorRelay\KeyGenerator;
use UCD\Unicode\CodepointAssigned;

class AggregatorRelay
{
    /**
     * @var KeyGenerator
     */
    private $keyGenerator;

    /**
     * @var Aggregator[]
     */
    private $aggregators = [];

    /**
     * @param KeyGenerator $keyGenerator
     * @param Factory $aggregatorFactory
     */
    public function __construct(KeyGenerator $keyGenerator, Factory $aggregatorFactory)
    {
        $this->keyGenerator = $keyGenerator;
        $this->aggregatorFactory = $aggregatorFactory;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * @param CodepointAssigned $entity
     * @throws InvalidArgumentException
     */
    public function add(CodepointAssigned $entity)
    {
        $aggregator = $this->getAggregatorFor($entity);
        $aggregator->addCodepoint($entity->getCodepoint());
    }

    /**
     * @param CodepointAssigned[] $entities
     */
    public function addMany(array $entities)
    {
        foreach ($entities as $entity) {
            $this->add($entity);
        }
    }

    /**
     * @param CodepointAssigned $entity
     * @return Aggregator
     */
    protected function getAggregatorFor(CodepointAssigned $entity)
    {
        $key = $this->keyGenerator->generateFor($entity);

        if (!array_key_exists($key, $this->aggregators)) {
            $this->aggregators[$key] = $this->aggregatorFactory->create();
        }

        return $this->aggregators[$key];
    }

    /**
     * @return Aggregator[]
     */
    public function getAll()
    {
        return $this->aggregators;
    }

    /**
     * @return Range\Collection[]
     */
    public function getAllRanges()
    {
        $ranges = [];

        foreach ($this->aggregators as $key => $aggregator) {
            $ranges[$key] = $aggregator->getAggregated();
        }

        return $ranges;
    }
}

1			<?php
2
3			namespace UCD\Unicode\Codepoint;
4
5			use UCD\Exception\InvalidArgumentException;
6
7			use UCD\Unicode\Codepoint\Aggregator\Factory;
8			use UCD\Unicode\Codepoint\AggregatorRelay\KeyGenerator;
9			use UCD\Unicode\CodepointAssigned;
10
11			class AggregatorRelay
12			{
13			/**
14			* @var KeyGenerator
15			*/
16			private $keyGenerator;
17
18			/**
19			* @var Aggregator[]
20			*/
21			private $aggregators = [];
22
23			/**
24			* @param KeyGenerator $keyGenerator
25			* @param Factory $aggregatorFactory
26			*/
27			public function __construct(KeyGenerator $keyGenerator, Factory $aggregatorFactory)
28			{
29			$this->keyGenerator = $keyGenerator;
30			$this->aggregatorFactory = $aggregatorFactory;
			0 ignored issues – show Bug introduced 2016-01-28 19:56 UTC by Report Bug Copy Issue Report The property `aggregatorFactory` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
31			}
32
33			/**
34			* @param CodepointAssigned $entity
35			* @throws InvalidArgumentException
36			*/
37			public function add(CodepointAssigned $entity)
38			{
39			$aggregator = $this->getAggregatorFor($entity);
40			$aggregator->addCodepoint($entity->getCodepoint());
41			}
42
43			/**
44			* @param CodepointAssigned[] $entities
45			*/
46			public function addMany(array $entities)
47			{
48			foreach ($entities as $entity) {
49			$this->add($entity);
50			}
51			}
52
53			/**
54			* @param CodepointAssigned $entity
55			* @return Aggregator
56			*/
57			protected function getAggregatorFor(CodepointAssigned $entity)
58			{
59			$key = $this->keyGenerator->generateFor($entity);
60
61			if (!array_key_exists($key, $this->aggregators)) {
62			$this->aggregators[$key] = $this->aggregatorFactory->create();
63			}
64
65			return $this->aggregators[$key];
66			}
67
68			/**
69			* @return Aggregator[]
70			*/
71			public function getAll()
72			{
73			return $this->aggregators;
74			}
75
76			/**
77			* @return Range\Collection[]
78			*/
79			public function getAllRanges()
80			{
81			$ranges = [];
82
83			foreach ($this->aggregators as $key => $aggregator) {
84			$ranges[$key] = $aggregator->getAggregated();
85			}
86
87			return $ranges;
88			}
89			}

nick-jones / php-ucd

GitHub Access Token became invalid

Push — master ( 61bf69...3a1917 )

AggregatorRelay::getAllRanges() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like