XMLReader::__construct() - Code Metrics - nick-jones/php-ucd - Measure and Improve Code Quality continuously with Scrutinizer

XMLReader::__construct() A
last analyzed 2017-12-01 22:57 UTC

↳ Parent: XMLReader

Complexity

Conditions	3
Paths	3

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	12
rs	9.4285
cc	3
eloc	6
nc	3
nop	3

<?php

namespace UCD\Infrastructure\Repository\CharacterRepository\XMLRepository;

use UCD\Exception\InvalidArgumentException;
use UCD\Exception\RuntimeException;

class XMLReader extends \XMLReader
{
    /**
     * @var string
     */
    private $openUri;

    /**
     * @var string|null
     */
    private $openEncoding;

    /**
     * @var int
     */
    private $openOptions;

    /**
     * @param string $uri
     * @param string|null $encoding
     * @param int $options
     * @throws InvalidArgumentException
     * @throws RuntimeException
     */
    public function __construct($uri, $encoding = null, $options = 0)
    {
        if (!is_readable($uri)) {
            throw new InvalidArgumentException(sprintf('Invalid URI: %s', $uri));
        }

        $result = $this->open($uri, $encoding, $options);

        if ($result !== true) {
            throw new RuntimeException(sprintf('Could not open %s', $uri));
        }
    }

    /**
     * {@inheritDoc}
     */
    public function open($uri, $encoding = null, $options = 0)
    {
        $this->openUri = $uri;
        $this->openEncoding = $encoding;
        $this->openOptions = $options;

        return parent::open($uri, $encoding, $options);
    }

    /**
     * @return bool
     */
    public function reopen()
    {
        return parent::open($this->openUri, $this->openEncoding, $this->openOptions);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }
} 

1			<?php
2
3			namespace UCD\Infrastructure\Repository\CharacterRepository\XMLRepository;
4
5			use UCD\Exception\InvalidArgumentException;
6			use UCD\Exception\RuntimeException;
7
8			class XMLReader extends \XMLReader
9			{
10			/**
11			* @var string
12			*/
13			private $openUri;
14
15			/**
16			* @var string\|null
17			*/
18			private $openEncoding;
19
20			/**
21			* @var int
22			*/
23			private $openOptions;
24
25			/**
26			* @param string $uri
27			* @param string\|null $encoding
28			* @param int $options
29			* @throws InvalidArgumentException
30			* @throws RuntimeException
31			*/
32			public function __construct($uri, $encoding = null, $options = 0)
33			{
34			if (!is_readable($uri)) {
35			throw new InvalidArgumentException(sprintf('Invalid URI: %s', $uri));
36			}
37
38			$result = $this->open($uri, $encoding, $options);
39
40			if ($result !== true) {
41			throw new RuntimeException(sprintf('Could not open %s', $uri));
42			}
43			}
44
45			/**
46			* {@inheritDoc}
47			*/
48			public function open($uri, $encoding = null, $options = 0)
49			{
50			$this->openUri = $uri;
51			$this->openEncoding = $encoding;
52			$this->openOptions = $options;
53
54			return parent::open($uri, $encoding, $options);
55			}
56
57			/**
58			* @return bool
59			*/
60			public function reopen()
61			{
62			return parent::open($this->openUri, $this->openEncoding, $this->openOptions);
			0 ignored issues – show Comprehensibility Bug introduced 2016-01-28 19:56 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`open()` instead of `reopen()`). Are you sure this is correct? If so, you might want to change this to `$this->open()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
63			}
64			}

nick-jones / php-ucd

GitHub Access Token became invalid

XMLReader::__construct() A last analyzed 2017-12-01 22:57 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

XMLReader::__construct() A
last analyzed 2017-12-01 22:57 UTC