Complex classes like AbstractElement often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use AbstractElement, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 8 | abstract class AbstractElement |
||
| 9 | { |
||
| 10 | /** |
||
| 11 | * @var Collection|iterable $classes Коллекция классом элемента |
||
| 12 | */ |
||
| 13 | protected $classes; |
||
| 14 | |||
| 15 | /** |
||
| 16 | * @var Collection|iterable $attributes Коллекция дополнительных атрибутов элемента |
||
| 17 | */ |
||
| 18 | protected $attributes; |
||
| 19 | |||
| 20 | /** |
||
| 21 | * @var Collection|iterable $styles Коллекция inline-стилей элемента |
||
| 22 | */ |
||
| 23 | protected $styles; |
||
| 24 | |||
| 25 | /** |
||
| 26 | * @var string $value Значение элемента |
||
| 27 | */ |
||
| 28 | protected $value; |
||
| 29 | |||
| 30 | /** |
||
| 31 | * @var string $tag Тег элемента |
||
| 32 | */ |
||
| 33 | protected $tag; |
||
| 34 | |||
| 35 | /** |
||
| 36 | * @var Collection|iterable $parts Набор атрибутов для генерации html-кода элементов |
||
| 37 | */ |
||
| 38 | protected $parts; |
||
| 39 | |||
| 40 | /** |
||
| 41 | * @var bool $needClose Признак, что надо закрывать тег элемента |
||
| 42 | */ |
||
| 43 | protected $needClose = false; |
||
| 44 | |||
| 45 | /** |
||
| 46 | * @return void |
||
| 47 | */ |
||
| 48 | abstract public function tag(); |
||
| 49 | |||
| 50 | public function __construct() |
||
| 62 | |||
| 63 | /** |
||
| 64 | * Сеттер значения элемента |
||
| 65 | * |
||
| 66 | * @param string|null $value |
||
| 67 | * @return AbstractElement |
||
| 68 | */ |
||
| 69 | public function value(?string $value): self |
||
| 75 | |||
| 76 | /** |
||
| 77 | * Сеттер атрибута id элемента |
||
| 78 | * |
||
| 79 | * @param string|null $value |
||
| 80 | * @return AbstractElement |
||
| 81 | */ |
||
| 82 | public function id(?string $value): self |
||
| 88 | |||
| 89 | /** |
||
| 90 | * Сеттер атрибута name элемента |
||
| 91 | * |
||
| 92 | * @param string|null $value |
||
| 93 | * @return AbstractElement |
||
| 94 | */ |
||
| 95 | public function name(?string $value): self |
||
| 101 | |||
| 102 | /** |
||
| 103 | * Добавить элементу один или несколько классов |
||
| 104 | * |
||
| 105 | * @param array ...$classes |
||
| 106 | * @return AbstractElement |
||
| 107 | */ |
||
| 108 | public function class(...$classes): self |
||
| 114 | |||
| 115 | /** |
||
| 116 | * Добавить элементу один или несколько классов из массива |
||
| 117 | * |
||
| 118 | * @param iterable $classes |
||
| 119 | * @return AbstractElement |
||
| 120 | */ |
||
| 121 | public function classes(iterable $classes): self |
||
| 131 | |||
| 132 | /** |
||
| 133 | * Добавить к элементу один или несколько inline-стилей |
||
| 134 | * |
||
| 135 | * @param string $key |
||
| 136 | * @param string|null $value |
||
| 137 | * @return AbstractElement |
||
| 138 | */ |
||
| 139 | public function style(string $key, string $value = null): self |
||
| 156 | |||
| 157 | /** |
||
| 158 | * Добавить к элементу один или несколько inline-стилей из массива |
||
| 159 | * |
||
| 160 | * @param iterable $styles |
||
| 161 | * @return AbstractElement |
||
| 162 | */ |
||
| 163 | public function styles(iterable $styles): self |
||
| 171 | |||
| 172 | /** |
||
| 173 | * Добавить аттрибут к элементу |
||
| 174 | * |
||
| 175 | * @param string $key |
||
| 176 | * @param mixed $value |
||
| 177 | * @return AbstractElement |
||
| 178 | */ |
||
| 179 | public function attr(string $key, $value = null): self |
||
| 185 | |||
| 186 | /** |
||
| 187 | * Добавить один или несколько атрибутов из массива к элементу |
||
| 188 | * |
||
| 189 | * @param iterable $attributes |
||
| 190 | * @return AbstractElement |
||
| 191 | */ |
||
| 192 | public function attrs(iterable $attributes): self |
||
| 206 | |||
| 207 | /** |
||
| 208 | * Очистить классы элемента |
||
| 209 | * |
||
| 210 | * @return AbstractElement |
||
| 211 | */ |
||
| 212 | public function clearClasses(): self |
||
| 218 | |||
| 219 | /** |
||
| 220 | * Очистить классы стили |
||
| 221 | * |
||
| 222 | * @return AbstractElement |
||
| 223 | */ |
||
| 224 | public function clearStyles(): self |
||
| 230 | |||
| 231 | /** |
||
| 232 | * Очистить классы атрибуты |
||
| 233 | * |
||
| 234 | * @return AbstractElement |
||
| 235 | */ |
||
| 236 | public function clearAttributes(): self |
||
| 242 | |||
| 243 | protected function render(): string |
||
| 249 | |||
| 250 | protected function beforeToParts(): void |
||
| 254 | |||
| 255 | protected function afterToParts(): void |
||
| 259 | |||
| 260 | /** |
||
| 261 | * Преобразовать в строку для вывода в HTML |
||
| 262 | * |
||
| 263 | * @return string |
||
| 264 | */ |
||
| 265 | public function __toString(): string |
||
| 279 | |||
| 280 | protected function generateAttributes(): string |
||
| 295 | |||
| 296 | protected function stylesToParts(): void |
||
| 309 | |||
| 310 | protected function classesToParts(): void |
||
| 316 | |||
| 317 | public function attributesToParts(): void |
||
| 323 | |||
| 324 | protected function addAttr(...$names): self |
||
| 334 | |||
| 335 | protected function addAttrAs(...$names): self |
||
| 345 | } |