Complex classes like AbstractElement often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use AbstractElement, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 10 | abstract class AbstractElement |
||
| 11 | { |
||
| 12 | /** |
||
| 13 | * @var Collection|iterable $classes Коллекция классом элемента |
||
| 14 | */ |
||
| 15 | public $classes; |
||
| 16 | |||
| 17 | /** |
||
| 18 | * @var Collection|iterable $attributes Коллекция дополнительных атрибутов элемента |
||
| 19 | */ |
||
| 20 | public $attributes; |
||
| 21 | |||
| 22 | /** |
||
| 23 | * @var Collection|iterable $styles Коллекция inline-стилей элемента |
||
| 24 | */ |
||
| 25 | public $styles; |
||
| 26 | |||
| 27 | /** |
||
| 28 | * @var string $value Значение элемента |
||
| 29 | */ |
||
| 30 | public $value; |
||
| 31 | |||
| 32 | /** |
||
| 33 | * @var string $tag Тег элемента |
||
| 34 | */ |
||
| 35 | protected $tag; |
||
| 36 | |||
| 37 | /** |
||
| 38 | * @var Collection|iterable $parts Набор атрибутов для генерации html-кода элементов |
||
| 39 | */ |
||
| 40 | public $parts; |
||
| 41 | |||
| 42 | /** |
||
| 43 | * @var string $label |
||
| 44 | */ |
||
| 45 | public $label; |
||
| 46 | |||
| 47 | /** |
||
| 48 | * @var string $help |
||
| 49 | */ |
||
| 50 | public $help; |
||
| 51 | |||
| 52 | /** |
||
| 53 | * @var AbstractLayout |
||
| 54 | */ |
||
| 55 | public $layout; |
||
| 56 | |||
| 57 | public $onlyTagRender = false; |
||
| 58 | |||
| 59 | /** |
||
| 60 | * @return void |
||
| 61 | */ |
||
| 62 | abstract public function tag(); |
||
| 63 | |||
| 64 | public function __construct() |
||
| 76 | |||
| 77 | public function layout(?AbstractLayout $layout): self |
||
| 83 | |||
| 84 | /** |
||
| 85 | * Сеттер значения лейбла для элемента |
||
| 86 | * |
||
| 87 | * @param string|null $value |
||
| 88 | * @return AbstractElement |
||
| 89 | */ |
||
| 90 | public function label(?string $value): self |
||
| 96 | |||
| 97 | /** |
||
| 98 | * Сеттер значения подсказки для элемента |
||
| 99 | * |
||
| 100 | * @param string|null $value |
||
| 101 | * @return AbstractElement |
||
| 102 | */ |
||
| 103 | public function help(?string $value): self |
||
| 109 | |||
| 110 | /** |
||
| 111 | * Сеттер значения элемента |
||
| 112 | * |
||
| 113 | * @param string|null $value |
||
| 114 | * @return AbstractElement |
||
| 115 | */ |
||
| 116 | public function value(?string $value): self |
||
| 122 | |||
| 123 | /** |
||
| 124 | * Сеттер атрибута id элемента |
||
| 125 | * |
||
| 126 | * @param string|null $value |
||
| 127 | * @return AbstractElement |
||
| 128 | */ |
||
| 129 | public function id(?string $value): self |
||
| 135 | |||
| 136 | /** |
||
| 137 | * Сеттер атрибута name элемента |
||
| 138 | * |
||
| 139 | * @param string|null $value |
||
| 140 | * @return AbstractElement |
||
| 141 | */ |
||
| 142 | public function name(?string $value): self |
||
| 148 | |||
| 149 | /** |
||
| 150 | * Добавить элементу один или несколько классов |
||
| 151 | * |
||
| 152 | * @param array ...$classes |
||
| 153 | * @return AbstractElement |
||
| 154 | */ |
||
| 155 | public function class(...$classes): self |
||
| 161 | |||
| 162 | /** |
||
| 163 | * Добавить элементу один или несколько классов из массива |
||
| 164 | * |
||
| 165 | * @param iterable $classes |
||
| 166 | * @return AbstractElement |
||
| 167 | */ |
||
| 168 | public function classes(iterable $classes): self |
||
| 178 | |||
| 179 | /** |
||
| 180 | * Добавить к элементу один или несколько inline-стилей |
||
| 181 | * |
||
| 182 | * @param string $key |
||
| 183 | * @param string|null $value |
||
| 184 | * @return AbstractElement |
||
| 185 | */ |
||
| 186 | public function style(string $key, string $value = null): self |
||
| 203 | |||
| 204 | /** |
||
| 205 | * Добавить к элементу один или несколько inline-стилей из массива |
||
| 206 | * |
||
| 207 | * @param iterable $styles |
||
| 208 | * @return AbstractElement |
||
| 209 | */ |
||
| 210 | public function styles(iterable $styles): self |
||
| 218 | |||
| 219 | /** |
||
| 220 | * Добавить аттрибут к элементу |
||
| 221 | * |
||
| 222 | * @param string $key |
||
| 223 | * @param string|null $value |
||
| 224 | * @return AbstractElement |
||
| 225 | */ |
||
| 226 | public function attr(string $key, $value = null): self |
||
| 232 | |||
| 233 | /** |
||
| 234 | * Добавить один или несколько атрибутов из массива к элементу |
||
| 235 | * |
||
| 236 | * @param iterable $attributes |
||
| 237 | * @return AbstractElement |
||
| 238 | */ |
||
| 239 | public function attrs(iterable $attributes): self |
||
| 253 | |||
| 254 | /** |
||
| 255 | * Очистить классы элемента |
||
| 256 | * |
||
| 257 | * @return AbstractElement |
||
| 258 | */ |
||
| 259 | public function clearClasses(): self |
||
| 265 | |||
| 266 | /** |
||
| 267 | * Очистить классы стили |
||
| 268 | * |
||
| 269 | * @return AbstractElement |
||
| 270 | */ |
||
| 271 | public function clearStyles(): self |
||
| 277 | |||
| 278 | /** |
||
| 279 | * Очистить классы атрибуты |
||
| 280 | * |
||
| 281 | * @return AbstractElement |
||
| 282 | */ |
||
| 283 | public function clearAttributes(): self |
||
| 289 | |||
| 290 | public function getTagHtml() |
||
| 294 | |||
| 295 | public function beforeToParts(): void |
||
| 296 | { |
||
| 297 | $this->addAttr('value'); |
||
| 298 | |||
| 299 | if (is_null($this->layout) === false && $this->layout->getElementClasses() && !in_array($this->getClassName(), $this->layout->skipElementClasses)) { |
||
| 300 | $this->class($this->layout->getElementClasses()); |
||
| 301 | } |
||
| 302 | } |
||
| 303 | |||
| 304 | public function afterToParts(): void |
||
| 310 | |||
| 311 | public function getClassName($strToLower = false): string |
||
| 315 | |||
| 316 | /** |
||
| 317 | * Преобразовать в строку для вывода в HTML |
||
| 318 | * |
||
| 319 | * @return string |
||
| 320 | */ |
||
| 321 | public function __toString(): string |
||
| 325 | |||
| 326 | protected function addAttr(...$names): self |
||
| 336 | |||
| 337 | protected function addAttrAs(...$names): self |
||
| 347 | } |