Complex classes like AbstractElement often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use AbstractElement, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
10 | abstract class AbstractElement |
||
11 | { |
||
12 | /** |
||
13 | * @var Collection|iterable $classes Коллекция классом элемента |
||
14 | */ |
||
15 | public $classes; |
||
16 | |||
17 | /** |
||
18 | * @var Collection|iterable $attributes Коллекция дополнительных атрибутов элемента |
||
19 | */ |
||
20 | public $attributes; |
||
21 | |||
22 | /** |
||
23 | * @var Collection|iterable $styles Коллекция inline-стилей элемента |
||
24 | */ |
||
25 | public $styles; |
||
26 | |||
27 | /** |
||
28 | * @var string $value Значение элемента |
||
29 | */ |
||
30 | public $value; |
||
31 | |||
32 | /** |
||
33 | * @var string $tag Тег элемента |
||
34 | */ |
||
35 | protected $tag; |
||
36 | |||
37 | /** |
||
38 | * @var Collection|iterable $parts Набор атрибутов для генерации html-кода элементов |
||
39 | */ |
||
40 | public $parts; |
||
41 | |||
42 | /** |
||
43 | * @var string $label |
||
44 | */ |
||
45 | public $label; |
||
46 | |||
47 | /** |
||
48 | * @var string $help |
||
49 | */ |
||
50 | public $help; |
||
51 | |||
52 | /** |
||
53 | * @var AbstractProvider |
||
54 | */ |
||
55 | public $layout; |
||
56 | |||
57 | public $onlyTagRender = false; |
||
58 | |||
59 | /** |
||
60 | * Генерировать значение атрибутом |
||
61 | * |
||
62 | * @var bool |
||
63 | */ |
||
64 | protected $valueAsAttribute = true; |
||
65 | |||
66 | /** |
||
67 | * @return void |
||
68 | */ |
||
69 | abstract public function tag(); |
||
70 | |||
71 | public function __construct() |
||
83 | |||
84 | public function layout(?AbstractProvider $layout): self |
||
90 | |||
91 | /** |
||
92 | * Сеттер значения лейбла для элемента |
||
93 | * |
||
94 | * @param string|null $value |
||
95 | * @return AbstractElement |
||
96 | */ |
||
97 | public function label(?string $value): self |
||
103 | |||
104 | /** |
||
105 | * Сеттер значения подсказки для элемента |
||
106 | * |
||
107 | * @param string|null $value |
||
108 | * @return AbstractElement |
||
109 | */ |
||
110 | public function help(?string $value): self |
||
116 | |||
117 | /** |
||
118 | * Сеттер значения элемента |
||
119 | * |
||
120 | * @param string|null $value |
||
121 | * @return AbstractElement |
||
122 | */ |
||
123 | public function value(?string $value): self |
||
129 | |||
130 | /** |
||
131 | * Сеттер атрибута id элемента |
||
132 | * |
||
133 | * @param string|null $value |
||
134 | * @return AbstractElement |
||
135 | */ |
||
136 | public function id(?string $value): self |
||
142 | |||
143 | /** |
||
144 | * Сеттер атрибута name элемента |
||
145 | * |
||
146 | * @param string|null $value |
||
147 | * @return AbstractElement |
||
148 | */ |
||
149 | public function name(?string $value): self |
||
155 | |||
156 | /** |
||
157 | * Добавить элементу один или несколько классов |
||
158 | * |
||
159 | * @param array ...$classes |
||
160 | * @return AbstractElement |
||
161 | */ |
||
162 | public function class(...$classes): self |
||
168 | |||
169 | /** |
||
170 | * Добавить элементу один или несколько классов из массива |
||
171 | * |
||
172 | * @param iterable $classes |
||
173 | * @return AbstractElement |
||
174 | */ |
||
175 | public function classes(iterable $classes): self |
||
185 | |||
186 | /** |
||
187 | * Добавить к элементу один или несколько inline-стилей |
||
188 | * |
||
189 | * @param string $key |
||
190 | * @param string|null $value |
||
191 | * @return AbstractElement |
||
192 | */ |
||
193 | public function style(string $key, string $value = null): self |
||
210 | |||
211 | /** |
||
212 | * Добавить к элементу один или несколько inline-стилей из массива |
||
213 | * |
||
214 | * @param iterable $styles |
||
215 | * @return AbstractElement |
||
216 | */ |
||
217 | public function styles(iterable $styles): self |
||
225 | |||
226 | /** |
||
227 | * Добавить аттрибут к элементу |
||
228 | * |
||
229 | * @param string $key |
||
230 | * @param string|null $value |
||
231 | * @return AbstractElement |
||
232 | */ |
||
233 | public function attr(string $key, $value = null): self |
||
239 | |||
240 | /** |
||
241 | * Добавить один или несколько атрибутов из массива к элементу |
||
242 | * |
||
243 | * @param iterable $attributes |
||
244 | * @return AbstractElement |
||
245 | */ |
||
246 | public function attrs(iterable $attributes): self |
||
260 | |||
261 | /** |
||
262 | * Очистить классы элемента |
||
263 | * |
||
264 | * @return AbstractElement |
||
265 | */ |
||
266 | public function clearClasses(): self |
||
272 | |||
273 | /** |
||
274 | * Очистить классы стили |
||
275 | * |
||
276 | * @return AbstractElement |
||
277 | */ |
||
278 | public function clearStyles(): self |
||
284 | |||
285 | /** |
||
286 | * Очистить классы атрибуты |
||
287 | * |
||
288 | * @return AbstractElement |
||
289 | */ |
||
290 | public function clearAttributes(): self |
||
296 | |||
297 | public function getTagHtml() |
||
301 | |||
302 | public function beforeCommonPrepareToRender(): void |
||
318 | |||
319 | public function beforeElementPrepareToRender(): void |
||
323 | |||
324 | public function afterCommonPrepareToRender(): void |
||
333 | |||
334 | public function afterElementPrepareToRender(): void |
||
338 | |||
339 | public function getLowerClassName(): string |
||
343 | |||
344 | public function getClassName(): string |
||
348 | |||
349 | /** |
||
350 | * Преобразовать в строку для вывода в HTML |
||
351 | * |
||
352 | * @return string |
||
353 | */ |
||
354 | public function __toString(): string |
||
358 | |||
359 | protected function addAttrAs(...$names): self |
||
369 | } |