Ngtfkx\Laradeck\Commands\DownloadCommand

Complexity

Total Complexity

7

Size/Duplication

Total Lines	68
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	handle()	0	14	1
A	getFileNameWithPath()	0	4	1
A	getFilePath()	0	4	2
A	getFileName()	0	4	2

<?php

namespace Ngtfkx\Laradeck\Commands;

use Illuminate\Console\Command;
use Illuminate\Support\Facades\Storage;

class DownloadCommand extends Command
{
    protected $signature = 'laradeck:download 
                            {url} 
                            {--name= : Save file with name} 
                            {--path= : Path relative storage/app}';

    protected $description = 'Download file';

    /**
     * @var string
     */
    protected $url;

    /**
     * @var string
     */
    protected $file;

    /**
     * @var string
     */
    protected $path;

    public function __construct()
    {
        parent::__construct();
    }

    public function handle()
    {
        $this->url = $this->argument('url');

It seems like $this->argument('url') can also be of type array. However, the property $url is declared as type string. Maybe add an additional type check?

        $this->file = $this->getFileName();

        $this->path = $this->getFilePath();

        $resource = fopen($this->url, 'r');

        Storage::put($this->getFileNameWithPath(), $resource);

        fclose($resource);
    }

    /**
     * @return string
     */
    protected function getFileNameWithPath(): string
    {
        return $this->path . DIRECTORY_SEPARATOR . $this->file;
    }

    /**
     * @return string
     */
    protected function getFilePath(): string
    {
        return $this->option('path') ?: '';
    }

    /**
     * @return string
     */
    protected function getFileName(): string
    {
        return $this->option('name') ?: array_slice(explode('/', $this->url), -1)[0];
    }
}