ngodingbang /
laravel-stisla-starter
| Conditions | 12 |
| Paths | 1 |
| Total Lines | 41 |
| Code Lines | 25 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 156 |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 12 | function terbilang($value): string |
||
| 13 | { |
||
| 14 | $result = value(function () use ($value) { |
||
| 15 | $angka = ['', 'satu', 'dua', 'tiga', 'empat', 'lima', 'enam', 'tujuh', 'delapan', 'sembilan', 'sepuluh', 'sebelas']; |
||
| 16 | |||
| 17 | $number = abs($value); |
||
| 18 | |||
| 19 | switch (true) { |
||
| 20 | case $number < 12: |
||
| 21 | return ' ' . $angka[$number]; |
||
| 22 | |||
| 23 | case $number < 20: |
||
| 24 | return terbilang($number - 10) . ' belas'; |
||
| 25 | |||
| 26 | case $number < 100: |
||
| 27 | return terbilang($number / 10) . ' puluh ' . terbilang($number % 10); |
||
| 28 | |||
| 29 | case $number < 200: |
||
| 30 | return 'seratus ' . terbilang($number - 100); |
||
| 31 | |||
| 32 | case $number < 1000: |
||
| 33 | return terbilang($number / 100) . ' ratus ' . terbilang($number % 100); |
||
| 34 | |||
| 35 | case $number < 2000: |
||
| 36 | return 'seribu ' . terbilang($number - 1000); |
||
| 37 | |||
| 38 | case $number < 1000000: |
||
| 39 | return terbilang($number / 1000) . ' ribu ' . terbilang($number % 1000); |
||
| 40 | |||
| 41 | case $number < 1000000000: |
||
| 42 | return terbilang($number / 1000000) . ' juta ' . terbilang($number % 1000000); |
||
| 43 | |||
| 44 | case $number < 1000000000000: |
||
| 45 | return terbilang($number / 1000000000) . ' milyar ' . terbilang($number % 1000000000); |
||
| 46 | |||
| 47 | case $number < 1000000000000000: |
||
| 48 | return terbilang($number / 1000000000000) . ' trilyun ' . terbilang($number % 1000000000000); |
||
| 49 | } |
||
| 50 | }); |
||
| 51 | |||
| 52 | return trim(($value < 0 ? 'minus ' : '') . $result); |
||
|
Bug
introduced
by
|
|||
| 53 | } |
||
| 101 |
Loading history...