TraitS1005 - Code Metrics - Inspection of "Merge pull request #306 from robmachado/master" - nfephp-org/sped-esocial - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( ce467a...63d89e )

by Roberto

created 2021-05-14 14:21 UTC

TraitS1005 B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	494
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
wmc	45
lcom	1
cbo	0
dl	0
loc	494
rs	8.8
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
F	toNode250()	0	263	23
F	toNodeS100()	0	221	22

How to fix Complexity

<?php

namespace NFePHP\eSocial\Factories\Traits;

trait TraitS1005
{
    /**
     * builder for version 2.5.0
     */
    protected function toNode250()
    {
        $ideEmpregador = $this->node->getElementsByTagName('ideEmpregador')->item(0);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        //o idEvento pode variar de evento para evento
        //então cada factory individualmente terá de construir o seu
        $ideEvento = $this->dom->createElement("ideEvento");
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->dom->addChild(
            $ideEvento,
            "tpAmb",
            $this->tpAmb,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            true
        );
        $this->dom->addChild(
            $ideEvento,
            "procEmi",
            $this->procEmi,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            true
        );
        $this->dom->addChild(
            $ideEvento,
            "verProc",
            $this->verProc,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            true
        );
        $this->node->insertBefore($ideEvento, $ideEmpregador);

        //tag deste evento em particular
        $infoEstab = $this->dom->createElement("infoEstab");
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        //tag comum a todos os modos
        $ideEstab = $this->dom->createElement("ideEstab");
        $this->dom->addChild(
            $ideEstab,
            "tpInsc",
            $this->std->tpinsc,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            true
        );
        $this->dom->addChild(
            $ideEstab,
            "nrInsc",
            $this->std->nrinsc,
            true
        );
        $this->dom->addChild(
            $ideEstab,
            "iniValid",
            $this->std->inivalid,
            true
        );
        $this->dom->addChild(
            $ideEstab,
            "fimValid",
            ! empty($this->std->fimvalid) ? $this->std->fimvalid : null,
            false
        );

        if ($this->std->modo == 'INC') {
            $node = $this->dom->createElement("inclusao");
        } elseif ($this->std->modo == 'ALT') {
            $node = $this->dom->createElement("alteracao");
        } else {
            $node = $this->dom->createElement("exclusao");
        }
        $node->appendChild($ideEstab);

        if (! empty($this->std->dadosestab)) {
            $dadosEstab = $this->dom->createElement("dadosEstab");
            $this->dom->addChild(
                $dadosEstab,
                "cnaePrep",
                $this->std->dadosestab->cnaeprep,
                true
            );
            $aliqGilrat = $this->dom->createElement("aliqGilrat");
            $this->dom->addChild(
                $aliqGilrat,
                "aliqRat",
                $this->std->dadosestab->aliqgilrat->aliqrat,
                true
            );
            $fap = ! empty($this->std->dadosestab->aliqgilrat->fap) ? $this->std->dadosestab->aliqgilrat->fap : null;
            if ($fap) {
                $fap = number_format($fap, 4, '.', '');
            }
            $this->dom->addChild(
                $aliqGilrat,
                "fap",
                $fap,
                false
            );
            $aliqrata = ! empty($this->std->dadosestab->aliqgilrat->aliqratajust)
                ? $this->std->dadosestab->aliqgilrat->aliqratajust
                : null;
            if ($aliqrata) {
                $aliqrata = number_format($aliqrata, 4, '.', '');
            }
            $this->dom->addChild(
                $aliqGilrat,
                "aliqRatAjust",
                $aliqrata,
                false
            );
            if (! empty($this->std->dadosestab->aliqgilrat->procadmjudrat)) {
                $procAdmJudRat = $this->dom->createElement("procAdmJudRat");
                $this->dom->addChild(
                    $procAdmJudRat,
                    "tpProc",
                    $this->std->dadosestab->aliqgilrat->procadmjudrat->tpproc,
                    true
                );
                $this->dom->addChild(
                    $procAdmJudRat,
                    "nrProc",
                    $this->std->dadosestab->aliqgilrat->procadmjudrat->nrproc,
                    true
                );
                $this->dom->addChild(
                    $procAdmJudRat,
                    "codSusp",
                    $this->std->dadosestab->aliqgilrat->procadmjudrat->codsusp,
                    true
                );
                $aliqGilrat->appendChild($procAdmJudRat);
            }
            if (! empty($this->std->dadosestab->aliqgilrat->procadmjudfap)) {
                $procAdmJudFap = $this->dom->createElement("procAdmJudFap");
                $this->dom->addChild(
                    $procAdmJudFap,
                    "tpProc",
                    $this->std->dadosestab->aliqgilrat->procadmjudfap->tpproc,
                    true
                );
                $this->dom->addChild(
                    $procAdmJudFap,
                    "nrProc",
                    $this->std->dadosestab->aliqgilrat->procadmjudfap->nrproc,
                    true
                );
                $this->dom->addChild(
                    $procAdmJudFap,
                    "codSusp",
                    $this->std->dadosestab->aliqgilrat->procadmjudfap->codsusp,
                    true
                );
                $aliqGilrat->appendChild($procAdmJudFap);
            }
            $dadosEstab->appendChild($aliqGilrat);

            if (! empty($this->std->dadosestab->infocaepf)) {
                $infoCaepf = $this->dom->createElement("infoCaepf");
                $this->dom->addChild(
                    $infoCaepf,
                    "tpCaepf",
                    $this->std->dadosestab->infocaepf->tpcaepf,
                    true
                );
                $dadosEstab->appendChild($infoCaepf);
            }

            if (! empty($this->std->dadosestab->infoobra)) {
                $infoObra = $this->dom->createElement("infoObra");
                $this->dom->addChild(
                    $infoObra,
                    "indSubstPatrObra",
                    $this->std->dadosestab->infoobra->indsubstpatrobra,
                    true
                );
                $dadosEstab->appendChild($infoObra);
            }
            
            $infoTrab = $this->dom->createElement("infoTrab");
            $this->dom->addChild(
                $infoTrab,
                "regPt",
                $this->std->dadosestab->infotrab->regpt,
                true
            );
            if (! empty($this->std->dadosestab->infoapr)) {
                $infoApr = $this->dom->createElement("infoApr");
                $this->dom->addChild(
                    $infoApr,
                    "contApr",
                    $this->std->dadosestab->infotrab->infoapr->contapr,
                    true
                );
                $this->dom->addChild(
                    $infoApr,
                    "nrProcJud",
                    ! empty($this->std->dadosestab->infotrab->infoapr->nrprocjud)
                        ? $this->std->dadosestab->infotrab->infoapr->nrprocjud
                        : null,
                    false
                );
                $this->dom->addChild(
                    $infoApr,
                    "contEntEd",
                    ! empty($this->std->dadosestab->infotrab->infoapr->contented)
                        ? $this->std->dadosestab->infotrab->infoapr->contented
                        : null,
                    false
                );

                if (! empty($this->std->dadosestab->infotrab->infoapr->infoenteduc)) {
                    foreach ($this->std->dadosestab->infotrab->infoapr->infoenteduc as $edu) {
                        $infoEntEduc = $this->dom->createElement("infoEntEduc");
                        $this->dom->addChild(
                            $infoEntEduc,
                            "nrInsc",
                            $edu->nrinsc,
                            true
                        );
                        $infoApr->appendChild($infoEntEduc);
                    }
                }

                $infoTrab->appendChild($infoApr);
            }
            if (! empty($this->std->dadosestab->infotrab->infopdc)) {
                $infoPCD = $this->dom->createElement("infoPCD");
                $this->dom->addChild(
                    $infoPCD,
                    "contPCD",
                    $this->std->dadosestab->infotrab->infopdc->contpdc,
                    true
                );
                $this->dom->addChild(
                    $infoPCD,
                    "nrProcJud",
                    ! empty($this->std->dadosestab->infotrab->infopdc->nrprocjud)
                        ? $this->std->dadosestab->infotrab->infopdc->nrprocjud
                        : null,
                    false
                );
                $infoTrab->appendChild($infoPCD);
            }
            $dadosEstab->appendChild($infoTrab);
            $node->appendChild($dadosEstab);
        }

        if (! empty($this->std->novavalidade) && $this->std->modo == 'ALT') {
            $newVal = $this->std->novavalidade;
            $novaValidade = $this->dom->createElement("novaValidade");
            $this->dom->addChild(
                $novaValidade,
                "iniValid",
                $newVal->inivalid,
                true
            );
            $this->dom->addChild(
                $novaValidade,
                "fimValid",
                ! empty($newVal->fimvalid) ? $newVal->fimvalid : null,
                false
            );
            $node->appendChild($novaValidade);
        }
        $infoEstab = $this->dom->createElement("infoEstab");
        $infoEstab->appendChild($node);
        //finalização do xml
        $this->node->appendChild($infoEstab);
        $this->eSocial->appendChild($this->node);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->sign();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
    
    /**
     * builder for version S.1.0.0
     */
    protected function toNodeS100()
    {
        $ideEmpregador = $this->node->getElementsByTagName('ideEmpregador')->item(0);
        //o idEvento pode variar de evento para evento
        //então cada factory individualmente terá de construir o seu
        $ideEvento = $this->dom->createElement("ideEvento");
        $this->dom->addChild(
            $ideEvento,
            "tpAmb",
            $this->tpAmb,
            true
        );
        $this->dom->addChild(
            $ideEvento,
            "procEmi",
            $this->procEmi,
            true
        );
        $this->dom->addChild(
            $ideEvento,
            "verProc",
            $this->verProc,
            true
        );
        $this->node->insertBefore($ideEvento, $ideEmpregador);

        //tag deste evento em particular
        $infoEstab = $this->dom->createElement("infoEstab");
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        //tag comum a todos os modos
        $ideEstab = $this->dom->createElement("ideEstab");
        $this->dom->addChild(
            $ideEstab,
            "tpInsc",
            $this->std->tpinsc,
            true
        );
        $this->dom->addChild(
            $ideEstab,
            "nrInsc",
            $this->std->nrinsc,
            true
        );
        $this->dom->addChild(
            $ideEstab,
            "iniValid",
            $this->std->inivalid,
            true
        );
        if ($this->std->modo !== 'INC') {
            $this->dom->addChild(
                $ideEstab,
                "fimValid",
                !empty($this->std->fimvalid) ? $this->std->fimvalid : null,
                false
            );
        }

        if ($this->std->modo == 'INC') {
            $node = $this->dom->createElement("inclusao");
        } elseif ($this->std->modo == 'ALT') {
            $node = $this->dom->createElement("alteracao");
        } else {
            $node = $this->dom->createElement("exclusao");
        }
        $node->appendChild($ideEstab);

        if (!empty($this->std->dadosestab) && in_array($this->std->modo, ['INC', 'ALT'])) {
            $dadosEstab = $this->dom->createElement("dadosEstab");
            $this->dom->addChild(
                $dadosEstab,
                "cnaePrep",
                $this->std->dadosestab->cnaeprep,
                true
            );
            $aliqGilrat = $this->dom->createElement("aliqGilrat");
            $this->dom->addChild(
                $aliqGilrat,
                "aliqRat",
                $this->std->dadosestab->aliqgilrat->aliqrat,
                false
            );
            $fap = !empty($this->std->dadosestab->aliqgilrat->fap) ? $this->std->dadosestab->aliqgilrat->fap : null;
            if ($fap) {
                $fap = number_format($fap, 4, '.', '');
            }
            $this->dom->addChild(
                $aliqGilrat,
                "fap",
                $fap,
                false
            );
            if (!empty($this->std->dadosestab->aliqgilrat->procadmjudrat)) {
                $procAdmJudRat = $this->dom->createElement("procAdmJudRat");
                $this->dom->addChild(
                    $procAdmJudRat,
                    "tpProc",
                    $this->std->dadosestab->aliqgilrat->procadmjudrat->tpproc,
                    true
                );
                $this->dom->addChild(
                    $procAdmJudRat,
                    "nrProc",
                    $this->std->dadosestab->aliqgilrat->procadmjudrat->nrproc,
                    true
                );
                $this->dom->addChild(
                    $procAdmJudRat,
                    "codSusp",
                    $this->std->dadosestab->aliqgilrat->procadmjudrat->codsusp,
                    true
                );
                $aliqGilrat->appendChild($procAdmJudRat);
            }
            if (!empty($this->std->dadosestab->aliqgilrat->procadmjudfap)) {
                $procAdmJudFap = $this->dom->createElement("procAdmJudFap");
                $this->dom->addChild(
                    $procAdmJudFap,
                    "tpProc",
                    $this->std->dadosestab->aliqgilrat->procadmjudfap->tpproc,
                    true
                );
                $this->dom->addChild(
                    $procAdmJudFap,
                    "nrProc",
                    $this->std->dadosestab->aliqgilrat->procadmjudfap->nrproc,
                    true
                );
                $this->dom->addChild(
                    $procAdmJudFap,
                    "codSusp",
                    $this->std->dadosestab->aliqgilrat->procadmjudfap->codsusp,
                    true
                );
                $aliqGilrat->appendChild($procAdmJudFap);
            }
            $dadosEstab->appendChild($aliqGilrat);
            if (!empty($this->std->dadosestab->infocaepf)) {
                $infoCaepf = $this->dom->createElement("infoCaepf");
                $this->dom->addChild(
                    $infoCaepf,
                    "tpCaepf",
                    $this->std->dadosestab->infocaepf->tpcaepf,
                    true
                );
                $dadosEstab->appendChild($infoCaepf);
            }
            if (! empty($this->std->dadosestab->infoobra)) {
                $infoObra = $this->dom->createElement("infoObra");
                $this->dom->addChild(
                    $infoObra,
                    "indSubstPatrObra",
                    $this->std->dadosestab->infoobra->indsubstpatrobra,
                    true
                );
                $dadosEstab->appendChild($infoObra);
            }
            if (!empty($this->std->dadosestab->infotrab)) {
                $infoTrab = $this->dom->createElement("infoTrab");
                if (!empty($this->std->dadosestab->infotrab->infoapr)) {
                    $infoApr = $this->dom->createElement("infoApr");
                    $this->dom->addChild(
                        $infoApr,
                        "nrProcJud",
                        ! empty($this->std->dadosestab->infotrab->infoapr->nrprocjud)
                            ? $this->std->dadosestab->infotrab->infoapr->nrprocjud
                            : null,
                        false
                    );
                    if (! empty($this->std->dadosestab->infotrab->infoapr->infoenteduc)) {
                        foreach ($this->std->dadosestab->infotrab->infoapr->infoenteduc as $edu) {
                            $infoEntEduc = $this->dom->createElement("infoEntEduc");
                            $this->dom->addChild(
                                $infoEntEduc,
                                "nrInsc",
                                $edu->nrinsc,
                                true
                            );
                            $infoApr->appendChild($infoEntEduc);
                        }
                    }
                    $infoTrab->appendChild($infoApr);
                }
            }
            if (!empty($this->std->dadosestab->infotrab->infopdc)) {
                $infoPCD = $this->dom->createElement("infoPCD");
                $this->dom->addChild(
                    $infoPCD,
                    "nrProcJud",
                    $this->std->dadosestab->infotrab->infopdc->nrprocjud,
                    true
                );
                $infoTrab->appendChild($infoPCD);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            }
            $dadosEstab->appendChild($infoTrab);
            $node->appendChild($dadosEstab);
        }
        if (!empty($this->std->novavalidade) && $this->std->modo == 'ALT') {
            $newVal = $this->std->novavalidade;
            $novaValidade = $this->dom->createElement("novaValidade");
            $this->dom->addChild(
                $novaValidade,
                "iniValid",
                $newVal->inivalid,
                true
            );
            $this->dom->addChild(
                $novaValidade,
                "fimValid",
                !empty($newVal->fimvalid) ? $newVal->fimvalid : null,
                false
            );
            $node->appendChild($novaValidade);
        }
        $infoEstab = $this->dom->createElement("infoEstab");
        $infoEstab->appendChild($node);
        //finalização do xml
        $this->node->appendChild($infoEstab);
        $this->eSocial->appendChild($this->node);
        $this->sign();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


Push — master ( ce467a...63d89e )

TraitS1005 B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Complexity

Complex Class

Available Fixes

1			<?php
2
3			namespace NFePHP\eSocial\Factories\Traits;
4
5			trait TraitS1005
6			{
7			/**
8			* builder for version 2.5.0
9			*/
10			protected function toNode250()
11			{
12			$ideEmpregador = $this->node->getElementsByTagName('ideEmpregador')->item(0);
			0 ignored issues – show Bug introduced 2021-05-13 21:09 UTC by Report Bug Copy Issue Report The property `node` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
13			//o idEvento pode variar de evento para evento
14			//então cada factory individualmente terá de construir o seu
15			$ideEvento = $this->dom->createElement("ideEvento");
			0 ignored issues – show Bug introduced 2021-05-13 21:09 UTC by Report Bug Copy Issue Report The property `dom` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
16			$this->dom->addChild(
17			$ideEvento,
18			"tpAmb",
19			$this->tpAmb,
			0 ignored issues – show Bug introduced 2021-05-13 21:09 UTC by Report Bug Copy Issue Report The property `tpAmb` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
20			true
21			);
22			$this->dom->addChild(
23			$ideEvento,
24			"procEmi",
25			$this->procEmi,
			0 ignored issues – show Bug introduced 2021-05-13 21:09 UTC by Report Bug Copy Issue Report The property `procEmi` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
26			true
27			);
28			$this->dom->addChild(
29			$ideEvento,
30			"verProc",
31			$this->verProc,
			0 ignored issues – show Bug introduced 2021-05-13 21:09 UTC by Report Bug Copy Issue Report The property `verProc` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
32			true
33			);
34			$this->node->insertBefore($ideEvento, $ideEmpregador);
35

nfephp-org / sped-esocial

Push — master ( ce467a...63d89e )

TraitS1005 B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Complexity

Complex Class

Available Fixes

Duplication Side-by-Side

Filter issues like