EvtTabCargo::toNode() - Code Metrics - Inspection of "[UPD] ISSUE #68 Evento EvtTabCargo" - nfephp-org/sped-esocial - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#114)

by Roberto

created 2017-08-24 14:20 UTC

EvtTabCargo::toNode() C

↳ Parent: EvtTabCargo

Complexity

Conditions	8
Paths	18

Size

Total Lines	146
Code Lines	114

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	72

Importance

Changes

Metric	Value
dl	0
loc	146
ccs	0
cts	136
cp	0
rs	5.2676
c	0
b	0
f	0
cc	8
eloc	114
nc	18
nop	0
crap	72

How to fix Long Method

<?php

namespace NFePHP\eSocial\Factories;

/**
 * Class eSocial EvtTabCargo Event S-1030 constructor
 *
 * @category  NFePHP
 * @package   NFePHPSocial
 * @copyright NFePHP Copyright (c) 2017
 * @license   http://www.gnu.org/licenses/lgpl.txt LGPLv3+
 * @license   https://opensource.org/licenses/MIT MIT
 * @license   http://www.gnu.org/licenses/gpl.txt GPLv3+
 * @author    Roberto L. Machado <linux.rlm at gmail dot com>
 * @link      http://github.com/nfephp-org/sped-esocial for the canonical source repository
 */

use NFePHP\Common\Certificate;
use NFePHP\eSocial\Common\Factory;
use NFePHP\eSocial\Common\FactoryId;
use NFePHP\eSocial\Common\FactoryInterface;
use stdClass;

class EvtTabCargo extends Factory implements FactoryInterface
{
    /**
     * @var int
     */
    public $sequencial;

    /**
     * @var string
     */
    protected $evtName = 'evtTabCargo';

    /**
     * @var string
     */
    protected $evtAlias = 'S-1030';

    /**
     * Parameters patterns
     *
     * @var array
     */
    protected $parameters = [];

    /**
     * Constructor
     *
     * @param string $config
     * @param stdClass $std
     * @param Certificate $certificate
     */
    public function __construct(
        $config,
        stdClass $std,
        Certificate $certificate
    ) {
        parent::__construct($config, $std, $certificate);
    }

    /**
     * Node constructor
     */
    protected function toNode()
    {
        $ideEmpregador = $this->node->getElementsByTagName('ideEmpregador')->item(0);
        //o idEvento pode variar de evento para evento
        //então cada factory individualmente terá de construir o seu
        $ideEvento = $this->dom->createElement("ideEvento");
        $this->dom->addChild(
            $ideEvento,
            "tpAmb",
            $this->tpAmb,
            true
        );
        $this->dom->addChild(
            $ideEvento,
            "procEmi",
            $this->procEmi,
            true
        );
        $this->dom->addChild(
            $ideEvento,
            "verProc",
            $this->verProc,
            true
        );
        $this->node->insertBefore($ideEvento, $ideEmpregador);
        
        $ide = $this->dom->createElement("ideCargo");
        $this->dom->addChild(
            $ide,
            "codCargo",
            $this->std->codcargo,
            true
        );
        $this->dom->addChild(
            $ide,
            "iniValid",
            $this->std->inivalid,
            true
        );
        $this->dom->addChild(
            $ide,
            "fimValid",
            ! empty($this->std->fimvalid) ? $this->std->fimvalid : null,
            false
        );
        
        
        if (!empty($this->std->dadoscargo)) {
            $da = $this->std->dadoscargo;
            $dados = $this->dom->createElement("dadosCargo");
            $this->dom->addChild(
                $dados,
                "nmCargo",
                $da->nmcargo,
                true
            );
            $this->dom->addChild(
                $dados,
                "codCBO",
                $da->codcbo,
                true
            );
            if (!empty($da->cargopublico)) {
                $cpub = $this->dom->createElement("cargoPublico");
                $this->dom->addChild(
                    $cpub,
                    "acumCargo",
                    $da->cargopublico->acumcargo,
                    true
                );
                $this->dom->addChild(
                    $cpub,
                    "contagemEsp",
                    $da->cargopublico->contagemesp,
                    true
                );
                $this->dom->addChild(
                    $cpub,
                    "dedicExcl",
                    $da->cargopublico->dedicexcl,
                    true
                );
                $lei = $this->dom->createElement("leiCargo");
                $this->dom->addChild(
                    $lei,
                    "nrLei",
                    $da->cargopublico->nrlei,
                    true
                );
                $this->dom->addChild(
                    $lei,
                    "dtLei",
                    $da->cargopublico->dtlei,
                    true
                );
                $this->dom->addChild(
                    $lei,
                    "sitCargo",
                    $da->cargopublico->sitcargo,
                    true
                );
                $cpub->appendChild($lei);
                $dados->appendChild($cpub);
            }
        }
        
        if (!empty($this->std->novavalidade)) {
            $nova = $this->dom->createElement("novaValidade");
            $this->dom->addChild(
                $nova,
                "iniValid",
                $this->std->novavalidade->inivalid,
                true
            );
            $this->dom->addChild(
                $nova,
                "fimValid",
                ! empty($this->std->novavalidade->fimvalid)
                    ? $this->std->novavalidade->fimvalid
                    : null,
                false
            );
        }
        
        $info = $this->dom->createElement("infoCargo");
        //seleção do modo
        if ($this->std->modo == 'INC') {
            $node = $this->dom->createElement("inclusao");
            $node->appendChild($ide);
            $node->appendChild($dados);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        } elseif ($this->std->modo == 'ALT') {
            $node = $this->dom->createElement("alteracao");
            $node->appendChild($ide);
            $node->appendChild($dados);
            $node->appendChild($nova);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        } else {
            $node = $this->dom->createElement("exclusao");
            $node->appendChild($ide);
        }
        
        $info->appendChild($node);
        $this->node->appendChild($info);
        $this->eSocial->appendChild($this->node);
        //$this->xml = $this->dom->saveXML($this->eSocial);

        $this->sign();
    }
}


Pull Request — master (#114)

EvtTabCargo::toNode() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Available Fixes

Available Fixes

1			<?php
2
3			namespace NFePHP\eSocial\Factories;
4
5			/**
6			* Class eSocial EvtTabCargo Event S-1030 constructor
7			*
8			* @category NFePHP
9			* @package NFePHPSocial
10			* @copyright NFePHP Copyright (c) 2017
11			* @license http://www.gnu.org/licenses/lgpl.txt LGPLv3+
12			* @license https://opensource.org/licenses/MIT MIT
13			* @license http://www.gnu.org/licenses/gpl.txt GPLv3+
14			* @author Roberto L. Machado <linux.rlm at gmail dot com>
15			* @link http://github.com/nfephp-org/sped-esocial for the canonical source repository
16			*/
17
18			use NFePHP\Common\Certificate;
19			use NFePHP\eSocial\Common\Factory;
20			use NFePHP\eSocial\Common\FactoryId;
21			use NFePHP\eSocial\Common\FactoryInterface;
22			use stdClass;
23
24			class EvtTabCargo extends Factory implements FactoryInterface
25			{
26			/**
27			* @var int
28			*/
29			public $sequencial;
30
31			/**
32			* @var string
33			*/
34			protected $evtName = 'evtTabCargo';
35
36			/**
37			* @var string
38			*/
39			protected $evtAlias = 'S-1030';
40
41			/**
42			* Parameters patterns
43			*
44			* @var array
45			*/
46			protected $parameters = [];
47
48			/**
49			* Constructor
50			*
51			* @param string $config
52			* @param stdClass $std
53			* @param Certificate $certificate
54			*/
55			public function __construct(
56			$config,
57			stdClass $std,
58			Certificate $certificate
59			) {
60			parent::__construct($config, $std, $certificate);
61			}
62
63			/**
64			* Node constructor
65			*/
66			protected function toNode()
67			{
68			$ideEmpregador = $this->node->getElementsByTagName('ideEmpregador')->item(0);
69			//o idEvento pode variar de evento para evento
70			//então cada factory individualmente terá de construir o seu
71			$ideEvento = $this->dom->createElement("ideEvento");
72			$this->dom->addChild(
73			$ideEvento,
74			"tpAmb",
75			$this->tpAmb,
76			true
77			);
78			$this->dom->addChild(
79			$ideEvento,
80			"procEmi",
81			$this->procEmi,
82			true
83			);
84			$this->dom->addChild(
85			$ideEvento,
86			"verProc",
87			$this->verProc,
88			true
89			);
90			$this->node->insertBefore($ideEvento, $ideEmpregador);
91
92			$ide = $this->dom->createElement("ideCargo");
93			$this->dom->addChild(
94			$ide,
95			"codCargo",
96			$this->std->codcargo,
97			true
98			);
99			$this->dom->addChild(
100			$ide,
101			"iniValid",
102			$this->std->inivalid,
103			true
104			);
105			$this->dom->addChild(
106			$ide,
107			"fimValid",
108			! empty($this->std->fimvalid) ? $this->std->fimvalid : null,
109			false
110			);
111
112
113			if (!empty($this->std->dadoscargo)) {
114			$da = $this->std->dadoscargo;
115			$dados = $this->dom->createElement("dadosCargo");
116			$this->dom->addChild(
117			$dados,
118			"nmCargo",
119			$da->nmcargo,
120			true
121			);
122			$this->dom->addChild(
123			$dados,
124			"codCBO",
125			$da->codcbo,
126			true
127			);
128			if (!empty($da->cargopublico)) {
129			$cpub = $this->dom->createElement("cargoPublico");
130			$this->dom->addChild(
131			$cpub,
132			"acumCargo",
133			$da->cargopublico->acumcargo,
134			true
135			);
136			$this->dom->addChild(
137			$cpub,
138			"contagemEsp",
139			$da->cargopublico->contagemesp,
140			true
141			);
142			$this->dom->addChild(
143			$cpub,
144			"dedicExcl",
145			$da->cargopublico->dedicexcl,
146			true
147			);
148			$lei = $this->dom->createElement("leiCargo");
149			$this->dom->addChild(
150			$lei,
151			"nrLei",
152			$da->cargopublico->nrlei,
153			true
154			);
155			$this->dom->addChild(
156			$lei,
157			"dtLei",
158			$da->cargopublico->dtlei,
159			true
160			);
161			$this->dom->addChild(
162			$lei,
163			"sitCargo",
164			$da->cargopublico->sitcargo,
165			true
166			);
167			$cpub->appendChild($lei);
168			$dados->appendChild($cpub);
169			}
170			}
171
172			if (!empty($this->std->novavalidade)) {
173			$nova = $this->dom->createElement("novaValidade");
174			$this->dom->addChild(
175			$nova,
176			"iniValid",
177			$this->std->novavalidade->inivalid,
178			true
179			);
180			$this->dom->addChild(
181			$nova,
182			"fimValid",
183			! empty($this->std->novavalidade->fimvalid)
184			? $this->std->novavalidade->fimvalid
185			: null,
186			false
187			);
188			}
189
190			$info = $this->dom->createElement("infoCargo");
191			//seleção do modo
192			if ($this->std->modo == 'INC') {
193			$node = $this->dom->createElement("inclusao");
194			$node->appendChild($ide);
195			$node->appendChild($dados);
			0 ignored issues – show Bug introduced 2017-08-24 14:25 UTC by Report Bug Copy Issue Report The variable `$dados` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
196			} elseif ($this->std->modo == 'ALT') {
197			$node = $this->dom->createElement("alteracao");
198			$node->appendChild($ide);
199			$node->appendChild($dados);
200			$node->appendChild($nova);
			0 ignored issues – show Bug introduced 2017-08-24 14:25 UTC by Report Bug Copy Issue Report The variable `$nova` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
201			} else {
202			$node = $this->dom->createElement("exclusao");
203			$node->appendChild($ide);
204			}
205
206			$info->appendChild($node);
207			$this->node->appendChild($info);
208			$this->eSocial->appendChild($this->node);
209			//$this->xml = $this->dom->saveXML($this->eSocial);
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-24 14:25 UTC by Report Bug Copy Issue Report `59%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
210			$this->sign();
211			}
212			}
213

nfephp-org / sped-esocial

Pull Request — master (#114)

EvtTabCargo::toNode() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like