TraitS2260::toNode250() - Code Metrics - Inspection of "Merge pull request #304 from robmachado/master" - nfephp-org/sped-esocial - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2973a2...01fa63 )

by Roberto

created 2021-05-14 12:54 UTC

TraitS2260::toNode250() B

↳ Parent: TraitS2260

Complexity

Conditions	7
Paths	2

Size

Total Lines

165

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	165
rs	7.0666
c	0
b	0
f	0
cc	7
nc	2
nop	0

How to fix Long Method

<?php

namespace NFePHP\eSocial\Factories\Traits;

trait TraitS2260
{
    /**
     * builder for version 2.5.0
     */
    protected function toNode250()
    {
        $ideEmpregador = $this->node->getElementsByTagName('ideEmpregador')->item(0);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        //o idEvento pode variar de evento para evento
        //então cada factory individualmente terá de construir o seu
        $ideEvento = $this->dom->createElement("ideEvento");
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->dom->addChild(
            $ideEvento,
            "indRetif",
            $this->std->indretif,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            true
        );
        $this->dom->addChild(
            $ideEvento,
            "nrRecibo",
            ! empty($this->std->nrrecibo) ? $this->std->nrrecibo : null,
            false
        );
        $this->dom->addChild(
            $ideEvento,
            "tpAmb",
            $this->tpAmb,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            true
        );
        $this->dom->addChild(
            $ideEvento,
            "procEmi",
            $this->procEmi,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            true
        );
        $this->dom->addChild(
            $ideEvento,
            "verProc",
            $this->verProc,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            true
        );
        $this->node->insertBefore($ideEvento, $ideEmpregador);
        $ideVinculo = $this->dom->createElement("ideVinculo");
        $this->dom->addChild(
            $ideVinculo,
            "cpfTrab",
            $this->std->idevinculo->cpftrab,
            true
        );
        $this->dom->addChild(
            $ideVinculo,
            "nisTrab",
            $this->std->idevinculo->nistrab,
            true
        );
        $this->dom->addChild(
            $ideVinculo,
            "matricula",
            $this->std->idevinculo->matricula,
            true
        );
        $this->node->appendChild($ideVinculo);
        
        $i = $this->std->infoconvinterm;
        $info = $this->dom->createElement("infoConvInterm");
        $this->dom->addChild(
            $info,
            "codConv",
            $i->codconv,
            true
        );
        $this->dom->addChild(
            $info,
            "dtInicio",
            $i->dtinicio,
            true
        );
        $this->dom->addChild(
            $info,
            "dtFim",
            $i->dtfim,
            true
        );
        $this->dom->addChild(
            $info,
            "dtPrevPgto",
            $i->dtprevpgto,
            true
        );
        $jornada = $this->dom->createElement("jornada");
        $this->dom->addChild(
            $jornada,
            "codHorContrat",
            !empty($i->jornada->codhorcontrat) ? $i->jornada->codhorcontrat : null,
            false
        );
        $this->dom->addChild(
            $jornada,
            "dscJornada",
            !empty($i->jornada->dscjornada) ? $i->jornada->dscjornada : null,
            false
        );
        $info->appendChild($jornada);
        
        $localTrab = $this->dom->createElement("localTrab");
        $this->dom->addChild(
            $localTrab,
            "indLocal",
            $i->localtrab->indlocal,
            true
        );
        if (!empty($i->localtrab->localtrabinterm)) {
            $l = $i->localtrab->localtrabinterm;
            $local = $this->dom->createElement("localTrabInterm");
            $this->dom->addChild(
                $local,
                "tpLograd",
                $l->tplograd,
                true
            );
            $this->dom->addChild(
                $local,
                "dscLograd",
                $l->dsclograd,
                true
            );
            $this->dom->addChild(
                $local,
                "nrLograd",
                $l->nrlograd,
                true
            );
            $this->dom->addChild(
                $local,
                "complem",
                !empty($l->complem) ? $l->complem : null,
                false
            );
            $this->dom->addChild(
                $local,
                "bairro",
                !empty($l->bairro) ? $l->bairro : null,
                false
            );
            $this->dom->addChild(
                $local,
                "cep",
                $l->cep,
                true
            );
            $this->dom->addChild(
                $local,
                "codMunic",
                $l->codmunic,
                true
            );
            $this->dom->addChild(
                $local,
                "uf",
                $l->uf,
                true
            );
            $localTrab->appendChild($local);
        }
        $info->appendChild($localTrab);
        $this->node->appendChild($info);
        $this->eSocial->appendChild($this->node);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        //$this->xml = $this->dom->saveXML($this->eSocial);
        $this->sign();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
    
    /**
     * builder for version S.1.0.0
     */
    protected function toNodeS100()
    {
        throw new \Exception("NÃO EXISTE EVENTO {$this->evtAlias} na versão S_1.0 !!");
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }
}


1			<?php
2
3			namespace NFePHP\eSocial\Factories\Traits;
4
5			trait TraitS2260
6			{
7			/**
8			* builder for version 2.5.0
9			*/
10			protected function toNode250()
11			{
12			$ideEmpregador = $this->node->getElementsByTagName('ideEmpregador')->item(0);
			0 ignored issues – show Bug introduced 2021-05-14 12:56 UTC by Report Bug Copy Issue Report The property `node` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
13			//o idEvento pode variar de evento para evento
14			//então cada factory individualmente terá de construir o seu
15			$ideEvento = $this->dom->createElement("ideEvento");
			0 ignored issues – show Bug introduced 2021-05-14 12:56 UTC by Report Bug Copy Issue Report The property `dom` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
16			$this->dom->addChild(
17			$ideEvento,
18			"indRetif",
19			$this->std->indretif,
			0 ignored issues – show Bug introduced 2021-05-14 12:56 UTC by Report Bug Copy Issue Report The property `std` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
20			true
21			);
22			$this->dom->addChild(
23			$ideEvento,
24			"nrRecibo",
25			! empty($this->std->nrrecibo) ? $this->std->nrrecibo : null,
26			false
27			);
28			$this->dom->addChild(
29			$ideEvento,
30			"tpAmb",
31			$this->tpAmb,
			0 ignored issues – show Bug introduced 2021-05-14 12:56 UTC by Report Bug Copy Issue Report The property `tpAmb` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
32			true
33			);
34			$this->dom->addChild(
35			$ideEvento,
36			"procEmi",
37			$this->procEmi,
			0 ignored issues – show Bug introduced 2021-05-14 12:56 UTC by Report Bug Copy Issue Report The property `procEmi` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
38			true
39			);
40			$this->dom->addChild(
41			$ideEvento,
42			"verProc",
43			$this->verProc,
			0 ignored issues – show Bug introduced 2021-05-14 12:56 UTC by Report Bug Copy Issue Report The property `verProc` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
44			true
45			);
46			$this->node->insertBefore($ideEvento, $ideEmpregador);
47			$ideVinculo = $this->dom->createElement("ideVinculo");
48			$this->dom->addChild(
49			$ideVinculo,
50			"cpfTrab",
51			$this->std->idevinculo->cpftrab,
52			true
53			);
54			$this->dom->addChild(
55			$ideVinculo,
56			"nisTrab",
57			$this->std->idevinculo->nistrab,
58			true
59			);
60			$this->dom->addChild(
61			$ideVinculo,
62			"matricula",
63			$this->std->idevinculo->matricula,
64			true
65			);
66			$this->node->appendChild($ideVinculo);
67
68			$i = $this->std->infoconvinterm;
69			$info = $this->dom->createElement("infoConvInterm");
70			$this->dom->addChild(
71			$info,
72			"codConv",
73			$i->codconv,
74			true
75			);
76			$this->dom->addChild(
77			$info,
78			"dtInicio",
79			$i->dtinicio,
80			true
81			);
82			$this->dom->addChild(
83			$info,
84			"dtFim",
85			$i->dtfim,
86			true
87			);
88			$this->dom->addChild(
89			$info,
90			"dtPrevPgto",
91			$i->dtprevpgto,
92			true
93			);
94			$jornada = $this->dom->createElement("jornada");
95			$this->dom->addChild(
96			$jornada,
97			"codHorContrat",
98			!empty($i->jornada->codhorcontrat) ? $i->jornada->codhorcontrat : null,
99			false
100			);
101			$this->dom->addChild(
102			$jornada,
103			"dscJornada",
104			!empty($i->jornada->dscjornada) ? $i->jornada->dscjornada : null,
105			false
106			);
107			$info->appendChild($jornada);
108
109			$localTrab = $this->dom->createElement("localTrab");
110			$this->dom->addChild(
111			$localTrab,
112			"indLocal",
113			$i->localtrab->indlocal,
114			true
115			);
116			if (!empty($i->localtrab->localtrabinterm)) {
117			$l = $i->localtrab->localtrabinterm;
118			$local = $this->dom->createElement("localTrabInterm");
119			$this->dom->addChild(
120			$local,
121			"tpLograd",
122			$l->tplograd,
123			true
124			);
125			$this->dom->addChild(
126			$local,
127			"dscLograd",
128			$l->dsclograd,
129			true
130			);
131			$this->dom->addChild(
132			$local,
133			"nrLograd",
134			$l->nrlograd,
135			true
136			);
137			$this->dom->addChild(
138			$local,
139			"complem",
140			!empty($l->complem) ? $l->complem : null,
141			false
142			);
143			$this->dom->addChild(
144			$local,
145			"bairro",
146			!empty($l->bairro) ? $l->bairro : null,
147			false
148			);
149			$this->dom->addChild(
150			$local,
151			"cep",
152			$l->cep,
153			true
154			);
155			$this->dom->addChild(
156			$local,
157			"codMunic",
158			$l->codmunic,
159			true
160			);
161			$this->dom->addChild(
162			$local,
163			"uf",
164			$l->uf,
165			true
166			);
167			$localTrab->appendChild($local);
168			}
169			$info->appendChild($localTrab);
170			$this->node->appendChild($info);
171			$this->eSocial->appendChild($this->node);
			0 ignored issues – show Bug introduced 2021-05-14 12:56 UTC by Report Bug Copy Issue Report The property `eSocial` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
172			//$this->xml = $this->dom->saveXML($this->eSocial);
173			$this->sign();
			0 ignored issues – show Bug introduced 2021-05-14 12:56 UTC by Report Bug Copy Issue Report It seems like `sign()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
174			}
175
176			/**
177			* builder for version S.1.0.0
178			*/
179			protected function toNodeS100()
180			{
181			throw new \Exception("NÃO EXISTE EVENTO {$this->evtAlias} na versão S_1.0 !!");
			0 ignored issues – show Bug introduced 2021-05-14 12:56 UTC by Report Bug Copy Issue Report The property `evtAlias` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
182			}
183			}
184

nfephp-org / sped-esocial

Push — master ( 2973a2...01fa63 )

TraitS2260::toNode250() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like