TraitS2250::toNode250() - Code Metrics - Inspection of "Merge pull request #304 from robmachado/master" - nfephp-org/sped-esocial - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2973a2...01fa63 )

by Roberto

created 2021-05-14 12:54 UTC

TraitS2250::toNode250() B

↳ Parent: TraitS2250

Complexity

Conditions	6
Paths	4

Size

Total Lines

115

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	115
rs	7.3777
c	0
b	0
f	0
cc	6
nc	4
nop	0

How to fix Long Method

<?php

namespace NFePHP\eSocial\Factories\Traits;

trait TraitS2250
{
    /**
     * builder for version 2.5.0
     */
    protected function toNode250()
    {
        $ideEmpregador = $this->node->getElementsByTagName('ideEmpregador')->item(0);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        //o idEvento pode variar de evento para evento
        //então cada factory individualmente terá de construir o seu
        $ideEvento = $this->dom->createElement("ideEvento");
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->dom->addChild(
            $ideEvento,
            "indRetif",
            $this->std->indretif,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            true
        );
        $this->dom->addChild(
            $ideEvento,
            "nrRecibo",
            ! empty($this->std->nrrecibo) ? $this->std->nrrecibo : null,
            false
        );
        $this->dom->addChild(
            $ideEvento,
            "tpAmb",
            $this->tpAmb,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            true
        );
        $this->dom->addChild(
            $ideEvento,
            "procEmi",
            $this->procEmi,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            true
        );
        $this->dom->addChild(
            $ideEvento,
            "verProc",
            $this->verProc,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            true
        );
        $this->node->insertBefore($ideEvento, $ideEmpregador);
        $ideVinculo = $this->dom->createElement("ideVinculo");
        $this->dom->addChild(
            $ideVinculo,
            "cpfTrab",
            $this->std->idevinculo->cpftrab,
            true
        );
        $this->dom->addChild(
            $ideVinculo,
            "nisTrab",
            $this->std->idevinculo->nistrab,
            true
        );
        $this->dom->addChild(
            $ideVinculo,
            "matricula",
            $this->std->idevinculo->matricula,
            true
        );
        $this->node->appendChild($ideVinculo);
        $infoAvPrevio = $this->dom->createElement("infoAvPrevio");
        if (! empty($this->std->infoavprevio->detavprevio)) {
            $detAvPrevio = $this->dom->createElement("detAvPrevio");
            $this->dom->addChild(
                $detAvPrevio,
                "dtAvPrv",
                $this->std->infoavprevio->detavprevio->dtavprv,
                true
            );
            $this->dom->addChild(
                $detAvPrevio,
                "dtPrevDeslig",
                $this->std->infoavprevio->detavprevio->dtprevdeslig,
                true
            );
            $this->dom->addChild(
                $detAvPrevio,
                "tpAvPrevio",
                $this->std->infoavprevio->detavprevio->tpavprevio,
                true
            );
            $this->dom->addChild(
                $detAvPrevio,
                "observacao",
                ! empty($this->std->infoavprevio->detavprevio->observacao) ?
                    $this->std->infoavprevio->detavprevio->observacao : null,
                false
            );
            $infoAvPrevio->appendChild($detAvPrevio);
        }
        if (! empty($this->std->infoavprevio->cancavprevio)) {
            $cancAvPrevio = $this->dom->createElement("cancAvPrevio");
            $this->dom->addChild(
                $cancAvPrevio,
                "dtCancAvPrv",
                $this->std->infoavprevio->cancavprevio->dtcancavprv,
                true
            );
            $this->dom->addChild(
                $cancAvPrevio,
                "observacao",
                ! empty($this->std->infoavprevio->cancavprevio->observacao) ?
                    $this->std->infoavprevio->cancavprevio->observacao : null,
                false
            );
            $this->dom->addChild(
                $cancAvPrevio,
                "mtvCancAvPrevio",
                $this->std->infoavprevio->cancavprevio->mtvcancavprevio,
                true
            );
            $infoAvPrevio->appendChild($cancAvPrevio);
        }
        $this->node->appendChild($infoAvPrevio);
        $this->eSocial->appendChild($this->node);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        //$this->xml = $this->dom->saveXML($this->eSocial);
        $this->sign();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
    
    /**
     * builder for version S.1.0.0
     */
    protected function toNodeS100()
    {
        throw new \Exception("NÃO EXISTE EVENTO {$this->evtAlias} na versão S_1.0 !!");
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }
}


1			<?php
2
3			namespace NFePHP\eSocial\Factories\Traits;
4
5			trait TraitS2250
6			{
7			/**
8			* builder for version 2.5.0
9			*/
10			protected function toNode250()
11			{
12			$ideEmpregador = $this->node->getElementsByTagName('ideEmpregador')->item(0);
			0 ignored issues – show Bug introduced 2021-05-14 12:56 UTC by Report Bug Copy Issue Report The property `node` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
13			//o idEvento pode variar de evento para evento
14			//então cada factory individualmente terá de construir o seu
15			$ideEvento = $this->dom->createElement("ideEvento");
			0 ignored issues – show Bug introduced 2021-05-14 12:56 UTC by Report Bug Copy Issue Report The property `dom` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
16			$this->dom->addChild(
17			$ideEvento,
18			"indRetif",
19			$this->std->indretif,
			0 ignored issues – show Bug introduced 2021-05-14 12:56 UTC by Report Bug Copy Issue Report The property `std` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
20			true
21			);
22			$this->dom->addChild(
23			$ideEvento,
24			"nrRecibo",
25			! empty($this->std->nrrecibo) ? $this->std->nrrecibo : null,
26			false
27			);
28			$this->dom->addChild(
29			$ideEvento,
30			"tpAmb",
31			$this->tpAmb,
			0 ignored issues – show Bug introduced 2021-05-14 12:56 UTC by Report Bug Copy Issue Report The property `tpAmb` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
32			true
33			);
34			$this->dom->addChild(
35			$ideEvento,
36			"procEmi",
37			$this->procEmi,
			0 ignored issues – show Bug introduced 2021-05-14 12:56 UTC by Report Bug Copy Issue Report The property `procEmi` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
38			true
39			);
40			$this->dom->addChild(
41			$ideEvento,
42			"verProc",
43			$this->verProc,
			0 ignored issues – show Bug introduced 2021-05-14 12:56 UTC by Report Bug Copy Issue Report The property `verProc` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
44			true
45			);
46			$this->node->insertBefore($ideEvento, $ideEmpregador);
47			$ideVinculo = $this->dom->createElement("ideVinculo");
48			$this->dom->addChild(
49			$ideVinculo,
50			"cpfTrab",
51			$this->std->idevinculo->cpftrab,
52			true
53			);
54			$this->dom->addChild(
55			$ideVinculo,
56			"nisTrab",
57			$this->std->idevinculo->nistrab,
58			true
59			);
60			$this->dom->addChild(
61			$ideVinculo,
62			"matricula",
63			$this->std->idevinculo->matricula,
64			true
65			);
66			$this->node->appendChild($ideVinculo);
67			$infoAvPrevio = $this->dom->createElement("infoAvPrevio");
68			if (! empty($this->std->infoavprevio->detavprevio)) {
69			$detAvPrevio = $this->dom->createElement("detAvPrevio");
70			$this->dom->addChild(
71			$detAvPrevio,
72			"dtAvPrv",
73			$this->std->infoavprevio->detavprevio->dtavprv,
74			true
75			);
76			$this->dom->addChild(
77			$detAvPrevio,
78			"dtPrevDeslig",
79			$this->std->infoavprevio->detavprevio->dtprevdeslig,
80			true
81			);
82			$this->dom->addChild(
83			$detAvPrevio,
84			"tpAvPrevio",
85			$this->std->infoavprevio->detavprevio->tpavprevio,
86			true
87			);
88			$this->dom->addChild(
89			$detAvPrevio,
90			"observacao",
91			! empty($this->std->infoavprevio->detavprevio->observacao) ?
92			$this->std->infoavprevio->detavprevio->observacao : null,
93			false
94			);
95			$infoAvPrevio->appendChild($detAvPrevio);
96			}
97			if (! empty($this->std->infoavprevio->cancavprevio)) {
98			$cancAvPrevio = $this->dom->createElement("cancAvPrevio");
99			$this->dom->addChild(
100			$cancAvPrevio,
101			"dtCancAvPrv",
102			$this->std->infoavprevio->cancavprevio->dtcancavprv,
103			true
104			);
105			$this->dom->addChild(
106			$cancAvPrevio,
107			"observacao",
108			! empty($this->std->infoavprevio->cancavprevio->observacao) ?
109			$this->std->infoavprevio->cancavprevio->observacao : null,
110			false
111			);
112			$this->dom->addChild(
113			$cancAvPrevio,
114			"mtvCancAvPrevio",
115			$this->std->infoavprevio->cancavprevio->mtvcancavprevio,
116			true
117			);
118			$infoAvPrevio->appendChild($cancAvPrevio);
119			}
120			$this->node->appendChild($infoAvPrevio);
121			$this->eSocial->appendChild($this->node);
			0 ignored issues – show Bug introduced 2021-05-14 12:56 UTC by Report Bug Copy Issue Report The property `eSocial` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
122			//$this->xml = $this->dom->saveXML($this->eSocial);
123			$this->sign();
			0 ignored issues – show Bug introduced 2021-05-14 12:56 UTC by Report Bug Copy Issue Report It seems like `sign()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
124			}
125
126			/**
127			* builder for version S.1.0.0
128			*/
129			protected function toNodeS100()
130			{
131			throw new \Exception("NÃO EXISTE EVENTO {$this->evtAlias} na versão S_1.0 !!");
			0 ignored issues – show Bug introduced 2021-05-14 12:56 UTC by Report Bug Copy Issue Report The property `evtAlias` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
132			}
133			}
134

nfephp-org / sped-esocial

Push — master ( 2973a2...01fa63 )

TraitS2250::toNode250() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like