TraitS2420::toNodeS100() - Code Metrics - Inspection of "Merge pull request #309 from robmachado/master" - nfephp-org/sped-esocial - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 0fe426...8c51ed )

by Roberto

created 2021-05-14 20:00 UTC

TraitS2420::toNodeS100() B

↳ Parent: TraitS2420

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	86
rs	8.3054
c	0
b	0
f	0
cc	2
nc	2
nop	0

How to fix Long Method

<?php

namespace NFePHP\eSocial\Factories\Traits;

trait TraitS2420
{
    /**
     * builder for version 2.5.0
     */
    protected function toNode250()
    {
        throw new \Exception("NÃO EXISTE EVENTO {$this->evtAlias} na versão 2.5.0 !!");
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }
    
    /**
     * builder for version S.1.0.0
     */
    protected function toNodeS100()
    {
        $ideEmpregador = $this->node->getElementsByTagName('ideEmpregador')->item(0);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        //o idEvento pode variar de evento para evento
        //então cada factory individualmente terá de construir o seu
        $ideEvento = $this->dom->createElement("ideEvento");
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->dom->addChild(
            $ideEvento,
            "indRetif",
            $this->std->indretif,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            true
        );
        if ($this->std->indretif == 2) {
            $this->dom->addChild(
                $ideEvento,
                "nrRecibo",
                $this->std->nrrecibo,
                true
            );
        }
        $this->dom->addChild(
            $ideEvento,
            "tpAmb",
            $this->tpAmb,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            true
        );
        $this->dom->addChild(
            $ideEvento,
            "procEmi",
            $this->procEmi,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            true
        );
        $this->dom->addChild(
            $ideEvento,
            "verProc",
            $this->verProc,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            true
        );
        $this->node->insertBefore($ideEvento, $ideEmpregador);
        
        $ideBeneficio = $this->dom->createElement("ideBeneficio");
        $this->dom->addChild(
            $ideBeneficio,
            "cpfBenef",
            $this->std->cpfbenef,
            true
        );
        $this->dom->addChild(
            $ideBeneficio,
            "nrBeneficio",
            $this->std->nrbeneficio,
            true
        );
        $this->node->appendChild($ideBeneficio);
        
        $infoBenTermino = $this->dom->createElement("infoBenTermino");
        $this->dom->addChild(
            $infoBenTermino,
            "dtTermBeneficio",
            $this->std->dttermbeneficio,
            true
        );
        $this->dom->addChild(
            $infoBenTermino,
            "mtvTermino",
            $this->std->mtvtermino,
            true
        );
        $this->dom->addChild(
            $infoBenTermino,
            "cnpjOrgaoSuc",
            $this->std->cnpjorgaosuc,
            false
        );
        $this->dom->addChild(
            $infoBenTermino,
            "novoCPF",
            $this->std->novocpf,
            false
        );
        $this->node->appendChild($infoBenTermino);
        //finalização do xml
        $this->eSocial->appendChild($this->node);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        //$this->xml = $this->dom->saveXML($this->eSocial);
        $this->sign();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			namespace NFePHP\eSocial\Factories\Traits;
4
5			trait TraitS2420
6			{
7			/**
8			* builder for version 2.5.0
9			*/
10			protected function toNode250()
11			{
12			throw new \Exception("NÃO EXISTE EVENTO {$this->evtAlias} na versão 2.5.0 !!");
			0 ignored issues – show Bug introduced 2021-05-14 12:56 UTC by Report Bug Copy Issue Report The property `evtAlias` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
13			}
14
15			/**
16			* builder for version S.1.0.0
17			*/
18			protected function toNodeS100()
19			{
20			$ideEmpregador = $this->node->getElementsByTagName('ideEmpregador')->item(0);
			0 ignored issues – show Bug introduced 2021-05-14 20:05 UTC by Report Bug Copy Issue Report The property `node` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
21			//o idEvento pode variar de evento para evento
22			//então cada factory individualmente terá de construir o seu
23			$ideEvento = $this->dom->createElement("ideEvento");
			0 ignored issues – show Bug introduced 2021-05-14 20:05 UTC by Report Bug Copy Issue Report The property `dom` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
24			$this->dom->addChild(
25			$ideEvento,
26			"indRetif",
27			$this->std->indretif,
			0 ignored issues – show Bug introduced 2021-05-14 20:05 UTC by Report Bug Copy Issue Report The property `std` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
28			true
29			);
30			if ($this->std->indretif == 2) {
31			$this->dom->addChild(
32			$ideEvento,
33			"nrRecibo",
34			$this->std->nrrecibo,
35			true
36			);
37			}
38			$this->dom->addChild(
39			$ideEvento,
40			"tpAmb",
41			$this->tpAmb,
			0 ignored issues – show Bug introduced 2021-05-14 20:05 UTC by Report Bug Copy Issue Report The property `tpAmb` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
42			true
43			);
44			$this->dom->addChild(
45			$ideEvento,
46			"procEmi",
47			$this->procEmi,
			0 ignored issues – show Bug introduced 2021-05-14 20:05 UTC by Report Bug Copy Issue Report The property `procEmi` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
48			true
49			);
50			$this->dom->addChild(
51			$ideEvento,
52			"verProc",
53			$this->verProc,
			0 ignored issues – show Bug introduced 2021-05-14 20:05 UTC by Report Bug Copy Issue Report The property `verProc` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
54			true
55			);
56			$this->node->insertBefore($ideEvento, $ideEmpregador);
57
58			$ideBeneficio = $this->dom->createElement("ideBeneficio");
59			$this->dom->addChild(
60			$ideBeneficio,
61			"cpfBenef",
62			$this->std->cpfbenef,
63			true
64			);
65			$this->dom->addChild(
66			$ideBeneficio,
67			"nrBeneficio",
68			$this->std->nrbeneficio,
69			true
70			);
71			$this->node->appendChild($ideBeneficio);
72
73			$infoBenTermino = $this->dom->createElement("infoBenTermino");
74			$this->dom->addChild(
75			$infoBenTermino,
76			"dtTermBeneficio",
77			$this->std->dttermbeneficio,
78			true
79			);
80			$this->dom->addChild(
81			$infoBenTermino,
82			"mtvTermino",
83			$this->std->mtvtermino,
84			true
85			);
86			$this->dom->addChild(
87			$infoBenTermino,
88			"cnpjOrgaoSuc",
89			$this->std->cnpjorgaosuc,
90			false
91			);
92			$this->dom->addChild(
93			$infoBenTermino,
94			"novoCPF",
95			$this->std->novocpf,
96			false
97			);
98			$this->node->appendChild($infoBenTermino);
99			//finalização do xml
100			$this->eSocial->appendChild($this->node);
			0 ignored issues – show Bug introduced 2021-05-14 20:05 UTC by Report Bug Copy Issue Report The property `eSocial` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
101			//$this->xml = $this->dom->saveXML($this->eSocial);
102			$this->sign();
			0 ignored issues – show Bug introduced 2021-05-14 20:05 UTC by Report Bug Copy Issue Report It seems like `sign()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
103			}
104			}
105

nfephp-org / sped-esocial

Push — master ( 0fe426...8c51ed )

TraitS2420::toNodeS100() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like