J932::__construct() - Code Metrics - Inspection of "elemnetos bloco K" - nfephp-org/sped-ecd - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 624185...e43015 )

by Roberto

created 2020-07-29 20:24 UTC

J932::__construct() A

↳ Parent: J932

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	6
Ratio	100 %

Importance

Changes

Metric	Value
dl	6
loc	6
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php

namespace NFePHP\ECD\Elements;

use NFePHP\ECD\Common\Element;
use NFePHP\ECD\Common\ElementInterface;
use \stdClass;

/**
 * Elemento J932 do Bloco J OBRIGATÓRIO [1:1]
 * REGISTRO J932: ABERTURA DO ARQUIVO DIGITAL E IDENTIFICAÇÃO DO EMPRESÁRIO OU DA SOCIEDADE EMPRESÁRIA
 *
 * OBS.: Fazer verificacao de tamanho do campo ident_cpf_cnpj_t quando preencher os dados;
 */
class J932 extends Element implements ElementInterface

{
    const REG = 'J932';
    const LEVEL = 3;
    const PARENT = '';

    protected $parameters = [
        'ident_nom_t' => [
            'type'     => 'string',
            'regex'    => '^[A-Za-z]$',
            'required' => true,
            'info'     => 'Nome do signatário.',
            'format'   => ''
        ],
        'ident_cpf_cnpj_t' => [
            'type'     => 'numeric',
            'regex'    => '^[0-9]$',
            'required' => true,
            'info'     => 'CPF ou CNPJ',
            'format'   => ''
        ],
        'ident_qualif_t' => [
            'type'     => 'string',
            'regex'    => '^[A-Za-z0-9]$',
            'required' => true,
            'info'     => 'Qualificação do assinante, conforme tabela.',
            'format'   => ''
        ],
        'cod_assin_t' => [
            'type'     => 'string',
            'regex'    => '^[A-Za-z0-9]{3}$',
            'required' => true,
            'info'     => 'Código de qualificação do assinante, conforme tabela.',
            'format'   => ''
        ],
        'ind_crc_t' => [
            'type'     => 'string',
            'regex'    => '^[A-Za-z0-9]$',
            'required' => false,
            'info'     => 'Número de inscrição do contabilista no Conselho Regional de Contabilidade.',
            'format'   => ''
        ],
        'email_t' => [
            'type'     => 'string',
            'regex'    => '^[A-Za-z0-9]{60}$',
            'required' => false,
            'info'     => 'Email do signatário.',
            'format'   => ''
        ],
        'fone_t' => [
            'type'     => 'string',
            'regex'    => '^[0-9]{14}$',
            'required' => false,
            'info'     => 'Telefone do signatário.',
            'format'   => ''
        ],
        'uf_crc_t' => [
            'type'     => 'string',
            'regex'    => '^[A-Z]{2}$',
            'required' => false,
            'info'     => 'Indicação da unidade da federação que expediu o CRC.',
            'format'   => ''
        ],
        'num_seq_crc_t' => [
            'type'     => 'string',
            'regex'    => '^[0-9]$',
            'required' => false,
            'info'     => 'Número da Certidão de Regularidade Profissional do Contador no '
                . 'seguinte formato: UF/ano/número',
            'format'   => ''
        ],
        'dt_crc_t'     => [
            'type'     => 'string',
            'regex'    => '^(0[1-9]|[1-2][0-9]|31(?!(?:0[2469]|11))|30(?!02))(0[1-9]|1[0-2])([12]\d{3})$',
            'required' => false,
            'info'     => 'Data de validade da Certidão de Regularidade Profissional do Contador.',
            'format'   => ''
        ]
    ];

    /**
     * Constructor
     * @param \stdClass $std
     */
    public function __construct(\stdClass $std)
    {
        parent::__construct(self::REG);
        $this->std = $this->standarize($std);
        $this->postValidation();
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
    }
}


1		<?php
2
3		namespace NFePHP\ECD\Elements;
4
5		use NFePHP\ECD\Common\Element;
6		use NFePHP\ECD\Common\ElementInterface;
7		use \stdClass;
8
9		/**
10		* Elemento J932 do Bloco J OBRIGATÓRIO [1:1]
11		* REGISTRO J932: ABERTURA DO ARQUIVO DIGITAL E IDENTIFICAÇÃO DO EMPRESÁRIO OU DA SOCIEDADE EMPRESÁRIA
12		*
13		* OBS.: Fazer verificacao de tamanho do campo ident_cpf_cnpj_t quando preencher os dados;
14		*/
15	View Code Duplication	class J932 extends Element implements ElementInterface
		0 ignored issues – show Duplication introduced 2020-07-29 20:37 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
16		{
17		const REG = 'J932';
18		const LEVEL = 3;
19		const PARENT = '';
20
21		protected $parameters = [
22		'ident_nom_t' => [
23		'type' => 'string',
24		'regex' => '^[A-Za-z]$',
25		'required' => true,
26		'info' => 'Nome do signatário.',
27		'format' => ''
28		],
29		'ident_cpf_cnpj_t' => [
30		'type' => 'numeric',
31		'regex' => '^[0-9]$',
32		'required' => true,
33		'info' => 'CPF ou CNPJ',
34		'format' => ''
35		],
36		'ident_qualif_t' => [
37		'type' => 'string',
38		'regex' => '^[A-Za-z0-9]$',
39		'required' => true,
40		'info' => 'Qualificação do assinante, conforme tabela.',
41		'format' => ''
42		],
43		'cod_assin_t' => [
44		'type' => 'string',
45		'regex' => '^[A-Za-z0-9]{3}$',
46		'required' => true,
47		'info' => 'Código de qualificação do assinante, conforme tabela.',
48		'format' => ''
49		],
50		'ind_crc_t' => [
51		'type' => 'string',
52		'regex' => '^[A-Za-z0-9]$',
53		'required' => false,
54		'info' => 'Número de inscrição do contabilista no Conselho Regional de Contabilidade.',
55		'format' => ''
56		],
57		'email_t' => [
58		'type' => 'string',
59		'regex' => '^[A-Za-z0-9]{60}$',
60		'required' => false,
61		'info' => 'Email do signatário.',
62		'format' => ''
63		],
64		'fone_t' => [
65		'type' => 'string',
66		'regex' => '^[0-9]{14}$',
67		'required' => false,
68		'info' => 'Telefone do signatário.',
69		'format' => ''
70		],
71		'uf_crc_t' => [
72		'type' => 'string',
73		'regex' => '^[A-Z]{2}$',
74		'required' => false,
75		'info' => 'Indicação da unidade da federação que expediu o CRC.',
76		'format' => ''
77		],
78		'num_seq_crc_t' => [
79		'type' => 'string',
80		'regex' => '^[0-9]$',
81		'required' => false,
82		'info' => 'Número da Certidão de Regularidade Profissional do Contador no '
83		. 'seguinte formato: UF/ano/número',
84		'format' => ''
85		],
86		'dt_crc_t' => [
87		'type' => 'string',
88		'regex' => '^(0[1-9]\|[1-2][0-9]\|31(?!(?:0[2469]\|11))\|30(?!02))(0[1-9]\|1[0-2])([12]\d{3})$',
89		'required' => false,
90		'info' => 'Data de validade da Certidão de Regularidade Profissional do Contador.',
91		'format' => ''
92		]
93		];
94
95		/**
96		* Constructor
97		* @param \stdClass $std
98		*/
99		public function __construct(\stdClass $std)
100		{
101		parent::__construct(self::REG);
102		$this->std = $this->standarize($std);
103		$this->postValidation();
		0 ignored issues – show Unused Code introduced 2020-07-29 20:37 UTC by Report Bug Copy Issue Report The call to the method `NFePHP\ECD\Elements\J932::postValidation()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
104		}
105		}
106

nfephp-org / sped-ecd

Push — master ( 624185...e43015 )

J932::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like