I053 - Code Metrics - Inspection of "Merge pull request #63 from robmachado/master" - nfephp-org/sped-ecd - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( df7a74...493c6b )

by Roberto

created 2020-07-27 19:02 UTC

I053 A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	43
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

Metric	Value
wmc	1
lcom	0
cbo	1
dl	43
loc	43
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	__construct()	6	6	1

How to fix Duplicated Code

<?php

namespace NFePHP\ECD\Elements;

use NFePHP\ECD\Common\Element;
use NFePHP\ECD\Common\ElementInterface;
use \stdClass;

/**
 * Elemento I053 do Bloco I OBRIGATÓRIO [0:N]
 * REGISTRO I053: SUBCONTAS CORRELATAS
 */
class I053 extends Element implements ElementInterface

{
    const REG = 'I053';
    const LEVEL = 4;
    const PARENT = '';

    protected $parameters = [
        'cod_idt'     => [
            'type'     => 'string',
            'regex'    => '^[A-Za-z0-9]{6}$',
            'required' => true,
            'info'     => 'Codigo de identificacao do grupo de conta-subcontas.',
            'format'   => ''
        ],
        'cod_cnt_corr'  => [
            'type'     => 'string',
            'regex'    => '^[A-Za-z0-9]$',
            'required' => true,
            'info'     => 'Código da subconta correlata (deve estar no plano de contas '
                . 'e só pode estar relacionada a um único grupo)',
            'format'   => ''
        ],
        'nat_sub_cnt'  => [
            'type'     => 'string',
            'regex'    => '^[A-Za-z0-9]{2}$',
            'required' => true,
            'info'     => 'Natureza da subconta correlata (conforme tabela de '
                . 'natureza da subconta publicada no Sped )',
            'format'   => ''
        ]
    ];

    /**
     * Constructor
     * @param \stdClass $std
     */
    public function __construct(\stdClass $std)
    {
        parent::__construct(self::REG);
        $this->std = $this->standarize($std);
        $this->postValidation();
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
    }
}


1		<?php
2
3		namespace NFePHP\ECD\Elements;
4
5		use NFePHP\ECD\Common\Element;
6		use NFePHP\ECD\Common\ElementInterface;
7		use \stdClass;
8
9		/**
10		* Elemento I053 do Bloco I OBRIGATÓRIO [0:N]
11		* REGISTRO I053: SUBCONTAS CORRELATAS
12		*/
13	View Code Duplication	class I053 extends Element implements ElementInterface
		0 ignored issues – show Duplication introduced 2020-07-27 19:17 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
14		{
15		const REG = 'I053';
16		const LEVEL = 4;
17		const PARENT = '';
18
19		protected $parameters = [
20		'cod_idt' => [
21		'type' => 'string',
22		'regex' => '^[A-Za-z0-9]{6}$',
23		'required' => true,
24		'info' => 'Codigo de identificacao do grupo de conta-subcontas.',
25		'format' => ''
26		],
27		'cod_cnt_corr' => [
28		'type' => 'string',
29		'regex' => '^[A-Za-z0-9]$',
30		'required' => true,
31		'info' => 'Código da subconta correlata (deve estar no plano de contas '
32		. 'e só pode estar relacionada a um único grupo)',
33		'format' => ''
34		],
35		'nat_sub_cnt' => [
36		'type' => 'string',
37		'regex' => '^[A-Za-z0-9]{2}$',
38		'required' => true,
39		'info' => 'Natureza da subconta correlata (conforme tabela de '
40		. 'natureza da subconta publicada no Sped )',
41		'format' => ''
42		]
43		];
44
45		/**
46		* Constructor
47		* @param \stdClass $std
48		*/
49		public function __construct(\stdClass $std)
50		{
51		parent::__construct(self::REG);
52		$this->std = $this->standarize($std);
53		$this->postValidation();
		0 ignored issues – show Unused Code introduced 2020-07-27 19:17 UTC by Report Bug Copy Issue Report The call to the method `NFePHP\ECD\Elements\I053::postValidation()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
54		}
55		}
56

nfephp-org / sped-ecd

Push — master ( df7a74...493c6b )

I053 A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like