I355 - Code Metrics - nfephp-org/sped-ecd - Measure and Improve Code Quality continuously with Scrutinizer

I355 A
last analyzed 2020-07-29 21:07 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	63
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

Metric	Value
wmc	1
lcom	0
cbo	1
dl	63
loc	63
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	__construct()	6	6	1

How to fix Duplicated Code

<?php

namespace NFePHP\ECD\Elements;

use NFePHP\ECD\Common\Element;
use NFePHP\ECD\Common\ElementInterface;
use \stdClass;

/**
 * Elemento I355 do Bloco I OBRIGATÓRIO [1:1]
 * REGISTRO I355: ABERTURA DO ARQUIVO DIGITAL E IDENTIFICAÇÃO DO EMPRESÁRIO OU DA SOCIEDADE EMPRESÁRIA
 *
 * Alterar campos: vl_cta e vl_cta_mf
 */
class I355 extends Element implements ElementInterface

{
    const REG = 'I355';
    const LEVEL = 4;
    const PARENT = '';

    protected $parameters = [
        'cod_cta' => [
            'type'     => 'string',
            'regex'    => '^[A-Za-z0-9]$',
            'required' => true,
            'info'     => 'Código da conta analítica de resultado.',
            'format'   => ''
        ],
        'cod_ccus' => [
            'type'     => 'string',
            'regex'    => '^[A-Za-z0-9]$',
            'required' => false,
            'info'     => 'Código do centro de custos.',
            'format'   => ''
        ],
        'vl_cta'     => [
            'type'     => 'string',
            'regex'    => '^[0-9]{19}$',
            'required' => true,
            'info'     => 'Valor do saldo final antes do lançamento de encerramento.',
            'format'   => ''
        ],
        'ind_dc' => [
            'type'     => 'string',
            'regex'    => '^(D|C)$',
            'required' => true,
            'info'     => 'Indicador da situação do saldo final: D - Devedor; C - Credor.',
            'format'   => ''
        ],
        'vl_cta_mf'     => [
            'type'     => 'string',
            'regex'    => '^[0-9]{19}$',
            'required' => false,
            'info'     => 'Valor do saldo final antes do lançamento de encerramento em moeda funcional,'
                . ' convertido para reais.',
            'format'   => ''
        ],
        'ind_dc_mf' => [
            'type'     => 'string',
            'regex'    => '^(D|C)$',
            'required' => false,
            'info'     => 'Indicador da situação do saldo final em moeda funcional: D - Devedor; C - Credor.',
            'format'   => ''
        ]
    ];

    /**
     * Constructor
     * @param \stdClass $std
     */
    public function __construct(\stdClass $std)
    {
        parent::__construct(self::REG);
        $this->std = $this->standarize($std);
        $this->postValidation();
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
    }
}


1		<?php
2
3		namespace NFePHP\ECD\Elements;
4
5		use NFePHP\ECD\Common\Element;
6		use NFePHP\ECD\Common\ElementInterface;
7		use \stdClass;
8
9		/**
10		* Elemento I355 do Bloco I OBRIGATÓRIO [1:1]
11		* REGISTRO I355: ABERTURA DO ARQUIVO DIGITAL E IDENTIFICAÇÃO DO EMPRESÁRIO OU DA SOCIEDADE EMPRESÁRIA
12		*
13		* Alterar campos: vl_cta e vl_cta_mf
14		*/
15	View Code Duplication	class I355 extends Element implements ElementInterface
		0 ignored issues – show Duplication introduced 2020-07-27 19:17 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
16		{
17		const REG = 'I355';
18		const LEVEL = 4;
19		const PARENT = '';
20
21		protected $parameters = [
22		'cod_cta' => [
23		'type' => 'string',
24		'regex' => '^[A-Za-z0-9]$',
25		'required' => true,
26		'info' => 'Código da conta analítica de resultado.',
27		'format' => ''
28		],
29		'cod_ccus' => [
30		'type' => 'string',
31		'regex' => '^[A-Za-z0-9]$',
32		'required' => false,
33		'info' => 'Código do centro de custos.',
34		'format' => ''
35		],
36		'vl_cta' => [
37		'type' => 'string',
38		'regex' => '^[0-9]{19}$',
39		'required' => true,
40		'info' => 'Valor do saldo final antes do lançamento de encerramento.',
41		'format' => ''
42		],
43		'ind_dc' => [
44		'type' => 'string',
45		'regex' => '^(D\|C)$',
46		'required' => true,
47		'info' => 'Indicador da situação do saldo final: D - Devedor; C - Credor.',
48		'format' => ''
49		],
50		'vl_cta_mf' => [
51		'type' => 'string',
52		'regex' => '^[0-9]{19}$',
53		'required' => false,
54		'info' => 'Valor do saldo final antes do lançamento de encerramento em moeda funcional,'
55		. ' convertido para reais.',
56		'format' => ''
57		],
58		'ind_dc_mf' => [
59		'type' => 'string',
60		'regex' => '^(D\|C)$',
61		'required' => false,
62		'info' => 'Indicador da situação do saldo final em moeda funcional: D - Devedor; C - Credor.',
63		'format' => ''
64		]
65		];
66
67		/**
68		* Constructor
69		* @param \stdClass $std
70		*/
71		public function __construct(\stdClass $std)
72		{
73		parent::__construct(self::REG);
74		$this->std = $this->standarize($std);
75		$this->postValidation();
		0 ignored issues – show Unused Code introduced 2020-07-27 19:17 UTC by Report Bug Copy Issue Report The call to the method `NFePHP\ECD\Elements\I355::postValidation()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
76		}
77		}
78

nfephp-org / sped-ecd

I355 A last analyzed 2020-07-29 21:07 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

I355 A
last analyzed 2020-07-29 21:07 UTC