Complex classes like Tools often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Tools, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
34 | class Tools |
||
35 | { |
||
36 | /** |
||
37 | * config class |
||
38 | * @var \stdClass |
||
39 | */ |
||
40 | public $config; |
||
41 | /** |
||
42 | * Path to storage folder |
||
43 | * @var string |
||
44 | */ |
||
45 | public $pathwsfiles = ''; |
||
46 | /** |
||
47 | * Path to schemes folder |
||
48 | * @var string |
||
49 | */ |
||
50 | public $pathschemes = ''; |
||
51 | /** |
||
52 | * ambiente |
||
53 | * @var string |
||
54 | */ |
||
55 | public $ambiente = 'homologacao'; |
||
56 | /** |
||
57 | * Environment |
||
58 | * @var int |
||
59 | */ |
||
60 | public $tpAmb = 2; |
||
61 | /** |
||
62 | * contingency class |
||
63 | * @var Contingency |
||
64 | */ |
||
65 | public $contingency; |
||
66 | /** |
||
67 | * soap class |
||
68 | * @var SoapInterface |
||
69 | */ |
||
70 | public $soap; |
||
71 | /** |
||
72 | * Application version |
||
73 | * @var string |
||
74 | */ |
||
75 | public $verAplic = ''; |
||
76 | /** |
||
77 | * last soap request |
||
78 | * @var string |
||
79 | */ |
||
80 | public $lastRequest = ''; |
||
81 | /** |
||
82 | * last soap response |
||
83 | * @var string |
||
84 | */ |
||
85 | public $lastResponse = ''; |
||
86 | /** |
||
87 | * certificate class |
||
88 | * @var Certificate |
||
89 | */ |
||
90 | protected $certificate; |
||
91 | /** |
||
92 | * Sign algorithm from OPENSSL |
||
93 | * @var int |
||
94 | */ |
||
95 | protected $algorithm = OPENSSL_ALGO_SHA1; |
||
96 | /** |
||
97 | * Canonical conversion options |
||
98 | * @var array |
||
99 | */ |
||
100 | protected $canonical = [true, false, null, null]; |
||
101 | /** |
||
102 | * Model of CTe 57 or 67 |
||
103 | * @var int |
||
104 | */ |
||
105 | protected $modelo = 57; |
||
106 | /** |
||
107 | * Version of layout |
||
108 | * @var string |
||
109 | */ |
||
110 | protected $versao = '3.00'; |
||
111 | /** |
||
112 | * urlPortal |
||
113 | * Instância do WebService |
||
114 | * |
||
115 | * @var string |
||
116 | */ |
||
117 | protected $urlPortal = 'http://www.portalfiscal.inf.br/cte'; |
||
118 | /** |
||
119 | * urlcUF |
||
120 | * @var string |
||
121 | */ |
||
122 | protected $urlcUF = ''; |
||
123 | /** |
||
124 | * urlVersion |
||
125 | * @var string |
||
126 | */ |
||
127 | protected $urlVersion = ''; |
||
128 | /** |
||
129 | * urlService |
||
130 | * @var string |
||
131 | */ |
||
132 | protected $urlService = ''; |
||
133 | /** |
||
134 | * @var string |
||
135 | */ |
||
136 | protected $urlMethod = ''; |
||
137 | /** |
||
138 | * @var string |
||
139 | */ |
||
140 | protected $urlOperation = ''; |
||
141 | /** |
||
142 | * @var string |
||
143 | */ |
||
144 | protected $urlNamespace = ''; |
||
145 | /** |
||
146 | * @var string |
||
147 | */ |
||
148 | protected $urlAction = ''; |
||
149 | /** |
||
150 | * @var \SOAPHeader |
||
151 | */ |
||
152 | protected $objHeader; |
||
153 | /** |
||
154 | * @var string |
||
155 | */ |
||
156 | protected $urlHeader = ''; |
||
157 | /** |
||
158 | * @var array |
||
159 | */ |
||
160 | protected $soapnamespaces = [ |
||
161 | 'xmlns:xsi' => "http://www.w3.org/2001/XMLSchema-instance", |
||
162 | 'xmlns:xsd' => "http://www.w3.org/2001/XMLSchema", |
||
163 | 'xmlns:soap' => "http://www.w3.org/2003/05/soap-envelope" |
||
164 | ]; |
||
165 | /** |
||
166 | * @var array |
||
167 | */ |
||
168 | protected $availableVersions = [ |
||
169 | '3.00' => 'PL_CTe_300a' |
||
170 | ]; |
||
171 | /** |
||
172 | * @var string |
||
173 | */ |
||
174 | protected $timezone; |
||
175 | |||
176 | /** |
||
177 | * Constructor |
||
178 | * load configurations, |
||
179 | * load Digital Certificate, |
||
180 | * map all paths, |
||
181 | * set timezone and |
||
182 | * and instanciate Contingency::class |
||
183 | * @param string $configJson content of config in json format |
||
184 | * @param Certificate $certificate |
||
185 | */ |
||
186 | public function __construct($configJson, Certificate $certificate) |
||
199 | |||
200 | /** |
||
201 | * set version in http |
||
202 | * |
||
203 | * @param string $sigla Sigla da uf |
||
204 | * @return void |
||
205 | */ |
||
206 | private function setEnvironmentHttpVersion($sigla) |
||
214 | |||
215 | /** |
||
216 | * Sets environment time zone |
||
217 | * @param string $acronym (ou seja a sigla do estado) |
||
218 | * @return void |
||
219 | */ |
||
220 | public function setEnvironmentTimeZone($acronym) |
||
224 | |||
225 | /** |
||
226 | * Set application version |
||
227 | * @param string $ver |
||
228 | */ |
||
229 | public function setVerAplic($ver) |
||
233 | |||
234 | /** |
||
235 | * Load Soap Class |
||
236 | * Soap Class may be \NFePHP\Common\Soap\SoapNative |
||
237 | * or \NFePHP\Common\Soap\SoapCurl |
||
238 | * @param SoapInterface $soap |
||
239 | * @return void |
||
240 | */ |
||
241 | public function loadSoapClass(SoapInterface $soap) |
||
246 | |||
247 | /** |
||
248 | * Set OPENSSL Algorithm using OPENSSL constants |
||
249 | * @param int $algorithm |
||
250 | * @return void |
||
251 | */ |
||
252 | public function setSignAlgorithm($algorithm = OPENSSL_ALGO_SHA1) |
||
256 | |||
257 | /** |
||
258 | * Set or get model of document CTe = 57 or CTeOS = 67 |
||
259 | * @param int $model |
||
260 | * @return int modelo class parameter |
||
261 | */ |
||
262 | public function model($model = null) |
||
269 | |||
270 | /** |
||
271 | * Set or get parameter layout version |
||
272 | * @param string $version |
||
273 | * @return string |
||
274 | * @throws InvalidArgumentException |
||
275 | */ |
||
276 | public function version($version = '') |
||
290 | |||
291 | /** |
||
292 | * Recover cUF number from state acronym |
||
293 | * @param string $acronym Sigla do estado |
||
294 | * @return int number cUF |
||
295 | */ |
||
296 | public function getcUF($acronym) |
||
300 | |||
301 | /** |
||
302 | * Recover state acronym from cUF number |
||
303 | * @param int $cUF |
||
304 | * @return string acronym sigla |
||
305 | */ |
||
306 | public function getAcronym($cUF) |
||
310 | |||
311 | /** |
||
312 | * Validate cUF from the key content and returns the state acronym |
||
313 | * @param string $chave |
||
314 | * @return string |
||
315 | * @throws InvalidArgumentException |
||
316 | */ |
||
317 | public function validKeyByUF($chave) |
||
327 | |||
328 | /** |
||
329 | * Sign CTe |
||
330 | * @param string $xml CTe xml content |
||
331 | * @return string singed CTe xml |
||
332 | * @throws RuntimeException |
||
333 | */ |
||
334 | public function signCTe($xml) |
||
410 | |||
411 | /** |
||
412 | * @param string $Dom CTe xml content |
||
413 | * @param string $xml CTe xml content |
||
414 | * @return string|bool |
||
415 | * @todo |
||
416 | * Retorna o xml do modal especifico |
||
417 | */ |
||
418 | public function getModalXML($dom, $modal) |
||
427 | |||
428 | /** |
||
429 | * @todo |
||
430 | * Corret NFe fields when in contingency mode is set |
||
431 | * @param string $xml CTe xml content |
||
432 | * @return string |
||
433 | */ |
||
434 | protected function correctCTeForContingencyMode($xml) |
||
442 | |||
443 | /** |
||
444 | * Performs xml validation with its respective |
||
445 | * XSD structure definition document |
||
446 | * NOTE: if dont exists the XSD file will return true |
||
447 | * @param string $version layout version |
||
448 | * @param string $body |
||
449 | * @param string $method |
||
450 | * @return boolean |
||
451 | */ |
||
452 | protected function isValid($version, $body, $method) |
||
463 | |||
464 | /** |
||
465 | * Verifies the existence of the service |
||
466 | * @param string $service |
||
467 | * @throws RuntimeException |
||
468 | */ |
||
469 | protected function checkContingencyForWebServices($service) |
||
487 | |||
488 | /** |
||
489 | * Alter environment from "homologacao" to "producao" and vice-versa |
||
490 | * @param int $tpAmb |
||
491 | * @return void |
||
492 | */ |
||
493 | public function setEnvironment($tpAmb = 2) |
||
500 | |||
501 | /** |
||
502 | * Set option for canonical transformation see C14n |
||
503 | * @param array $opt |
||
504 | * @return array |
||
505 | */ |
||
506 | public function canonicalOptions($opt = [true, false, null, null]) |
||
513 | |||
514 | /** |
||
515 | * Assembles all the necessary parameters for soap communication |
||
516 | * @param string $service |
||
517 | * @param string $uf |
||
518 | * @param string $tpAmb |
||
519 | * @param bool $ignoreContingency |
||
520 | * @return void |
||
521 | */ |
||
522 | protected function servico( |
||
591 | |||
592 | /** |
||
593 | * Send request message to webservice |
||
594 | * @param array $parameters |
||
595 | * @param string $request |
||
596 | * @return string |
||
597 | */ |
||
598 | protected function sendRequest($request, array $parameters = []) |
||
612 | |||
613 | /** |
||
614 | * Recover path to xml data base with list of soap services |
||
615 | * @return string |
||
616 | */ |
||
617 | protected function getXmlUrlPath() |
||
627 | |||
628 | /** |
||
629 | * Add QRCode Tag to signed XML from a NFCe |
||
630 | * @param DOMDocument $dom |
||
631 | * @return string |
||
632 | */ |
||
633 | protected function addQRCode(DOMDocument $dom) |
||
664 | |||
665 | /** |
||
666 | * Verify if SOAP class is loaded, if not, force load SoapCurl |
||
667 | */ |
||
668 | protected function checkSoap() |
||
674 | } |
||
675 |
It seems like the type of the argument is not accepted by the function/method which you are calling.
In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.
We suggest to add an explicit type cast like in the following example: