Certificate::isExpired() - Code Metrics - Inspection of "create a Certificate value object" - nfephp-org/sped-common - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#43)

by Antonio Oertel

created 2016-08-19 05:02 UTC

Certificate::isExpired() A

↳ Parent: Certificate

Complexity

Conditions	2
Paths	2

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	5
rs	9.4285
cc	2
eloc	3
nc	2
nop	0

<?php

namespace NFePHP\Common;

use NFePHP\Common\Exception\CertificateException;

class Certificate
{
    /**
     * @var string
     */
    public $companyName;

    /**
     * @var string
     */
    public $privateKey;

    /**
     * @var string
     */
    public $publicKey;

    /**
     * @var \DateTime
     */
    public $validFrom;

    /**
     * @var \DateTime
     */
    public $validTo;

    public function __construct($content, $password = '')
    {
        $this->read($content, $password);
        $this->load();
    }

    private function read($content, $password)
    {
        $certs = [];
        if (!openssl_pkcs12_read($content, $certs, $password)) {
            throw CertificateException::unableToRead();
        }
        $this->privateKey = $certs['pkey'];
        $this->publicKey = $certs['cert'];
    }

    private function load()
    {
        if (!$resource = openssl_x509_read($this->publicKey)) {
            throw CertificateException::unableToOpen();
        }

        $detail = openssl_x509_parse($resource, false);

        $this->companyName = $detail['subject']['organizationName'];
        $this->validFrom = \DateTime::createFromFormat('ymdHis\Z', $detail['validFrom']);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $this->validTo = \DateTime::createFromFormat('ymdHis\Z', $detail['validTo']);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }

    /**
     * Check if certificate has been expired.
     * @return bool Returns true when it is truth, otherwise false.
     */
    public function isExpired()
    {
        $now = new \DateTime('now');
        return $this->validFrom <= $now && $this->validTo >= $now;
    }

    public function encrypt($content, $algorithm = OPENSSL_ALGO_SHA1)
    {
        if (!$privateResource = openssl_pkey_get_private($this->privateKey)) {
            throw CertificateException::getPrivateKey();
        }

        $encryptedData = '';
        if (!openssl_sign($content, $encryptedData, $privateResource, $algorithm)) {
            throw CertificateException::signContent();
        }
        return $encryptedData;
    }
}


1			<?php
2
3			namespace NFePHP\Common;
4
5			use NFePHP\Common\Exception\CertificateException;
6
7			class Certificate
8			{
9			/**
10			* @var string
11			*/
12			public $companyName;
13
14			/**
15			* @var string
16			*/
17			public $privateKey;
18
19			/**
20			* @var string
21			*/
22			public $publicKey;
23
24			/**
25			* @var \DateTime
26			*/
27			public $validFrom;
28
29			/**
30			* @var \DateTime
31			*/
32			public $validTo;
33
34			public function __construct($content, $password = '')
35			{
36			$this->read($content, $password);
37			$this->load();
38			}
39
40			private function read($content, $password)
41			{
42			$certs = [];
43			if (!openssl_pkcs12_read($content, $certs, $password)) {
44			throw CertificateException::unableToRead();
45			}
46			$this->privateKey = $certs['pkey'];
47			$this->publicKey = $certs['cert'];
48			}
49
50			private function load()
51			{
52			if (!$resource = openssl_x509_read($this->publicKey)) {
53			throw CertificateException::unableToOpen();
54			}
55
56			$detail = openssl_x509_parse($resource, false);
57
58			$this->companyName = $detail['subject']['organizationName'];
59			$this->validFrom = \DateTime::createFromFormat('ymdHis\Z', $detail['validFrom']);
			0 ignored issues – show Documentation Bug introduced 2016-08-19 04:54 UTC by Report Bug Copy Issue Report It seems like `\DateTime::createFromFor..., $detail['validFrom'])` can also be of type `false`. However, the property `$validFrom` is declared as type `object<DateTime>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
60			$this->validTo = \DateTime::createFromFormat('ymdHis\Z', $detail['validTo']);
			0 ignored issues – show Documentation Bug introduced 2016-08-19 04:54 UTC by Report Bug Copy Issue Report It seems like `\DateTime::createFromFor...Z', $detail['validTo'])` can also be of type `false`. However, the property `$validTo` is declared as type `object<DateTime>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
61			}
62
63			/**
64			* Check if certificate has been expired.
65			* @return bool Returns true when it is truth, otherwise false.
66			*/
67			public function isExpired()
68			{
69			$now = new \DateTime('now');
70			return $this->validFrom <= $now && $this->validTo >= $now;
71			}
72
73			public function encrypt($content, $algorithm = OPENSSL_ALGO_SHA1)
74			{
75			if (!$privateResource = openssl_pkey_get_private($this->privateKey)) {
76			throw CertificateException::getPrivateKey();
77			}
78
79			$encryptedData = '';
80			if (!openssl_sign($content, $encryptedData, $privateResource, $algorithm)) {
81			throw CertificateException::signContent();
82			}
83			return $encryptedData;
84			}
85			}
86

nfephp-org / sped-common

Pull Request — master (#43)

Certificate::isExpired() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like