OCA\TwoFactorGateway\Service\Gateway\XMPP\Gateway

Complexity

Total Complexity

6

Size/Duplication

Total Lines	72
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	send()	0	31	4
A	__construct()	0	8	1
A	getConfig()	0	2	1

<?php

declare(strict_types=1);

/**
 * @author Rainer Dohmen <rdohmen@pensionmoselblick.de>
 *
 * Nextcloud - Two-factor Gateway for XMPP
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
 *
 */

namespace OCA\TwoFactorGateway\Service\Gateway\XMPP;

use OCA\TwoFactorGateway\Exception\SmsTransmissionException;
use OCA\TwoFactorGateway\Service\Gateway\IGateway;
use OCA\TwoFactorGateway\Service\Gateway\IGatewayConfig;
use OCP\Http\Client\IClient;
use OCP\Http\Client\IClientService;
use OCP\IConfig;
use OCP\ILogger;
use OCP\IUser;

class Gateway implements IGateway {

	/** @var IClient */
	private $client;

	/** @var GatewayConfig */
	private $gatewayConfig;

	/** @var IConfig */
	private $config;

	/** @var ILogger */
	private $logger;

	public function __construct(IClientService $clientService,
								GatewayConfig $gatewayConfig,
								IConfig $config,
								ILogger $logger) {
		$this->client = $clientService->newClient();
		$this->gatewayConfig = $gatewayConfig;
		$this->config = $config;
		$this->logger = $logger;
	}

	/**
	 * @param IUser $user
	 * @param string $identifier
	 * @param string $message
	 *
	 * @throws SmsTransmissionException
	 */
	public function send(IUser $user, string $identifier, string $message) {
		$this->logger->debug("sending xmpp message to $identifier, message: $message");

The function OCP\ILogger::debug() has been deprecated: 20.0.0 use \Psr\Log\LoggerInterface::debug

		$sender = $this->gatewayConfig->getSender();
		$password = $this->gatewayConfig->getPassword();
		$server = $this->gatewayConfig->getServer();
		$method = $this->gatewayConfig->getMethod();
		$user = $this->gatewayConfig->getUsername();
		$url = $server.$identifier;

		if ($method === "1") {
			$from = $user;
		}
		if ($method === "2") {
			$from = $sender;
		}
		$this->logger->debug("URL: $url, sender: $sender, method: $method");

The function OCP\ILogger::debug() has been deprecated: 20.0.0 use \Psr\Log\LoggerInterface::debug

		try {
			$ch = curl_init();
			curl_setopt($ch, CURLOPT_URL, $url);
			curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
			curl_setopt($ch, CURLOPT_POST, 1);
			curl_setopt($ch, CURLOPT_POSTFIELDS, $message);
			curl_setopt($ch, CURLOPT_USERPWD, $from.":".$password);

The variable $from does not seem to be defined for all execution paths leading up to this point.

			curl_setopt($ch, CURLOPT_HTTPHEADER, array('Content-Type: text/plain'));
			$result = curl_exec($ch);

The assignment to $result is dead and can be removed.

			curl_close($ch);
			$this->logger->debug("XMPP message to $identifier sent");

The function OCP\ILogger::debug() has been deprecated: 20.0.0 use \Psr\Log\LoggerInterface::debug

		} catch (Exception $ex) {

The type OCA\TwoFactorGateway\Service\Gateway\XMPP\Exception was not found. Did you mean Exception? If so, make sure to prefix the type with \.

			throw new SmsTransmissionException();
		}
	}

	/**
	 * Get the gateway-specific configuration
	 *
	 * @return IGatewayConfig
	 */
	public function getConfig(): IGatewayConfig {
		return $this->gatewayConfig;
	}
}