OCA\TwoFactorGateway\Service\Gateway\SMS\Provider\PuzzelSMS

Complexity

Total Complexity

4

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getConfig()	0	2	1
A	send()	0	18	2
A	__construct()	0	4	1

<?php

declare(strict_types=1);

/**
 * @author Kim Syversen <kim.syversen@gmail.com>
 *
 * Nextcloud - Two-factor Gateway
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
 *
 */

namespace OCA\TwoFactorGateway\Service\Gateway\SMS\Provider;

use Exception;
use OCA\TwoFactorGateway\Exception\SmsTransmissionException;
use OCP\Http\Client\IClient;
use OCP\Http\Client\IClientService;
use OCP\IConfig;

class PuzzelSMS implements IProvider {

	const PROVIDER_ID = 'puzzelsms';

	/** @var IClient */
	private $client;

	/** @var PuzzelConfig */

The type OCA\TwoFactorGateway\Service\Gateway\SMS\Provider\PuzzelConfig was not found. Maybe you did not declare it correctly or list all dependencies?

	private $config;

	public function __construct(IClientService $clientService,
								PuzzelSMSConfig $config) {
		$this->client = $clientService->newClient();
		$this->config = $config;

It seems like $config of type OCA\TwoFactorGateway\Service\Gateway\SMS\Provider\PuzzelSMSConfig is incompatible with the declared type OCA\TwoFactorGateway\Service\Gateway\SMS\Provider\PuzzelConfig of property $config.

	}

	/**
	 * @param string $identifier
	 * @param string $message
	 *
	 * @throws SmsTransmissionException
	 */
	public function send(string $identifier, string $message) {
		$config = $this->getConfig();

		try {
			$this->client->get(
				$config->getUrl(),

The method getUrl() does not exist on OCA\TwoFactorGateway\Service\Gateway\SMS\Provider\IProviderConfig. It seems like you code against a sub-type of OCA\TwoFactorGateway\Service\Gateway\SMS\Provider\IProviderConfig such as OCA\TwoFactorGateway\Service\Gateway\SMS\Provider\PlaySMSConfig or OCA\TwoFactorGateway\Service\Gateway\SMS\Provider\PuzzelSMSConfig.

				[
					'query' => [
						'username' => $config->getUser(),

The method getUser() does not exist on OCA\TwoFactorGateway\Service\Gateway\SMS\Provider\IProviderConfig. It seems like you code against a sub-type of said class. However, the method does not exist in OCA\TwoFactorGateway\Service\Gateway\SMS\Provider\ClockworkSMSConfig. Are you sure you never get one of those?

						'password' => $config->getPassword(),

The method getPassword() does not exist on OCA\TwoFactorGateway\Service\Gateway\SMS\Provider\IProviderConfig. It seems like you code against a sub-type of said class. However, the method does not exist in OCA\TwoFactorGateway\Service\Gateway\SMS\Provider\ClockworkSMSConfig. Are you sure you never get one of those?

						"message[0].recipient" => "+".$identifier,
						"message[0].content" => $message,
						'serviceId'=> $config->getServiceId(),

The method getServiceId() does not exist on OCA\TwoFactorGateway\Service\Gateway\SMS\Provider\IProviderConfig. It seems like you code against a sub-type of OCA\TwoFactorGateway\Service\Gateway\SMS\Provider\IProviderConfig such as OCA\TwoFactorGateway\Service\Gateway\SMS\Provider\PuzzelSMSConfig.

					],
				]
			);
		} catch (Exception $ex) {
			throw new SmsTransmissionException();
		}
	}

	/**
	 * @return PuzzelConfig
	 */
	public function getConfig(): IProviderConfig {
		return $this->config;
	}

}