| Conditions | 12 |
| Paths | 12 |
| Total Lines | 26 |
| Code Lines | 25 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 8 | ||
| Bugs | 0 | Features | 3 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 38 | public function getProvider(string $id): IProvider { |
||
| 39 | switch ($id) { |
||
| 40 | case PuzzelSMS::PROVIDER_ID: |
||
| 41 | return $this->container->query(PuzzelSMS::class); |
||
| 42 | case PlaySMS::PROVIDER_ID: |
||
| 43 | return $this->container->query(PlaySMS::class); |
||
| 44 | case WebSms::PROVIDER_ID: |
||
| 45 | return $this->container->query(WebSms::class); |
||
| 46 | case ClockworkSMS::PROVIDER_ID: |
||
| 47 | return $this->container->query(ClockworkSMS::class); |
||
| 48 | case EcallSMS::PROVIDER_ID: |
||
| 49 | return $this->container->query(EcallSMS::class); |
||
| 50 | case VoipMs::PROVIDER_ID: |
||
| 51 | return $this->container->query(VoipMs::class); |
||
| 52 | case HuaweiE3531::PROVIDER_ID: |
||
| 53 | return $this->container->query(HuaweiE3531::class); |
||
| 54 | case Sms77Io::PROVIDER_ID: |
||
| 55 | return $this->container->query(Sms77Io::class); |
||
| 56 | case Ovh::PROVIDER_ID: |
||
| 57 | return $this->container->query(Ovh::class); |
||
| 58 | case SpryngSMS::PROVIDER_ID: |
||
| 59 | return $this->container->query(SpryngSMS::class); |
||
| 60 | case ClickatellCentral::PROVIDER_ID: |
||
| 61 | return $this->container->query(ClickatellCentral::class); |
||
| 62 | default: |
||
| 63 | throw new InvalidSmsProviderException("Provider <$id> does not exist"); |
||
| 64 | } |
||
| 68 |