OCA\TwoFactorGateway\Provider\Channel\Telegram\Provider\AProvider

Complexity

Total Complexity

11

Size/Duplication

Total Lines	55
Duplicated Lines	0 %

Test Coverage

Coverage

25%

Importance

Changes	2
Bugs	1	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	idOverride()	0	3	1
A	getProviderId()	0	11	3
A	getIdFromProviderFqcn()	0	10	4
A	getSettings()	0	6	2
A	setAppConfig()	0	3	1

<?php

declare(strict_types=1);

/**
 * SPDX-FileCopyrightText: 2024 Christoph Wurst <christoph@winzerhof-wurst.at>
 * SPDX-License-Identifier: AGPL-3.0-or-later
 */

namespace OCA\TwoFactorGateway\Provider\Channel\Telegram\Provider;

use OCA\TwoFactorGateway\Exception\MessageTransmissionException;
use OCA\TwoFactorGateway\Provider\Gateway\TConfigurable;
use OCA\TwoFactorGateway\Provider\Settings;
use OCP\IAppConfig;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

abstract class AProvider implements IProvider {
	use TConfigurable;

The trait OCA\TwoFactorGateway\Provider\Gateway\TConfigurable requires some properties which are not provided by OCA\TwoFactorGateway\Provider\Channel\Telegram\Provider\AProvider: $fields, $field, $id

	public IAppConfig $appConfig;
	protected ?Settings $settings = null;

	/**
	 * @throws MessageTransmissionException
	 */
	#[\Override]
	abstract public function send(string $identifier, string $message);

	#[\Override]
	public function setAppConfig(IAppConfig $appConfig): void {
		$this->appConfig = $appConfig;
	}

	#[\Override]
	public function getSettings(): Settings {
		if ($this->settings !== null) {
			return $this->settings;
		}
		return $this->settings = $this->createSettings();

The method createSettings() does not exist on OCA\TwoFactorGateway\Provider\Channel\Telegram\Provider\AProvider. Since you implemented __call, consider adding a @method annotation.

The expression return $this->settings = $this->createSettings() returns the type OCA\TwoFactorGateway\Provider\Channel\Telegram\Provider\AProvider which is incompatible with the type-hinted return OCA\TwoFactorGateway\Provider\Settings.

	}

	#[\Override]
	public static function idOverride(): ?string {
		return null;
	}

	#[\Override]
	public function getProviderId(): string {
		$settings = $this->getSettings();
		if (!empty($settings->id)) {
			return $settings->id;
		}
		$id = self::getIdFromProviderFqcn(static::class);
		if ($id === null) {
			throw new \LogicException('Cannot derive gateway id from FQCN: ' . static::class);
		}
		return $id;
	}

	#[\Override]
	abstract public function cliConfigure(InputInterface $input, OutputInterface $output): int;

	private static function getIdFromProviderFqcn(string $fqcn): ?string {
		$prefix = 'OCA\\TwoFactorGateway\\Provider\\Channel\\Telegram\\Provider\\Drivers\\';
		if (strncmp($fqcn, $prefix, strlen($prefix)) !== 0) {
			return null;
		}
		$type = substr($fqcn, strlen($prefix));
		if (strpos($type, '\\') !== false) {
			return null;
		}
		return $type !== '' ? strtolower($type) : null;
	}
}