OCA\TwoFactorGateway\Provider\Channel\SMS\Provider\Drivers\ClickatellPortal

Complexity

Total Complexity

5

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	send()	0	17	4
A	__construct()	0	4	1

<?php

declare(strict_types=1);

/**
 * SPDX-FileCopyrightText: 2024 Christian Schrötter <cs@fnx.li>
 * SPDX-License-Identifier: AGPL-3.0-or-later
 */

namespace OCA\TwoFactorGateway\Provider\Channel\SMS\Provider\Drivers;

use Exception;
use OCA\TwoFactorGateway\Exception\MessageTransmissionException;
use OCA\TwoFactorGateway\Provider\Channel\SMS\Provider\AProvider;
use OCP\Http\Client\IClient;
use OCP\Http\Client\IClientService;

/**
 * @method string getApikey()
 * @method static setApikey(string $apikey)
 *
 * @method string getFrom()
 * @method static setFrom(string $from)
 */
class ClickatellPortal extends AProvider {
	public const SCHEMA = [
		'id' => 'clickatell_portal',
		'name' => 'Clickatell Portal',
		'fields' => [
			['field' => 'apikey', 'prompt' => 'Please enter your portal.clickatell.com API-Key:'],
			['field' => 'from',   'prompt' => 'Please enter your sender number for two-way messaging (empty = one-way): ', 'optional' => true],
		],
	];
	private IClient $client;

	public function __construct(
		IClientService $clientService,
	) {
		$this->client = $clientService->newClient();
	}

	#[\Override]
	public function send(string $identifier, string $message) {
		try {
			$from = $this->getFrom();
			$from = !is_null($from) ? sprintf('&from=%s', urlencode($from)) : '';

The condition is_null($from) is always false.

			$response = $this->client->get(vsprintf('https://platform.clickatell.com/messages/http/send?apiKey=%s&to=%s&content=%s%s', [
				urlencode($this->getApikey()),
				urlencode($identifier),
				urlencode($message),
				$from,
			]));
		} catch (Exception $ex) {
			throw new MessageTransmissionException();
		}

		if ($response->getStatusCode() !== 202) {
			throw new MessageTransmissionException($response->getBody());

It seems like $response->getBody() can also be of type resource; however, parameter $message of OCA\TwoFactorGateway\Exception\MessageTransmissionException::__construct() does only seem to accept string, maybe add an additional type check?

		}
	}
}