AndroidGsmModem::send() - Code Metrics - Inspection of "Android GSM Modem SMS support" - nextcloud/twofactor_gateway - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#268)

unknown

created 2019-09-08 08:33 UTC

AndroidGsmModem::send() A

↳ Parent: AndroidGsmModem

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	13
dl	0
loc	16
rs	9.8333
c	0
b	0
f	0
cc	2
nc	2
nop	2

<?php

declare(strict_types=1);

namespace OCA\TwoFactorGateway\Service\Gateway\SMS\Provider;

use Exception;
use OCA\TwoFactorGateway\Exception\SmsTransmissionException;
use OCP\Http\Client\IClient;
use OCP\Http\Client\IClientService;

class AndroidGsmModem implements IProvider {

	const PROVIDER_ID = 'android_gsm_modem';

	/** @var IClient */
	private $client;

	/** @var AndroidGsmModemConfig */
	private $config;

	public function __construct(IClientService $clientService,
								AndroidGsmModemConfig $config) {
		$this->client = $clientService->newClient();
		$this->config = $config;
	}

	/**
	 * @param string $identifier
	 * @param string $message
	 *
	 * @throws SmsTransmissionException
	 */
	public function send(string $identifier, string $message) {
		$config = $this->getConfig();
		$user = $config->getUser();
		$password = $config->getPassword();
		$host = $config->getHost();
		try {
			$this->client->get("http://$host/SendSMS", [
				'query' => [
					'user' => $user,
					'password' => $password,
					'phone' => $identifier,
					'message' => $message,
				],
			]);
		} catch (Exception $ex) {
			throw new SmsTransmissionException();
		}
	}

	/**
	 * @return AndroidGsmModemConfig
	 */
	public function getConfig(): IProviderConfig {
		return $this->config;
	}
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace OCA\TwoFactorGateway\Service\Gateway\SMS\Provider;
6
7			use Exception;
8			use OCA\TwoFactorGateway\Exception\SmsTransmissionException;
9			use OCP\Http\Client\IClient;
10			use OCP\Http\Client\IClientService;
11
12			class AndroidGsmModem implements IProvider {
13
14			const PROVIDER_ID = 'android_gsm_modem';
15
16			/** @var IClient */
17			private $client;
18
19			/** @var AndroidGsmModemConfig */
20			private $config;
21
22			public function __construct(IClientService $clientService,
23			AndroidGsmModemConfig $config) {
24			$this->client = $clientService->newClient();
25			$this->config = $config;
26			}
27
28			/**
29			* @param string $identifier
30			* @param string $message
31			*
32			* @throws SmsTransmissionException
33			*/
34			public function send(string $identifier, string $message) {
35			$config = $this->getConfig();
36			$user = $config->getUser();
37			$password = $config->getPassword();
38			$host = $config->getHost();
39			try {
40			$this->client->get("http://$host/SendSMS", [
41			'query' => [
42			'user' => $user,
43			'password' => $password,
44			'phone' => $identifier,
45			'message' => $message,
46			],
47			]);
48			} catch (Exception $ex) {
49			throw new SmsTransmissionException();
50			}
51			}
52
53			/**
54			* @return AndroidGsmModemConfig
55			*/
56			public function getConfig(): IProviderConfig {
57			return $this->config;
58			}
59			}
60

nextcloud / twofactor_gateway

Pull Request — master (#268)

AndroidGsmModem::send() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like