ClockworkSMS::send() - Code Metrics - Inspection of "chore: reorganize settings" - nextcloud/twofactor_gateway - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#686)

by Vitor

created 2025-09-26 13:19 UTC

ClockworkSMS::send() A

↳ Parent: ClockworkSMS

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
eloc	10
dl	0
loc	15
ccs	0
cts	13
cp	0
rs	9.9332
c	0
b	0
f	0
cc	2
nc	2
nop	2
crap	6

<?php

declare(strict_types=1);

/**
 * SPDX-FileCopyrightText: 2024 Mario Klug <[email protected]>
 * SPDX-License-Identifier: AGPL-3.0-or-later
 */

namespace OCA\TwoFactorGateway\Provider\Channel\SMS\Provider\Drivers;

use Exception;
use OCA\TwoFactorGateway\Exception\MessageTransmissionException;
use OCA\TwoFactorGateway\Provider\Channel\SMS\Provider\AProvider;
use OCA\TwoFactorGateway\Provider\FieldDefinition;
use OCA\TwoFactorGateway\Provider\Settings;
use OCP\Http\Client\IClient;
use OCP\Http\Client\IClientService;

/**
 * @method string getApitoken()
 * @method static setApitoken(string $apitoken)
 */
class ClockworkSMS extends AProvider {
	private IClient $client;

	public function __construct(
		IClientService $clientService,
	) {
		$this->client = $clientService->newClient();
	}

	public function createSettings(): Settings {
		return new Settings(
			id: 'clockworksms',
			name: 'ClockworkSMS',
			fields: [
				new FieldDefinition(
					field: 'apitoken',
					prompt: 'Please enter your clockworksms api token:',
				),
			]
		);
	}

	#[\Override]
	public function send(string $identifier, string $message) {
		try {
			$response = $this->client->get(

				'https://api.clockworksms.com/http/send.aspx',
				[
					'query' => [
						'key' => $this->getApiToken(),
						'to' => $identifier,
						'content' => $message,
					],
				]
			);
		} catch (Exception $ex) {
			throw new MessageTransmissionException();
		}
	}
}


1			<?php
2
3			declare(strict_types=1);
4
5			/**
6			* SPDX-FileCopyrightText: 2024 Mario Klug <[email protected]>
7			* SPDX-License-Identifier: AGPL-3.0-or-later
8			*/
9
10			namespace OCA\TwoFactorGateway\Provider\Channel\SMS\Provider\Drivers;
11
12			use Exception;
13			use OCA\TwoFactorGateway\Exception\MessageTransmissionException;
14			use OCA\TwoFactorGateway\Provider\Channel\SMS\Provider\AProvider;
15			use OCA\TwoFactorGateway\Provider\FieldDefinition;
16			use OCA\TwoFactorGateway\Provider\Settings;
17			use OCP\Http\Client\IClient;
18			use OCP\Http\Client\IClientService;
19
20			/**
21			* @method string getApitoken()
22			* @method static setApitoken(string $apitoken)
23			*/
24			class ClockworkSMS extends AProvider {
25			private IClient $client;
26
27			public function __construct(
28			IClientService $clientService,
29			) {
30			$this->client = $clientService->newClient();
31			}
32
33			public function createSettings(): Settings {
34			return new Settings(
35			id: 'clockworksms',
36			name: 'ClockworkSMS',
37			fields: [
38			new FieldDefinition(
39			field: 'apitoken',
40			prompt: 'Please enter your clockworksms api token:',
41			),
42			]
43			);
44			}
45
46			#[\Override]
47			public function send(string $identifier, string $message) {
48			try {
49			$response = $this->client->get(
			0 ignored issues – show Unused Code introduced 2018-09-26 13:08 UTC by Report Bug Copy Issue Report The assignment to `$response` is dead and can be removed. Loading history...
50			'https://api.clockworksms.com/http/send.aspx',
51			[
52			'query' => [
53			'key' => $this->getApiToken(),
54			'to' => $identifier,
55			'content' => $message,
56			],
57			]
58			);
59			} catch (Exception $ex) {
60			throw new MessageTransmissionException();
61			}
62			}
63			}
64

nextcloud / twofactor_gateway

Pull Request — master (#686)

ClockworkSMS::send() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like