Factory::isValid() - Code Metrics - Inspection of "chore: reorganize settings" - nextcloud/twofactor_gateway - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#686)

by Vitor

created 2025-09-26 13:19 UTC

Factory::isValid() A

↳ Parent: Factory::get()

Complexity

Conditions	2
Paths	2

Size

Total Lines	4
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	2

Importance

Changes

Metric	Value
eloc	3
dl	0
loc	4
ccs	3
cts	3
cp	1
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	1
crap	2

<?php

declare(strict_types=1);

/**
 * SPDX-FileCopyrightText: 2024 Christoph Wurst <[email protected]>
 * SPDX-License-Identifier: AGPL-3.0-or-later
 */

namespace OCA\TwoFactorGateway\Provider\Channel\SMS;

use OCA\TwoFactorGateway\Exception\InvalidProviderException;
use OCA\TwoFactorGateway\Provider\AFactory;
use OCA\TwoFactorGateway\Provider\Channel\SMS\Provider\AProvider;

/** @extends AFactory<AProvider> */
class Factory extends AFactory {
	#[\Override]
	protected function getPrefix(): string {
		return 'OCA\\TwoFactorGateway\\Provider\\Channel\\SMS\\Provider\\Drivers\\';
	}

	#[\Override]
	protected function getSuffix(): string {
		return '';
	}

	#[\Override]
	protected function getBaseClass(): string {
		return AProvider::class;
	}

	#[\Override]
	public function get(string $name): object {
		if (isset($this->instances[$name])) {
			return $this->instances[$name];
		}
		foreach ($this->getFqcnList() as $fqcn) {
			$instance = \OCP\Server::get($fqcn);
			if ($instance->getSettings()->id === $name) {
				$instance->setAppConfig(\OCP\Server::get(\OCP\IAppConfig::class));
				$this->instances[$name] = $instance;
				return $instance;
			}
		}
		throw new InvalidProviderException("Provider <$name> does not exist");
	}
}


1		<?php
2
3		declare(strict_types=1);
4
5		/**
6		* SPDX-FileCopyrightText: 2024 Christoph Wurst <[email protected]>
7		* SPDX-License-Identifier: AGPL-3.0-or-later
8		*/
9
10		namespace OCA\TwoFactorGateway\Provider\Channel\SMS;
11
12		use OCA\TwoFactorGateway\Exception\InvalidProviderException;
13		use OCA\TwoFactorGateway\Provider\AFactory;
14		use OCA\TwoFactorGateway\Provider\Channel\SMS\Provider\AProvider;
15
16		/** @extends AFactory<AProvider> */
17		class Factory extends AFactory {
18	1	#[\Override]
19		protected function getPrefix(): string {
20	1	return 'OCA\\TwoFactorGateway\\Provider\\Channel\\SMS\\Provider\\Drivers\\';
21		}
22
23	1	#[\Override]
24		protected function getSuffix(): string {
25	1	return '';
26		}
27
28	1	#[\Override]
29		protected function getBaseClass(): string {
30	1	return AProvider::class;
31		}
32
33	1	#[\Override]
34		public function get(string $name): object {
35	1	if (isset($this->instances[$name])) {
36		return $this->instances[$name];
37		}
38	1	foreach ($this->getFqcnList() as $fqcn) {
39	1	$instance = \OCP\Server::get($fqcn);
40	1	if ($instance->getSettings()->id === $name) {
41	1	$instance->setAppConfig(\OCP\Server::get(\OCP\IAppConfig::class));
42	1	$this->instances[$name] = $instance;
43	1	return $instance;
44		}
45		}
46		throw new InvalidProviderException("Provider <$name> does not exist");
47		}
48		}
49

nextcloud / twofactor_gateway

Pull Request — master (#686)

Factory::isValid() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like