OCA\TwoFactorGateway\Provider\Channel\Signal\Gateway::send()

Complexity

Conditions	11
Paths	4

Size

Total Lines	37
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
	#[\Override]
	public function send(IUser $user, string $identifier, string $message, array $extra = []): void {
		$client = $this->clientService->newClient();
		// determine type of gateway
		$response = $client->get($this->getUrl() . '/v1/about');
		if ($response->getStatusCode() === 200) {
			// New style gateway https://gitlab.com/morph027/signal-cli-dbus-rest-api
			$response = $client->post(
				$this->getUrl() . '/v1/send/' . $identifier,
				[
					'json' => [ 'message' => $message ],
				]
			);
			$body = (string) $response->getBody();
			$json = json_decode($body, true);
			if ($response->getStatusCode() !== 201 || is_null($json) || !is_array($json) || !isset($json['timestamp'])) {
				$status = $response->getStatusCode();
				throw new MessageTransmissionException("error reported by Signal gateway, status=$status, body=$body}");
			}
		} else {
			// Try old deprecated gateway https://gitlab.com/morph027/signal-web-gateway
			$response = $client->post(
				$this->getUrl() . '/v1/send/' . $identifier,
				[
					'body' => [
						'to' => $identifier,
						'message' => $message,
					],
					'json' => [ 'message' => $message ],
				]
			);
			$body = $response->getBody();
			$json = json_decode($body, true);

It seems like $body can also be of type null and resource; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

			if ($response->getStatusCode() !== 200 || is_null($json) || !is_array($json) || !isset($json['success']) || $json['success'] !== true) {
				$status = $response->getStatusCode();
				throw new MessageTransmissionException("error reported by Signal gateway, status=$status, body=$body}");
			}