OCA\TwoFactorGateway\Service\Gateway\SMS\Provider\HuaweiE3531

Complexity

Total Complexity

4

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	send()	0	24	2
A	getConfig()	0	2	1

<?php

declare(strict_types=1);

/**
 * @author Martin Keßler <martin@moegger.de>
 *
 * Nextcloud - Two-factor Gateway
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
 *
 */

namespace OCA\TwoFactorGateway\Service\Gateway\SMS\Provider;

use Exception;
use OCA\TwoFactorGateway\Exception\SmsTransmissionException;
use OCP\Http\Client\IClient;
use OCP\Http\Client\IClientService;
use OCP\IConfig;

class HuaweiE3531 implements IProvider {

	const PROVIDER_ID = 'huawei_e3531';

	/** @var IClient */
	private $client;

	/** @var HuaweiE3531Config */
	private $config;

	public function __construct(IClientService $clientService,
								HuaweiE3531Config $config) {
		$this->client = $clientService->newClient();
		$this->config = $config;
	}

	/**
	 * @param string $identifier
	 * @param string $message
	 *
	 * @throws SmsTransmissionException
	 */
	public function send(string $identifier, string $message) {
		$config = $this->getConfig();
		$url = $config->getUrl();

		try {
			$session_token_response = $this->client->get("{$url}/webserver/SesTokInfo");
			$session_token_xml = simplexml_load_string($session_token_response->getBody());

It seems like $session_token_response->getBody() can also be of type resource; however, parameter $data of simplexml_load_string() does only seem to accept string, maybe add an additional type check?

			$date = date('Y-m-d H:i:s');
			$message_escaped = htmlspecialchars($message, ENT_XML1);

			$send_response = $this->client->post("{$url}/sms/send-sms", [
				'body' => "<request><Index>-1</Index><Phones><Phone>$identifier</Phone></Phones><Sca/><Content>$message_escaped</Content><Length>-1</Length><Reserved>1</Reserved><Date>$date</Date></request>",
				'headers' => [
					'Cookie' => $session_token_xml->SesInfo,
					'X-Requested-With' => 'XMLHttpRequest',
					'__RequestVerificationToken' => $session_token_xml->TokInfo,
					'Content-Type' => 'text/xml',
				],
			]);
			$send_xml = simplexml_load_string($send_response->getBody());

The assignment to $send_xml is dead and can be removed.

			// TODO: check that $send_xml content is "OK"
		} catch (Exception $ex) {
			throw new SmsTransmissionException();
		}
	}

	/**
	 * @return HuaweiE3531Config
	 */
	public function getConfig(): IProviderConfig {
		return $this->config;
	}

}