OCA\TwoFactorGateway\Provider\Channel\Signal\Gateway::send()

Complexity

Conditions	21
Paths	12

Size

Total Lines	83
Code Lines	52

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	462

Importance

Changes	2
Bugs	0	Features	1

<?php
	#[\Override]
	public function send(string $identifier, string $message, array $extra = []): void {
		$client = $this->clientService->newClient();
		// determine type of gateway

		// test for native signal-cli JSON RPC.
		$response = $client->post(
			$this->getUrl() . '/api/v1/rpc',
			[
				'http_errors' => false,
				'json' => [
					'jsonrpc' => '2.0',
					'method' => 'version',
					'id' => 'version_' . $this->timeFactory->getTime(),
				],
			]);
		if ($response->getStatusCode() === 200 || $response->getStatusCode() === 201) {
			// native signal-cli JSON RPC.

			// Groups have to be detected and passed with the "group-id" parameter. We assume a group is given as base64 encoded string
			$groupId = base64_decode($identifier, strict: true);
			$isGroup = $groupId !== false && base64_encode($groupId) === $identifier;
			$recipientKey = $isGroup ? 'group-id' : 'recipient';
			$params = [
				'message' => $message,
				$recipientKey => $identifier,
				'account' => $this->getAccount(), // mandatory for native RPC API
			];
			$response = $response = $client->post(

The assignment to $response is dead and can be removed.

				$this->getUrl() . '/api/v1/rpc',
				[
					'json' => [
						'jsonrpc' => '2.0',
						'method' => 'send',
						'id' => 'code_' . $this->timeFactory->getTime(),
						'params' => $params,
					],
				]);
			$body = $response->getBody();
			$json = json_decode($body, true);

It seems like $body can also be of type null and resource; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

			$statusCode = $response->getStatusCode();
			// The 201 "created" is probably a bug.
			if ($statusCode < 200 || $statusCode >= 300 || is_null($json) || !is_array($json) || ($json['jsonrpc'] ?? null) != '2.0' || !isset($json['result']['timestamp'])) {
				throw new MessageTransmissionException("error reported by Signal gateway, status=$statusCode, body=$body}");
			}
		} else {
			// Try gateway in the style of https://gitlab.com/morph027/signal-cli-dbus-rest-api
			$response = $client->get($this->getUrl() . '/v1/about');
			if ($response->getStatusCode() === 200) {
				// Not so "ńew style" gateway, see
				// https://gitlab.com/morph027/signal-cli-dbus-rest-api
				// https://gitlab.com/morph027/python-signal-cli-rest-api
				// https://github.com/bbernhard/signal-cli-rest-api
				$response = $client->post(
					$this->getUrl() . '/v1/send/' . $identifier,
					[
						'json' => [ 'message' => $message ],
					]
				);
				$body = (string)$response->getBody();
				$json = json_decode($body, true);
				$status = $response->getStatusCode();
				if ($status !== 201 || is_null($json) || !is_array($json) || !isset($json['timestamp'])) {
					throw new MessageTransmissionException("error reported by Signal gateway, status=$status, body=$body}");
				}
			} else {
				// Try old deprecated gateway https://gitlab.com/morph027/signal-web-gateway
				$response = $client->post(
					$this->getUrl() . '/v1/send/' . $identifier,
					[
						'body' => [
							'to' => $identifier,
							'message' => $message,
						],
						'json' => [ 'message' => $message ],
					]
				);
				$body = (string)$response->getBody();
				$json = json_decode($body, true);

				$status = $response->getStatusCode();
				if ($status !== 200 || is_null($json) || !is_array($json) || !isset($json['success']) || $json['success'] !== true) {
					throw new MessageTransmissionException("error reported by Signal gateway, status=$status, body=$body}");
				}