OCA\TwoFactorGateway\Service\Gateway\SMS\Provider\AndroidGSMmodem

Complexity

Total Complexity

4

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	send()	0	9	2
A	__construct()	0	4	1
A	getConfig()	0	2	1

<?php

declare(strict_types=1);

namespace OCA\TwoFactorGateway\Service\Gateway\SMS\Provider;

use Exception;
use OCA\TwoFactorGateway\Exception\SmsTransmissionException;
use OCP\Http\Client\IClient;
use OCP\Http\Client\IClientService;

class AndroidGSMmodem implements IProvider {

	const PROVIDER_ID = 'android_gsm_modem';

	/** @var IClient */
	private $client;

	/** @var AndroidGSMmodemConfig */

The type OCA\TwoFactorGateway\Service\Gateway\SMS\Provider\AndroidGSMmodemConfig was not found. Maybe you did not declare it correctly or list all dependencies?

	private $config;

	public function __construct(IClientService $clientService,
								AndroidGSMmodemConfig $config) {
		$this->client = $clientService->newClient();
		$this->config = $config;
	}

	/**
	 * @param string $identifier
	 * @param string $message
	 *
	 * @throws SmsTransmissionException
	 */
	public function send(string $identifier, string $message) {
		$config = $this->getConfig();
		$user = $config->getUser();

The method getUser() does not exist on OCA\TwoFactorGateway\Service\Gateway\SMS\Provider\IProviderConfig. It seems like you code against a sub-type of said class. However, the method does not exist in OCA\TwoFactorGateway\Service\Gateway\SMS\Provider\ClockworkSMSConfig or OCA\TwoFactorGateway\Service\Gateway\SMS\Provider\HuaweiE3531Config. Are you sure you never get one of those?

		$password = $config->getPassword();

The method getPassword() does not exist on OCA\TwoFactorGateway\Service\Gateway\SMS\Provider\IProviderConfig. It seems like you code against a sub-type of said class. However, the method does not exist in OCA\TwoFactorGateway\Service\Gateway\SMS\Provider\ClockworkSMSConfig or OCA\TwoFactorGateway\Service\Gateway\SMS\Provider\HuaweiE3531Config. Are you sure you never get one of those?

		$host = $config->getHost();

The method getHost() does not exist on OCA\TwoFactorGateway\Service\Gateway\SMS\Provider\IProviderConfig.

		try {
			$this->client->get('http://'.$host.'/SendSMS/username='.$user.'&password='.$password.'&phone='.$identifier.'&message='.$message);
		} catch (Exception $ex) {
			throw new SmsTransmissionException();
		}
	}

	/**
	 * @return AndroidGSMmodemConfig
	 */
	public function getConfig(): IProviderConfig {
		return $this->config;
	}
}