Inspection of "fix: only replace the message when haven't a messa..." - nextcloud/twofactor_gateway - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#665)

by Vitor

created 2025-09-22 19:57 UTC

Status

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -24,7 +24,7 @@  discard block
 block discarded – undo
 		'id' => 'huawei_e3531',
 		'name' => 'Huawei E3531',
 		'fields' => [
-			['field' => 'api', 'prompt' => 'Please enter the base URL of the Huawei E3531 stick: ', 'default' => 'http://192.168.8.1/api'],
+			[ 'field' => 'api', 'prompt' => 'Please enter the base URL of the Huawei E3531 stick: ', 'default' => 'http://192.168.8.1/api' ],
 		],
 	];
 	private IClient $client;
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
 		$this->client = $clientService->newClient();
 	}
 
-	#[\Override]
+	#[\Override ]
 	public function send(string $identifier, string $message) {
 		$url = $this->getApi();
 

Please login to merge, or discard this patch.

lib/Provider/Channel/SMS/Provider/Drivers/SMSApi.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -25,8 +25,8 @@  discard block
 block discarded – undo
 	public const SCHEMA = [
 		'name' => 'SMSAPI',
 		'fields' => [
-			['field' => 'token', 'prompt' => 'Please enter your SMSApi.com API token:'],
-			['field' => 'sender','prompt' => 'Please enter your SMSApi.com sender name:'],
+			[ 'field' => 'token', 'prompt' => 'Please enter your SMSApi.com API token:' ],
+			[ 'field' => 'sender', 'prompt' => 'Please enter your SMSApi.com sender name:' ],
 		],
 	];
 	private IClient $client;
@@ -37,17 +37,17 @@  discard block
 block discarded – undo
 		$this->client = $clientService->newClient();
 	}
 
-	#[\Override]
+	#[\Override ]
 	public function send(string $identifier, string $message) {
 		$sender = $this->getSender();
 		$token = $this->getToken();
 		$url = 'https://api.smsapi.com/sms.do';
 
 		$params = [
-			'to' => $identifier,         //destination number
-			'from' => $sender,             //sendername made in https://ssl.smsapi.com/sms_settings/sendernames
-			'message' => $message,    		//message content
-			'format' => 'json',           	//get response in json format
+			'to' => $identifier, //destination number
+			'from' => $sender, //sendername made in https://ssl.smsapi.com/sms_settings/sendernames
+			'message' => $message, //message content
+			'format' => 'json', //get response in json format
 		];
 
 		try {
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
 			curl_close($c);
 			$responseData = json_decode($content, true);
 
-			if ($responseData['count'] !== 1) {
+			if ($responseData[ 'count' ] !== 1) {
 				throw new MessageTransmissionException();
 			}
 		} catch (Exception $ex) {

Please login to merge, or discard this patch.

lib/Provider/Channel/SMS/Provider/Drivers/VoipMs.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -27,9 +27,9 @@  discard block
 block discarded – undo
 	public const SCHEMA = [
 		'name' => 'VoIP.ms',
 		'fields' => [
-			['field' => 'api_user',     'prompt' => 'Please enter your VoIP.ms API username:'],
-			['field' => 'api_password', 'prompt' => 'Please enter your VoIP.ms API password:'],
-			['field' => 'did',          'prompt' => 'Please enter your VoIP.ms DID:'],
+			[ 'field' => 'api_user', 'prompt' => 'Please enter your VoIP.ms API username:' ],
+			[ 'field' => 'api_password', 'prompt' => 'Please enter your VoIP.ms API password:' ],
+			[ 'field' => 'did', 'prompt' => 'Please enter your VoIP.ms DID:' ],
 		],
 	];
 	private IClient $client;
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
 		$this->client = $clientService->newClient();
 	}
 
-	#[\Override]
+	#[\Override ]
 	public function send(string $identifier, string $message) {
 		$user = $this->getApiUser();
 		$password = $this->getApiPassword();

Please login to merge, or discard this patch.

lib/Provider/Channel/SMS/Provider/Drivers/Sms77Io.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -23,7 +23,7 @@  discard block
 block discarded – undo
 	public const SCHEMA = [
 		'name' => 'sms77.io',
 		'fields' => [
-			['field' => 'api_key', 'prompt' => 'Please enter your sms77.io API key:'],
+			[ 'field' => 'api_key', 'prompt' => 'Please enter your sms77.io API key:' ],
 		],
 	];
 	private IClient $client;
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
 		$this->client = $clientService->newClient();
 	}
 
-	#[\Override]
+	#[\Override ]
 	public function send(string $identifier, string $message) {
 		$apiKey = $this->getApiKey();
 		try {

Please login to merge, or discard this patch.

lib/Provider/Channel/SMS/Provider/Drivers/ClickatellPortal.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -27,8 +27,8 @@  discard block
 block discarded – undo
 		'id' => 'clickatell_portal',
 		'name' => 'Clickatell Portal',
 		'fields' => [
-			['field' => 'apikey', 'prompt' => 'Please enter your portal.clickatell.com API-Key:'],
-			['field' => 'from',   'prompt' => 'Please enter your sender number for two-way messaging (empty = one-way): ', 'optional' => true],
+			[ 'field' => 'apikey', 'prompt' => 'Please enter your portal.clickatell.com API-Key:' ],
+			[ 'field' => 'from', 'prompt' => 'Please enter your sender number for two-way messaging (empty = one-way): ', 'optional' => true ],
 		],
 	];
 	private IClient $client;
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
 		$this->client = $clientService->newClient();
 	}
 
-	#[\Override]
+	#[\Override ]
 	public function send(string $identifier, string $message) {
 		try {
 			$from = $this->getFrom();

Please login to merge, or discard this patch.

lib/Provider/Channel/SMS/Provider/Drivers/ClockworkSMS.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -23,7 +23,7 @@  discard block
 block discarded – undo
 	public const SCHEMA = [
 		'name' => 'ClockworkSMS',
 		'fields' => [
-			['field' => 'apitoken', 'prompot' => 'Please enter your clockworksms api token:'],
+			[ 'field' => 'apitoken', 'prompot' => 'Please enter your clockworksms api token:' ],
 		]
 	];
 	private IClient $client;
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
 		$this->client = $clientService->newClient();
 	}
 
-	#[\Override]
+	#[\Override ]
 	public function send(string $identifier, string $message) {
 		try {
 			$response = $this->client->get(

Please login to merge, or discard this patch.

lib/Provider/Channel/SMS/Provider/Drivers/PuzzelSMS.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -30,10 +30,10 @@  discard block
 block discarded – undo
 		'id' => 'puzzel',
 		'name' => 'Puzzel SMS',
 		'fields' => [
-			['field' => 'url',       'prompt' => 'Please enter your PuzzelSMS URL:'],
-			['field' => 'user',      'prompt' => 'Please enter your PuzzelSMS username:'],
-			['field' => 'password',  'prompt' => 'Please enter your PuzzelSMS password:'],
-			['field' => 'serviceid', 'prompt' => 'Please enter your PuzzelSMS service ID:'],
+			[ 'field' => 'url', 'prompt' => 'Please enter your PuzzelSMS URL:' ],
+			[ 'field' => 'user', 'prompt' => 'Please enter your PuzzelSMS username:' ],
+			[ 'field' => 'password', 'prompt' => 'Please enter your PuzzelSMS password:' ],
+			[ 'field' => 'serviceid', 'prompt' => 'Please enter your PuzzelSMS service ID:' ],
 		],
 	];
 	private IClient $client;
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
 		$this->client = $clientService->newClient();
 	}
 
-	#[\Override]
+	#[\Override ]
 	public function send(string $identifier, string $message) {
 		try {
 			$this->client->get(
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
 					'query' => [
 						'username' => $this->getUser(),
 						'password' => $this->getPassword(),
-						'message[0].recipient' => '+' . $identifier,
+						'message[0].recipient' => '+'.$identifier,
 						'message[0].content' => $message,
 						'serviceId' => $this->getServiceid(),
 					],

Please login to merge, or discard this patch.

lib/Provider/Channel/SMS/Provider/Drivers/EcallSMS.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -27,9 +27,9 @@  discard block
 block discarded – undo
 	public const SCHEMA = [
 		'name' => 'EcallSMS',
 		'fields' => [
-			['field' => 'user',      'prompt' => 'Please enter your eCall.ch username:'],
-			['field' => 'password',  'prompt' => 'Please enter your eCall.ch password:'],
-			['field' => 'sender_id', 'prompt' => 'Please enter your eCall.ch sender ID:'],
+			[ 'field' => 'user', 'prompt' => 'Please enter your eCall.ch username:' ],
+			[ 'field' => 'password', 'prompt' => 'Please enter your eCall.ch password:' ],
+			[ 'field' => 'sender_id', 'prompt' => 'Please enter your eCall.ch sender ID:' ],
 		],
 	];
 	private IClient $client;
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
 		$this->client = $clientService->newClient();
 	}
 
-	#[\Override]
+	#[\Override ]
 	public function send(string $identifier, string $message) {
 		$user = $this->getUsername();
 		$password = $this->getPassword();

Please login to merge, or discard this patch.

lib/Provider/Channel/SMS/Provider/Drivers/PlaySMS.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -27,9 +27,9 @@  discard block
 block discarded – undo
 	public const SCHEMA = [
 		'name' => 'PlaySMS',
 		'fields' => [
-			['field' => 'url',      'prompt' => 'Please enter your PlaySMS URL:'],
-			['field' => 'user',     'prompt' => 'Please enter your PlaySMS username:'],
-			['field' => 'password', 'prompt' => 'Please enter your PlaySMS password:'],
+			[ 'field' => 'url', 'prompt' => 'Please enter your PlaySMS URL:' ],
+			[ 'field' => 'user', 'prompt' => 'Please enter your PlaySMS username:' ],
+			[ 'field' => 'password', 'prompt' => 'Please enter your PlaySMS password:' ],
 		],
 	];
 	private IClient $client;
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
 		$this->client = $clientService->newClient();
 	}
 
-	#[\Override]
+	#[\Override ]
 	public function send(string $identifier, string $message) {
 		try {
 			$this->client->get(

Please login to merge, or discard this patch.

		@@ -24,7 +24,7 @@ discard block
		block discarded – undo
24	24	'id' => 'huawei_e3531',
25	25	'name' => 'Huawei E3531',
26	26	'fields' => [
27		- ['field' => 'api', 'prompt' => 'Please enter the base URL of the Huawei E3531 stick: ', 'default' => 'http://192.168.8.1/api'],
	27	+ [ 'field' => 'api', 'prompt' => 'Please enter the base URL of the Huawei E3531 stick: ', 'default' => 'http://192.168.8.1/api' ],
28	28	],
29	29	];
30	30	private IClient $client;
		@@ -35,7 +35,7 @@ discard block
		block discarded – undo
35	35	$this->client = $clientService->newClient();
36	36	}
37	37
38		- #[\Override]
	38	+ #[\Override ]
39	39	public function send(string $identifier, string $message) {
40	40	$url = $this->getApi();
41	41

		@@ -25,8 +25,8 @@ discard block
		block discarded – undo
25	25	public const SCHEMA = [
26	26	'name' => 'SMSAPI',
27	27	'fields' => [
28		- ['field' => 'token', 'prompt' => 'Please enter your SMSApi.com API token:'],
29		- ['field' => 'sender','prompt' => 'Please enter your SMSApi.com sender name:'],
	28	+ [ 'field' => 'token', 'prompt' => 'Please enter your SMSApi.com API token:' ],
	29	+ [ 'field' => 'sender', 'prompt' => 'Please enter your SMSApi.com sender name:' ],
30	30	],
31	31	];
32	32	private IClient $client;
		@@ -37,17 +37,17 @@ discard block
		block discarded – undo
37	37	$this->client = $clientService->newClient();
38	38	}
39	39
40		- #[\Override]
	40	+ #[\Override ]
41	41	public function send(string $identifier, string $message) {
42	42	$sender = $this->getSender();
43	43	$token = $this->getToken();
44	44	$url = 'https://api.smsapi.com/sms.do';
45	45
46	46	$params = [
47		- 'to' => $identifier, //destination number
48		- 'from' => $sender, //sendername made in https://ssl.smsapi.com/sms_settings/sendernames
49		- 'message' => $message, //message content
50		- 'format' => 'json', //get response in json format
	47	+ 'to' => $identifier, //destination number
	48	+ 'from' => $sender, //sendername made in https://ssl.smsapi.com/sms_settings/sendernames
	49	+ 'message' => $message, //message content
	50	+ 'format' => 'json', //get response in json format
51	51	];
52	52
53	53	try {
		@@ -71,7 +71,7 @@ discard block
		block discarded – undo
71	71	curl_close($c);
72	72	$responseData = json_decode($content, true);
73	73
74		- if ($responseData['count'] !== 1) {
	74	+ if ($responseData[ 'count' ] !== 1) {
75	75	throw new MessageTransmissionException();
76	76	}
77	77	} catch (Exception $ex) {

		@@ -27,9 +27,9 @@ discard block
		block discarded – undo
27	27	public const SCHEMA = [
28	28	'name' => 'VoIP.ms',
29	29	'fields' => [
30		- ['field' => 'api_user', 'prompt' => 'Please enter your VoIP.ms API username:'],
31		- ['field' => 'api_password', 'prompt' => 'Please enter your VoIP.ms API password:'],
32		- ['field' => 'did', 'prompt' => 'Please enter your VoIP.ms DID:'],
	30	+ [ 'field' => 'api_user', 'prompt' => 'Please enter your VoIP.ms API username:' ],
	31	+ [ 'field' => 'api_password', 'prompt' => 'Please enter your VoIP.ms API password:' ],
	32	+ [ 'field' => 'did', 'prompt' => 'Please enter your VoIP.ms DID:' ],
33	33	],
34	34	];
35	35	private IClient $client;
		@@ -40,7 +40,7 @@ discard block
		block discarded – undo
40	40	$this->client = $clientService->newClient();
41	41	}
42	42
43		- #[\Override]
	43	+ #[\Override ]
44	44	public function send(string $identifier, string $message) {
45	45	$user = $this->getApiUser();
46	46	$password = $this->getApiPassword();

		@@ -23,7 +23,7 @@ discard block
		block discarded – undo
23	23	public const SCHEMA = [
24	24	'name' => 'sms77.io',
25	25	'fields' => [
26		- ['field' => 'api_key', 'prompt' => 'Please enter your sms77.io API key:'],
	26	+ [ 'field' => 'api_key', 'prompt' => 'Please enter your sms77.io API key:' ],
27	27	],
28	28	];
29	29	private IClient $client;
		@@ -34,7 +34,7 @@ discard block
		block discarded – undo
34	34	$this->client = $clientService->newClient();
35	35	}
36	36
37		- #[\Override]
	37	+ #[\Override ]
38	38	public function send(string $identifier, string $message) {
39	39	$apiKey = $this->getApiKey();
40	40	try {

		@@ -27,8 +27,8 @@ discard block
		block discarded – undo
27	27	'id' => 'clickatell_portal',
28	28	'name' => 'Clickatell Portal',
29	29	'fields' => [
30		- ['field' => 'apikey', 'prompt' => 'Please enter your portal.clickatell.com API-Key:'],
31		- ['field' => 'from', 'prompt' => 'Please enter your sender number for two-way messaging (empty = one-way): ', 'optional' => true],
	30	+ [ 'field' => 'apikey', 'prompt' => 'Please enter your portal.clickatell.com API-Key:' ],
	31	+ [ 'field' => 'from', 'prompt' => 'Please enter your sender number for two-way messaging (empty = one-way): ', 'optional' => true ],
32	32	],
33	33	];
34	34	private IClient $client;
		@@ -39,7 +39,7 @@ discard block
		block discarded – undo
39	39	$this->client = $clientService->newClient();
40	40	}
41	41
42		- #[\Override]
	42	+ #[\Override ]
43	43	public function send(string $identifier, string $message) {
44	44	try {
45	45	$from = $this->getFrom();

		@@ -30,10 +30,10 @@ discard block
		block discarded – undo
30	30	'id' => 'puzzel',
31	31	'name' => 'Puzzel SMS',
32	32	'fields' => [
33		- ['field' => 'url', 'prompt' => 'Please enter your PuzzelSMS URL:'],
34		- ['field' => 'user', 'prompt' => 'Please enter your PuzzelSMS username:'],
35		- ['field' => 'password', 'prompt' => 'Please enter your PuzzelSMS password:'],
36		- ['field' => 'serviceid', 'prompt' => 'Please enter your PuzzelSMS service ID:'],
	33	+ [ 'field' => 'url', 'prompt' => 'Please enter your PuzzelSMS URL:' ],
	34	+ [ 'field' => 'user', 'prompt' => 'Please enter your PuzzelSMS username:' ],
	35	+ [ 'field' => 'password', 'prompt' => 'Please enter your PuzzelSMS password:' ],
	36	+ [ 'field' => 'serviceid', 'prompt' => 'Please enter your PuzzelSMS service ID:' ],
37	37	],
38	38	];
39	39	private IClient $client;
		@@ -44,7 +44,7 @@ discard block
		block discarded – undo
44	44	$this->client = $clientService->newClient();
45	45	}
46	46
47		- #[\Override]
	47	+ #[\Override ]
48	48	public function send(string $identifier, string $message) {
49	49	try {
50	50	$this->client->get(
		@@ -53,7 +53,7 @@ discard block
		block discarded – undo
53	53	'query' => [
54	54	'username' => $this->getUser(),
55	55	'password' => $this->getPassword(),
56		- 'message[0].recipient' => '+' . $identifier,
	56	+ 'message[0].recipient' => '+'.$identifier,
57	57	'message[0].content' => $message,
58	58	'serviceId' => $this->getServiceid(),
59	59	],

nextcloud / twofactor_gateway

Pull Request — master (#665)

Status

Category

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch