OCA\TwoFactorGateway\Provider\Channel\SMS\Provider\Drivers\SMSApi

Complexity

Total Complexity

6

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Test Coverage

Coverage

36.96%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	send()	0	39	4
A	__construct()	0	4	1
A	createSettings()	0	12	1

<?php

declare(strict_types=1);

/**
 * SPDX-FileCopyrightText: 2024 Marcin Kot <kodek11@gmail.com>
 * SPDX-License-Identifier: AGPL-3.0-or-later
 */

namespace OCA\TwoFactorGateway\Provider\Channel\SMS\Provider\Drivers;

use Exception;
use OCA\TwoFactorGateway\Exception\MessageTransmissionException;
use OCA\TwoFactorGateway\Provider\Channel\SMS\Provider\AProvider;
use OCA\TwoFactorGateway\Provider\FieldDefinition;
use OCA\TwoFactorGateway\Provider\Settings;
use OCP\Http\Client\IClient;
use OCP\Http\Client\IClientService;

/**
 * @method string getToken()
 * @method static setToken(string $token)
 * @method string getSender()
 * @method static setSender(string $sender)
 */
class SMSApi extends AProvider {
	private IClient $client;

	public function __construct(
		IClientService $clientService,
	) {
		$this->client = $clientService->newClient();
	}

	public function createSettings(): Settings {
		return new Settings(
			id: 'smsapi',
			name: 'SMSAPI',
			fields: [
				new FieldDefinition(
					field: 'token',
					prompt: 'Please enter your SMSApi.com API token:',
				),
				new FieldDefinition(
					field: 'sender',
					prompt: 'Please enter your SMSApi.com sender name:',
				),
			]
		);
	}

	#[\Override]
	public function send(string $identifier, string $message) {
		$sender = $this->getSender();
		$token = $this->getToken();
		$url = 'https://api.smsapi.com/sms.do';

		$params = [
			'to' => $identifier,         //destination number
			'from' => $sender,             //sendername made in https://ssl.smsapi.com/sms_settings/sendernames
			'message' => $message,    		//message content
			'format' => 'json',           	//get response in json format
		];

		try {
			static $content;

			$c = curl_init();
			curl_setopt($c, CURLOPT_URL, $url);
			curl_setopt($c, CURLOPT_POST, true);
			curl_setopt($c, CURLOPT_POSTFIELDS, $params);
			curl_setopt($c, CURLOPT_RETURNTRANSFER, true);
			curl_setopt($c, CURLOPT_HTTPHEADER, [
				"Authorization: Bearer $token"
			]);

			$content = curl_exec($c);
			if ($content === false) {
				throw new MessageTransmissionException();
			}
			$http_status = curl_getinfo($c, CURLINFO_HTTP_CODE);

The assignment to $http_status is dead and can be removed.

			curl_close($c);
			$responseData = json_decode($content, true);

It seems like $content can also be of type true; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

			if ($responseData['count'] !== 1) {
				throw new MessageTransmissionException();
			}
		} catch (Exception $ex) {
			throw new MessageTransmissionException();
		}
	}
}