Completed
Pull Request — master (#1745)
by Thomas
10:36
created
apps/dav/lib/CardDAV/AddressBookRoot.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
 
31 31
 	/**
32 32
 	 * @param \Sabre\DAVACL\PrincipalBackend\BackendInterface $principalBackend
33
-	 * @param \Sabre\CardDAV\Backend\BackendInterface $carddavBackend
33
+	 * @param CardDavBackend $carddavBackend
34 34
 	 * @param string $principalPrefix
35 35
 	 */
36 36
 	public function __construct(\Sabre\DAVACL\PrincipalBackend\BackendInterface $principalBackend, \Sabre\CardDAV\Backend\BackendInterface $carddavBackend, $principalPrefix = 'principals') {
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/CalDavBackend.php 1 patch
Doc Comments   +8 added lines, -2 removed lines patch added patch discarded remove patch
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
 	 *
138 138
 	 * By default this excludes the automatically generated birthday calendar
139 139
 	 *
140
-	 * @param $principalUri
140
+	 * @param string $principalUri
141 141
 	 * @param bool $excludeBirthday
142 142
 	 * @return int
143 143
 	 */
@@ -282,6 +282,9 @@  discard block
 block discarded – undo
282 282
 		return array_values($calendars);
283 283
 	}
284 284
 
285
+	/**
286
+	 * @param string $principalUri
287
+	 */
285 288
 	public function getUsersOwnCalendars($principalUri) {
286 289
 		$principalUri = $this->convertPrincipal($principalUri, true);
287 290
 		$fields = array_values($this->propertyMap);
@@ -1174,7 +1177,7 @@  discard block
 block discarded – undo
1174 1177
 	 * @param string $principalUri
1175 1178
 	 * @param string $uri
1176 1179
 	 * @param array $properties
1177
-	 * @return mixed
1180
+	 * @return integer
1178 1181
 	 */
1179 1182
 	function createSubscription($principalUri, $uri, array $properties) {
1180 1183
 
@@ -1533,6 +1536,9 @@  discard block
 block discarded – undo
1533 1536
 		return $this->sharingBackend->applyShareAcl($resourceId, $acl);
1534 1537
 	}
1535 1538
 
1539
+	/**
1540
+	 * @param boolean $toV2
1541
+	 */
1536 1542
 	private function convertPrincipal($principalUri, $toV2) {
1537 1543
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
1538 1544
 			list(, $name) = URLUtil::splitPath($principalUri);
Please login to merge, or discard this patch.
lib/private/legacy/app.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -1331,6 +1331,9 @@
 block discarded – undo
1331 1331
 		}
1332 1332
 	}
1333 1333
 
1334
+	/**
1335
+	 * @param string $lang
1336
+	 */
1334 1337
 	protected static function findBestL10NOption($options, $lang) {
1335 1338
 		$fallback = $englishFallback = false;
1336 1339
 		foreach ($options as $option) {
Please login to merge, or discard this patch.
lib/private/Share20/DefaultShareProvider.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -770,7 +770,7 @@
 block discarded – undo
770 770
 
771 771
 	/**
772 772
 	 * @param Share[] $shares
773
-	 * @param $userId
773
+	 * @param string $userId
774 774
 	 * @return Share[] The updates shares if no update is found for a share return the original
775 775
 	 */
776 776
 	private function resolveGroupShares($shares, $userId) {
Please login to merge, or discard this patch.
apps/user_ldap/lib/Helper.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -105,6 +105,9 @@
 block discarded – undo
105 105
 		return $result;
106 106
 	}
107 107
 
108
+	/**
109
+	 * @param string $value
110
+	 */
108 111
 	private function getServersConfig($value) {
109 112
 		$regex = '/' . $value . '$/S';
110 113
 
Please login to merge, or discard this patch.