nextcloud / server

apps/theming/lib/Util.php

Doc Comments +4 added lines, -4 removed lines

@@ -71,7 +71,7 @@ 
 	/**
 	 * get color for on-page elements:
 	 * theme color by default, grey if theme color is to bright
-	 * @param $color
+	 * @param string $color
 	 * @return string
 	 */
 	public function elementColor($color) {
@@ -114,7 +114,7 @@ 
 
 	/**
 	 * @param $app string app name
-	 * @return string|ISimpleFile path to app icon / file of logo
+	 * @return string path to app icon / file of logo
 	 */
 	public function getAppIcon($app) {
 		$app = str_replace(array('\0', '/', '\\', '..'), '', $app);
@@ -190,8 +190,8 @@ 
 	/**
 	 * replace default color with a custom one
 	 *
-	 * @param $svg string content of a svg file
-	 * @param $color string color to match
+	 * @param string $svg string content of a svg file
+	 * @param string $color string color to match
 	 * @return string
 	 */
 	public function colorizeSvg($svg, $color) {

lib/private/Settings/Manager.php

Doc Comments +6 added lines

@@ -265,6 +265,9 @@ 
 		return $this->mapper->has($table, $className);
 	}
 
+	/**
+	 * @param string $type
+	 */
 	private function setupSettingsEntry($settingsClassName, $type) {
 		if (!class_exists($settingsClassName)) {
 			$this->log->debug('Could not find ' . $type . ' section class ' . $settingsClassName);
@@ -294,6 +297,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $type
+	 */
 	private function getSectionTableForType($type) {
 		if($type === 'admin') {
 			return Mapper::TABLE_ADMIN_SECTIONS;

apps/user_ldap/lib/Access.php

Doc Comments +8 added lines, -6 removed lines

@@ -491,7 +491,7 @@ 
 
 	/**
 	 * returns the internal Nextcloud name for the given LDAP DN of the user, false on DN outside of search DN or failure
-	 * @param string $dn the dn of the user object
+	 * @param string $fdn the dn of the user object
 	 * @param string $ldapName optional, the display name of the object
 	 * @return string|false with with the name to use in Nextcloud
 	 */
@@ -508,7 +508,7 @@ 
 
 	/**
 	 * returns an internal Nextcloud name for the given LDAP DN, false on DN outside of search DN
-	 * @param string $dn the dn of the user object
+	 * @param string $fdn the dn of the user object
 	 * @param string $ldapName optional, the display name of the object
 	 * @param bool $isUser optional, whether it is a user object (otherwise group assumed)
 	 * @return string|false with with the name to use in Nextcloud
@@ -771,7 +771,7 @@ 
 	 * the login filter.
 	 *
 	 * @param string $loginName
-	 * @param array $attributes optional, list of attributes to read
+	 * @param string[] $attributes optional, list of attributes to read
 	 * @return array
 	 */
 	public function fetchUsersByLoginName($loginName, $attributes = array('dn')) {
@@ -844,7 +844,7 @@ 
 
 	/**
 	 * @param string $filter
-	 * @param string|string[] $attr
+	 * @param string[] $attr
 	 * @param int $limit
 	 * @param int $offset
 	 * @return array
@@ -892,7 +892,7 @@ 
 
 	/**
 	 * @param string $filter
-	 * @param string|string[] $attr
+	 * @param string[] $attr
 	 * @param int $limit
 	 * @param int $offset
 	 * @return false|int
@@ -989,6 +989,7 @@ 
 	 * retrieved. Results will according to the order in the array.
 	 * @param int $limit optional, maximum results to be counted
 	 * @param int $offset optional, a starting point
+	 * @param string $filter
 	 * @return array|false array with the search result as first value and pagedSearchOK as
 	 * second | false if not successful
 	 * @throws \OC\ServerNotAvailableException
@@ -1240,7 +1241,7 @@ 
 
 	/**
 	 * @param string $name
-	 * @return bool|mixed|string
+	 * @return string
 	 */
 	public function sanitizeUsername($name) {
 		if($this->connection->ldapIgnoreNamingRules) {
@@ -1264,6 +1265,7 @@ 
 	* escapes (user provided) parts for LDAP filter
 	* @param string $input, the provided value
 	* @param bool $allowAsterisk whether in * at the beginning should be preserved
+	* @param string $input
 	* @return string the escaped string
 	*/
 	public function escapeFilterPart($input, $allowAsterisk = false) {

lib/private/Session/Internal.php

Doc Comments +1 added lines, -1 removed lines

@@ -164,7 +164,7 @@
 	 * @param array $parameters
 	 * @param bool $silence whether to suppress warnings
 	 * @throws \ErrorException via trapError
-	 * @return mixed
+	 * @return string
 	 */
 	private function invoke($functionName, array $parameters = [], $silence = false) {
 		try {

settings/Controller/CommonSettingsTrait.php

Doc Comments +13 added lines

@@ -51,6 +51,9 @@ 
 		];
 	}
 
+	/**
+	 * @param string $type
+	 */
 	protected function formatSections($sections, $currentSection, $type, $currentType) {
 		$templateParameters = [];
 		/** @var \OCP\Settings\ISection[] $prioritizedSections */
@@ -84,6 +87,9 @@ 
 		return $templateParameters;
 	}
 
+	/**
+	 * @param string $currentSections
+	 */
 	protected function formatPersonalSections($currentType, $currentSections) {
 		$sections = $this->settingsManager->getPersonalSections();
 		$templateParameters = $this->formatSections($sections, $currentSections, 'personal', $currentType);
@@ -91,6 +97,9 @@ 
 		return $templateParameters;
 	}
 
+	/**
+	 * @param string $currentSections
+	 */
 	protected function formatAdminSections($currentType, $currentSections) {
 		$sections = $this->settingsManager->getAdminSections();
 		$templateParameters = $this->formatSections($sections, $currentSections, 'admin', $currentType);
@@ -114,6 +123,10 @@ 
 		return ['content' => $html];
 	}
 
+	/**
+	 * @param string $type
+	 * @param string $section
+	 */
 	private function getIndexResponse($type, $section) {
 		$templateParams = [];
 		$templateParams = array_merge($templateParams, $this->getNavigationParameters($type, $section));

apps/user_ldap/lib/LogWrapper.php

Doc Comments +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
 
 	/**
 	 * @brief states whether the filesystem was loaded
-	 * @return bool
+	 * @return boolean|null
 	 */
 	public function log($msg, $level) {
 		\OCP\Util::writeLog($this->app, $msg, $level);

lib/private/Files/Mount/ObjectHomeMountProvider.php

Doc Comments +3 added lines, -3 removed lines

@@ -51,7 +51,7 @@ 
 	 *
 	 * @param IUser $user
 	 * @param IStorageFactory $loader
-	 * @return \OCP\Files\Mount\IMountPoint
+	 * @return null|MountPoint
 	 */
 	public function getHomeMountForUser(IUser $user, IStorageFactory $loader) {
 
@@ -69,7 +69,7 @@ 
 
 	/**
 	 * @param IUser $user
-	 * @return array|null
+	 * @return IStorageFactory|null
 	 */
 	private function getSingleBucketObjectStoreConfig(IUser $user) {
 		$config = $this->config->getSystemValue('objectstore');
@@ -93,7 +93,7 @@ 
 
 	/**
 	 * @param IUser $user
-	 * @return array|null
+	 * @return IStorageFactory|null
 	 */
 	private function getMultiBucketObjectStoreConfig(IUser $user) {
 		$config = $this->config->getSystemValue('objectstore_multibucket');

apps/files_external/lib/Lib/Auth/PublicKey/RSA.php

Doc Comments +1 added lines, -1 removed lines

@@ -69,7 +69,7 @@
 	/**
 	 * Generate a keypair
 	 *
-	 * @param int $keyLenth
+	 * @param integer $keyLength
 	 * @return array ['privatekey' => $privateKey, 'publickey' => $publicKey]
 	 */
 	public function createKey($keyLength) {

apps/dav/lib/Upload/AssemblyStream.php

Doc Comments +1 added lines, -1 removed lines

@@ -126,7 +126,7 @@
 
 	/**
 	 * @param string $data
-	 * @return int
+	 * @return boolean
 	 */
 	public function stream_write($data) {
 		return false;