Completed
Push — master ( ca0f2f...6aa6d2 )
by Björn
33:52 queued 15:38
created
apps/dav/lib/CalDAV/CalDavBackend.php 1 patch
Doc Comments   +10 added lines, -4 removed lines patch added patch discarded remove patch
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
 	 *
183 183
 	 * By default this excludes the automatically generated birthday calendar
184 184
 	 *
185
-	 * @param $principalUri
185
+	 * @param string $principalUri
186 186
 	 * @param bool $excludeBirthday
187 187
 	 * @return int
188 188
 	 */
@@ -351,6 +351,9 @@  discard block
 block discarded – undo
351 351
 		return array_values($calendars);
352 352
 	}
353 353
 
354
+	/**
355
+	 * @param string $principalUri
356
+	 */
354 357
 	public function getUsersOwnCalendars($principalUri) {
355 358
 		$principalUri = $this->convertPrincipal($principalUri, true);
356 359
 		$fields = array_values($this->propertyMap);
@@ -946,7 +949,7 @@  discard block
 block discarded – undo
946 949
 	 * calendar-data. If the result of a subsequent GET to this object is not
947 950
 	 * the exact same as this request body, you should omit the ETag.
948 951
 	 *
949
-	 * @param mixed $calendarId
952
+	 * @param integer $calendarId
950 953
 	 * @param string $objectUri
951 954
 	 * @param string $calendarData
952 955
 	 * @return string
@@ -1000,7 +1003,7 @@  discard block
 block discarded – undo
1000 1003
 	 * calendar-data. If the result of a subsequent GET to this object is not
1001 1004
 	 * the exact same as this request body, you should omit the ETag.
1002 1005
 	 *
1003
-	 * @param mixed $calendarId
1006
+	 * @param integer $calendarId
1004 1007
 	 * @param string $objectUri
1005 1008
 	 * @param string $calendarData
1006 1009
 	 * @return string
@@ -1563,7 +1566,7 @@  discard block
 block discarded – undo
1563 1566
 	 * @param string $principalUri
1564 1567
 	 * @param string $uri
1565 1568
 	 * @param array $properties
1566
-	 * @return mixed
1569
+	 * @return integer
1567 1570
 	 */
1568 1571
 	function createSubscription($principalUri, $uri, array $properties) {
1569 1572
 
@@ -2103,6 +2106,9 @@  discard block
 block discarded – undo
2103 2106
 		return (int)$objectIds['id'];
2104 2107
 	}
2105 2108
 
2109
+	/**
2110
+	 * @param boolean $toV2
2111
+	 */
2106 2112
 	private function convertPrincipal($principalUri, $toV2) {
2107 2113
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
2108 2114
 			list(, $name) = Uri\split($principalUri);
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/CardDavBackend.php 1 patch
Doc Comments   +11 added lines, -3 removed lines patch added patch discarded remove patch
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
 	/**
105 105
 	 * Return the number of address books for a principal
106 106
 	 *
107
-	 * @param $principalUri
107
+	 * @param string $principalUri
108 108
 	 * @return int
109 109
 	 */
110 110
 	public function getAddressBooksForUserCount($principalUri) {
@@ -219,6 +219,9 @@  discard block
 block discarded – undo
219 219
 		return array_values($addressBooks);
220 220
 	}
221 221
 
222
+	/**
223
+	 * @param string $principalUri
224
+	 */
222 225
 	public function getUsersOwnAddressBooks($principalUri) {
223 226
 		$principalUri = $this->convertPrincipal($principalUri, true);
224 227
 		$query = $this->db->getQueryBuilder();
@@ -293,7 +296,8 @@  discard block
 block discarded – undo
293 296
 	}
294 297
 
295 298
 	/**
296
-	 * @param $addressBookUri
299
+	 * @param string $addressBookUri
300
+	 * @param string $principal
297 301
 	 * @return array|null
298 302
 	 */
299 303
 	public function getAddressBooksByUri($principal, $addressBookUri) {
@@ -982,6 +986,7 @@  discard block
 block discarded – undo
982 986
 	 *   * readOnly - boolean
983 987
 	 *   * summary - Optional, a description for the share
984 988
 	 *
989
+	 * @param integer $addressBookId
985 990
 	 * @return array
986 991
 	 */
987 992
 	public function getShares($addressBookId) {
@@ -1081,7 +1086,7 @@  discard block
 block discarded – undo
1081 1086
 
1082 1087
 	/**
1083 1088
 	 * For shared address books the sharee is set in the ACL of the address book
1084
-	 * @param $addressBookId
1089
+	 * @param integer $addressBookId
1085 1090
 	 * @param $acl
1086 1091
 	 * @return array
1087 1092
 	 */
@@ -1089,6 +1094,9 @@  discard block
 block discarded – undo
1089 1094
 		return $this->sharingBackend->applyShareAcl($addressBookId, $acl);
1090 1095
 	}
1091 1096
 
1097
+	/**
1098
+	 * @param boolean $toV2
1099
+	 */
1092 1100
 	private function convertPrincipal($principalUri, $toV2) {
1093 1101
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
1094 1102
 			list(, $name) = \Sabre\Uri\split($principalUri);
Please login to merge, or discard this patch.
lib/private/legacy/template/functions.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@
 block discarded – undo
106 106
 /**
107 107
  * Prints an unsanitized string - usage of this function may result into XSS.
108 108
  * Consider using p() instead.
109
- * @param string|array $string the string which will be printed as it is
109
+ * @param string $string the string which will be printed as it is
110 110
  */
111 111
 function print_unescaped($string) {
112 112
 	print($string);
Please login to merge, or discard this patch.
lib/public/AppFramework/Http/Response.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -261,7 +261,7 @@
 block discarded – undo
261 261
 
262 262
 	/**
263 263
 	 * Get the currently used Content-Security-Policy
264
-	 * @return EmptyContentSecurityPolicy|null Used Content-Security-Policy or null if
264
+	 * @return ContentSecurityPolicy|null Used Content-Security-Policy or null if
265 265
 	 *                                    none specified.
266 266
 	 * @since 8.1.0
267 267
 	 */
Please login to merge, or discard this patch.
lib/private/Archive/ZIP.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -370,6 +370,7 @@
 block discarded – undo
370 370
 
371 371
 	/**
372 372
 	 * write back temporary files
373
+	 * @param string $path
373 374
 	 */
374 375
 	public function writeBack($tmpFile, $path) {
375 376
 		$this->addFile($path, $tmpFile);
Please login to merge, or discard this patch.
lib/private/legacy/helper.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
 	/**
132 132
 	 * Make a computer file size
133 133
 	 * @param string $str file size in human readable format
134
-	 * @return float|bool a file size in bytes
134
+	 * @return integer a file size in bytes
135 135
 	 *
136 136
 	 * Makes 2kB to 2048.
137 137
 	 *
@@ -529,7 +529,7 @@  discard block
 block discarded – undo
529 529
 	 *
530 530
 	 * @param string $path
531 531
 	 * @param \OCP\Files\FileInfo $rootInfo (optional)
532
-	 * @return array
532
+	 * @return string
533 533
 	 * @throws \OCP\Files\NotFoundException
534 534
 	 */
535 535
 	public static function getStorageInfo($path, $rootInfo = null) {
Please login to merge, or discard this patch.
core/Middleware/TwoFactorMiddleware.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -104,6 +104,9 @@
 block discarded – undo
104 104
 		// TODO: dont check/enforce 2FA if a auth token is used
105 105
 	}
106 106
 
107
+	/**
108
+	 * @param string $methodName
109
+	 */
107 110
 	private function checkTwoFactor(Controller $controller, $methodName, IUser $user) {
108 111
 		// If two-factor auth is in progress disallow access to any controllers
109 112
 		// defined within "LoginController".
Please login to merge, or discard this patch.
lib/private/Contacts/ContactsMenu/ContactsStore.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@
 block discarded – undo
63 63
 	/**
64 64
 	 * @param IUser $user
65 65
 	 * @param string|null $filter
66
-	 * @return IEntry[]
66
+	 * @return Entry[]
67 67
 	 */
68 68
 	public function getContacts(IUser $user, $filter) {
69 69
 		$allContacts = $this->contactsManager->search($filter ?: '', [
Please login to merge, or discard this patch.
lib/private/User/User.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -450,6 +450,10 @@
 block discarded – undo
450 450
 		return $url;
451 451
 	}
452 452
 
453
+	/**
454
+	 * @param string $feature
455
+	 * @param string $oldValue
456
+	 */
453 457
 	public function triggerChange($feature, $value = null, $oldValue = null) {
454 458
 		if ($this->emitter) {
455 459
 			$this->emitter->emit('\OC\User', 'changeUser', array($this, $feature, $value, $oldValue));
Please login to merge, or discard this patch.