Completed
Push — master ( ca0f2f...6aa6d2 )
by Björn
33:52 queued 15:38
created
apps/twofactor_backupcodes/lib/Db/BackupCodeMapper.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
 		$rows = $result->fetchAll();
48 48
 		$result->closeCursor();
49 49
 
50
-		return array_map(function ($row) {
50
+		return array_map(function($row) {
51 51
 			return BackupCode::fromRow($row);
52 52
 		}, $rows);
53 53
 	}
Please login to merge, or discard this patch.
apps/encryption/templates/altmail.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
 /** @var array $_ */
4 4
 
5 5
 print_unescaped($l->t("Hey there,\n\nthe admin enabled server-side-encryption. Your files were encrypted using the password '%s'.\n\nPlease login to the web interface, go to the section 'basic encryption module' of your personal settings and update your encryption password by entering this password into the 'old log-in password' field and your current login-password.\n\n", array($_['password'])));
6
-if ( isset($_['expiration']) ) {
6
+if (isset($_['expiration'])) {
7 7
 	print_unescaped($l->t("The share will expire on %s.", array($_['expiration'])));
8 8
 	print_unescaped("\n\n");
9 9
 }
@@ -12,5 +12,5 @@  discard block
 block discarded – undo
12 12
 ?>
13 13
 
14 14
 	--
15
-<?php p($theme->getName() . ' - ' . $theme->getSlogan()); ?>
15
+<?php p($theme->getName().' - '.$theme->getSlogan()); ?>
16 16
 <?php print_unescaped("\n".$theme->getBaseUrl());
Please login to merge, or discard this patch.
apps/encryption/lib/Util.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
 	 * @return bool
164 164
 	 */
165 165
 	public function userHasFiles($uid) {
166
-		return $this->files->file_exists($uid . '/files');
166
+		return $this->files->file_exists($uid.'/files');
167 167
 	}
168 168
 
169 169
 	/**
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
 		if (count($parts) > 1) {
180 180
 			$owner = $parts[1];
181 181
 			if ($this->userManager->userExists($owner) === false) {
182
-				throw new \BadMethodCallException('Unknown user: ' .
182
+				throw new \BadMethodCallException('Unknown user: '.
183 183
 				'method expects path to a user folder relative to the data folder');
184 184
 			}
185 185
 
Please login to merge, or discard this patch.
apps/encryption/lib/Controller/SettingsController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -128,7 +128,7 @@
 block discarded – undo
128 128
 				$encryptedKey = $this->crypt->encryptPrivateKey($decryptedKey, $newPassword, $uid);
129 129
 				$header = $this->crypt->generateHeader();
130 130
 				if ($encryptedKey) {
131
-					$this->keyManager->setPrivateKey($uid, $header . $encryptedKey);
131
+					$this->keyManager->setPrivateKey($uid, $header.$encryptedKey);
132 132
 					$this->session->setPrivateKey($decryptedKey);
133 133
 					$result = true;
134 134
 				}
Please login to merge, or discard this patch.
apps/encryption/lib/Controller/RecoveryController.php 1 patch
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -74,36 +74,36 @@  discard block
 block discarded – undo
74 74
 	public function adminRecovery($recoveryPassword, $confirmPassword, $adminEnableRecovery) {
75 75
 		// Check if both passwords are the same
76 76
 		if (empty($recoveryPassword)) {
77
-			$errorMessage = (string)$this->l->t('Missing recovery key password');
77
+			$errorMessage = (string) $this->l->t('Missing recovery key password');
78 78
 			return new DataResponse(['data' => ['message' => $errorMessage]],
79 79
 				Http::STATUS_BAD_REQUEST);
80 80
 		}
81 81
 
82 82
 		if (empty($confirmPassword)) {
83
-			$errorMessage = (string)$this->l->t('Please repeat the recovery key password');
83
+			$errorMessage = (string) $this->l->t('Please repeat the recovery key password');
84 84
 			return new DataResponse(['data' => ['message' => $errorMessage]],
85 85
 				Http::STATUS_BAD_REQUEST);
86 86
 		}
87 87
 
88 88
 		if ($recoveryPassword !== $confirmPassword) {
89
-			$errorMessage = (string)$this->l->t('Repeated recovery key password does not match the provided recovery key password');
89
+			$errorMessage = (string) $this->l->t('Repeated recovery key password does not match the provided recovery key password');
90 90
 			return new DataResponse(['data' => ['message' => $errorMessage]],
91 91
 				Http::STATUS_BAD_REQUEST);
92 92
 		}
93 93
 
94 94
 		if (isset($adminEnableRecovery) && $adminEnableRecovery === '1') {
95 95
 			if ($this->recovery->enableAdminRecovery($recoveryPassword)) {
96
-				return new DataResponse(['data' => ['message' => (string)$this->l->t('Recovery key successfully enabled')]]);
96
+				return new DataResponse(['data' => ['message' => (string) $this->l->t('Recovery key successfully enabled')]]);
97 97
 			}
98
-			return new DataResponse(['data' => ['message' => (string)$this->l->t('Could not enable recovery key. Please check your recovery key password!')]], Http::STATUS_BAD_REQUEST);
98
+			return new DataResponse(['data' => ['message' => (string) $this->l->t('Could not enable recovery key. Please check your recovery key password!')]], Http::STATUS_BAD_REQUEST);
99 99
 		} elseif (isset($adminEnableRecovery) && $adminEnableRecovery === '0') {
100 100
 			if ($this->recovery->disableAdminRecovery($recoveryPassword)) {
101
-				return new DataResponse(['data' => ['message' => (string)$this->l->t('Recovery key successfully disabled')]]);
101
+				return new DataResponse(['data' => ['message' => (string) $this->l->t('Recovery key successfully disabled')]]);
102 102
 			}
103
-			return new DataResponse(['data' => ['message' => (string)$this->l->t('Could not disable recovery key. Please check your recovery key password!')]], Http::STATUS_BAD_REQUEST);
103
+			return new DataResponse(['data' => ['message' => (string) $this->l->t('Could not disable recovery key. Please check your recovery key password!')]], Http::STATUS_BAD_REQUEST);
104 104
 		}
105 105
 		// this response should never be sent but just in case.
106
-		return new DataResponse(['data' => ['message' => (string)$this->l->t('Missing parameters')]], Http::STATUS_BAD_REQUEST);
106
+		return new DataResponse(['data' => ['message' => (string) $this->l->t('Missing parameters')]], Http::STATUS_BAD_REQUEST);
107 107
 	}
108 108
 
109 109
 	/**
@@ -115,22 +115,22 @@  discard block
 block discarded – undo
115 115
 	public function changeRecoveryPassword($newPassword, $oldPassword, $confirmPassword) {
116 116
 		//check if both passwords are the same
117 117
 		if (empty($oldPassword)) {
118
-			$errorMessage = (string)$this->l->t('Please provide the old recovery password');
118
+			$errorMessage = (string) $this->l->t('Please provide the old recovery password');
119 119
 			return new DataResponse(['data' => ['message' => $errorMessage]], Http::STATUS_BAD_REQUEST);
120 120
 		}
121 121
 
122 122
 		if (empty($newPassword)) {
123
-			$errorMessage = (string)$this->l->t('Please provide a new recovery password');
124
-			return new DataResponse (['data' => ['message' => $errorMessage]], Http::STATUS_BAD_REQUEST);
123
+			$errorMessage = (string) $this->l->t('Please provide a new recovery password');
124
+			return new DataResponse(['data' => ['message' => $errorMessage]], Http::STATUS_BAD_REQUEST);
125 125
 		}
126 126
 
127 127
 		if (empty($confirmPassword)) {
128
-			$errorMessage = (string)$this->l->t('Please repeat the new recovery password');
128
+			$errorMessage = (string) $this->l->t('Please repeat the new recovery password');
129 129
 			return new DataResponse(['data' => ['message' => $errorMessage]], Http::STATUS_BAD_REQUEST);
130 130
 		}
131 131
 
132 132
 		if ($newPassword !== $confirmPassword) {
133
-			$errorMessage = (string)$this->l->t('Repeated recovery key password does not match the provided recovery key password');
133
+			$errorMessage = (string) $this->l->t('Repeated recovery key password does not match the provided recovery key password');
134 134
 			return new DataResponse(['data' => ['message' => $errorMessage]], Http::STATUS_BAD_REQUEST);
135 135
 		}
136 136
 
@@ -141,14 +141,14 @@  discard block
 block discarded – undo
141 141
 			return new DataResponse(
142 142
 				[
143 143
 					'data' => [
144
-						'message' => (string)$this->l->t('Password successfully changed.')]
144
+						'message' => (string) $this->l->t('Password successfully changed.')]
145 145
 				]
146 146
 			);
147 147
 		}
148 148
 		return new DataResponse(
149 149
 			[
150 150
 				'data' => [
151
-					'message' => (string)$this->l->t('Could not change the password. Maybe the old password was not correct.')
151
+					'message' => (string) $this->l->t('Could not change the password. Maybe the old password was not correct.')
152 152
 				]
153 153
 			], Http::STATUS_BAD_REQUEST);
154 154
 	}
@@ -169,14 +169,14 @@  discard block
 block discarded – undo
169 169
 					return new DataResponse(
170 170
 						[
171 171
 							'data' => [
172
-								'message' => (string)$this->l->t('Recovery Key disabled')]
172
+								'message' => (string) $this->l->t('Recovery Key disabled')]
173 173
 						]
174 174
 					);
175 175
 				}
176 176
 				return new DataResponse(
177 177
 					[
178 178
 						'data' => [
179
-							'message' => (string)$this->l->t('Recovery Key enabled')]
179
+							'message' => (string) $this->l->t('Recovery Key enabled')]
180 180
 					]
181 181
 				);
182 182
 			}
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
 		return new DataResponse(
186 186
 			[
187 187
 				'data' => [
188
-					'message' => (string)$this->l->t('Could not enable the recovery key, please try again or contact your administrator')
188
+					'message' => (string) $this->l->t('Could not enable the recovery key, please try again or contact your administrator')
189 189
 				]
190 190
 			], Http::STATUS_BAD_REQUEST);
191 191
 	}
Please login to merge, or discard this patch.
apps/encryption/lib/Exceptions/PublicKeyMissingException.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
 	 * @param string $userId
30 30
 	 */
31 31
 	public function __construct($userId) {
32
-		if(empty($userId)) {
32
+		if (empty($userId)) {
33 33
 			$userId = "<no-user-id-given>";
34 34
 		}
35 35
 		parent::__construct("Public Key missing for user: $userId");
Please login to merge, or discard this patch.
apps/encryption/lib/Exceptions/PrivateKeyMissingException.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
 	 * @param string $userId
33 33
 	 */
34 34
 	public function __construct($userId) {
35
-		if(empty($userId)) {
35
+		if (empty($userId)) {
36 36
 			$userId = "<no-user-id-given>";
37 37
 		}
38 38
 		parent::__construct("Private Key missing for user: $userId");
Please login to merge, or discard this patch.
apps/encryption/lib/Recovery.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
 
110 110
 		if (!$keyManager->recoveryKeyExists()) {
111 111
 			$keyPair = $this->crypt->createKeyPair();
112
-			if(!is_array($keyPair)) {
112
+			if (!is_array($keyPair)) {
113 113
 				return false;
114 114
 			}
115 115
 
@@ -134,13 +134,13 @@  discard block
 block discarded – undo
134 134
 	public function changeRecoveryKeyPassword($newPassword, $oldPassword) {
135 135
 		$recoveryKey = $this->keyManager->getSystemPrivateKey($this->keyManager->getRecoveryKeyId());
136 136
 		$decryptedRecoveryKey = $this->crypt->decryptPrivateKey($recoveryKey, $oldPassword);
137
-		if($decryptedRecoveryKey === false) {
137
+		if ($decryptedRecoveryKey === false) {
138 138
 			return false;
139 139
 		}
140 140
 		$encryptedRecoveryKey = $this->crypt->encryptPrivateKey($decryptedRecoveryKey, $newPassword);
141 141
 		$header = $this->crypt->generateHeader();
142 142
 		if ($encryptedRecoveryKey) {
143
-			$this->keyManager->setSystemPrivateKey($this->keyManager->getRecoveryKeyId(), $header . $encryptedRecoveryKey);
143
+			$this->keyManager->setSystemPrivateKey($this->keyManager->getRecoveryKeyId(), $header.$encryptedRecoveryKey);
144 144
 			return true;
145 145
 		}
146 146
 		return false;
@@ -202,9 +202,9 @@  discard block
 block discarded – undo
202 202
 				$value);
203 203
 
204 204
 			if ($value === '1') {
205
-				$this->addRecoveryKeys('/' . $this->user->getUID() . '/files/');
205
+				$this->addRecoveryKeys('/'.$this->user->getUID().'/files/');
206 206
 			} else {
207
-				$this->removeRecoveryKeys('/' . $this->user->getUID() . '/files/');
207
+				$this->removeRecoveryKeys('/'.$this->user->getUID().'/files/');
208 208
 			}
209 209
 
210 210
 			return true;
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
 		foreach ($dirContent as $item) {
223 223
 			$filePath = $item->getPath();
224 224
 			if ($item['type'] === 'dir') {
225
-				$this->addRecoveryKeys($filePath . '/');
225
+				$this->addRecoveryKeys($filePath.'/');
226 226
 			} else {
227 227
 				$fileKey = $this->keyManager->getFileKey($filePath, $this->user->getUID());
228 228
 				if (!empty($fileKey)) {
@@ -250,7 +250,7 @@  discard block
 block discarded – undo
250 250
 		foreach ($dirContent as $item) {
251 251
 			$filePath = $item->getPath();
252 252
 			if ($item['type'] === 'dir') {
253
-				$this->removeRecoveryKeys($filePath . '/');
253
+				$this->removeRecoveryKeys($filePath.'/');
254 254
 			} else {
255 255
 				$this->keyManager->deleteShareKey($filePath, $this->keyManager->getRecoveryKeyId());
256 256
 			}
@@ -267,8 +267,8 @@  discard block
 block discarded – undo
267 267
 		$encryptedKey = $this->keyManager->getSystemPrivateKey($this->keyManager->getRecoveryKeyId());
268 268
 
269 269
 		$privateKey = $this->crypt->decryptPrivateKey($encryptedKey, $recoveryPassword);
270
-		if($privateKey !== false) {
271
-			$this->recoverAllFiles('/' . $user . '/files/', $privateKey, $user);
270
+		if ($privateKey !== false) {
271
+			$this->recoverAllFiles('/'.$user.'/files/', $privateKey, $user);
272 272
 		}
273 273
 	}
274 274
 
@@ -286,7 +286,7 @@  discard block
 block discarded – undo
286 286
 			// Get relative path from encryption/keyfiles
287 287
 			$filePath = $item->getPath();
288 288
 			if ($this->view->is_dir($filePath)) {
289
-				$this->recoverAllFiles($filePath . '/', $privateKey, $uid);
289
+				$this->recoverAllFiles($filePath.'/', $privateKey, $uid);
290 290
 			} else {
291 291
 				$this->recoverFile($filePath, $privateKey, $uid);
292 292
 			}
Please login to merge, or discard this patch.
apps/encryption/lib/Command/EnableMasterKey.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
 
69 69
 		$isAlreadyEnabled = $this->util->isMasterKeyEnabled();
70 70
 
71
-		if($isAlreadyEnabled) {
71
+		if ($isAlreadyEnabled) {
72 72
 			$output->writeln('Master key already enabled');
73 73
 		} else {
74 74
 			$question = new ConfirmationQuestion(
Please login to merge, or discard this patch.