| Conditions | 10 |
| Paths | 10 |
| Total Lines | 39 |
| Code Lines | 21 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 61 | public function isValidEmoji(string $emoji): bool { |
||
| 62 | $intlBreakIterator = \IntlBreakIterator::createCharacterInstance(); |
||
| 63 | $intlBreakIterator->setText($emoji); |
||
| 64 | |||
| 65 | $characterCount = 0; |
||
| 66 | while ($intlBreakIterator->next() !== \IntlBreakIterator::DONE) { |
||
| 67 | $characterCount++; |
||
| 68 | } |
||
| 69 | |||
| 70 | if ($characterCount !== 1) { |
||
| 71 | return false; |
||
| 72 | } |
||
| 73 | |||
| 74 | $codePointIterator = \IntlBreakIterator::createCodePointInstance(); |
||
| 75 | $codePointIterator->setText($emoji); |
||
| 76 | |||
| 77 | foreach ($codePointIterator->getPartsIterator() as $codePoint) { |
||
| 78 | $codePointType = \IntlChar::charType($codePoint); |
||
| 79 | |||
| 80 | // If the current code-point is an emoji or a modifier (like a skin-tone) |
||
| 81 | // just continue and check the next character |
||
| 82 | if ($codePointType === \IntlChar::CHAR_CATEGORY_MODIFIER_SYMBOL || |
||
| 83 | $codePointType === \IntlChar::CHAR_CATEGORY_MODIFIER_LETTER || |
||
| 84 | $codePointType === \IntlChar::CHAR_CATEGORY_OTHER_SYMBOL || |
||
| 85 | $codePointType === \IntlChar::CHAR_CATEGORY_GENERAL_OTHER_TYPES) { |
||
| 86 | continue; |
||
| 87 | } |
||
| 88 | |||
| 89 | // If it's neither a modifier nor an emoji, we only allow |
||
| 90 | // a zero-width-joiner or a variation selector 16 |
||
| 91 | $codePointValue = \IntlChar::ord($codePoint); |
||
| 92 | if ($codePointValue === 8205 || $codePointValue === 65039) { |
||
| 93 | continue; |
||
| 94 | } |
||
| 95 | |||
| 96 | return false; |
||
| 97 | } |
||
| 98 | |||
| 99 | return true; |
||
| 100 | } |
||
| 102 |