nextcloud / server

core/Command/Encryption/DecryptAll.php

Indentation +135 added lines, -135 removed lines

@@ -38,139 +38,139 @@
 
 class DecryptAll extends Command {
 
-	/** @var IManager */
-	protected $encryptionManager;
-
-	/** @var  IAppManager */
-	protected $appManager;
-
-	/** @var IConfig */
-	protected $config;
-
-	/** @var  QuestionHelper */
-	protected $questionHelper;
-
-	/** @var bool */
-	protected $wasTrashbinEnabled;
-
-	/** @var  bool */
-	protected $wasMaintenanceModeEnabled;
-
-	/** @var \OC\Encryption\DecryptAll */
-	protected $decryptAll;
-
-	/**
-	 * @param IManager $encryptionManager
-	 * @param IAppManager $appManager
-	 * @param IConfig $config
-	 * @param \OC\Encryption\DecryptAll $decryptAll
-	 * @param QuestionHelper $questionHelper
-	 */
-	public function __construct(
-		IManager $encryptionManager,
-		IAppManager $appManager,
-		IConfig $config,
-		\OC\Encryption\DecryptAll $decryptAll,
-		QuestionHelper $questionHelper
-	) {
-		parent::__construct();
-
-		$this->appManager = $appManager;
-		$this->encryptionManager = $encryptionManager;
-		$this->config = $config;
-		$this->decryptAll = $decryptAll;
-		$this->questionHelper = $questionHelper;
-	}
-
-	/**
-	 * Set maintenance mode and disable the trashbin app
-	 */
-	protected function forceMaintenanceAndTrashbin() {
-		$this->wasTrashbinEnabled = $this->appManager->isEnabledForUser('files_trashbin');
-		$this->wasMaintenanceModeEnabled = $this->config->getSystemValue('maintenance', false);
-		$this->config->setSystemValue('maintenance', true);
-		$this->appManager->disableApp('files_trashbin');
-	}
-
-	/**
-	 * Reset the maintenance mode and re-enable the trashbin app
-	 */
-	protected function resetMaintenanceAndTrashbin() {
-		$this->config->setSystemValue('maintenance', $this->wasMaintenanceModeEnabled);
-		if ($this->wasTrashbinEnabled) {
-			$this->appManager->enableApp('files_trashbin');
-		}
-	}
-
-	protected function configure() {
-		parent::configure();
-
-		$this->setName('encryption:decrypt-all');
-		$this->setDescription('Disable server-side encryption and decrypt all files');
-		$this->setHelp(
-			'This will disable server-side encryption and decrypt all files for '
-			. 'all users if it is supported by your encryption module. '
-			. 'Please make sure that no user access his files during this process!'
-		);
-		$this->addArgument(
-			'user',
-			InputArgument::OPTIONAL,
-			'user for which you want to decrypt all files (optional)',
-			''
-		);
-	}
-
-	protected function execute(InputInterface $input, OutputInterface $output) {
-
-		try {
-			if ($this->encryptionManager->isEnabled() === true) {
-				$output->write('Disable server side encryption... ');
-				$this->config->setAppValue('core', 'encryption_enabled', 'no');
-				$output->writeln('done.');
-			} else {
-				$output->writeln('Server side encryption not enabled. Nothing to do.');
-				return;
-			}
-
-			$uid = $input->getArgument('user');
-			if ($uid === '') {
-				$message = 'your Nextcloud';
-			} else {
-				$message = "$uid's account";
-			}
-
-			$output->writeln("\n");
-			$output->writeln("You are about to start to decrypt all files stored in $message.");
-			$output->writeln('It will depend on the encryption module and your setup if this is possible.');
-			$output->writeln('Depending on the number and size of your files this can take some time');
-			$output->writeln('Please make sure that no user access his files during this process!');
-			$output->writeln('');
-			$question = new ConfirmationQuestion('Do you really want to continue? (y/n) ', false);
-			if ($this->questionHelper->ask($input, $output, $question)) {
-				$this->forceMaintenanceAndTrashbin();
-				$user = $input->getArgument('user');
-				$result = $this->decryptAll->decryptAll($input, $output, $user);
-				if ($result === false) {
-					$output->writeln(' aborted.');
-					$output->writeln('Server side encryption remains enabled');
-					$this->config->setAppValue('core', 'encryption_enabled', 'yes');
-				} else if ($uid !== '') {
-					$output->writeln('Server side encryption remains enabled');
-					$this->config->setAppValue('core', 'encryption_enabled', 'yes');
-				}
-				$this->resetMaintenanceAndTrashbin();
-			} else {
-				$output->write('Enable server side encryption... ');
-				$this->config->setAppValue('core', 'encryption_enabled', 'yes');
-				$output->writeln('done.');
-				$output->writeln('aborted');
-			}
-		} catch (\Exception $e) {
-			// enable server side encryption again if something went wrong
-			$this->config->setAppValue('core', 'encryption_enabled', 'yes');
-			$this->resetMaintenanceAndTrashbin();
-			throw $e;
-		}
-
-	}
+    /** @var IManager */
+    protected $encryptionManager;
+
+    /** @var  IAppManager */
+    protected $appManager;
+
+    /** @var IConfig */
+    protected $config;
+
+    /** @var  QuestionHelper */
+    protected $questionHelper;
+
+    /** @var bool */
+    protected $wasTrashbinEnabled;
+
+    /** @var  bool */
+    protected $wasMaintenanceModeEnabled;
+
+    /** @var \OC\Encryption\DecryptAll */
+    protected $decryptAll;
+
+    /**
+     * @param IManager $encryptionManager
+     * @param IAppManager $appManager
+     * @param IConfig $config
+     * @param \OC\Encryption\DecryptAll $decryptAll
+     * @param QuestionHelper $questionHelper
+     */
+    public function __construct(
+        IManager $encryptionManager,
+        IAppManager $appManager,
+        IConfig $config,
+        \OC\Encryption\DecryptAll $decryptAll,
+        QuestionHelper $questionHelper
+    ) {
+        parent::__construct();
+
+        $this->appManager = $appManager;
+        $this->encryptionManager = $encryptionManager;
+        $this->config = $config;
+        $this->decryptAll = $decryptAll;
+        $this->questionHelper = $questionHelper;
+    }
+
+    /**
+     * Set maintenance mode and disable the trashbin app
+     */
+    protected function forceMaintenanceAndTrashbin() {
+        $this->wasTrashbinEnabled = $this->appManager->isEnabledForUser('files_trashbin');
+        $this->wasMaintenanceModeEnabled = $this->config->getSystemValue('maintenance', false);
+        $this->config->setSystemValue('maintenance', true);
+        $this->appManager->disableApp('files_trashbin');
+    }
+
+    /**
+     * Reset the maintenance mode and re-enable the trashbin app
+     */
+    protected function resetMaintenanceAndTrashbin() {
+        $this->config->setSystemValue('maintenance', $this->wasMaintenanceModeEnabled);
+        if ($this->wasTrashbinEnabled) {
+            $this->appManager->enableApp('files_trashbin');
+        }
+    }
+
+    protected function configure() {
+        parent::configure();
+
+        $this->setName('encryption:decrypt-all');
+        $this->setDescription('Disable server-side encryption and decrypt all files');
+        $this->setHelp(
+            'This will disable server-side encryption and decrypt all files for '
+            . 'all users if it is supported by your encryption module. '
+            . 'Please make sure that no user access his files during this process!'
+        );
+        $this->addArgument(
+            'user',
+            InputArgument::OPTIONAL,
+            'user for which you want to decrypt all files (optional)',
+            ''
+        );
+    }
+
+    protected function execute(InputInterface $input, OutputInterface $output) {
+
+        try {
+            if ($this->encryptionManager->isEnabled() === true) {
+                $output->write('Disable server side encryption... ');
+                $this->config->setAppValue('core', 'encryption_enabled', 'no');
+                $output->writeln('done.');
+            } else {
+                $output->writeln('Server side encryption not enabled. Nothing to do.');
+                return;
+            }
+
+            $uid = $input->getArgument('user');
+            if ($uid === '') {
+                $message = 'your Nextcloud';
+            } else {
+                $message = "$uid's account";
+            }
+
+            $output->writeln("\n");
+            $output->writeln("You are about to start to decrypt all files stored in $message.");
+            $output->writeln('It will depend on the encryption module and your setup if this is possible.');
+            $output->writeln('Depending on the number and size of your files this can take some time');
+            $output->writeln('Please make sure that no user access his files during this process!');
+            $output->writeln('');
+            $question = new ConfirmationQuestion('Do you really want to continue? (y/n) ', false);
+            if ($this->questionHelper->ask($input, $output, $question)) {
+                $this->forceMaintenanceAndTrashbin();
+                $user = $input->getArgument('user');
+                $result = $this->decryptAll->decryptAll($input, $output, $user);
+                if ($result === false) {
+                    $output->writeln(' aborted.');
+                    $output->writeln('Server side encryption remains enabled');
+                    $this->config->setAppValue('core', 'encryption_enabled', 'yes');
+                } else if ($uid !== '') {
+                    $output->writeln('Server side encryption remains enabled');
+                    $this->config->setAppValue('core', 'encryption_enabled', 'yes');
+                }
+                $this->resetMaintenanceAndTrashbin();
+            } else {
+                $output->write('Enable server side encryption... ');
+                $this->config->setAppValue('core', 'encryption_enabled', 'yes');
+                $output->writeln('done.');
+                $output->writeln('aborted');
+            }
+        } catch (\Exception $e) {
+            // enable server side encryption again if something went wrong
+            $this->config->setAppValue('core', 'encryption_enabled', 'yes');
+            $this->resetMaintenanceAndTrashbin();
+            throw $e;
+        }
+
+    }
 }

lib/private/OCS/Provider.php

Spacing +3 added lines, -3 removed lines

@@ -54,7 +54,7 @@ 
 			],
 		];
 
-		if($this->appManager->isEnabledForUser('files_sharing')) {
+		if ($this->appManager->isEnabledForUser('files_sharing')) {
 			$services['SHARING'] = [
 				'version' => 1,
 				'endpoints' => [
@@ -85,7 +85,7 @@ 
 			}
 		}
 
-		if($this->appManager->isEnabledForUser('activity')) {
+		if ($this->appManager->isEnabledForUser('activity')) {
 			$services['ACTIVITY'] = [
 				'version' => 1,
 				'endpoints' => [
@@ -94,7 +94,7 @@ 
 			];
 		}
 
-		if($this->appManager->isEnabledForUser('provisioning_api')) {
+		if ($this->appManager->isEnabledForUser('provisioning_api')) {
 			$services['PROVISIONING'] = [
 				'version' => 1,
 				'endpoints' => [

Indentation +81 added lines, -81 removed lines

@@ -24,92 +24,92 @@
 namespace OC\OCS;
 
 class Provider extends \OCP\AppFramework\Controller {
-	/** @var \OCP\App\IAppManager */
-	private $appManager;
+    /** @var \OCP\App\IAppManager */
+    private $appManager;
 
-	/**
-	 * @param string $appName
-	 * @param \OCP\IRequest $request
-	 * @param \OCP\App\IAppManager $appManager
-	 */
-	public function __construct($appName,
-								\OCP\IRequest $request,
-								\OCP\App\IAppManager $appManager) {
-		parent::__construct($appName, $request);
-		$this->appManager = $appManager;
-	}
+    /**
+     * @param string $appName
+     * @param \OCP\IRequest $request
+     * @param \OCP\App\IAppManager $appManager
+     */
+    public function __construct($appName,
+                                \OCP\IRequest $request,
+                                \OCP\App\IAppManager $appManager) {
+        parent::__construct($appName, $request);
+        $this->appManager = $appManager;
+    }
 
-	/**
-	 * @return \OCP\AppFramework\Http\JSONResponse
-	 */
-	public function buildProviderList() {
-		$services = [
-			'PRIVATE_DATA' => [
-				'version' => 1,
-				'endpoints' => [
-					'store' => '/ocs/v2.php/privatedata/setattribute',
-					'read' => '/ocs/v2.php/privatedata/getattribute',
-					'delete' => '/ocs/v2.php/privatedata/deleteattribute',
-				],
-			],
-		];
+    /**
+     * @return \OCP\AppFramework\Http\JSONResponse
+     */
+    public function buildProviderList() {
+        $services = [
+            'PRIVATE_DATA' => [
+                'version' => 1,
+                'endpoints' => [
+                    'store' => '/ocs/v2.php/privatedata/setattribute',
+                    'read' => '/ocs/v2.php/privatedata/getattribute',
+                    'delete' => '/ocs/v2.php/privatedata/deleteattribute',
+                ],
+            ],
+        ];
 
-		if($this->appManager->isEnabledForUser('files_sharing')) {
-			$services['SHARING'] = [
-				'version' => 1,
-				'endpoints' => [
-					'share' => '/ocs/v2.php/apps/files_sharing/api/v1/shares',
-				],
-			];
-			$services['FEDERATED_SHARING'] = [
-				'version' => 1,
-				'endpoints' => [
-					'share' => '/ocs/v2.php/cloud/shares',
-					'webdav' => '/public.php/webdav/',
-				],
-			];
-		}
+        if($this->appManager->isEnabledForUser('files_sharing')) {
+            $services['SHARING'] = [
+                'version' => 1,
+                'endpoints' => [
+                    'share' => '/ocs/v2.php/apps/files_sharing/api/v1/shares',
+                ],
+            ];
+            $services['FEDERATED_SHARING'] = [
+                'version' => 1,
+                'endpoints' => [
+                    'share' => '/ocs/v2.php/cloud/shares',
+                    'webdav' => '/public.php/webdav/',
+                ],
+            ];
+        }
 
-		if ($this->appManager->isEnabledForUser('federation')) {
-			if (isset($services['FEDERATED_SHARING'])) {
-				$services['FEDERATED_SHARING']['endpoints']['shared-secret'] = '/ocs/v2.php/cloud/shared-secret';
-				$services['FEDERATED_SHARING']['endpoints']['system-address-book'] = '/remote.php/dav/addressbooks/system/system/system';
-				$services['FEDERATED_SHARING']['endpoints']['carddav-user'] = 'system';
-			} else {
-				$services['FEDERATED_SHARING'] = [
-					'version' => 1,
-					'endpoints' => [
-						'shared-secret' => '/ocs/v2.php/cloud/shared-secret',
-						'system-address-book' => '/remote.php/dav/addressbooks/system/system/system',
-						'carddav-user' => 'system'
-					],
-				];
-			}
-		}
+        if ($this->appManager->isEnabledForUser('federation')) {
+            if (isset($services['FEDERATED_SHARING'])) {
+                $services['FEDERATED_SHARING']['endpoints']['shared-secret'] = '/ocs/v2.php/cloud/shared-secret';
+                $services['FEDERATED_SHARING']['endpoints']['system-address-book'] = '/remote.php/dav/addressbooks/system/system/system';
+                $services['FEDERATED_SHARING']['endpoints']['carddav-user'] = 'system';
+            } else {
+                $services['FEDERATED_SHARING'] = [
+                    'version' => 1,
+                    'endpoints' => [
+                        'shared-secret' => '/ocs/v2.php/cloud/shared-secret',
+                        'system-address-book' => '/remote.php/dav/addressbooks/system/system/system',
+                        'carddav-user' => 'system'
+                    ],
+                ];
+            }
+        }
 
-		if($this->appManager->isEnabledForUser('activity')) {
-			$services['ACTIVITY'] = [
-				'version' => 1,
-				'endpoints' => [
-					'list' => '/ocs/v2.php/cloud/activity',
-				],
-			];
-		}
+        if($this->appManager->isEnabledForUser('activity')) {
+            $services['ACTIVITY'] = [
+                'version' => 1,
+                'endpoints' => [
+                    'list' => '/ocs/v2.php/cloud/activity',
+                ],
+            ];
+        }
 
-		if($this->appManager->isEnabledForUser('provisioning_api')) {
-			$services['PROVISIONING'] = [
-				'version' => 1,
-				'endpoints' => [
-					'user' => '/ocs/v2.php/cloud/users',
-					'groups' => '/ocs/v2.php/cloud/groups',
-					'apps' => '/ocs/v2.php/cloud/apps',
-				],
-			];
-		}
+        if($this->appManager->isEnabledForUser('provisioning_api')) {
+            $services['PROVISIONING'] = [
+                'version' => 1,
+                'endpoints' => [
+                    'user' => '/ocs/v2.php/cloud/users',
+                    'groups' => '/ocs/v2.php/cloud/groups',
+                    'apps' => '/ocs/v2.php/cloud/apps',
+                ],
+            ];
+        }
 
-		return new \OCP\AppFramework\Http\JSONResponse([
-			'version' => 2,
-			'services' => $services,
-		]);
-	}
+        return new \OCP\AppFramework\Http\JSONResponse([
+            'version' => 2,
+            'services' => $services,
+        ]);
+    }
 }

apps/dav/lib/DAV/GroupPrincipalBackend.php

Indentation +168 added lines, -168 removed lines

@@ -30,172 +30,172 @@
 
 class GroupPrincipalBackend implements BackendInterface {
 
-	const PRINCIPAL_PREFIX = 'principals/groups';
-
-	/** @var IGroupManager */
-	private $groupManager;
-
-	/**
-	 * @param IGroupManager $IGroupManager
-	 */
-	public function __construct(IGroupManager $IGroupManager) {
-		$this->groupManager = $IGroupManager;
-	}
-
-	/**
-	 * Returns a list of principals based on a prefix.
-	 *
-	 * This prefix will often contain something like 'principals'. You are only
-	 * expected to return principals that are in this base path.
-	 *
-	 * You are expected to return at least a 'uri' for every user, you can
-	 * return any additional properties if you wish so. Common properties are:
-	 *   {DAV:}displayname
-	 *
-	 * @param string $prefixPath
-	 * @return string[]
-	 */
-	public function getPrincipalsByPrefix($prefixPath) {
-		$principals = [];
-
-		if ($prefixPath === self::PRINCIPAL_PREFIX) {
-			foreach($this->groupManager->search('') as $user) {
-				$principals[] = $this->groupToPrincipal($user);
-			}
-		}
-
-		return $principals;
-	}
-
-	/**
-	 * Returns a specific principal, specified by it's path.
-	 * The returned structure should be the exact same as from
-	 * getPrincipalsByPrefix.
-	 *
-	 * @param string $path
-	 * @return array
-	 */
-	public function getPrincipalByPath($path) {
-		$elements = explode('/', $path,  3);
-		if ($elements[0] !== 'principals') {
-			return null;
-		}
-		if ($elements[1] !== 'groups') {
-			return null;
-		}
-		$name = urldecode($elements[2]);
-		$group = $this->groupManager->get($name);
-
-		if (!is_null($group)) {
-			return $this->groupToPrincipal($group);
-		}
-
-		return null;
-	}
-
-	/**
-	 * Returns the list of members for a group-principal
-	 *
-	 * @param string $principal
-	 * @return string[]
-	 * @throws Exception
-	 */
-	public function getGroupMemberSet($principal) {
-		$elements = explode('/', $principal);
-		if ($elements[0] !== 'principals') {
-			return [];
-		}
-		if ($elements[1] !== 'groups') {
-			return [];
-		}
-		$name = $elements[2];
-		$group = $this->groupManager->get($name);
-
-		if (is_null($group)) {
-			return [];
-		}
-
-		return array_map(function($user) {
-			return $this->userToPrincipal($user);
-		}, $group->getUsers());
-	}
-
-	/**
-	 * Returns the list of groups a principal is a member of
-	 *
-	 * @param string $principal
-	 * @return array
-	 * @throws Exception
-	 */
-	public function getGroupMembership($principal) {
-		return [];
-	}
-
-	/**
-	 * Updates the list of group members for a group principal.
-	 *
-	 * The principals should be passed as a list of uri's.
-	 *
-	 * @param string $principal
-	 * @param string[] $members
-	 * @throws Exception
-	 */
-	public function setGroupMemberSet($principal, array $members) {
-		throw new Exception('Setting members of the group is not supported yet');
-	}
-
-	/**
-	 * @param string $path
-	 * @param PropPatch $propPatch
-	 * @return int
-	 */
-	function updatePrincipal($path, PropPatch $propPatch) {
-		return 0;
-	}
-
-	/**
-	 * @param string $prefixPath
-	 * @param array $searchProperties
-	 * @param string $test
-	 * @return array
-	 */
-	function searchPrincipals($prefixPath, array $searchProperties, $test = 'allof') {
-		return [];
-	}
-
-	/**
-	 * @param string $uri
-	 * @param string $principalPrefix
-	 * @return string
-	 */
-	function findByUri($uri, $principalPrefix) {
-		return '';
-	}
-
-	/**
-	 * @param IGroup $group
-	 * @return array
-	 */
-	protected function groupToPrincipal($group) {
-		$groupId = $group->getGID();
-		$principal = [
-			'uri' => 'principals/groups/' . urlencode($groupId),
-			'{DAV:}displayname' => $groupId,
-		];
-
-		return $principal;
-	}
-
-	/**
-	 * @param IUser $user
-	 * @return array
-	 */
-	protected function userToPrincipal($user) {
-		$principal = [
-			'uri' => 'principals/users/' . $user->getUID(),
-			'{DAV:}displayname' => $user->getDisplayName(),
-		];
-
-		return $principal;
-	}
+    const PRINCIPAL_PREFIX = 'principals/groups';
+
+    /** @var IGroupManager */
+    private $groupManager;
+
+    /**
+     * @param IGroupManager $IGroupManager
+     */
+    public function __construct(IGroupManager $IGroupManager) {
+        $this->groupManager = $IGroupManager;
+    }
+
+    /**
+     * Returns a list of principals based on a prefix.
+     *
+     * This prefix will often contain something like 'principals'. You are only
+     * expected to return principals that are in this base path.
+     *
+     * You are expected to return at least a 'uri' for every user, you can
+     * return any additional properties if you wish so. Common properties are:
+     *   {DAV:}displayname
+     *
+     * @param string $prefixPath
+     * @return string[]
+     */
+    public function getPrincipalsByPrefix($prefixPath) {
+        $principals = [];
+
+        if ($prefixPath === self::PRINCIPAL_PREFIX) {
+            foreach($this->groupManager->search('') as $user) {
+                $principals[] = $this->groupToPrincipal($user);
+            }
+        }
+
+        return $principals;
+    }
+
+    /**
+     * Returns a specific principal, specified by it's path.
+     * The returned structure should be the exact same as from
+     * getPrincipalsByPrefix.
+     *
+     * @param string $path
+     * @return array
+     */
+    public function getPrincipalByPath($path) {
+        $elements = explode('/', $path,  3);
+        if ($elements[0] !== 'principals') {
+            return null;
+        }
+        if ($elements[1] !== 'groups') {
+            return null;
+        }
+        $name = urldecode($elements[2]);
+        $group = $this->groupManager->get($name);
+
+        if (!is_null($group)) {
+            return $this->groupToPrincipal($group);
+        }
+
+        return null;
+    }
+
+    /**
+     * Returns the list of members for a group-principal
+     *
+     * @param string $principal
+     * @return string[]
+     * @throws Exception
+     */
+    public function getGroupMemberSet($principal) {
+        $elements = explode('/', $principal);
+        if ($elements[0] !== 'principals') {
+            return [];
+        }
+        if ($elements[1] !== 'groups') {
+            return [];
+        }
+        $name = $elements[2];
+        $group = $this->groupManager->get($name);
+
+        if (is_null($group)) {
+            return [];
+        }
+
+        return array_map(function($user) {
+            return $this->userToPrincipal($user);
+        }, $group->getUsers());
+    }
+
+    /**
+     * Returns the list of groups a principal is a member of
+     *
+     * @param string $principal
+     * @return array
+     * @throws Exception
+     */
+    public function getGroupMembership($principal) {
+        return [];
+    }
+
+    /**
+     * Updates the list of group members for a group principal.
+     *
+     * The principals should be passed as a list of uri's.
+     *
+     * @param string $principal
+     * @param string[] $members
+     * @throws Exception
+     */
+    public function setGroupMemberSet($principal, array $members) {
+        throw new Exception('Setting members of the group is not supported yet');
+    }
+
+    /**
+     * @param string $path
+     * @param PropPatch $propPatch
+     * @return int
+     */
+    function updatePrincipal($path, PropPatch $propPatch) {
+        return 0;
+    }
+
+    /**
+     * @param string $prefixPath
+     * @param array $searchProperties
+     * @param string $test
+     * @return array
+     */
+    function searchPrincipals($prefixPath, array $searchProperties, $test = 'allof') {
+        return [];
+    }
+
+    /**
+     * @param string $uri
+     * @param string $principalPrefix
+     * @return string
+     */
+    function findByUri($uri, $principalPrefix) {
+        return '';
+    }
+
+    /**
+     * @param IGroup $group
+     * @return array
+     */
+    protected function groupToPrincipal($group) {
+        $groupId = $group->getGID();
+        $principal = [
+            'uri' => 'principals/groups/' . urlencode($groupId),
+            '{DAV:}displayname' => $groupId,
+        ];
+
+        return $principal;
+    }
+
+    /**
+     * @param IUser $user
+     * @return array
+     */
+    protected function userToPrincipal($user) {
+        $principal = [
+            'uri' => 'principals/users/' . $user->getUID(),
+            '{DAV:}displayname' => $user->getDisplayName(),
+        ];
+
+        return $principal;
+    }
 }

Spacing +4 added lines, -4 removed lines

@@ -59,7 +59,7 @@ 
 		$principals = [];
 
 		if ($prefixPath === self::PRINCIPAL_PREFIX) {
-			foreach($this->groupManager->search('') as $user) {
+			foreach ($this->groupManager->search('') as $user) {
 				$principals[] = $this->groupToPrincipal($user);
 			}
 		}
@@ -76,7 +76,7 @@ 
 	 * @return array
 	 */
 	public function getPrincipalByPath($path) {
-		$elements = explode('/', $path,  3);
+		$elements = explode('/', $path, 3);
 		if ($elements[0] !== 'principals') {
 			return null;
 		}
@@ -179,7 +179,7 @@ 
 	protected function groupToPrincipal($group) {
 		$groupId = $group->getGID();
 		$principal = [
-			'uri' => 'principals/groups/' . urlencode($groupId),
+			'uri' => 'principals/groups/'.urlencode($groupId),
 			'{DAV:}displayname' => $groupId,
 		];
 
@@ -192,7 +192,7 @@ 
 	 */
 	protected function userToPrincipal($user) {
 		$principal = [
-			'uri' => 'principals/users/' . $user->getUID(),
+			'uri' => 'principals/users/'.$user->getUID(),
 			'{DAV:}displayname' => $user->getDisplayName(),
 		];
 

core/templates/twofactorshowchallenge.php

Spacing +1 added lines, -1 removed lines

@@ -14,7 +14,7 @@
 <div class="warning">
 	<h2 class="two-factor-header"><?php p($provider->getDisplayName()); ?></h2>
 	<?php if ($error): ?>
-			<?php if($error_message): ?>
+			<?php if ($error_message): ?>
 				<p><strong><?php p($error_message); ?></strong></p>
 			<?php else: ?>
 				<p><strong><?php p($l->t('Error while validating your second factor')); ?></strong></p>

Braces +5 added lines, -2 removed lines

@@ -16,8 +16,11 @@
 	<?php if ($error): ?>
 			<?php if($error_message): ?>
 				<p><strong><?php p($error_message); ?></strong></p>
-			<?php else: ?>
-				<p><strong><?php p($l->t('Error while validating your second factor')); ?></strong></p>
+			<?php else {
+    : ?>
+				<p><strong><?php p($l->t('Error while validating your second factor'));
+}
+?></strong></p>
 			<?php endif; ?>
 	<?php endif; ?>
 	<?php print_unescaped($template); ?>

Indentation +5 added lines, -5 removed lines

@@ -25,11 +25,11 @@
 		<a class="button" href="<?php print_unescaped($_['logout_url']); ?>"><?php p($l->t('Cancel log in')) ?></a>
 		<?php if (!is_null($_['backupProvider'])): ?>
 		<a class="button" href="<?php p(\OC::$server->getURLGenerator()->linkToRoute('core.TwoFactorChallenge.showChallenge',
-												[
-													'challengeProviderId' => $_['backupProvider']->getId(),
-													'redirect_url' => $_['redirect_url'],
-												]
-											)) ?>"><?php p($l->t('Use backup code')) ?></a>
+                                                [
+                                                    'challengeProviderId' => $_['backupProvider']->getId(),
+                                                    'redirect_url' => $_['redirect_url'],
+                                                ]
+                                            )) ?>"><?php p($l->t('Use backup code')) ?></a>
 		<?php endif; ?>
 	</p>
 </div>

apps/workflowengine/lib/AppInfo/Application.php

Indentation +45 added lines, -45 removed lines

@@ -23,56 +23,56 @@
 
 class Application extends \OCP\AppFramework\App {
 
-	public function __construct() {
-		parent::__construct('workflowengine');
+    public function __construct() {
+        parent::__construct('workflowengine');
 
-		$this->getContainer()->registerAlias('FlowOperationsController', 'OCA\WorkflowEngine\Controller\FlowOperations');
-		$this->getContainer()->registerAlias('RequestTimeController', 'OCA\WorkflowEngine\Controller\RequestTime');
-	}
+        $this->getContainer()->registerAlias('FlowOperationsController', 'OCA\WorkflowEngine\Controller\FlowOperations');
+        $this->getContainer()->registerAlias('RequestTimeController', 'OCA\WorkflowEngine\Controller\RequestTime');
+    }
 
-	/**
-	 * Register all hooks and listeners
-	 */
-	public function registerHooksAndListeners() {
-		$dispatcher = $this->getContainer()->getServer()->getEventDispatcher();
-		$dispatcher->addListener(
-			'OCP\WorkflowEngine::loadAdditionalSettingScripts',
-			function() {
-				if (!function_exists('style')) {
-					// This is hacky, but we need to load the template class
-					class_exists('OCP\Template', true);
-				}
+    /**
+     * Register all hooks and listeners
+     */
+    public function registerHooksAndListeners() {
+        $dispatcher = $this->getContainer()->getServer()->getEventDispatcher();
+        $dispatcher->addListener(
+            'OCP\WorkflowEngine::loadAdditionalSettingScripts',
+            function() {
+                if (!function_exists('style')) {
+                    // This is hacky, but we need to load the template class
+                    class_exists('OCP\Template', true);
+                }
 
-				style('workflowengine', [
-					'admin',
-				]);
+                style('workflowengine', [
+                    'admin',
+                ]);
 
-				script('core', [
-					'files/fileinfo',
-					'files/client',
-					'oc-backbone-webdav',
-					'systemtags/systemtags',
-					'systemtags/systemtagmodel',
-					'systemtags/systemtagscollection',
-				]);
+                script('core', [
+                    'files/fileinfo',
+                    'files/client',
+                    'oc-backbone-webdav',
+                    'systemtags/systemtags',
+                    'systemtags/systemtagmodel',
+                    'systemtags/systemtagscollection',
+                ]);
 
-				vendor_script('jsTimezoneDetect/jstz');
+                vendor_script('jsTimezoneDetect/jstz');
 
-				script('workflowengine', [
-					'admin',
+                script('workflowengine', [
+                    'admin',
 
-					// Check plugins
-					'filemimetypeplugin',
-					'filesizeplugin',
-					'filesystemtagsplugin',
-					'requestremoteaddressplugin',
-					'requesttimeplugin',
-					'requesturlplugin',
-					'requestuseragentplugin',
-					'usergroupmembershipplugin',
-				]);
-			},
-			-100
-		);
-	}
+                    // Check plugins
+                    'filemimetypeplugin',
+                    'filesizeplugin',
+                    'filesystemtagsplugin',
+                    'requestremoteaddressplugin',
+                    'requesttimeplugin',
+                    'requesturlplugin',
+                    'requestuseragentplugin',
+                    'usergroupmembershipplugin',
+                ]);
+            },
+            -100
+        );
+    }
 }

apps/workflowengine/lib/Check/FileMimeType.php

Spacing +1 added lines, -1 removed lines

@@ -88,7 +88,7 @@
 				if (strpos($path, '/webdav/') === 0) {
 					$path = substr($path, strlen('/webdav'));
 				}
-				$path = $this->path . $path;
+				$path = $this->path.$path;
 				$this->mimeType[$this->storage->getId()][$path] = $this->mimeTypeDetector->detectPath($path);
 				return $this->mimeType[$this->storage->getId()][$path];
 			}

Indentation +155 added lines, -155 removed lines

@@ -29,159 +29,159 @@
 
 class FileMimeType extends AbstractStringCheck {
 
-	/** @var array */
-	protected $mimeType;
-
-	/** @var IRequest */
-	protected $request;
-
-	/** @var IMimeTypeDetector */
-	protected $mimeTypeDetector;
-
-	/** @var IStorage */
-	protected $storage;
-
-	/** @var string */
-	protected $path;
-
-	/**
-	 * @param IL10N $l
-	 * @param IRequest $request
-	 * @param IMimeTypeDetector $mimeTypeDetector
-	 */
-	public function __construct(IL10N $l, IRequest $request, IMimeTypeDetector $mimeTypeDetector) {
-		parent::__construct($l);
-		$this->request = $request;
-		$this->mimeTypeDetector = $mimeTypeDetector;
-	}
-
-	/**
-	 * @param IStorage $storage
-	 * @param string $path
-	 */
-	public function setFileInfo(IStorage $storage, $path) {
-		$this->storage = $storage;
-		$this->path = $path;
-		if (!isset($this->mimeType[$this->storage->getId()][$this->path])
-			|| $this->mimeType[$this->storage->getId()][$this->path] === '') {
-			$this->mimeType[$this->storage->getId()][$this->path] = null;
-		}
-	}
-
-	/**
-	 * @return string
-	 */
-	protected function getActualValue() {
-		if ($this->mimeType[$this->storage->getId()][$this->path] !== null) {
-			return $this->mimeType[$this->storage->getId()][$this->path];
-		}
-
-		if ($this->isWebDAVRequest()) {
-			// Creating a folder
-			if ($this->request->getMethod() === 'MKCOL') {
-				$this->mimeType[$this->storage->getId()][$this->path] = 'httpd/unix-directory';
-				return $this->mimeType[$this->storage->getId()][$this->path];
-			}
-
-			if ($this->request->getMethod() === 'PUT') {
-				$path = $this->request->getPathInfo();
-				$this->mimeType[$this->storage->getId()][$this->path] = $this->mimeTypeDetector->detectPath($path);
-				return $this->mimeType[$this->storage->getId()][$this->path];
-			}
-		} else if ($this->isPublicWebDAVRequest()) {
-			if ($this->request->getMethod() === 'PUT') {
-				$path = $this->request->getPathInfo();
-				if (strpos($path, '/webdav/') === 0) {
-					$path = substr($path, strlen('/webdav'));
-				}
-				$path = $this->path . $path;
-				$this->mimeType[$this->storage->getId()][$path] = $this->mimeTypeDetector->detectPath($path);
-				return $this->mimeType[$this->storage->getId()][$path];
-			}
-		}
-
-		if (in_array($this->request->getMethod(), ['POST', 'PUT'])) {
-			$files = $this->request->getUploadedFile('files');
-			if (isset($files['type'][0])) {
-				$mimeType = $files['type'][0];
-				if ($this->mimeType === 'application/octet-stream') {
-					// Maybe not...
-					$mimeTypeTest = $this->mimeTypeDetector->detectPath($files['name'][0]);
-					if ($mimeTypeTest !== 'application/octet-stream' && $mimeTypeTest !== false) {
-						$mimeType = $mimeTypeTest;
-					} else {
-						$mimeTypeTest = $this->mimeTypeDetector->detect($files['tmp_name'][0]);
-						if ($mimeTypeTest !== 'application/octet-stream' && $mimeTypeTest !== false) {
-							$mimeType = $mimeTypeTest;
-						}
-					}
-				}
-				$this->mimeType[$this->storage->getId()][$this->path] = $mimeType;
-				return $mimeType;
-			}
-		}
-
-		$this->mimeType[$this->storage->getId()][$this->path] = $this->storage->getMimeType($this->path);
-		if ($this->mimeType[$this->storage->getId()][$this->path] === 'application/octet-stream') {
-			$this->mimeType[$this->storage->getId()][$this->path] = $this->detectMimetypeFromPath();
-		}
-
-		return $this->mimeType[$this->storage->getId()][$this->path];
-	}
-
-	/**
-	 * @return string
-	 */
-	protected function detectMimetypeFromPath() {
-		$mimeType = $this->mimeTypeDetector->detectPath($this->path);
-		if ($mimeType !== 'application/octet-stream' && $mimeType !== false) {
-			return $mimeType;
-		}
-
-		if ($this->storage->instanceOfStorage('\OC\Files\Storage\Local')
-			|| $this->storage->instanceOfStorage('\OC\Files\Storage\Home')
-			|| $this->storage->instanceOfStorage('\OC\Files\ObjectStore\HomeObjectStoreStorage')) {
-			$localFile = $this->storage->getLocalFile($this->path);
-			if ($localFile !== false) {
-				$mimeType = $this->mimeTypeDetector->detect($localFile);
-				if ($mimeType !== false) {
-					return $mimeType;
-				}
-			}
-
-			return 'application/octet-stream';
-		} else {
-			$handle = $this->storage->fopen($this->path, 'r');
-			$data = fread($handle, 8024);
-			fclose($handle);
-			$mimeType = $this->mimeTypeDetector->detectString($data);
-			if ($mimeType !== false) {
-				return $mimeType;
-			}
-
-			return 'application/octet-stream';
-		}
-	}
-
-	/**
-	 * @return bool
-	 */
-	protected function isWebDAVRequest() {
-		return substr($this->request->getScriptName(), 0 - strlen('/remote.php')) === '/remote.php' && (
-			$this->request->getPathInfo() === '/webdav' ||
-			strpos($this->request->getPathInfo(), '/webdav/') === 0 ||
-			$this->request->getPathInfo() === '/dav/files' ||
-			strpos($this->request->getPathInfo(), '/dav/files/') === 0
-		);
-	}
-
-	/**
-	 * @return bool
-	 */
-	protected function isPublicWebDAVRequest() {
-		return substr($this->request->getScriptName(), 0 - strlen('/public.php')) === '/public.php' && (
-			$this->request->getPathInfo() === '/webdav' ||
-			strpos($this->request->getPathInfo(), '/webdav/') === 0
-		);
-	}
+    /** @var array */
+    protected $mimeType;
+
+    /** @var IRequest */
+    protected $request;
+
+    /** @var IMimeTypeDetector */
+    protected $mimeTypeDetector;
+
+    /** @var IStorage */
+    protected $storage;
+
+    /** @var string */
+    protected $path;
+
+    /**
+     * @param IL10N $l
+     * @param IRequest $request
+     * @param IMimeTypeDetector $mimeTypeDetector
+     */
+    public function __construct(IL10N $l, IRequest $request, IMimeTypeDetector $mimeTypeDetector) {
+        parent::__construct($l);
+        $this->request = $request;
+        $this->mimeTypeDetector = $mimeTypeDetector;
+    }
+
+    /**
+     * @param IStorage $storage
+     * @param string $path
+     */
+    public function setFileInfo(IStorage $storage, $path) {
+        $this->storage = $storage;
+        $this->path = $path;
+        if (!isset($this->mimeType[$this->storage->getId()][$this->path])
+            || $this->mimeType[$this->storage->getId()][$this->path] === '') {
+            $this->mimeType[$this->storage->getId()][$this->path] = null;
+        }
+    }
+
+    /**
+     * @return string
+     */
+    protected function getActualValue() {
+        if ($this->mimeType[$this->storage->getId()][$this->path] !== null) {
+            return $this->mimeType[$this->storage->getId()][$this->path];
+        }
+
+        if ($this->isWebDAVRequest()) {
+            // Creating a folder
+            if ($this->request->getMethod() === 'MKCOL') {
+                $this->mimeType[$this->storage->getId()][$this->path] = 'httpd/unix-directory';
+                return $this->mimeType[$this->storage->getId()][$this->path];
+            }
+
+            if ($this->request->getMethod() === 'PUT') {
+                $path = $this->request->getPathInfo();
+                $this->mimeType[$this->storage->getId()][$this->path] = $this->mimeTypeDetector->detectPath($path);
+                return $this->mimeType[$this->storage->getId()][$this->path];
+            }
+        } else if ($this->isPublicWebDAVRequest()) {
+            if ($this->request->getMethod() === 'PUT') {
+                $path = $this->request->getPathInfo();
+                if (strpos($path, '/webdav/') === 0) {
+                    $path = substr($path, strlen('/webdav'));
+                }
+                $path = $this->path . $path;
+                $this->mimeType[$this->storage->getId()][$path] = $this->mimeTypeDetector->detectPath($path);
+                return $this->mimeType[$this->storage->getId()][$path];
+            }
+        }
+
+        if (in_array($this->request->getMethod(), ['POST', 'PUT'])) {
+            $files = $this->request->getUploadedFile('files');
+            if (isset($files['type'][0])) {
+                $mimeType = $files['type'][0];
+                if ($this->mimeType === 'application/octet-stream') {
+                    // Maybe not...
+                    $mimeTypeTest = $this->mimeTypeDetector->detectPath($files['name'][0]);
+                    if ($mimeTypeTest !== 'application/octet-stream' && $mimeTypeTest !== false) {
+                        $mimeType = $mimeTypeTest;
+                    } else {
+                        $mimeTypeTest = $this->mimeTypeDetector->detect($files['tmp_name'][0]);
+                        if ($mimeTypeTest !== 'application/octet-stream' && $mimeTypeTest !== false) {
+                            $mimeType = $mimeTypeTest;
+                        }
+                    }
+                }
+                $this->mimeType[$this->storage->getId()][$this->path] = $mimeType;
+                return $mimeType;
+            }
+        }
+
+        $this->mimeType[$this->storage->getId()][$this->path] = $this->storage->getMimeType($this->path);
+        if ($this->mimeType[$this->storage->getId()][$this->path] === 'application/octet-stream') {
+            $this->mimeType[$this->storage->getId()][$this->path] = $this->detectMimetypeFromPath();
+        }
+
+        return $this->mimeType[$this->storage->getId()][$this->path];
+    }
+
+    /**
+     * @return string
+     */
+    protected function detectMimetypeFromPath() {
+        $mimeType = $this->mimeTypeDetector->detectPath($this->path);
+        if ($mimeType !== 'application/octet-stream' && $mimeType !== false) {
+            return $mimeType;
+        }
+
+        if ($this->storage->instanceOfStorage('\OC\Files\Storage\Local')
+            || $this->storage->instanceOfStorage('\OC\Files\Storage\Home')
+            || $this->storage->instanceOfStorage('\OC\Files\ObjectStore\HomeObjectStoreStorage')) {
+            $localFile = $this->storage->getLocalFile($this->path);
+            if ($localFile !== false) {
+                $mimeType = $this->mimeTypeDetector->detect($localFile);
+                if ($mimeType !== false) {
+                    return $mimeType;
+                }
+            }
+
+            return 'application/octet-stream';
+        } else {
+            $handle = $this->storage->fopen($this->path, 'r');
+            $data = fread($handle, 8024);
+            fclose($handle);
+            $mimeType = $this->mimeTypeDetector->detectString($data);
+            if ($mimeType !== false) {
+                return $mimeType;
+            }
+
+            return 'application/octet-stream';
+        }
+    }
+
+    /**
+     * @return bool
+     */
+    protected function isWebDAVRequest() {
+        return substr($this->request->getScriptName(), 0 - strlen('/remote.php')) === '/remote.php' && (
+            $this->request->getPathInfo() === '/webdav' ||
+            strpos($this->request->getPathInfo(), '/webdav/') === 0 ||
+            $this->request->getPathInfo() === '/dav/files' ||
+            strpos($this->request->getPathInfo(), '/dav/files/') === 0
+        );
+    }
+
+    /**
+     * @return bool
+     */
+    protected function isPublicWebDAVRequest() {
+        return substr($this->request->getScriptName(), 0 - strlen('/public.php')) === '/public.php' && (
+            $this->request->getPathInfo() === '/webdav' ||
+            strpos($this->request->getPathInfo(), '/webdav/') === 0
+        );
+    }
 }

lib/public/Files/Search/ISearchQuery.php

Indentation +33 added lines, -33 removed lines

@@ -27,41 +27,41 @@
  * @since 12.0.0
  */
 interface ISearchQuery {
-	/**
-	 * @return ISearchOperator
-	 * @since 12.0.0
-	 */
-	public function getSearchOperation();
+    /**
+     * @return ISearchOperator
+     * @since 12.0.0
+     */
+    public function getSearchOperation();
 
-	/**
-	 * Get the maximum number of results to return
-	 *
-	 * @return integer
-	 * @since 12.0.0
-	 */
-	public function getLimit();
+    /**
+     * Get the maximum number of results to return
+     *
+     * @return integer
+     * @since 12.0.0
+     */
+    public function getLimit();
 
-	/**
-	 * Get the offset for returned results
-	 *
-	 * @return integer
-	 * @since 12.0.0
-	 */
-	public function getOffset();
+    /**
+     * Get the offset for returned results
+     *
+     * @return integer
+     * @since 12.0.0
+     */
+    public function getOffset();
 
-	/**
-	 * The fields and directions to order by
-	 *
-	 * @return ISearchOrder[]
-	 * @since 12.0.0
-	 */
-	public function getOrder();
+    /**
+     * The fields and directions to order by
+     *
+     * @return ISearchOrder[]
+     * @since 12.0.0
+     */
+    public function getOrder();
 
-	/**
-	 * The user that issued the search
-	 *
-	 * @return IUser
-	 * @since 12.0.0
-	 */
-	public function getUser();
+    /**
+     * The user that issued the search
+     *
+     * @return IUser
+     * @since 12.0.0
+     */
+    public function getUser();
 }

lib/private/Files/Search/SearchQuery.php

Indentation +56 added lines, -56 removed lines

@@ -27,66 +27,66 @@
 use OCP\IUser;
 
 class SearchQuery implements ISearchQuery {
-	/** @var  ISearchOperator */
-	private $searchOperation;
-	/** @var  integer */
-	private $limit;
-	/** @var  integer */
-	private $offset;
-	/** @var  ISearchOrder[] */
-	private $order;
-	/** @var IUser */
-	private $user;
+    /** @var  ISearchOperator */
+    private $searchOperation;
+    /** @var  integer */
+    private $limit;
+    /** @var  integer */
+    private $offset;
+    /** @var  ISearchOrder[] */
+    private $order;
+    /** @var IUser */
+    private $user;
 
-	/**
-	 * SearchQuery constructor.
-	 *
-	 * @param ISearchOperator $searchOperation
-	 * @param int $limit
-	 * @param int $offset
-	 * @param array $order
-	 * @param IUser $user
-	 */
-	public function __construct(ISearchOperator $searchOperation, $limit, $offset, array $order, IUser $user) {
-		$this->searchOperation = $searchOperation;
-		$this->limit = $limit;
-		$this->offset = $offset;
-		$this->order = $order;
-		$this->user = $user;
-	}
+    /**
+     * SearchQuery constructor.
+     *
+     * @param ISearchOperator $searchOperation
+     * @param int $limit
+     * @param int $offset
+     * @param array $order
+     * @param IUser $user
+     */
+    public function __construct(ISearchOperator $searchOperation, $limit, $offset, array $order, IUser $user) {
+        $this->searchOperation = $searchOperation;
+        $this->limit = $limit;
+        $this->offset = $offset;
+        $this->order = $order;
+        $this->user = $user;
+    }
 
-	/**
-	 * @return ISearchOperator
-	 */
-	public function getSearchOperation() {
-		return $this->searchOperation;
-	}
+    /**
+     * @return ISearchOperator
+     */
+    public function getSearchOperation() {
+        return $this->searchOperation;
+    }
 
-	/**
-	 * @return int
-	 */
-	public function getLimit() {
-		return $this->limit;
-	}
+    /**
+     * @return int
+     */
+    public function getLimit() {
+        return $this->limit;
+    }
 
-	/**
-	 * @return int
-	 */
-	public function getOffset() {
-		return $this->offset;
-	}
+    /**
+     * @return int
+     */
+    public function getOffset() {
+        return $this->offset;
+    }
 
-	/**
-	 * @return ISearchOrder[]
-	 */
-	public function getOrder() {
-		return $this->order;
-	}
+    /**
+     * @return ISearchOrder[]
+     */
+    public function getOrder() {
+        return $this->order;
+    }
 
-	/**
-	 * @return IUser
-	 */
-	public function getUser() {
-		return $this->user;
-	}
+    /**
+     * @return IUser
+     */
+    public function getUser() {
+        return $this->user;
+    }
 }

lib/public/OCS/IDiscoveryService.php

Indentation +12 added lines, -12 removed lines

@@ -32,17 +32,17 @@
  */
 interface IDiscoveryService {
 
-	/**
-	 * Discover OCS end-points
-	 *
-	 * If no valid discovery data is found the defaults are returned
-	 *
-	 * @since 12.0.0
-	 *
-	 * @param string $remote
-	 * @param string $service the service you want to discover
-	 * @return array
-	 */
-	public function discover($remote, $service);
+    /**
+     * Discover OCS end-points
+     *
+     * If no valid discovery data is found the defaults are returned
+     *
+     * @since 12.0.0
+     *
+     * @param string $remote
+     * @param string $service the service you want to discover
+     * @return array
+     */
+    public function discover($remote, $service);
 
 }