Passed
Push — master ( f61779...efbe97 )
by John
31:43 queued 16:46
created
lib/private/Group/Group.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
 			return;
174 174
 		}
175 175
 
176
-		$this->dispatcher->dispatch(IGroup::class . '::preAddUser', new GenericEvent($this, [
176
+		$this->dispatcher->dispatch(IGroup::class.'::preAddUser', new GenericEvent($this, [
177 177
 			'user' => $user,
178 178
 		]));
179 179
 
@@ -187,7 +187,7 @@  discard block
 block discarded – undo
187 187
 					$this->users[$user->getUID()] = $user;
188 188
 				}
189 189
 
190
-				$this->dispatcher->dispatch(IGroup::class . '::postAddUser', new GenericEvent($this, [
190
+				$this->dispatcher->dispatch(IGroup::class.'::postAddUser', new GenericEvent($this, [
191 191
 					'user' => $user,
192 192
 				]));
193 193
 
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 	 */
207 207
 	public function removeUser($user) {
208 208
 		$result = false;
209
-		$this->dispatcher->dispatch(IGroup::class . '::preRemoveUser', new GenericEvent($this, [
209
+		$this->dispatcher->dispatch(IGroup::class.'::preRemoveUser', new GenericEvent($this, [
210 210
 			'user' => $user,
211 211
 		]));
212 212
 		if ($this->emitter) {
@@ -219,7 +219,7 @@  discard block
 block discarded – undo
219 219
 			}
220 220
 		}
221 221
 		if ($result) {
222
-			$this->dispatcher->dispatch(IGroup::class . '::postRemoveUser', new GenericEvent($this, [
222
+			$this->dispatcher->dispatch(IGroup::class.'::postRemoveUser', new GenericEvent($this, [
223 223
 				'user' => $user,
224 224
 			]));
225 225
 			if ($this->emitter) {
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
 		}
330 330
 
331 331
 		$result = false;
332
-		$this->dispatcher->dispatch(IGroup::class . '::preDelete', new GenericEvent($this));
332
+		$this->dispatcher->dispatch(IGroup::class.'::preDelete', new GenericEvent($this));
333 333
 		if ($this->emitter) {
334 334
 			$this->emitter->emit('\OC\Group', 'preDelete', [$this]);
335 335
 		}
@@ -340,7 +340,7 @@  discard block
 block discarded – undo
340 340
 			}
341 341
 		}
342 342
 		if ($result) {
343
-			$this->dispatcher->dispatch(IGroup::class . '::postDelete', new GenericEvent($this));
343
+			$this->dispatcher->dispatch(IGroup::class.'::postDelete', new GenericEvent($this));
344 344
 			if ($this->emitter) {
345 345
 				$this->emitter->emit('\OC\Group', 'postDelete', [$this]);
346 346
 			}
@@ -398,7 +398,7 @@  discard block
 block discarded – undo
398 398
 	 * @since 16.0.0
399 399
 	 */
400 400
 	public function hideFromCollaboration(): bool {
401
-		return array_reduce($this->backends, function (bool $hide, GroupInterface $backend) {
401
+		return array_reduce($this->backends, function(bool $hide, GroupInterface $backend) {
402 402
 			return $hide | ($backend instanceof IHideFromCollaborationBackend && $backend->hideGroup($this->gid));
403 403
 		}, false);
404 404
 	}
Please login to merge, or discard this patch.
lib/private/Repair/RemoveLinkShares.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
 
113 113
 		$subQuery = $this->connection->getQueryBuilder();
114 114
 		$subQuery->select('s1.id')
115
-			->from($subQuery->createFunction('(' . $subSubQuery->getSQL() . ')'), 's1')
115
+			->from($subQuery->createFunction('('.$subSubQuery->getSQL().')'), 's1')
116 116
 			->join(
117 117
 				's1', 'share', 's2',
118 118
 				$subQuery->expr()->eq('s1.parent', 's2.id')
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
 		$query = $this->connection->getQueryBuilder();
127 127
 		$query->select($query->func()->count('*', 'total'))
128 128
 			->from('share')
129
-			->where($query->expr()->in('id', $query->createFunction('(' . $subQuery->getSQL() . ')')));
129
+			->where($query->expr()->in('id', $query->createFunction('('.$subQuery->getSQL().')')));
130 130
 
131 131
 		$result = $query->execute();
132 132
 		$data = $result->fetch();
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
 
150 150
 		$query = $this->connection->getQueryBuilder();
151 151
 		$query->select('s1.id', 's1.uid_owner', 's1.uid_initiator')
152
-			->from($query->createFunction('(' . $subQuery->getSQL() . ')'), 's1')
152
+			->from($query->createFunction('('.$subQuery->getSQL().')'), 's1')
153 153
 			->join(
154 154
 				's1', 'share', 's2',
155 155
 				$query->expr()->eq('s1.parent', 's2.id')
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
 		$this->addToNotify($data['uid_owner']);
174 174
 		$this->addToNotify($data['uid_initiator']);
175 175
 
176
-		$this->deleteShare((int)$id);
176
+		$this->deleteShare((int) $id);
177 177
 	}
178 178
 
179 179
 	/**
Please login to merge, or discard this patch.
lib/private/legacy/OC_Response.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -40,10 +40,10 @@  discard block
 block discarded – undo
40 40
 				\OC\AppFramework\Http\Request::USER_AGENT_ANDROID_MOBILE_CHROME,
41 41
 				\OC\AppFramework\Http\Request::USER_AGENT_FREEBOX,
42 42
 			])) {
43
-			header('Content-Disposition: ' . rawurlencode($type) . '; filename="' . rawurlencode($filename) . '"');
43
+			header('Content-Disposition: '.rawurlencode($type).'; filename="'.rawurlencode($filename).'"');
44 44
 		} else {
45
-			header('Content-Disposition: ' . rawurlencode($type) . '; filename*=UTF-8\'\'' . rawurlencode($filename)
46
-												 . '; filename="' . rawurlencode($filename) . '"');
45
+			header('Content-Disposition: '.rawurlencode($type).'; filename*=UTF-8\'\''.rawurlencode($filename)
46
+												 . '; filename="'.rawurlencode($filename).'"');
47 47
 		}
48 48
 	}
49 49
 
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
 			. 'connect-src *; '
91 91
 			. 'object-src \'none\'; '
92 92
 			. 'base-uri \'self\'; ';
93
-		header('Content-Security-Policy:' . $policy);
93
+		header('Content-Security-Policy:'.$policy);
94 94
 
95 95
 		// Send fallback headers for installations that don't have the possibility to send
96 96
 		// custom headers on the webserver side
Please login to merge, or discard this patch.
lib/private/legacy/OC_EventSource.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 		header('X-Accel-Buffering: no');
61 61
 		$this->fallback = isset($_GET['fallback']) and $_GET['fallback'] == 'true';
62 62
 		if ($this->fallback) {
63
-			$this->fallBackId = (int)$_GET['fallback_id'];
63
+			$this->fallBackId = (int) $_GET['fallback_id'];
64 64
 			/**
65 65
 			 * FIXME: The default content-security-policy of ownCloud forbids inline
66 66
 			 * JavaScript for security reasons. IE starting on Windows 10 will
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 			 */
74 74
 			header("Content-Security-Policy: default-src 'none'; script-src 'unsafe-inline'");
75 75
 			header("Content-Type: text/html");
76
-			echo str_repeat('<span></span>' . PHP_EOL, 10); //dummy data to keep IE happy
76
+			echo str_repeat('<span></span>'.PHP_EOL, 10); //dummy data to keep IE happy
77 77
 		} else {
78 78
 			header("Content-Type: text/event-stream");
79 79
 		}
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
 	 */
102 102
 	public function send($type, $data = null) {
103 103
 		if ($data and !preg_match('/^[A-Za-z0-9_]+$/', $type)) {
104
-			throw new BadMethodCallException('Type needs to be alphanumeric ('. $type .')');
104
+			throw new BadMethodCallException('Type needs to be alphanumeric ('.$type.')');
105 105
 		}
106 106
 		$this->init();
107 107
 		if (is_null($data)) {
@@ -110,13 +110,13 @@  discard block
 block discarded – undo
110 110
 		}
111 111
 		if ($this->fallback) {
112 112
 			$response = '<script type="text/javascript">window.parent.OC.EventSource.fallBackCallBack('
113
-				. $this->fallBackId . ',"' . $type . '",' . OC_JSON::encode($data) . ')</script>' . PHP_EOL;
113
+				. $this->fallBackId.',"'.$type.'",'.OC_JSON::encode($data).')</script>'.PHP_EOL;
114 114
 			echo $response;
115 115
 		} else {
116 116
 			if ($type) {
117
-				echo 'event: ' . $type . PHP_EOL;
117
+				echo 'event: '.$type.PHP_EOL;
118 118
 			}
119
-			echo 'data: ' . OC_JSON::encode($data) . PHP_EOL;
119
+			echo 'data: '.OC_JSON::encode($data).PHP_EOL;
120 120
 		}
121 121
 		echo PHP_EOL;
122 122
 		flush();
Please login to merge, or discard this patch.
lib/private/legacy/OC_JSON.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
 	public static function checkAppEnabled($app) {
45 45
 		if (!\OC::$server->getAppManager()->isEnabledForUser($app)) {
46 46
 			$l = \OC::$server->getL10N('lib');
47
-			self::error([ 'data' => [ 'message' => $l->t('Application is not enabled'), 'error' => 'application_not_enabled' ]]);
47
+			self::error(['data' => ['message' => $l->t('Application is not enabled'), 'error' => 'application_not_enabled']]);
48 48
 			exit();
49 49
 		}
50 50
 	}
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 			|| $twoFactorAuthManger->needsSecondFactor(\OC::$server->getUserSession()->getUser())) {
61 61
 			$l = \OC::$server->getL10N('lib');
62 62
 			http_response_code(\OCP\AppFramework\Http::STATUS_UNAUTHORIZED);
63
-			self::error([ 'data' => [ 'message' => $l->t('Authentication error'), 'error' => 'authentication_error' ]]);
63
+			self::error(['data' => ['message' => $l->t('Authentication error'), 'error' => 'authentication_error']]);
64 64
 			exit();
65 65
 		}
66 66
 	}
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 
79 79
 		if (!\OC::$server->getRequest()->passesCSRFCheck()) {
80 80
 			$l = \OC::$server->getL10N('lib');
81
-			self::error([ 'data' => [ 'message' => $l->t('Token expired. Please reload page.'), 'error' => 'token_expired' ]]);
81
+			self::error(['data' => ['message' => $l->t('Token expired. Please reload page.'), 'error' => 'token_expired']]);
82 82
 			exit();
83 83
 		}
84 84
 	}
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
 	public static function checkAdminUser() {
92 92
 		if (!OC_User::isAdminUser(OC_User::getUser())) {
93 93
 			$l = \OC::$server->getL10N('lib');
94
-			self::error([ 'data' => [ 'message' => $l->t('Authentication error'), 'error' => 'authentication_error' ]]);
94
+			self::error(['data' => ['message' => $l->t('Authentication error'), 'error' => 'authentication_error']]);
95 95
 			exit();
96 96
 		}
97 97
 	}
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
 	 */
124 124
 	protected static function to_string(&$value) {
125 125
 		if ($value instanceof \OC\L10N\L10NString) {
126
-			$value = (string)$value;
126
+			$value = (string) $value;
127 127
 		}
128 128
 	}
129 129
 
Please login to merge, or discard this patch.
apps/user_ldap/lib/GroupPluginManager.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
 		$this->respondToActions |= $respondToActions;
55 55
 
56 56
 		foreach ($this->which as $action => $v) {
57
-			if ((bool)($respondToActions & $action)) {
57
+			if ((bool) ($respondToActions & $action)) {
58 58
 				$this->which[$action] = $plugin;
59 59
 				\OC::$server->getLogger()->debug("Registered action ".$action." to plugin ".get_class($plugin), ['app' => 'user_ldap']);
60 60
 			}
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
 		$plugin = $this->which[GroupInterface::COUNT_USERS];
148 148
 
149 149
 		if ($plugin) {
150
-			return $plugin->countUsersInGroup($gid,$search);
150
+			return $plugin->countUsersInGroup($gid, $search);
151 151
 		}
152 152
 		throw new \Exception('No plugin implements countUsersInGroup in this LDAP Backend.');
153 153
 	}
Please login to merge, or discard this patch.
apps/user_ldap/lib/User/DeletedUsersIndex.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@
 block discarded – undo
114 114
 			return;
115 115
 		}
116 116
 		$this->config->setUserValue($ocName, 'user_ldap', 'isDeleted', '1');
117
-		$this->config->setUserValue($ocName, 'user_ldap', 'foundDeleted', (string)time());
117
+		$this->config->setUserValue($ocName, 'user_ldap', 'foundDeleted', (string) time());
118 118
 		$this->deletedUsers = null;
119 119
 	}
120 120
 }
Please login to merge, or discard this patch.
apps/user_ldap/lib/Controller/ConfigAPIController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -292,7 +292,7 @@
 block discarded – undo
292 292
 
293 293
 			$config = new Configuration($configID);
294 294
 			$data = $config->getConfiguration();
295
-			if (!(int)$showPassword) {
295
+			if (!(int) $showPassword) {
296 296
 				$data['ldapAgentPassword'] = '***';
297 297
 			}
298 298
 			foreach ($data as $key => $value) {
Please login to merge, or discard this patch.
apps/user_ldap/lib/Jobs/Sync.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
 	 */
104 104
 	protected function getMinPagingSize() {
105 105
 		$configKeys = $this->config->getAppKeys('user_ldap');
106
-		$configKeys = array_filter($configKeys, function ($key) {
106
+		$configKeys = array_filter($configKeys, function($key) {
107 107
 			return strpos($key, 'ldap_paging_size') !== false;
108 108
 		});
109 109
 		$minPagingSize = null;
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 			$pagingSize = $this->config->getAppValue('user_ldap', $configKey, $minPagingSize);
112 112
 			$minPagingSize = $minPagingSize === null ? $pagingSize : min($minPagingSize, $pagingSize);
113 113
 		}
114
-		return (int)$minPagingSize;
114
+		return (int) $minPagingSize;
115 115
 	}
116 116
 
117 117
 	/**
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
 
165 165
 		$filter = $access->combineFilterWithAnd([
166 166
 			$access->connection->ldapUserFilter,
167
-			$access->connection->ldapUserDisplayName . '=*',
167
+			$access->connection->ldapUserDisplayName.'=*',
168 168
 			$access->getFilterPartForUserSearch('')
169 169
 		]);
170 170
 		$results = $access->fetchListOfUsers(
@@ -175,10 +175,10 @@  discard block
 block discarded – undo
175 175
 			true
176 176
 		);
177 177
 
178
-		if ((int)$connection->ldapPagingSize === 0) {
178
+		if ((int) $connection->ldapPagingSize === 0) {
179 179
 			return false;
180 180
 		}
181
-		return count($results) >= (int)$connection->ldapPagingSize;
181
+		return count($results) >= (int) $connection->ldapPagingSize;
182 182
 	}
183 183
 
184 184
 	/**
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
 
196 196
 		$cycleData = [
197 197
 			'prefix' => $this->config->getAppValue('user_ldap', 'background_sync_prefix', null),
198
-			'offset' => (int)$this->config->getAppValue('user_ldap', 'background_sync_offset', 0),
198
+			'offset' => (int) $this->config->getAppValue('user_ldap', 'background_sync_offset', 0),
199 199
 		];
200 200
 
201 201
 		if (
@@ -252,7 +252,7 @@  discard block
 block discarded – undo
252 252
 	 * @return bool
253 253
 	 */
254 254
 	public function qualifiesToRun($cycleData) {
255
-		$lastChange = $this->config->getAppValue('user_ldap', $cycleData['prefix'] . '_lastChange', 0);
255
+		$lastChange = $this->config->getAppValue('user_ldap', $cycleData['prefix'].'_lastChange', 0);
256 256
 		if ((time() - $lastChange) > 60 * 30) {
257 257
 			return true;
258 258
 		}
@@ -266,7 +266,7 @@  discard block
 block discarded – undo
266 266
 	 */
267 267
 	protected function increaseOffset($cycleData) {
268 268
 		$ldapConfig = new Configuration($cycleData['prefix']);
269
-		$cycleData['offset'] += (int)$ldapConfig->ldapPagingSize;
269
+		$cycleData['offset'] += (int) $ldapConfig->ldapPagingSize;
270 270
 		$this->setCycle($cycleData);
271 271
 	}
272 272
 
Please login to merge, or discard this patch.