nextcloud / server

tests/Core/Command/User/ProfileTest.php

Indentation +444 added lines, -444 removed lines

@@ -23,448 +23,448 @@
 
 class ProfileTest extends TestCase {
 
-	protected IAccountManager&MockObject $accountManager;
-	protected IUserManager&MockObject $userManager;
-	protected IDBConnection&MockObject $connection;
-	protected InputInterface&MockObject $consoleInput;
-	protected OutputInterface&MockObject $consoleOutput;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->accountManager = $this->createMock(IAccountManager::class);
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->connection = $this->createMock(IDBConnection::class);
-		$this->consoleInput = $this->createMock(InputInterface::class);
-		$this->consoleOutput = $this->createMock(OutputInterface::class);
-	}
-
-	public function getCommand(array $methods = []): Profile|MockObject {
-		if (empty($methods)) {
-			return new Profile($this->userManager, $this->accountManager);
-		} else {
-			return $this->getMockBuilder(Profile::class)
-				->setConstructorArgs([
-					$this->userManager,
-					$this->accountManager,
-				])
-				->onlyMethods($methods)
-				->getMock();
-		}
-	}
-
-	public static function dataCheckInput(): array {
-		return [
-			'Call with existing user should pass check' => [
-				[['uid', 'username']],
-				[],
-				[],
-				true,
-				null,
-			],
-			'Call with non-existing user should fail check' => [
-				[['uid', 'username']],
-				[],
-				[],
-				false,
-				'The user "username" does not exist.',
-			],
-
-			'Call with uid, key and --default value should pass check' => [
-				[['uid', 'username'], ['key', 'configkey']],
-				[],
-				[['--default-value', false, true]],
-				true,
-				null,
-			],
-			'Call with uid and empty key with default-value option should fail check' => [
-				[['uid', 'username'], ['key', '']],
-				[],
-				[['--default-value', false, true]],
-				true,
-				'The "default-value" option can only be used when specifying a key.',
-			],
-
-			'Call with uid, key, value should pass check' => [
-				[['uid', 'username'], ['key', 'configkey'], ['value', '']],
-				[],
-				[],
-				true,
-				null,
-			],
-			'Call with uid, empty key and empty value should fail check' => [
-				[['uid', 'username'], ['key', ''], ['value', '']],
-				[],
-				[],
-				true,
-				'The value argument can only be used when specifying a key.',
-			],
-			'Call with uid, key, empty value and default-value option should fail check' => [
-				[['uid', 'username'], ['key', 'configkey'], ['value', '']],
-				[],
-				[['--default-value', false, true]],
-				true,
-				'The value argument can not be used together with "default-value".',
-			],
-			'Call with uid, key, empty value and update-only option should pass check' => [
-				[['uid', 'username'], ['key', 'configkey'], ['value', '']],
-				[['update-only', true]],
-				[],
-				true,
-				null,
-			],
-			'Call with uid, key, null value and update-only option should fail check' => [
-				[['uid', 'username'], ['key', 'configkey'], ['value', null]],
-				[['update-only', true]],
-				[],
-				true,
-				'The "update-only" option can only be used together with "value".',
-			],
-
-			'Call with uid, key and delete option should pass check' => [
-				[['uid', 'username'], ['key', 'configkey']],
-				[['delete', true]],
-				[],
-				true,
-				null,
-			],
-			'Call with uid, empty key and delete option should fail check' => [
-				[['uid', 'username'], ['key', '']],
-				[['delete', true]],
-				[],
-				true,
-				'The "delete" option can only be used when specifying a key.',
-			],
-			'Call with uid, key, delete option and default-value should fail check' => [
-				[['uid', 'username'], ['key', 'configkey']],
-				[['delete', true]],
-				[['--default-value', false, true]],
-				true,
-				'The "delete" option can not be used together with "default-value".',
-			],
-			'Call with uid, key, empty value and delete option should fail check' => [
-				[['uid', 'username'], ['key', 'configkey'], ['value', '']],
-				[['delete', true]],
-				[],
-				true,
-				'The "delete" option can not be used together with "value".',
-			],
-			'Call with uid, key, delete and error-if-not-exists should pass check' => [
-				[['uid', 'username'], ['key', 'configkey']],
-				[['delete', true], ['error-if-not-exists', true]],
-				[],
-				true,
-				null,
-			],
-			'Call with uid, key and error-if-not-exists should fail check' => [
-				[['uid', 'username'], ['key', 'configkey']],
-				[['delete', false], ['error-if-not-exists', true]],
-				[],
-				true,
-				'The "error-if-not-exists" option can only be used together with "delete".',
-			],
-		];
-	}
-
-	/**
-	 * @dataProvider dataCheckInput
-	 */
-	public function testCheckInput(array $arguments, array $options, array $parameterOptions, bool $existingUser, ?string $expectedException): void {
-		$this->consoleInput->expects($this->any())
-			->method('getArgument')
-			->willReturnMap($arguments);
-		$this->consoleInput->expects($this->any())
-			->method('getOption')
-			->willReturnMap($options);
-		$this->consoleInput->expects($this->any())
-			->method('hasParameterOption')
-			->willReturnCallback(function (string|array $values, bool $onlyParams = false) use ($parameterOptions): bool {
-				$arguments = func_get_args();
-				foreach ($parameterOptions as $parameterOption) {
-					// check the arguments of the function, if they are the same, return the mocked value
-					if (array_diff($arguments, $parameterOption) === []) {
-						return end($parameterOption);
-					}
-				}
-
-				return false;
-			});
-
-		$returnedUser = null;
-		if ($existingUser) {
-			$mockUser = $this->createMock(IUser::class);
-			$mockUser->expects($this->once())->method('getUID')->willReturn('user');
-			$returnedUser = $mockUser;
-		}
-		$this->userManager->expects($this->once())
-			->method('get')
-			->willReturn($returnedUser);
-
-		$command = $this->getCommand();
-		try {
-			$this->invokePrivate($command, 'checkInput', [$this->consoleInput]);
-			$this->assertNull($expectedException);
-		} catch (\InvalidArgumentException $e) {
-			$this->assertEquals($expectedException, $e->getMessage());
-		}
-	}
-
-	public function testCheckInputExceptionCatch(): void {
-		$command = $this->getCommand(['checkInput']);
-		$command->expects($this->once())
-			->method('checkInput')
-			->willThrowException(new \InvalidArgumentException('test'));
-
-		$this->consoleOutput->expects($this->once())
-			->method('writeln')
-			->with('<error>test</error>');
-
-		$this->assertEquals(1, $this->invokePrivate($command, 'execute', [$this->consoleInput, $this->consoleOutput]));
-	}
-
-	public static function dataExecuteDeleteProfileProperty(): array {
-		return [
-			'Deleting existing property should succeed' => ['address', 'Berlin', false, null, Command::SUCCESS],
-			'Deleting existing property with error-if-not-exists should succeed' => ['address', 'Berlin', true, null, Command::SUCCESS],
-			'Deleting non-existing property should succeed' => ['address', '', false, null, Command::SUCCESS],
-			'Deleting non-existing property with error-if-not-exists should fail' => ['address', '', true, '<error>The property does not exist for user "username".</error>', Command::FAILURE],
-		];
-	}
-
-	/**
-	 * Tests the deletion mechanism on profile settings.
-	 *
-	 * @dataProvider dataExecuteDeleteProfileProperty
-	 */
-	public function testExecuteDeleteProfileProperty(string $configKey, string $value, bool $errorIfNotExists, ?string $expectedLine, int $expectedReturn): void {
-		$uid = 'username';
-		$appName = 'profile';
-		$command = $this->getCommand([
-			'writeArrayInOutputFormat',
-			'checkInput',
-		]);
-
-		$this->consoleInput->expects($this->any())
-			->method('getArgument')
-			->willReturnMap([
-				['uid', $uid],
-				['app', $appName],
-				['key', $configKey],
-			]);
-
-		$mocks = $this->setupProfilePropertiesMock([$configKey => $value]);
-
-		$command->expects($this->once())
-			->method('checkInput')
-			->willReturn($mocks['userMock']);
-
-		$this->consoleInput->expects($this->atLeastOnce())
-			->method('hasParameterOption')
-			->willReturnMap([
-				['--delete', false, true],
-				['--error-if-not-exists', false, $errorIfNotExists],
-			]);
-
-		if ($expectedLine === null) {
-			$this->consoleOutput->expects($this->never())
-				->method('writeln');
-			$mocks['profilePropertiesMocks'][0]->expects($this->once())
-				->method('setValue')
-				->with('');
-			$this->accountManager->expects($this->once())
-				->method('updateAccount')
-				->with($mocks['accountMock']);
-		} else {
-			$this->consoleOutput->expects($this->once())
-				->method('writeln')
-				->with($expectedLine);
-			$this->accountManager->expects($this->never())
-				->method('updateAccount');
-		}
-
-		$this->assertEquals($expectedReturn, $this->invokePrivate($command, 'execute', [$this->consoleInput, $this->consoleOutput]));
-	}
-
-	public function testExecuteSetProfileProperty(): void {
-		$command = $this->getCommand([
-			'writeArrayInOutputFormat',
-			'checkInput',
-		]);
-
-		$uid = 'username';
-		$propertyKey = 'address';
-		$propertyValue = 'Barcelona';
-
-		$this->consoleInput->expects($this->atLeast(3))
-			->method('getArgument')
-			->willReturnMap([
-				['uid', $uid],
-				['key', $propertyKey],
-				['value', $propertyValue],
-			]);
-
-		$mocks = $this->setupProfilePropertiesMock([$propertyKey => $propertyValue]);
-
-		$command->expects($this->once())
-			->method('checkInput')
-			->willReturn($mocks['userMock']);
-
-		$mocks['profilePropertiesMocks'][0]->expects($this->once())
-			->method('setValue')
-			->with($propertyValue);
-		$this->accountManager->expects($this->once())
-			->method('updateAccount')
-			->with($mocks['accountMock']);
-
-		$this->assertEquals(0, $this->invokePrivate($command, 'execute', [$this->consoleInput, $this->consoleOutput]));
-	}
-
-	public static function dataExecuteGet(): array {
-		return [
-			'Get property with set value should pass' => ['configkey', 'value', null, 'value', Command::SUCCESS],
-			'Get property with empty value and default-value option should pass' => ['configkey', '', 'default-value', 'default-value', Command::SUCCESS],
-			'Get property with empty value should fail' => ['configkey', '', null, '<error>The property does not exist for user "username".</error>', Command::FAILURE],
-		];
-	}
-
-	/**
-	 * @dataProvider dataExecuteGet
-	 */
-	public function testExecuteGet(string $key, string $value, ?string $defaultValue, string $expectedLine, int $expectedReturn): void {
-		$command = $this->getCommand([
-			'writeArrayInOutputFormat',
-			'checkInput',
-		]);
-
-		$uid = 'username';
-
-		$this->consoleInput->expects($this->any())
-			->method('getArgument')
-			->willReturnMap([
-				['uid', $uid],
-				['key', $key],
-			]);
-
-		$mocks = $this->setupProfilePropertiesMock([$key => $value]);
-
-		$command->expects($this->once())
-			->method('checkInput')
-			->willReturn($mocks['userMock']);
-
-		if ($value === '') {
-			if ($defaultValue === null) {
-				$this->consoleInput->expects($this->atLeastOnce())
-					->method('hasParameterOption')
-					->willReturn(false);
-			} else {
-				$this->consoleInput->expects($this->atLeastOnce())
-					->method('hasParameterOption')
-					->willReturnCallback(fn (string|array $values): bool => $values === '--default-value');
-				$this->consoleInput->expects($this->once())
-					->method('getOption')
-					->with('default-value')
-					->willReturn($defaultValue);
-			}
-		}
-
-		$this->consoleOutput->expects($this->once())
-			->method('writeln')
-			->with($expectedLine);
-
-		$this->assertEquals($expectedReturn, $this->invokePrivate($command, 'execute', [$this->consoleInput, $this->consoleOutput]));
-	}
-
-	public function testExecuteList(): void {
-		$uid = 'username';
-		$profileData = [
-			'pronouns' => 'they/them',
-			'address' => 'Berlin',
-		];
-
-		$command = $this->getCommand([
-			'writeArrayInOutputFormat',
-			'checkInput',
-		]);
-
-		$this->consoleInput->expects($this->any())
-			->method('getArgument')
-			->willReturnMap([
-				['uid', $uid],
-				['key', ''],
-			]);
-
-		$mocks = $this->setupProfilePropertiesMock(['address' => $profileData['address'], 'pronouns' => $profileData['pronouns']]);
-
-		$command->expects($this->once())
-			->method('checkInput')
-			->willReturn($mocks['userMock']);
-
-		$command->expects($this->once())
-			->method('writeArrayInOutputFormat')
-			->with($this->consoleInput, $this->consoleOutput, $profileData);
-
-
-		$this->assertEquals(0, $this->invokePrivate($command, 'execute', [$this->consoleInput, $this->consoleOutput]));
-	}
-
-	/**
-	 * Helper to avoid boilerplate in tests in this file when mocking objects
-	 * of IAccountProperty type.
-	 *
-	 * @param array<string, string> $properties the properties to be set up as key => value
-	 * @return array{
-	 *     userMock: IUser&MockObject,
-	 *     accountMock: IAccount&MockObject,
-	 *     profilePropertiesMocks: IAccountProperty&MockObject[]
-	 * }
-	 */
-	private function setupProfilePropertiesMock(array $properties): array {
-		$userMock = $this->createMock(IUser::class);
-		$accountMock = $this->createMock(IAccount::class);
-		$this->accountManager->expects($this->atLeastOnce())
-			->method('getAccount')
-			->with($userMock)
-			->willReturn($accountMock);
-
-		/** @var IAccountProperty&MockObject[] $propertiesMocks */
-		$propertiesMocks = [];
-		foreach ($properties as $key => $value) {
-			$propertiesMocks[] = $this->getAccountPropertyMock($key, $value);
-		}
-
-		if (count($properties) === 1) {
-			$accountMock->expects($this->atLeastOnce())
-				->method('getProperty')
-				->with(array_keys($properties)[0])
-				->willReturn($propertiesMocks[array_key_first($propertiesMocks)]);
-		} else {
-			$accountMock->expects($this->atLeastOnce())
-				->method('getAllProperties')
-				->willReturnCallback(function () use ($propertiesMocks) {
-					foreach ($propertiesMocks as $property) {
-						yield $property;
-					}
-				});
-		}
-
-		return [
-			'userMock' => $userMock,
-			'accountMock' => $accountMock,
-			'profilePropertiesMocks' => $propertiesMocks,
-		];
-	}
-
-	private function getAccountPropertyMock(string $name, string $value): IAccountProperty&MockObject {
-		$propertyMock = $this->getMockBuilder(IAccountProperty::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$propertyMock->expects($this->any())
-			->method('getName')
-			->willReturn($name);
-		$propertyMock->expects($this->any())
-			->method('getValue')
-			->willReturn($value);
-
-		return $propertyMock;
-	}
+    protected IAccountManager&MockObject $accountManager;
+    protected IUserManager&MockObject $userManager;
+    protected IDBConnection&MockObject $connection;
+    protected InputInterface&MockObject $consoleInput;
+    protected OutputInterface&MockObject $consoleOutput;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->accountManager = $this->createMock(IAccountManager::class);
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->connection = $this->createMock(IDBConnection::class);
+        $this->consoleInput = $this->createMock(InputInterface::class);
+        $this->consoleOutput = $this->createMock(OutputInterface::class);
+    }
+
+    public function getCommand(array $methods = []): Profile|MockObject {
+        if (empty($methods)) {
+            return new Profile($this->userManager, $this->accountManager);
+        } else {
+            return $this->getMockBuilder(Profile::class)
+                ->setConstructorArgs([
+                    $this->userManager,
+                    $this->accountManager,
+                ])
+                ->onlyMethods($methods)
+                ->getMock();
+        }
+    }
+
+    public static function dataCheckInput(): array {
+        return [
+            'Call with existing user should pass check' => [
+                [['uid', 'username']],
+                [],
+                [],
+                true,
+                null,
+            ],
+            'Call with non-existing user should fail check' => [
+                [['uid', 'username']],
+                [],
+                [],
+                false,
+                'The user "username" does not exist.',
+            ],
+
+            'Call with uid, key and --default value should pass check' => [
+                [['uid', 'username'], ['key', 'configkey']],
+                [],
+                [['--default-value', false, true]],
+                true,
+                null,
+            ],
+            'Call with uid and empty key with default-value option should fail check' => [
+                [['uid', 'username'], ['key', '']],
+                [],
+                [['--default-value', false, true]],
+                true,
+                'The "default-value" option can only be used when specifying a key.',
+            ],
+
+            'Call with uid, key, value should pass check' => [
+                [['uid', 'username'], ['key', 'configkey'], ['value', '']],
+                [],
+                [],
+                true,
+                null,
+            ],
+            'Call with uid, empty key and empty value should fail check' => [
+                [['uid', 'username'], ['key', ''], ['value', '']],
+                [],
+                [],
+                true,
+                'The value argument can only be used when specifying a key.',
+            ],
+            'Call with uid, key, empty value and default-value option should fail check' => [
+                [['uid', 'username'], ['key', 'configkey'], ['value', '']],
+                [],
+                [['--default-value', false, true]],
+                true,
+                'The value argument can not be used together with "default-value".',
+            ],
+            'Call with uid, key, empty value and update-only option should pass check' => [
+                [['uid', 'username'], ['key', 'configkey'], ['value', '']],
+                [['update-only', true]],
+                [],
+                true,
+                null,
+            ],
+            'Call with uid, key, null value and update-only option should fail check' => [
+                [['uid', 'username'], ['key', 'configkey'], ['value', null]],
+                [['update-only', true]],
+                [],
+                true,
+                'The "update-only" option can only be used together with "value".',
+            ],
+
+            'Call with uid, key and delete option should pass check' => [
+                [['uid', 'username'], ['key', 'configkey']],
+                [['delete', true]],
+                [],
+                true,
+                null,
+            ],
+            'Call with uid, empty key and delete option should fail check' => [
+                [['uid', 'username'], ['key', '']],
+                [['delete', true]],
+                [],
+                true,
+                'The "delete" option can only be used when specifying a key.',
+            ],
+            'Call with uid, key, delete option and default-value should fail check' => [
+                [['uid', 'username'], ['key', 'configkey']],
+                [['delete', true]],
+                [['--default-value', false, true]],
+                true,
+                'The "delete" option can not be used together with "default-value".',
+            ],
+            'Call with uid, key, empty value and delete option should fail check' => [
+                [['uid', 'username'], ['key', 'configkey'], ['value', '']],
+                [['delete', true]],
+                [],
+                true,
+                'The "delete" option can not be used together with "value".',
+            ],
+            'Call with uid, key, delete and error-if-not-exists should pass check' => [
+                [['uid', 'username'], ['key', 'configkey']],
+                [['delete', true], ['error-if-not-exists', true]],
+                [],
+                true,
+                null,
+            ],
+            'Call with uid, key and error-if-not-exists should fail check' => [
+                [['uid', 'username'], ['key', 'configkey']],
+                [['delete', false], ['error-if-not-exists', true]],
+                [],
+                true,
+                'The "error-if-not-exists" option can only be used together with "delete".',
+            ],
+        ];
+    }
+
+    /**
+     * @dataProvider dataCheckInput
+     */
+    public function testCheckInput(array $arguments, array $options, array $parameterOptions, bool $existingUser, ?string $expectedException): void {
+        $this->consoleInput->expects($this->any())
+            ->method('getArgument')
+            ->willReturnMap($arguments);
+        $this->consoleInput->expects($this->any())
+            ->method('getOption')
+            ->willReturnMap($options);
+        $this->consoleInput->expects($this->any())
+            ->method('hasParameterOption')
+            ->willReturnCallback(function (string|array $values, bool $onlyParams = false) use ($parameterOptions): bool {
+                $arguments = func_get_args();
+                foreach ($parameterOptions as $parameterOption) {
+                    // check the arguments of the function, if they are the same, return the mocked value
+                    if (array_diff($arguments, $parameterOption) === []) {
+                        return end($parameterOption);
+                    }
+                }
+
+                return false;
+            });
+
+        $returnedUser = null;
+        if ($existingUser) {
+            $mockUser = $this->createMock(IUser::class);
+            $mockUser->expects($this->once())->method('getUID')->willReturn('user');
+            $returnedUser = $mockUser;
+        }
+        $this->userManager->expects($this->once())
+            ->method('get')
+            ->willReturn($returnedUser);
+
+        $command = $this->getCommand();
+        try {
+            $this->invokePrivate($command, 'checkInput', [$this->consoleInput]);
+            $this->assertNull($expectedException);
+        } catch (\InvalidArgumentException $e) {
+            $this->assertEquals($expectedException, $e->getMessage());
+        }
+    }
+
+    public function testCheckInputExceptionCatch(): void {
+        $command = $this->getCommand(['checkInput']);
+        $command->expects($this->once())
+            ->method('checkInput')
+            ->willThrowException(new \InvalidArgumentException('test'));
+
+        $this->consoleOutput->expects($this->once())
+            ->method('writeln')
+            ->with('<error>test</error>');
+
+        $this->assertEquals(1, $this->invokePrivate($command, 'execute', [$this->consoleInput, $this->consoleOutput]));
+    }
+
+    public static function dataExecuteDeleteProfileProperty(): array {
+        return [
+            'Deleting existing property should succeed' => ['address', 'Berlin', false, null, Command::SUCCESS],
+            'Deleting existing property with error-if-not-exists should succeed' => ['address', 'Berlin', true, null, Command::SUCCESS],
+            'Deleting non-existing property should succeed' => ['address', '', false, null, Command::SUCCESS],
+            'Deleting non-existing property with error-if-not-exists should fail' => ['address', '', true, '<error>The property does not exist for user "username".</error>', Command::FAILURE],
+        ];
+    }
+
+    /**
+     * Tests the deletion mechanism on profile settings.
+     *
+     * @dataProvider dataExecuteDeleteProfileProperty
+     */
+    public function testExecuteDeleteProfileProperty(string $configKey, string $value, bool $errorIfNotExists, ?string $expectedLine, int $expectedReturn): void {
+        $uid = 'username';
+        $appName = 'profile';
+        $command = $this->getCommand([
+            'writeArrayInOutputFormat',
+            'checkInput',
+        ]);
+
+        $this->consoleInput->expects($this->any())
+            ->method('getArgument')
+            ->willReturnMap([
+                ['uid', $uid],
+                ['app', $appName],
+                ['key', $configKey],
+            ]);
+
+        $mocks = $this->setupProfilePropertiesMock([$configKey => $value]);
+
+        $command->expects($this->once())
+            ->method('checkInput')
+            ->willReturn($mocks['userMock']);
+
+        $this->consoleInput->expects($this->atLeastOnce())
+            ->method('hasParameterOption')
+            ->willReturnMap([
+                ['--delete', false, true],
+                ['--error-if-not-exists', false, $errorIfNotExists],
+            ]);
+
+        if ($expectedLine === null) {
+            $this->consoleOutput->expects($this->never())
+                ->method('writeln');
+            $mocks['profilePropertiesMocks'][0]->expects($this->once())
+                ->method('setValue')
+                ->with('');
+            $this->accountManager->expects($this->once())
+                ->method('updateAccount')
+                ->with($mocks['accountMock']);
+        } else {
+            $this->consoleOutput->expects($this->once())
+                ->method('writeln')
+                ->with($expectedLine);
+            $this->accountManager->expects($this->never())
+                ->method('updateAccount');
+        }
+
+        $this->assertEquals($expectedReturn, $this->invokePrivate($command, 'execute', [$this->consoleInput, $this->consoleOutput]));
+    }
+
+    public function testExecuteSetProfileProperty(): void {
+        $command = $this->getCommand([
+            'writeArrayInOutputFormat',
+            'checkInput',
+        ]);
+
+        $uid = 'username';
+        $propertyKey = 'address';
+        $propertyValue = 'Barcelona';
+
+        $this->consoleInput->expects($this->atLeast(3))
+            ->method('getArgument')
+            ->willReturnMap([
+                ['uid', $uid],
+                ['key', $propertyKey],
+                ['value', $propertyValue],
+            ]);
+
+        $mocks = $this->setupProfilePropertiesMock([$propertyKey => $propertyValue]);
+
+        $command->expects($this->once())
+            ->method('checkInput')
+            ->willReturn($mocks['userMock']);
+
+        $mocks['profilePropertiesMocks'][0]->expects($this->once())
+            ->method('setValue')
+            ->with($propertyValue);
+        $this->accountManager->expects($this->once())
+            ->method('updateAccount')
+            ->with($mocks['accountMock']);
+
+        $this->assertEquals(0, $this->invokePrivate($command, 'execute', [$this->consoleInput, $this->consoleOutput]));
+    }
+
+    public static function dataExecuteGet(): array {
+        return [
+            'Get property with set value should pass' => ['configkey', 'value', null, 'value', Command::SUCCESS],
+            'Get property with empty value and default-value option should pass' => ['configkey', '', 'default-value', 'default-value', Command::SUCCESS],
+            'Get property with empty value should fail' => ['configkey', '', null, '<error>The property does not exist for user "username".</error>', Command::FAILURE],
+        ];
+    }
+
+    /**
+     * @dataProvider dataExecuteGet
+     */
+    public function testExecuteGet(string $key, string $value, ?string $defaultValue, string $expectedLine, int $expectedReturn): void {
+        $command = $this->getCommand([
+            'writeArrayInOutputFormat',
+            'checkInput',
+        ]);
+
+        $uid = 'username';
+
+        $this->consoleInput->expects($this->any())
+            ->method('getArgument')
+            ->willReturnMap([
+                ['uid', $uid],
+                ['key', $key],
+            ]);
+
+        $mocks = $this->setupProfilePropertiesMock([$key => $value]);
+
+        $command->expects($this->once())
+            ->method('checkInput')
+            ->willReturn($mocks['userMock']);
+
+        if ($value === '') {
+            if ($defaultValue === null) {
+                $this->consoleInput->expects($this->atLeastOnce())
+                    ->method('hasParameterOption')
+                    ->willReturn(false);
+            } else {
+                $this->consoleInput->expects($this->atLeastOnce())
+                    ->method('hasParameterOption')
+                    ->willReturnCallback(fn (string|array $values): bool => $values === '--default-value');
+                $this->consoleInput->expects($this->once())
+                    ->method('getOption')
+                    ->with('default-value')
+                    ->willReturn($defaultValue);
+            }
+        }
+
+        $this->consoleOutput->expects($this->once())
+            ->method('writeln')
+            ->with($expectedLine);
+
+        $this->assertEquals($expectedReturn, $this->invokePrivate($command, 'execute', [$this->consoleInput, $this->consoleOutput]));
+    }
+
+    public function testExecuteList(): void {
+        $uid = 'username';
+        $profileData = [
+            'pronouns' => 'they/them',
+            'address' => 'Berlin',
+        ];
+
+        $command = $this->getCommand([
+            'writeArrayInOutputFormat',
+            'checkInput',
+        ]);
+
+        $this->consoleInput->expects($this->any())
+            ->method('getArgument')
+            ->willReturnMap([
+                ['uid', $uid],
+                ['key', ''],
+            ]);
+
+        $mocks = $this->setupProfilePropertiesMock(['address' => $profileData['address'], 'pronouns' => $profileData['pronouns']]);
+
+        $command->expects($this->once())
+            ->method('checkInput')
+            ->willReturn($mocks['userMock']);
+
+        $command->expects($this->once())
+            ->method('writeArrayInOutputFormat')
+            ->with($this->consoleInput, $this->consoleOutput, $profileData);
+
+
+        $this->assertEquals(0, $this->invokePrivate($command, 'execute', [$this->consoleInput, $this->consoleOutput]));
+    }
+
+    /**
+     * Helper to avoid boilerplate in tests in this file when mocking objects
+     * of IAccountProperty type.
+     *
+     * @param array<string, string> $properties the properties to be set up as key => value
+     * @return array{
+     *     userMock: IUser&MockObject,
+     *     accountMock: IAccount&MockObject,
+     *     profilePropertiesMocks: IAccountProperty&MockObject[]
+     * }
+     */
+    private function setupProfilePropertiesMock(array $properties): array {
+        $userMock = $this->createMock(IUser::class);
+        $accountMock = $this->createMock(IAccount::class);
+        $this->accountManager->expects($this->atLeastOnce())
+            ->method('getAccount')
+            ->with($userMock)
+            ->willReturn($accountMock);
+
+        /** @var IAccountProperty&MockObject[] $propertiesMocks */
+        $propertiesMocks = [];
+        foreach ($properties as $key => $value) {
+            $propertiesMocks[] = $this->getAccountPropertyMock($key, $value);
+        }
+
+        if (count($properties) === 1) {
+            $accountMock->expects($this->atLeastOnce())
+                ->method('getProperty')
+                ->with(array_keys($properties)[0])
+                ->willReturn($propertiesMocks[array_key_first($propertiesMocks)]);
+        } else {
+            $accountMock->expects($this->atLeastOnce())
+                ->method('getAllProperties')
+                ->willReturnCallback(function () use ($propertiesMocks) {
+                    foreach ($propertiesMocks as $property) {
+                        yield $property;
+                    }
+                });
+        }
+
+        return [
+            'userMock' => $userMock,
+            'accountMock' => $accountMock,
+            'profilePropertiesMocks' => $propertiesMocks,
+        ];
+    }
+
+    private function getAccountPropertyMock(string $name, string $value): IAccountProperty&MockObject {
+        $propertyMock = $this->getMockBuilder(IAccountProperty::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $propertyMock->expects($this->any())
+            ->method('getName')
+            ->willReturn($name);
+        $propertyMock->expects($this->any())
+            ->method('getValue')
+            ->willReturn($value);
+
+        return $propertyMock;
+    }
 }

tests/Core/Command/User/SettingTest.php

Indentation +430 added lines, -430 removed lines

@@ -18,434 +18,434 @@
 use Test\TestCase;
 
 class SettingTest extends TestCase {
-	protected IUserManager&MockObject $userManager;
-	protected IConfig&MockObject $config;
-	protected IDBConnection&MockObject $connection;
-	protected InputInterface&MockObject $consoleInput;
-	protected MockObject&OutputInterface $consoleOutput;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->connection = $this->createMock(IDBConnection::class);
-		$this->consoleInput = $this->createMock(InputInterface::class);
-		$this->consoleOutput = $this->createMock(OutputInterface::class);
-	}
-
-	public function getCommand(array $methods = []) {
-		if (empty($methods)) {
-			return new Setting($this->userManager, $this->config);
-		} else {
-			$mock = $this->getMockBuilder(Setting::class)
-				->setConstructorArgs([
-					$this->userManager,
-					$this->config,
-				])
-				->onlyMethods($methods)
-				->getMock();
-			return $mock;
-		}
-	}
-
-	public static function dataCheckInput(): array {
-		return [
-			[
-				[['uid', 'username']],
-				[['ignore-missing-user', true]],
-				[],
-				false,
-				false,
-			],
-			[
-				[['uid', 'username']],
-				[['ignore-missing-user', false]],
-				[],
-				null,
-				'The user "username" does not exist.',
-			],
-
-			[
-				[['uid', 'username'], ['key', 'configkey']],
-				[['ignore-missing-user', true]],
-				[['--default-value', false, true]],
-				false,
-				false,
-			],
-			[
-				[['uid', 'username'], ['key', '']],
-				[['ignore-missing-user', true]],
-				[['--default-value', false, true]],
-				false,
-				'The "default-value" option can only be used when specifying a key.',
-			],
-
-			[
-				[['uid', 'username'], ['key', 'configkey'], ['value', '']],
-				[['ignore-missing-user', true]],
-				[],
-				false,
-				false,
-			],
-			[
-				[['uid', 'username'], ['key', ''], ['value', '']],
-				[['ignore-missing-user', true]],
-				[],
-				false,
-				'The value argument can only be used when specifying a key.',
-			],
-			[
-				[['uid', 'username'], ['key', 'configkey'], ['value', '']],
-				[['ignore-missing-user', true]],
-				[['--default-value', false, true]],
-				false,
-				'The value argument can not be used together with "default-value".',
-			],
-			[
-				[['uid', 'username'], ['key', 'configkey'], ['value', '']],
-				[['ignore-missing-user', true], ['update-only', true]],
-				[],
-				false,
-				false,
-			],
-			[
-				[['uid', 'username'], ['key', 'configkey'], ['value', null]],
-				[['ignore-missing-user', true], ['update-only', true]],
-				[],
-				false,
-				'The "update-only" option can only be used together with "value".',
-			],
-
-			[
-				[['uid', 'username'], ['key', 'configkey']],
-				[['ignore-missing-user', true], ['delete', true]],
-				[],
-				false,
-				false,
-			],
-			[
-				[['uid', 'username'], ['key', '']],
-				[['ignore-missing-user', true], ['delete', true]],
-				[],
-				false,
-				'The "delete" option can only be used when specifying a key.',
-			],
-			[
-				[['uid', 'username'], ['key', 'configkey']],
-				[['ignore-missing-user', true], ['delete', true]],
-				[['--default-value', false, true]],
-				false,
-				'The "delete" option can not be used together with "default-value".',
-			],
-			[
-				[['uid', 'username'], ['key', 'configkey'], ['value', '']],
-				[['ignore-missing-user', true], ['delete', true]],
-				[],
-				false,
-				'The "delete" option can not be used together with "value".',
-			],
-			[
-				[['uid', 'username'], ['key', 'configkey']],
-				[['ignore-missing-user', true], ['delete', true], ['error-if-not-exists', true]],
-				[],
-				false,
-				false,
-			],
-			[
-				[['uid', 'username'], ['key', 'configkey']],
-				[['ignore-missing-user', true], ['delete', false], ['error-if-not-exists', true]],
-				[],
-				false,
-				'The "error-if-not-exists" option can only be used together with "delete".',
-			],
-		];
-	}
-
-	/**
-	 * @dataProvider dataCheckInput
-	 *
-	 * @param array $arguments
-	 * @param array $options
-	 * @param array $parameterOptions
-	 * @param mixed $user
-	 * @param string $expectedException
-	 */
-	public function testCheckInput($arguments, $options, $parameterOptions, $user, $expectedException): void {
-		$this->consoleInput->expects($this->any())
-			->method('getArgument')
-			->willReturnMap($arguments);
-		$this->consoleInput->expects($this->any())
-			->method('getOption')
-			->willReturnMap($options);
-		$this->consoleInput->expects($this->any())
-			->method('hasParameterOption')
-			->willReturnCallback(function (string|array $config, bool $default = false) use ($parameterOptions): bool {
-				foreach ($parameterOptions as $parameterOption) {
-					if ($config === $parameterOption[0]
-						// Check the default value if the maps has 3 entries
-						&& (!isset($parameterOption[2]) || $default === $parameterOption[1])) {
-						return end($parameterOption);
-					}
-				}
-				return false;
-			});
-
-		if ($user !== false) {
-			$this->userManager->expects($this->once())
-				->method('get')
-				->willReturn($user);
-		} else {
-			$this->userManager->expects($this->never())
-				->method('get');
-		}
-
-		$command = $this->getCommand();
-		try {
-			$this->invokePrivate($command, 'checkInput', [$this->consoleInput]);
-			$this->assertFalse($expectedException);
-		} catch (InvalidArgumentException $e) {
-			$this->assertEquals($expectedException, $e->getMessage());
-		}
-	}
-
-	public function testCheckInputExceptionCatch(): void {
-		$command = $this->getCommand(['checkInput']);
-		$command->expects($this->once())
-			->method('checkInput')
-			->willThrowException(new InvalidArgumentException('test'));
-
-		$this->consoleOutput->expects($this->once())
-			->method('writeln')
-			->with('<error>test</error>');
-
-		$this->assertEquals(1, $this->invokePrivate($command, 'execute', [$this->consoleInput, $this->consoleOutput]));
-	}
-
-	public static function dataExecuteDelete(): array {
-		return [
-			['config', false, null, 0],
-			['config', true, null, 0],
-			[null, false, null, 0],
-			[null, true, '<error>The setting does not exist for user "username".</error>', 1],
-		];
-	}
-
-	/**
-	 * @dataProvider dataExecuteDelete
-	 *
-	 * @param string|null $value
-	 * @param bool $errorIfNotExists
-	 * @param string $expectedLine
-	 * @param int $expectedReturn
-	 */
-	public function testExecuteDelete($value, $errorIfNotExists, $expectedLine, $expectedReturn): void {
-		$command = $this->getCommand([
-			'writeArrayInOutputFormat',
-			'checkInput',
-			'getUserSettings',
-		]);
-
-		$this->consoleInput->expects($this->any())
-			->method('getArgument')
-			->willReturnMap([
-				['uid', 'username'],
-				['app', 'appname'],
-				['key', 'configkey'],
-			]);
-
-		$command->expects($this->once())
-			->method('checkInput');
-
-		$this->config->expects($this->once())
-			->method('getUserValue')
-			->with('username', 'appname', 'configkey', null)
-			->willReturn($value);
-
-		$this->consoleInput->expects($this->atLeastOnce())
-			->method('hasParameterOption')
-			->willReturnMap([
-				['--delete', false, true],
-				['--error-if-not-exists', false, $errorIfNotExists],
-			]);
-
-		if ($expectedLine === null) {
-			$this->consoleOutput->expects($this->never())
-				->method('writeln');
-			$this->config->expects($this->once())
-				->method('deleteUserValue')
-				->with('username', 'appname', 'configkey');
-		} else {
-			$this->consoleOutput->expects($this->once())
-				->method('writeln')
-				->with($expectedLine);
-			$this->config->expects($this->never())
-				->method('deleteUserValue');
-		}
-
-		$this->assertEquals($expectedReturn, $this->invokePrivate($command, 'execute', [$this->consoleInput, $this->consoleOutput]));
-	}
-
-	public static function dataExecuteSet(): array {
-		return [
-			['config', false, null, 0],
-			['config', true, null, 0],
-			[null, false, null, 0],
-			[null, true, '<error>The setting does not exist for user "username".</error>', 1],
-		];
-	}
-
-	/**
-	 * @dataProvider dataExecuteSet
-	 *
-	 * @param string|null $value
-	 * @param bool $updateOnly
-	 * @param string $expectedLine
-	 * @param int $expectedReturn
-	 */
-	public function testExecuteSet($value, $updateOnly, $expectedLine, $expectedReturn): void {
-		$command = $this->getCommand([
-			'writeArrayInOutputFormat',
-			'checkInput',
-			'getUserSettings',
-		]);
-
-		$this->consoleInput->expects($this->atLeast(4))
-			->method('getArgument')
-			->willReturnMap([
-				['uid', 'username'],
-				['app', 'appname'],
-				['key', 'configkey'],
-				['value', 'setValue'],
-			]);
-
-		$command->expects($this->once())
-			->method('checkInput');
-
-		$this->config->expects($this->once())
-			->method('getUserValue')
-			->with('username', 'appname', 'configkey', null)
-			->willReturn($value);
-
-		$this->consoleInput->expects($this->atLeastOnce())
-			->method('hasParameterOption')
-			->willReturnMap([
-				['--update-only', false, $updateOnly],
-			]);
-
-		if ($expectedLine === null) {
-			$this->consoleOutput->expects($this->never())
-				->method('writeln');
-
-			$this->consoleInput->expects($this->never())
-				->method('getOption');
-
-			$this->config->expects($this->once())
-				->method('setUserValue')
-				->with('username', 'appname', 'configkey', 'setValue');
-		} else {
-			$this->consoleOutput->expects($this->once())
-				->method('writeln')
-				->with($expectedLine);
-			$this->config->expects($this->never())
-				->method('setUserValue');
-		}
-
-		$this->assertEquals($expectedReturn, $this->invokePrivate($command, 'execute', [$this->consoleInput, $this->consoleOutput]));
-	}
-
-	public static function dataExecuteGet(): array {
-		return [
-			['config', null, 'config', 0],
-			[null, 'config', 'config', 0],
-			[null, null, '<error>The setting does not exist for user "username".</error>', 1],
-		];
-	}
-
-	/**
-	 * @dataProvider dataExecuteGet
-	 *
-	 * @param string|null $value
-	 * @param string|null $defaultValue
-	 * @param string $expectedLine
-	 * @param int $expectedReturn
-	 */
-	public function testExecuteGet($value, $defaultValue, $expectedLine, $expectedReturn): void {
-		$command = $this->getCommand([
-			'writeArrayInOutputFormat',
-			'checkInput',
-			'getUserSettings',
-		]);
-
-		$this->consoleInput->expects($this->any())
-			->method('getArgument')
-			->willReturnMap([
-				['uid', 'username'],
-				['app', 'appname'],
-				['key', 'configkey'],
-			]);
-
-		$command->expects($this->once())
-			->method('checkInput');
-
-		$this->config->expects($this->once())
-			->method('getUserValue')
-			->with('username', 'appname', 'configkey', null)
-			->willReturn($value);
-
-		if ($value === null) {
-			if ($defaultValue === null) {
-				$this->consoleInput->expects($this->atLeastOnce())
-					->method('hasParameterOption')
-					->willReturn(false);
-			} else {
-				$this->consoleInput->expects($this->atLeastOnce())
-					->method('hasParameterOption')
-					->willReturnCallback(function (string|array $config, bool $default = false): bool {
-						if ($config === '--default-value' && $default === false) {
-							return true;
-						}
-						return false;
-					});
-				$this->consoleInput->expects($this->once())
-					->method('getOption')
-					->with('default-value')
-					->willReturn($defaultValue);
-			}
-		}
-
-		$this->consoleOutput->expects($this->once())
-			->method('writeln')
-			->with($expectedLine);
-
-		$this->assertEquals($expectedReturn, $this->invokePrivate($command, 'execute', [$this->consoleInput, $this->consoleOutput]));
-	}
-
-	public function testExecuteList(): void {
-		$command = $this->getCommand([
-			'writeArrayInOutputFormat',
-			'checkInput',
-			'getUserSettings',
-		]);
-
-		$this->consoleInput->expects($this->any())
-			->method('getArgument')
-			->willReturnMap([
-				['uid', 'username'],
-				['app', 'appname'],
-				['key', ''],
-			]);
-
-		$command->expects($this->once())
-			->method('checkInput');
-		$command->expects($this->once())
-			->method('getUserSettings')
-			->willReturn(['settings']);
-		$command->expects($this->once())
-			->method('writeArrayInOutputFormat')
-			->with($this->consoleInput, $this->consoleOutput, ['settings']);
-
-
-		$this->assertEquals(0, $this->invokePrivate($command, 'execute', [$this->consoleInput, $this->consoleOutput]));
-	}
+    protected IUserManager&MockObject $userManager;
+    protected IConfig&MockObject $config;
+    protected IDBConnection&MockObject $connection;
+    protected InputInterface&MockObject $consoleInput;
+    protected MockObject&OutputInterface $consoleOutput;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->connection = $this->createMock(IDBConnection::class);
+        $this->consoleInput = $this->createMock(InputInterface::class);
+        $this->consoleOutput = $this->createMock(OutputInterface::class);
+    }
+
+    public function getCommand(array $methods = []) {
+        if (empty($methods)) {
+            return new Setting($this->userManager, $this->config);
+        } else {
+            $mock = $this->getMockBuilder(Setting::class)
+                ->setConstructorArgs([
+                    $this->userManager,
+                    $this->config,
+                ])
+                ->onlyMethods($methods)
+                ->getMock();
+            return $mock;
+        }
+    }
+
+    public static function dataCheckInput(): array {
+        return [
+            [
+                [['uid', 'username']],
+                [['ignore-missing-user', true]],
+                [],
+                false,
+                false,
+            ],
+            [
+                [['uid', 'username']],
+                [['ignore-missing-user', false]],
+                [],
+                null,
+                'The user "username" does not exist.',
+            ],
+
+            [
+                [['uid', 'username'], ['key', 'configkey']],
+                [['ignore-missing-user', true]],
+                [['--default-value', false, true]],
+                false,
+                false,
+            ],
+            [
+                [['uid', 'username'], ['key', '']],
+                [['ignore-missing-user', true]],
+                [['--default-value', false, true]],
+                false,
+                'The "default-value" option can only be used when specifying a key.',
+            ],
+
+            [
+                [['uid', 'username'], ['key', 'configkey'], ['value', '']],
+                [['ignore-missing-user', true]],
+                [],
+                false,
+                false,
+            ],
+            [
+                [['uid', 'username'], ['key', ''], ['value', '']],
+                [['ignore-missing-user', true]],
+                [],
+                false,
+                'The value argument can only be used when specifying a key.',
+            ],
+            [
+                [['uid', 'username'], ['key', 'configkey'], ['value', '']],
+                [['ignore-missing-user', true]],
+                [['--default-value', false, true]],
+                false,
+                'The value argument can not be used together with "default-value".',
+            ],
+            [
+                [['uid', 'username'], ['key', 'configkey'], ['value', '']],
+                [['ignore-missing-user', true], ['update-only', true]],
+                [],
+                false,
+                false,
+            ],
+            [
+                [['uid', 'username'], ['key', 'configkey'], ['value', null]],
+                [['ignore-missing-user', true], ['update-only', true]],
+                [],
+                false,
+                'The "update-only" option can only be used together with "value".',
+            ],
+
+            [
+                [['uid', 'username'], ['key', 'configkey']],
+                [['ignore-missing-user', true], ['delete', true]],
+                [],
+                false,
+                false,
+            ],
+            [
+                [['uid', 'username'], ['key', '']],
+                [['ignore-missing-user', true], ['delete', true]],
+                [],
+                false,
+                'The "delete" option can only be used when specifying a key.',
+            ],
+            [
+                [['uid', 'username'], ['key', 'configkey']],
+                [['ignore-missing-user', true], ['delete', true]],
+                [['--default-value', false, true]],
+                false,
+                'The "delete" option can not be used together with "default-value".',
+            ],
+            [
+                [['uid', 'username'], ['key', 'configkey'], ['value', '']],
+                [['ignore-missing-user', true], ['delete', true]],
+                [],
+                false,
+                'The "delete" option can not be used together with "value".',
+            ],
+            [
+                [['uid', 'username'], ['key', 'configkey']],
+                [['ignore-missing-user', true], ['delete', true], ['error-if-not-exists', true]],
+                [],
+                false,
+                false,
+            ],
+            [
+                [['uid', 'username'], ['key', 'configkey']],
+                [['ignore-missing-user', true], ['delete', false], ['error-if-not-exists', true]],
+                [],
+                false,
+                'The "error-if-not-exists" option can only be used together with "delete".',
+            ],
+        ];
+    }
+
+    /**
+     * @dataProvider dataCheckInput
+     *
+     * @param array $arguments
+     * @param array $options
+     * @param array $parameterOptions
+     * @param mixed $user
+     * @param string $expectedException
+     */
+    public function testCheckInput($arguments, $options, $parameterOptions, $user, $expectedException): void {
+        $this->consoleInput->expects($this->any())
+            ->method('getArgument')
+            ->willReturnMap($arguments);
+        $this->consoleInput->expects($this->any())
+            ->method('getOption')
+            ->willReturnMap($options);
+        $this->consoleInput->expects($this->any())
+            ->method('hasParameterOption')
+            ->willReturnCallback(function (string|array $config, bool $default = false) use ($parameterOptions): bool {
+                foreach ($parameterOptions as $parameterOption) {
+                    if ($config === $parameterOption[0]
+                        // Check the default value if the maps has 3 entries
+                        && (!isset($parameterOption[2]) || $default === $parameterOption[1])) {
+                        return end($parameterOption);
+                    }
+                }
+                return false;
+            });
+
+        if ($user !== false) {
+            $this->userManager->expects($this->once())
+                ->method('get')
+                ->willReturn($user);
+        } else {
+            $this->userManager->expects($this->never())
+                ->method('get');
+        }
+
+        $command = $this->getCommand();
+        try {
+            $this->invokePrivate($command, 'checkInput', [$this->consoleInput]);
+            $this->assertFalse($expectedException);
+        } catch (InvalidArgumentException $e) {
+            $this->assertEquals($expectedException, $e->getMessage());
+        }
+    }
+
+    public function testCheckInputExceptionCatch(): void {
+        $command = $this->getCommand(['checkInput']);
+        $command->expects($this->once())
+            ->method('checkInput')
+            ->willThrowException(new InvalidArgumentException('test'));
+
+        $this->consoleOutput->expects($this->once())
+            ->method('writeln')
+            ->with('<error>test</error>');
+
+        $this->assertEquals(1, $this->invokePrivate($command, 'execute', [$this->consoleInput, $this->consoleOutput]));
+    }
+
+    public static function dataExecuteDelete(): array {
+        return [
+            ['config', false, null, 0],
+            ['config', true, null, 0],
+            [null, false, null, 0],
+            [null, true, '<error>The setting does not exist for user "username".</error>', 1],
+        ];
+    }
+
+    /**
+     * @dataProvider dataExecuteDelete
+     *
+     * @param string|null $value
+     * @param bool $errorIfNotExists
+     * @param string $expectedLine
+     * @param int $expectedReturn
+     */
+    public function testExecuteDelete($value, $errorIfNotExists, $expectedLine, $expectedReturn): void {
+        $command = $this->getCommand([
+            'writeArrayInOutputFormat',
+            'checkInput',
+            'getUserSettings',
+        ]);
+
+        $this->consoleInput->expects($this->any())
+            ->method('getArgument')
+            ->willReturnMap([
+                ['uid', 'username'],
+                ['app', 'appname'],
+                ['key', 'configkey'],
+            ]);
+
+        $command->expects($this->once())
+            ->method('checkInput');
+
+        $this->config->expects($this->once())
+            ->method('getUserValue')
+            ->with('username', 'appname', 'configkey', null)
+            ->willReturn($value);
+
+        $this->consoleInput->expects($this->atLeastOnce())
+            ->method('hasParameterOption')
+            ->willReturnMap([
+                ['--delete', false, true],
+                ['--error-if-not-exists', false, $errorIfNotExists],
+            ]);
+
+        if ($expectedLine === null) {
+            $this->consoleOutput->expects($this->never())
+                ->method('writeln');
+            $this->config->expects($this->once())
+                ->method('deleteUserValue')
+                ->with('username', 'appname', 'configkey');
+        } else {
+            $this->consoleOutput->expects($this->once())
+                ->method('writeln')
+                ->with($expectedLine);
+            $this->config->expects($this->never())
+                ->method('deleteUserValue');
+        }
+
+        $this->assertEquals($expectedReturn, $this->invokePrivate($command, 'execute', [$this->consoleInput, $this->consoleOutput]));
+    }
+
+    public static function dataExecuteSet(): array {
+        return [
+            ['config', false, null, 0],
+            ['config', true, null, 0],
+            [null, false, null, 0],
+            [null, true, '<error>The setting does not exist for user "username".</error>', 1],
+        ];
+    }
+
+    /**
+     * @dataProvider dataExecuteSet
+     *
+     * @param string|null $value
+     * @param bool $updateOnly
+     * @param string $expectedLine
+     * @param int $expectedReturn
+     */
+    public function testExecuteSet($value, $updateOnly, $expectedLine, $expectedReturn): void {
+        $command = $this->getCommand([
+            'writeArrayInOutputFormat',
+            'checkInput',
+            'getUserSettings',
+        ]);
+
+        $this->consoleInput->expects($this->atLeast(4))
+            ->method('getArgument')
+            ->willReturnMap([
+                ['uid', 'username'],
+                ['app', 'appname'],
+                ['key', 'configkey'],
+                ['value', 'setValue'],
+            ]);
+
+        $command->expects($this->once())
+            ->method('checkInput');
+
+        $this->config->expects($this->once())
+            ->method('getUserValue')
+            ->with('username', 'appname', 'configkey', null)
+            ->willReturn($value);
+
+        $this->consoleInput->expects($this->atLeastOnce())
+            ->method('hasParameterOption')
+            ->willReturnMap([
+                ['--update-only', false, $updateOnly],
+            ]);
+
+        if ($expectedLine === null) {
+            $this->consoleOutput->expects($this->never())
+                ->method('writeln');
+
+            $this->consoleInput->expects($this->never())
+                ->method('getOption');
+
+            $this->config->expects($this->once())
+                ->method('setUserValue')
+                ->with('username', 'appname', 'configkey', 'setValue');
+        } else {
+            $this->consoleOutput->expects($this->once())
+                ->method('writeln')
+                ->with($expectedLine);
+            $this->config->expects($this->never())
+                ->method('setUserValue');
+        }
+
+        $this->assertEquals($expectedReturn, $this->invokePrivate($command, 'execute', [$this->consoleInput, $this->consoleOutput]));
+    }
+
+    public static function dataExecuteGet(): array {
+        return [
+            ['config', null, 'config', 0],
+            [null, 'config', 'config', 0],
+            [null, null, '<error>The setting does not exist for user "username".</error>', 1],
+        ];
+    }
+
+    /**
+     * @dataProvider dataExecuteGet
+     *
+     * @param string|null $value
+     * @param string|null $defaultValue
+     * @param string $expectedLine
+     * @param int $expectedReturn
+     */
+    public function testExecuteGet($value, $defaultValue, $expectedLine, $expectedReturn): void {
+        $command = $this->getCommand([
+            'writeArrayInOutputFormat',
+            'checkInput',
+            'getUserSettings',
+        ]);
+
+        $this->consoleInput->expects($this->any())
+            ->method('getArgument')
+            ->willReturnMap([
+                ['uid', 'username'],
+                ['app', 'appname'],
+                ['key', 'configkey'],
+            ]);
+
+        $command->expects($this->once())
+            ->method('checkInput');
+
+        $this->config->expects($this->once())
+            ->method('getUserValue')
+            ->with('username', 'appname', 'configkey', null)
+            ->willReturn($value);
+
+        if ($value === null) {
+            if ($defaultValue === null) {
+                $this->consoleInput->expects($this->atLeastOnce())
+                    ->method('hasParameterOption')
+                    ->willReturn(false);
+            } else {
+                $this->consoleInput->expects($this->atLeastOnce())
+                    ->method('hasParameterOption')
+                    ->willReturnCallback(function (string|array $config, bool $default = false): bool {
+                        if ($config === '--default-value' && $default === false) {
+                            return true;
+                        }
+                        return false;
+                    });
+                $this->consoleInput->expects($this->once())
+                    ->method('getOption')
+                    ->with('default-value')
+                    ->willReturn($defaultValue);
+            }
+        }
+
+        $this->consoleOutput->expects($this->once())
+            ->method('writeln')
+            ->with($expectedLine);
+
+        $this->assertEquals($expectedReturn, $this->invokePrivate($command, 'execute', [$this->consoleInput, $this->consoleOutput]));
+    }
+
+    public function testExecuteList(): void {
+        $command = $this->getCommand([
+            'writeArrayInOutputFormat',
+            'checkInput',
+            'getUserSettings',
+        ]);
+
+        $this->consoleInput->expects($this->any())
+            ->method('getArgument')
+            ->willReturnMap([
+                ['uid', 'username'],
+                ['app', 'appname'],
+                ['key', ''],
+            ]);
+
+        $command->expects($this->once())
+            ->method('checkInput');
+        $command->expects($this->once())
+            ->method('getUserSettings')
+            ->willReturn(['settings']);
+        $command->expects($this->once())
+            ->method('writeArrayInOutputFormat')
+            ->with($this->consoleInput, $this->consoleOutput, ['settings']);
+
+
+        $this->assertEquals(0, $this->invokePrivate($command, 'execute', [$this->consoleInput, $this->consoleOutput]));
+    }
 }

core/register_command.php

Indentation +132 added lines, -132 removed lines

@@ -114,137 +114,137 @@
 $config = Server::get(IConfig::class);
 
 if ($config->getSystemValueBool('installed', false)) {
-	$application->add(Server::get(Disable::class));
-	$application->add(Server::get(Enable::class));
-	$application->add(Server::get(Install::class));
-	$application->add(Server::get(GetPath::class));
-	$application->add(Server::get(ListApps::class));
-	$application->add(Server::get(Remove::class));
-	$application->add(Server::get(Update::class));
-
-	$application->add(Server::get(Cleanup::class));
-	$application->add(Server::get(Enforce::class));
-	$application->add(Server::get(Command\TwoFactorAuth\Enable::class));
-	$application->add(Server::get(Command\TwoFactorAuth\Disable::class));
-	$application->add(Server::get(State::class));
-
-	$application->add(Server::get(Mode::class));
-	$application->add(Server::get(Job::class));
-	$application->add(Server::get(ListCommand::class));
-	$application->add(Server::get(Delete::class));
-	$application->add(Server::get(JobWorker::class));
-
-	$application->add(Server::get(Test::class));
-
-	$application->add(Server::get(DeleteConfig::class));
-	$application->add(Server::get(GetConfig::class));
-	$application->add(Server::get(SetConfig::class));
-	$application->add(Server::get(Import::class));
-	$application->add(Server::get(ListConfigs::class));
-	$application->add(Server::get(Command\Config\System\DeleteConfig::class));
-	$application->add(Server::get(Command\Config\System\GetConfig::class));
-	$application->add(Server::get(Command\Config\System\SetConfig::class));
-
-	$application->add(Server::get(File::class));
-	$application->add(Server::get(Space::class));
-	$application->add(Server::get(Storage::class));
-	$application->add(Server::get(Storages::class));
-
-	$application->add(Server::get(ConvertType::class));
-	$application->add(Server::get(ConvertMysqlToMB4::class));
-	$application->add(Server::get(ConvertFilecacheBigInt::class));
-	$application->add(Server::get(AddMissingColumns::class));
-	$application->add(Server::get(AddMissingIndices::class));
-	$application->add(Server::get(AddMissingPrimaryKeys::class));
-	$application->add(Server::get(ExpectedSchema::class));
-	$application->add(Server::get(ExportSchema::class));
-
-	$application->add(Server::get(GenerateMetadataCommand::class));
-	$application->add(Server::get(PreviewCommand::class));
-	if ($config->getSystemValueBool('debug', false)) {
-		$application->add(Server::get(StatusCommand::class));
-		$application->add(Server::get(MigrateCommand::class));
-		$application->add(Server::get(GenerateCommand::class));
-		$application->add(Server::get(ExecuteCommand::class));
-	}
-
-	$application->add(Server::get(Command\Encryption\Disable::class));
-	$application->add(Server::get(Command\Encryption\Enable::class));
-	$application->add(Server::get(ListModules::class));
-	$application->add(Server::get(SetDefaultModule::class));
-	$application->add(Server::get(Command\Encryption\Status::class));
-	$application->add(Server::get(EncryptAll::class));
-	$application->add(Server::get(DecryptAll::class));
-
-	$application->add(Server::get(Manage::class));
-	$application->add(Server::get(Command\Log\File::class));
-
-	$application->add(Server::get(ChangeKeyStorageRoot::class));
-	$application->add(Server::get(ShowKeyStorageRoot::class));
-	$application->add(Server::get(MigrateKeyStorage::class));
-
-	$application->add(Server::get(DataFingerprint::class));
-	$application->add(Server::get(UpdateDB::class));
-	$application->add(Server::get(UpdateJS::class));
-	$application->add(Server::get(Command\Maintenance\Mode::class));
-	$application->add(Server::get(UpdateHtaccess::class));
-	$application->add(Server::get(UpdateTheme::class));
-
-	$application->add(Server::get(Upgrade::class));
-	$application->add(Server::get(Repair::class));
-	$application->add(Server::get(RepairShareOwnership::class));
-
-	$application->add(Server::get(Command\Preview\Cleanup::class));
-	$application->add(Server::get(Generate::class));
-	$application->add(Server::get(Command\Preview\Repair::class));
-	$application->add(Server::get(ResetRenderedTexts::class));
-
-	$application->add(Server::get(Add::class));
-	$application->add(Server::get(Command\User\Delete::class));
-	$application->add(Server::get(Command\User\Disable::class));
-	$application->add(Server::get(Command\User\Enable::class));
-	$application->add(Server::get(LastSeen::class));
-	$application->add(Server::get(Report::class));
-	$application->add(Server::get(ResetPassword::class));
-	$application->add(Server::get(Setting::class));
-	$application->add(Server::get(Profile::class));
-	$application->add(Server::get(Command\User\ListCommand::class));
-	$application->add(Server::get(ClearGeneratedAvatarCacheCommand::class));
-	$application->add(Server::get(Info::class));
-	$application->add(Server::get(SyncAccountDataCommand::class));
-	$application->add(Server::get(Command\User\AuthTokens\Add::class));
-	$application->add(Server::get(Command\User\AuthTokens\ListCommand::class));
-	$application->add(Server::get(Command\User\AuthTokens\Delete::class));
-	$application->add(Server::get(Verify::class));
-	$application->add(Server::get(Welcome::class));
-
-	$application->add(Server::get(Command\Group\Add::class));
-	$application->add(Server::get(Command\Group\Delete::class));
-	$application->add(Server::get(Command\Group\ListCommand::class));
-	$application->add(Server::get(AddUser::class));
-	$application->add(Server::get(RemoveUser::class));
-	$application->add(Server::get(Command\Group\Info::class));
-
-	$application->add(Server::get(Command\SystemTag\ListCommand::class));
-	$application->add(Server::get(Command\SystemTag\Delete::class));
-	$application->add(Server::get(Command\SystemTag\Add::class));
-	$application->add(Server::get(Edit::class));
-
-	$application->add(Server::get(ListCertificates::class));
-	$application->add(Server::get(ExportCertificates::class));
-	$application->add(Server::get(ImportCertificate::class));
-	$application->add(Server::get(RemoveCertificate::class));
-	$application->add(Server::get(BruteforceAttempts::class));
-	$application->add(Server::get(BruteforceResetAttempts::class));
-	$application->add(Server::get(SetupChecks::class));
-	$application->add(Server::get(Get::class));
-
-	$application->add(Server::get(GetCommand::class));
-	$application->add(Server::get(EnabledCommand::class));
-	$application->add(Server::get(Command\TaskProcessing\ListCommand::class));
-	$application->add(Server::get(Statistics::class));
-
-	$application->add(Server::get(RedisCommand::class));
+    $application->add(Server::get(Disable::class));
+    $application->add(Server::get(Enable::class));
+    $application->add(Server::get(Install::class));
+    $application->add(Server::get(GetPath::class));
+    $application->add(Server::get(ListApps::class));
+    $application->add(Server::get(Remove::class));
+    $application->add(Server::get(Update::class));
+
+    $application->add(Server::get(Cleanup::class));
+    $application->add(Server::get(Enforce::class));
+    $application->add(Server::get(Command\TwoFactorAuth\Enable::class));
+    $application->add(Server::get(Command\TwoFactorAuth\Disable::class));
+    $application->add(Server::get(State::class));
+
+    $application->add(Server::get(Mode::class));
+    $application->add(Server::get(Job::class));
+    $application->add(Server::get(ListCommand::class));
+    $application->add(Server::get(Delete::class));
+    $application->add(Server::get(JobWorker::class));
+
+    $application->add(Server::get(Test::class));
+
+    $application->add(Server::get(DeleteConfig::class));
+    $application->add(Server::get(GetConfig::class));
+    $application->add(Server::get(SetConfig::class));
+    $application->add(Server::get(Import::class));
+    $application->add(Server::get(ListConfigs::class));
+    $application->add(Server::get(Command\Config\System\DeleteConfig::class));
+    $application->add(Server::get(Command\Config\System\GetConfig::class));
+    $application->add(Server::get(Command\Config\System\SetConfig::class));
+
+    $application->add(Server::get(File::class));
+    $application->add(Server::get(Space::class));
+    $application->add(Server::get(Storage::class));
+    $application->add(Server::get(Storages::class));
+
+    $application->add(Server::get(ConvertType::class));
+    $application->add(Server::get(ConvertMysqlToMB4::class));
+    $application->add(Server::get(ConvertFilecacheBigInt::class));
+    $application->add(Server::get(AddMissingColumns::class));
+    $application->add(Server::get(AddMissingIndices::class));
+    $application->add(Server::get(AddMissingPrimaryKeys::class));
+    $application->add(Server::get(ExpectedSchema::class));
+    $application->add(Server::get(ExportSchema::class));
+
+    $application->add(Server::get(GenerateMetadataCommand::class));
+    $application->add(Server::get(PreviewCommand::class));
+    if ($config->getSystemValueBool('debug', false)) {
+        $application->add(Server::get(StatusCommand::class));
+        $application->add(Server::get(MigrateCommand::class));
+        $application->add(Server::get(GenerateCommand::class));
+        $application->add(Server::get(ExecuteCommand::class));
+    }
+
+    $application->add(Server::get(Command\Encryption\Disable::class));
+    $application->add(Server::get(Command\Encryption\Enable::class));
+    $application->add(Server::get(ListModules::class));
+    $application->add(Server::get(SetDefaultModule::class));
+    $application->add(Server::get(Command\Encryption\Status::class));
+    $application->add(Server::get(EncryptAll::class));
+    $application->add(Server::get(DecryptAll::class));
+
+    $application->add(Server::get(Manage::class));
+    $application->add(Server::get(Command\Log\File::class));
+
+    $application->add(Server::get(ChangeKeyStorageRoot::class));
+    $application->add(Server::get(ShowKeyStorageRoot::class));
+    $application->add(Server::get(MigrateKeyStorage::class));
+
+    $application->add(Server::get(DataFingerprint::class));
+    $application->add(Server::get(UpdateDB::class));
+    $application->add(Server::get(UpdateJS::class));
+    $application->add(Server::get(Command\Maintenance\Mode::class));
+    $application->add(Server::get(UpdateHtaccess::class));
+    $application->add(Server::get(UpdateTheme::class));
+
+    $application->add(Server::get(Upgrade::class));
+    $application->add(Server::get(Repair::class));
+    $application->add(Server::get(RepairShareOwnership::class));
+
+    $application->add(Server::get(Command\Preview\Cleanup::class));
+    $application->add(Server::get(Generate::class));
+    $application->add(Server::get(Command\Preview\Repair::class));
+    $application->add(Server::get(ResetRenderedTexts::class));
+
+    $application->add(Server::get(Add::class));
+    $application->add(Server::get(Command\User\Delete::class));
+    $application->add(Server::get(Command\User\Disable::class));
+    $application->add(Server::get(Command\User\Enable::class));
+    $application->add(Server::get(LastSeen::class));
+    $application->add(Server::get(Report::class));
+    $application->add(Server::get(ResetPassword::class));
+    $application->add(Server::get(Setting::class));
+    $application->add(Server::get(Profile::class));
+    $application->add(Server::get(Command\User\ListCommand::class));
+    $application->add(Server::get(ClearGeneratedAvatarCacheCommand::class));
+    $application->add(Server::get(Info::class));
+    $application->add(Server::get(SyncAccountDataCommand::class));
+    $application->add(Server::get(Command\User\AuthTokens\Add::class));
+    $application->add(Server::get(Command\User\AuthTokens\ListCommand::class));
+    $application->add(Server::get(Command\User\AuthTokens\Delete::class));
+    $application->add(Server::get(Verify::class));
+    $application->add(Server::get(Welcome::class));
+
+    $application->add(Server::get(Command\Group\Add::class));
+    $application->add(Server::get(Command\Group\Delete::class));
+    $application->add(Server::get(Command\Group\ListCommand::class));
+    $application->add(Server::get(AddUser::class));
+    $application->add(Server::get(RemoveUser::class));
+    $application->add(Server::get(Command\Group\Info::class));
+
+    $application->add(Server::get(Command\SystemTag\ListCommand::class));
+    $application->add(Server::get(Command\SystemTag\Delete::class));
+    $application->add(Server::get(Command\SystemTag\Add::class));
+    $application->add(Server::get(Edit::class));
+
+    $application->add(Server::get(ListCertificates::class));
+    $application->add(Server::get(ExportCertificates::class));
+    $application->add(Server::get(ImportCertificate::class));
+    $application->add(Server::get(RemoveCertificate::class));
+    $application->add(Server::get(BruteforceAttempts::class));
+    $application->add(Server::get(BruteforceResetAttempts::class));
+    $application->add(Server::get(SetupChecks::class));
+    $application->add(Server::get(Get::class));
+
+    $application->add(Server::get(GetCommand::class));
+    $application->add(Server::get(EnabledCommand::class));
+    $application->add(Server::get(Command\TaskProcessing\ListCommand::class));
+    $application->add(Server::get(Statistics::class));
+
+    $application->add(Server::get(RedisCommand::class));
 } else {
-	$application->add(Server::get(Command\Maintenance\Install::class));
+    $application->add(Server::get(Command\Maintenance\Install::class));
 }

core/Command/User/Profile.php

Indentation +210 added lines, -210 removed lines

@@ -21,214 +21,214 @@
 use Symfony\Component\Console\Output\OutputInterface;
 
 class Profile extends Base {
-	public function __construct(
-		protected IUserManager $userManager,
-		protected IAccountManager $accountManager,
-	) {
-		parent::__construct();
-	}
-
-	protected function configure() {
-		parent::configure();
-		$this
-			->setName('user:profile')
-			->setDescription('Read and modify user profile properties')
-			->addArgument(
-				'uid',
-				InputArgument::REQUIRED,
-				'Account ID used to login'
-			)
-			->addArgument(
-				'key',
-				InputArgument::OPTIONAL,
-				'Profile property to set, get or delete',
-				''
-			)
-
-			// Get
-			->addOption(
-				'default-value',
-				null,
-				InputOption::VALUE_REQUIRED,
-				'(Only applicable on get) If no default value is set and the property does not exist, the command will exit with 1'
-			)
-
-			// Set
-			->addArgument(
-				'value',
-				InputArgument::OPTIONAL,
-				'The new value of the property',
-				null
-			)
-			->addOption(
-				'update-only',
-				null,
-				InputOption::VALUE_NONE,
-				'Only updates the value, if it is not set before, it is not being added'
-			)
-
-			// Delete
-			->addOption(
-				'delete',
-				null,
-				InputOption::VALUE_NONE,
-				'Specify this option to delete the property value'
-			)
-			->addOption(
-				'error-if-not-exists',
-				null,
-				InputOption::VALUE_NONE,
-				'Checks whether the property exists before deleting it'
-			)
-		;
-	}
-
-	protected function checkInput(InputInterface $input): IUser {
-		$uid = $input->getArgument('uid');
-		$user = $this->userManager->get($uid);
-		if (!$user) {
-			throw new \InvalidArgumentException('The user "' . $uid . '" does not exist.');
-		}
-		// normalize uid
-		$input->setArgument('uid', $user->getUID());
-
-		$key = $input->getArgument('key');
-		if ($key === '') {
-			if ($input->hasParameterOption('--default-value')) {
-				throw new \InvalidArgumentException('The "default-value" option can only be used when specifying a key.');
-			}
-			if ($input->getArgument('value') !== null) {
-				throw new \InvalidArgumentException('The value argument can only be used when specifying a key.');
-			}
-			if ($input->getOption('delete')) {
-				throw new \InvalidArgumentException('The "delete" option can only be used when specifying a key.');
-			}
-		}
-
-		if ($input->getArgument('value') !== null && $input->hasParameterOption('--default-value')) {
-			throw new \InvalidArgumentException('The value argument can not be used together with "default-value".');
-		}
-		if ($input->getOption('update-only') && $input->getArgument('value') === null) {
-			throw new \InvalidArgumentException('The "update-only" option can only be used together with "value".');
-		}
-
-		if ($input->getOption('delete') && $input->hasParameterOption('--default-value')) {
-			throw new \InvalidArgumentException('The "delete" option can not be used together with "default-value".');
-		}
-		if ($input->getOption('delete') && $input->getArgument('value') !== null) {
-			throw new \InvalidArgumentException('The "delete" option can not be used together with "value".');
-		}
-		if ($input->getOption('error-if-not-exists') && !$input->getOption('delete')) {
-			throw new \InvalidArgumentException('The "error-if-not-exists" option can only be used together with "delete".');
-		}
-
-		return $user;
-	}
-
-	protected function execute(InputInterface $input, OutputInterface $output): int {
-		try {
-			$user = $this->checkInput($input);
-		} catch (\InvalidArgumentException $e) {
-			$output->writeln('<error>' . $e->getMessage() . '</error>');
-			return self::FAILURE;
-		}
-
-		$uid = $input->getArgument('uid');
-		$key = $input->getArgument('key');
-		$userAccount = $this->accountManager->getAccount($user);
-
-		if ($key === '') {
-			$settings = $this->getAllProfileProperties($userAccount);
-			$this->writeArrayInOutputFormat($input, $output, $settings);
-			return self::SUCCESS;
-		}
-
-		$value = $this->getStoredValue($userAccount, $key);
-		$inputValue = $input->getArgument('value');
-		if ($inputValue !== null) {
-			if ($input->hasParameterOption('--update-only') && $value === null) {
-				$output->writeln('<error>The property does not exist for user "' . $uid . '".</error>');
-				return self::FAILURE;
-			}
-
-			return $this->editProfileProperty($output, $userAccount, $key, $inputValue);
-		} elseif ($input->hasParameterOption('--delete')) {
-			if ($input->hasParameterOption('--error-if-not-exists') && $value === null) {
-				$output->writeln('<error>The property does not exist for user "' . $uid . '".</error>');
-				return self::FAILURE;
-			}
-
-			return $this->deleteProfileProperty($output, $userAccount, $key);
-		} elseif ($value !== null) {
-			$output->writeln($value);
-		} elseif ($input->hasParameterOption('--default-value')) {
-			$output->writeln($input->getOption('default-value'));
-		} else {
-			$output->writeln('<error>The property does not exist for user "' . $uid . '".</error>');
-			return self::FAILURE;
-		}
-
-		return self::SUCCESS;
-	}
-
-	private function deleteProfileProperty(OutputInterface $output, IAccount $userAccount, string $key): int {
-		return $this->editProfileProperty($output, $userAccount, $key, '');
-	}
-
-	private function editProfileProperty(OutputInterface $output, IAccount $userAccount, string $key, string $value): int {
-		try {
-			$userAccount->getProperty($key)->setValue($value);
-		} catch (PropertyDoesNotExistException $exception) {
-			$output->writeln('<error>' . $exception->getMessage() . '</error>');
-			return self::FAILURE;
-		}
-
-		$this->accountManager->updateAccount($userAccount);
-		return self::SUCCESS;
-	}
-
-	private function getStoredValue(IAccount $userAccount, string $key): ?string {
-		try {
-			$property = $userAccount->getProperty($key);
-		} catch (PropertyDoesNotExistException) {
-			return null;
-		}
-		return $property->getValue() === '' ? null : $property->getValue();
-	}
-
-	private function getAllProfileProperties(IAccount $userAccount): array {
-		$properties = [];
-
-		foreach ($userAccount->getAllProperties() as $property) {
-			if ($property->getValue() !== '') {
-				$properties[$property->getName()] = $property->getValue();
-			}
-		}
-
-		return $properties;
-	}
-
-	/**
-	 * @param string $argumentName
-	 * @param CompletionContext $context
-	 * @return string[]
-	 */
-	public function completeArgumentValues($argumentName, CompletionContext $context): array {
-		if ($argumentName === 'uid') {
-			return array_map(static fn (IUser $user) => $user->getUID(), $this->userManager->search($context->getCurrentWord()));
-		}
-		if ($argumentName === 'key') {
-			$userId = $context->getWordAtIndex($context->getWordIndex() - 1);
-			$user = $this->userManager->get($userId);
-			if (!($user instanceof IUser)) {
-				return [];
-			}
-
-			$account = $this->accountManager->getAccount($user);
-
-			$properties = $this->getAllProfileProperties($account);
-			return array_keys($properties);
-		}
-		return [];
-	}
+    public function __construct(
+        protected IUserManager $userManager,
+        protected IAccountManager $accountManager,
+    ) {
+        parent::__construct();
+    }
+
+    protected function configure() {
+        parent::configure();
+        $this
+            ->setName('user:profile')
+            ->setDescription('Read and modify user profile properties')
+            ->addArgument(
+                'uid',
+                InputArgument::REQUIRED,
+                'Account ID used to login'
+            )
+            ->addArgument(
+                'key',
+                InputArgument::OPTIONAL,
+                'Profile property to set, get or delete',
+                ''
+            )
+
+            // Get
+            ->addOption(
+                'default-value',
+                null,
+                InputOption::VALUE_REQUIRED,
+                '(Only applicable on get) If no default value is set and the property does not exist, the command will exit with 1'
+            )
+
+            // Set
+            ->addArgument(
+                'value',
+                InputArgument::OPTIONAL,
+                'The new value of the property',
+                null
+            )
+            ->addOption(
+                'update-only',
+                null,
+                InputOption::VALUE_NONE,
+                'Only updates the value, if it is not set before, it is not being added'
+            )
+
+            // Delete
+            ->addOption(
+                'delete',
+                null,
+                InputOption::VALUE_NONE,
+                'Specify this option to delete the property value'
+            )
+            ->addOption(
+                'error-if-not-exists',
+                null,
+                InputOption::VALUE_NONE,
+                'Checks whether the property exists before deleting it'
+            )
+        ;
+    }
+
+    protected function checkInput(InputInterface $input): IUser {
+        $uid = $input->getArgument('uid');
+        $user = $this->userManager->get($uid);
+        if (!$user) {
+            throw new \InvalidArgumentException('The user "' . $uid . '" does not exist.');
+        }
+        // normalize uid
+        $input->setArgument('uid', $user->getUID());
+
+        $key = $input->getArgument('key');
+        if ($key === '') {
+            if ($input->hasParameterOption('--default-value')) {
+                throw new \InvalidArgumentException('The "default-value" option can only be used when specifying a key.');
+            }
+            if ($input->getArgument('value') !== null) {
+                throw new \InvalidArgumentException('The value argument can only be used when specifying a key.');
+            }
+            if ($input->getOption('delete')) {
+                throw new \InvalidArgumentException('The "delete" option can only be used when specifying a key.');
+            }
+        }
+
+        if ($input->getArgument('value') !== null && $input->hasParameterOption('--default-value')) {
+            throw new \InvalidArgumentException('The value argument can not be used together with "default-value".');
+        }
+        if ($input->getOption('update-only') && $input->getArgument('value') === null) {
+            throw new \InvalidArgumentException('The "update-only" option can only be used together with "value".');
+        }
+
+        if ($input->getOption('delete') && $input->hasParameterOption('--default-value')) {
+            throw new \InvalidArgumentException('The "delete" option can not be used together with "default-value".');
+        }
+        if ($input->getOption('delete') && $input->getArgument('value') !== null) {
+            throw new \InvalidArgumentException('The "delete" option can not be used together with "value".');
+        }
+        if ($input->getOption('error-if-not-exists') && !$input->getOption('delete')) {
+            throw new \InvalidArgumentException('The "error-if-not-exists" option can only be used together with "delete".');
+        }
+
+        return $user;
+    }
+
+    protected function execute(InputInterface $input, OutputInterface $output): int {
+        try {
+            $user = $this->checkInput($input);
+        } catch (\InvalidArgumentException $e) {
+            $output->writeln('<error>' . $e->getMessage() . '</error>');
+            return self::FAILURE;
+        }
+
+        $uid = $input->getArgument('uid');
+        $key = $input->getArgument('key');
+        $userAccount = $this->accountManager->getAccount($user);
+
+        if ($key === '') {
+            $settings = $this->getAllProfileProperties($userAccount);
+            $this->writeArrayInOutputFormat($input, $output, $settings);
+            return self::SUCCESS;
+        }
+
+        $value = $this->getStoredValue($userAccount, $key);
+        $inputValue = $input->getArgument('value');
+        if ($inputValue !== null) {
+            if ($input->hasParameterOption('--update-only') && $value === null) {
+                $output->writeln('<error>The property does not exist for user "' . $uid . '".</error>');
+                return self::FAILURE;
+            }
+
+            return $this->editProfileProperty($output, $userAccount, $key, $inputValue);
+        } elseif ($input->hasParameterOption('--delete')) {
+            if ($input->hasParameterOption('--error-if-not-exists') && $value === null) {
+                $output->writeln('<error>The property does not exist for user "' . $uid . '".</error>');
+                return self::FAILURE;
+            }
+
+            return $this->deleteProfileProperty($output, $userAccount, $key);
+        } elseif ($value !== null) {
+            $output->writeln($value);
+        } elseif ($input->hasParameterOption('--default-value')) {
+            $output->writeln($input->getOption('default-value'));
+        } else {
+            $output->writeln('<error>The property does not exist for user "' . $uid . '".</error>');
+            return self::FAILURE;
+        }
+
+        return self::SUCCESS;
+    }
+
+    private function deleteProfileProperty(OutputInterface $output, IAccount $userAccount, string $key): int {
+        return $this->editProfileProperty($output, $userAccount, $key, '');
+    }
+
+    private function editProfileProperty(OutputInterface $output, IAccount $userAccount, string $key, string $value): int {
+        try {
+            $userAccount->getProperty($key)->setValue($value);
+        } catch (PropertyDoesNotExistException $exception) {
+            $output->writeln('<error>' . $exception->getMessage() . '</error>');
+            return self::FAILURE;
+        }
+
+        $this->accountManager->updateAccount($userAccount);
+        return self::SUCCESS;
+    }
+
+    private function getStoredValue(IAccount $userAccount, string $key): ?string {
+        try {
+            $property = $userAccount->getProperty($key);
+        } catch (PropertyDoesNotExistException) {
+            return null;
+        }
+        return $property->getValue() === '' ? null : $property->getValue();
+    }
+
+    private function getAllProfileProperties(IAccount $userAccount): array {
+        $properties = [];
+
+        foreach ($userAccount->getAllProperties() as $property) {
+            if ($property->getValue() !== '') {
+                $properties[$property->getName()] = $property->getValue();
+            }
+        }
+
+        return $properties;
+    }
+
+    /**
+     * @param string $argumentName
+     * @param CompletionContext $context
+     * @return string[]
+     */
+    public function completeArgumentValues($argumentName, CompletionContext $context): array {
+        if ($argumentName === 'uid') {
+            return array_map(static fn (IUser $user) => $user->getUID(), $this->userManager->search($context->getCurrentWord()));
+        }
+        if ($argumentName === 'key') {
+            $userId = $context->getWordAtIndex($context->getWordIndex() - 1);
+            $user = $this->userManager->get($userId);
+            if (!($user instanceof IUser)) {
+                return [];
+            }
+
+            $account = $this->accountManager->getAccount($user);
+
+            $properties = $this->getAllProfileProperties($account);
+            return array_keys($properties);
+        }
+        return [];
+    }
 }