nextcloud / server

core/Command/User/LastSeen.php

Spacing +5 added lines, -5 removed lines

@@ -56,20 +56,20 @@
 
 	protected function execute(InputInterface $input, OutputInterface $output) {
 		$user = $this->userManager->get($input->getArgument('uid'));
-		if(is_null($user)) {
+		if (is_null($user)) {
 			$output->writeln('<error>User does not exist</error>');
 			return;
 		}
 
 		$lastLogin = $user->getLastLogin();
-		if($lastLogin === 0) {
-			$output->writeln('User ' . $user->getUID() .
+		if ($lastLogin === 0) {
+			$output->writeln('User '.$user->getUID().
 				' has never logged in, yet.');
 		} else {
 			$date = new \DateTime();
 			$date->setTimestamp($lastLogin);
-			$output->writeln($user->getUID() .
-				'`s last login: ' . $date->format('d.m.Y H:i'));
+			$output->writeln($user->getUID().
+				'`s last login: '.$date->format('d.m.Y H:i'));
 		}
 	}
 }

Indentation +36 added lines, -36 removed lines

@@ -32,44 +32,44 @@
 use Symfony\Component\Console\Output\OutputInterface;
 
 class LastSeen extends Command {
-	/** @var IUserManager */
-	protected $userManager;
+    /** @var IUserManager */
+    protected $userManager;
 
-	/**
-	 * @param IUserManager $userManager
-	 */
-	public function __construct(IUserManager $userManager) {
-		$this->userManager = $userManager;
-		parent::__construct();
-	}
+    /**
+     * @param IUserManager $userManager
+     */
+    public function __construct(IUserManager $userManager) {
+        $this->userManager = $userManager;
+        parent::__construct();
+    }
 
-	protected function configure() {
-		$this
-			->setName('user:lastseen')
-			->setDescription('shows when the user was logged in last time')
-			->addArgument(
-				'uid',
-				InputArgument::REQUIRED,
-				'the username'
-			);
-	}
+    protected function configure() {
+        $this
+            ->setName('user:lastseen')
+            ->setDescription('shows when the user was logged in last time')
+            ->addArgument(
+                'uid',
+                InputArgument::REQUIRED,
+                'the username'
+            );
+    }
 
-	protected function execute(InputInterface $input, OutputInterface $output) {
-		$user = $this->userManager->get($input->getArgument('uid'));
-		if(is_null($user)) {
-			$output->writeln('<error>User does not exist</error>');
-			return;
-		}
+    protected function execute(InputInterface $input, OutputInterface $output) {
+        $user = $this->userManager->get($input->getArgument('uid'));
+        if(is_null($user)) {
+            $output->writeln('<error>User does not exist</error>');
+            return;
+        }
 
-		$lastLogin = $user->getLastLogin();
-		if($lastLogin === 0) {
-			$output->writeln('User ' . $user->getUID() .
-				' has never logged in, yet.');
-		} else {
-			$date = new \DateTime();
-			$date->setTimestamp($lastLogin);
-			$output->writeln($user->getUID() .
-				'`s last login: ' . $date->format('d.m.Y H:i'));
-		}
-	}
+        $lastLogin = $user->getLastLogin();
+        if($lastLogin === 0) {
+            $output->writeln('User ' . $user->getUID() .
+                ' has never logged in, yet.');
+        } else {
+            $date = new \DateTime();
+            $date->setTimestamp($lastLogin);
+            $output->writeln($user->getUID() .
+                '`s last login: ' . $date->format('d.m.Y H:i'));
+        }
+    }
 }

core/Command/User/ResetPassword.php

Spacing +2 added lines, -2 removed lines

@@ -117,12 +117,12 @@
 		try {
 			$success = $user->setPassword($password);
 		} catch (\Exception $e) {
-			$output->writeln('<error>' . $e->getMessage() . '</error>');
+			$output->writeln('<error>'.$e->getMessage().'</error>');
 			return 1;
 		}
 
 		if ($success) {
-			$output->writeln("<info>Successfully reset password for " . $username . "</info>");
+			$output->writeln("<info>Successfully reset password for ".$username."</info>");
 		} else {
 			$output->writeln("<error>Error while resetting password!</error>");
 			return 1;

Indentation +94 added lines, -94 removed lines

@@ -39,98 +39,98 @@
 
 class ResetPassword extends Command {
 
-	/** @var IUserManager */
-	protected $userManager;
-
-	public function __construct(IUserManager $userManager) {
-		$this->userManager = $userManager;
-		parent::__construct();
-	}
-
-	protected function configure() {
-		$this
-			->setName('user:resetpassword')
-			->setDescription('Resets the password of the named user')
-			->addArgument(
-				'user',
-				InputArgument::REQUIRED,
-				'Username to reset password'
-			)
-			->addOption(
-				'password-from-env',
-				null,
-				InputOption::VALUE_NONE,
-				'read password from environment variable OC_PASS'
-			)
-		;
-	}
-
-	protected function execute(InputInterface $input, OutputInterface $output) {
-		$username = $input->getArgument('user');
-
-		/** @var $user \OCP\IUser */
-		$user = $this->userManager->get($username);
-		if (is_null($user)) {
-			$output->writeln('<error>User does not exist</error>');
-			return 1;
-		}
-
-		if ($input->getOption('password-from-env')) {
-			$password = getenv('OC_PASS');
-			if (!$password) {
-				$output->writeln('<error>--password-from-env given, but OC_PASS is empty!</error>');
-				return 1;
-			}
-		} elseif ($input->isInteractive()) {
-			/** @var QuestionHelper $helper */
-			$helper = $this->getHelper('question');
-
-			if (\OCP\App::isEnabled('encryption')) {
-				$output->writeln(
-					'<error>Warning: Resetting the password when using encryption will result in data loss!</error>'
-				);
-
-				$question = new ConfirmationQuestion('Do you want to continue?');
-				if (!$helper->ask($input, $output, $question)) {
-					return 1;
-				}
-			}
-
-			$question = new Question('Enter a new password: ');
-			$question->setHidden(true);
-			$password = $helper->ask($input, $output, $question);
-
-			if ($password === null) {
-				$output->writeln("<error>Password cannot be empty!</error>");
-				return 1;
-			}
-
-			$question = new Question('Confirm the new password: ');
-			$question->setHidden(true);
-			$confirm = $helper->ask($input, $output, $question);
-
-			if ($password !== $confirm) {
-				$output->writeln("<error>Passwords did not match!</error>");
-				return 1;
-			}
-		} else {
-			$output->writeln("<error>Interactive input or --password-from-env is needed for entering a new password!</error>");
-			return 1;
-		}
-
-
-		try {
-			$success = $user->setPassword($password);
-		} catch (\Exception $e) {
-			$output->writeln('<error>' . $e->getMessage() . '</error>');
-			return 1;
-		}
-
-		if ($success) {
-			$output->writeln("<info>Successfully reset password for " . $username . "</info>");
-		} else {
-			$output->writeln("<error>Error while resetting password!</error>");
-			return 1;
-		}
-	}
+    /** @var IUserManager */
+    protected $userManager;
+
+    public function __construct(IUserManager $userManager) {
+        $this->userManager = $userManager;
+        parent::__construct();
+    }
+
+    protected function configure() {
+        $this
+            ->setName('user:resetpassword')
+            ->setDescription('Resets the password of the named user')
+            ->addArgument(
+                'user',
+                InputArgument::REQUIRED,
+                'Username to reset password'
+            )
+            ->addOption(
+                'password-from-env',
+                null,
+                InputOption::VALUE_NONE,
+                'read password from environment variable OC_PASS'
+            )
+        ;
+    }
+
+    protected function execute(InputInterface $input, OutputInterface $output) {
+        $username = $input->getArgument('user');
+
+        /** @var $user \OCP\IUser */
+        $user = $this->userManager->get($username);
+        if (is_null($user)) {
+            $output->writeln('<error>User does not exist</error>');
+            return 1;
+        }
+
+        if ($input->getOption('password-from-env')) {
+            $password = getenv('OC_PASS');
+            if (!$password) {
+                $output->writeln('<error>--password-from-env given, but OC_PASS is empty!</error>');
+                return 1;
+            }
+        } elseif ($input->isInteractive()) {
+            /** @var QuestionHelper $helper */
+            $helper = $this->getHelper('question');
+
+            if (\OCP\App::isEnabled('encryption')) {
+                $output->writeln(
+                    '<error>Warning: Resetting the password when using encryption will result in data loss!</error>'
+                );
+
+                $question = new ConfirmationQuestion('Do you want to continue?');
+                if (!$helper->ask($input, $output, $question)) {
+                    return 1;
+                }
+            }
+
+            $question = new Question('Enter a new password: ');
+            $question->setHidden(true);
+            $password = $helper->ask($input, $output, $question);
+
+            if ($password === null) {
+                $output->writeln("<error>Password cannot be empty!</error>");
+                return 1;
+            }
+
+            $question = new Question('Confirm the new password: ');
+            $question->setHidden(true);
+            $confirm = $helper->ask($input, $output, $question);
+
+            if ($password !== $confirm) {
+                $output->writeln("<error>Passwords did not match!</error>");
+                return 1;
+            }
+        } else {
+            $output->writeln("<error>Interactive input or --password-from-env is needed for entering a new password!</error>");
+            return 1;
+        }
+
+
+        try {
+            $success = $user->setPassword($password);
+        } catch (\Exception $e) {
+            $output->writeln('<error>' . $e->getMessage() . '</error>');
+            return 1;
+        }
+
+        if ($success) {
+            $output->writeln("<info>Successfully reset password for " . $username . "</info>");
+        } else {
+            $output->writeln("<error>Error while resetting password!</error>");
+            return 1;
+        }
+    }
 }

core/Command/Background/WebCron.php

Indentation +3 added lines, -3 removed lines

@@ -27,7 +27,7 @@
 
 class WebCron extends Base {
 
-	protected function getMode() {
-		return 'webcron';
-	}
+    protected function getMode() {
+        return 'webcron';
+    }
 }

core/Command/Background/Base.php

Indentation +31 added lines, -31 removed lines

@@ -39,39 +39,39 @@
 abstract class Base extends Command {
 
 
-	abstract protected function getMode();
+    abstract protected function getMode();
 
-	/**
-	* @var \OCP\IConfig
-	*/
-	protected $config;
+    /**
+     * @var \OCP\IConfig
+     */
+    protected $config;
 
-	/**
-	* @param \OCP\IConfig $config
-	*/
-	public function __construct(IConfig $config) {
-		$this->config = $config;
-		parent::__construct();
-	}
+    /**
+     * @param \OCP\IConfig $config
+     */
+    public function __construct(IConfig $config) {
+        $this->config = $config;
+        parent::__construct();
+    }
 
-	protected function configure() {
-		$mode = $this->getMode();
-		$this
-			->setName("background:$mode")
-			->setDescription("Use $mode to run background jobs");
-	}
+    protected function configure() {
+        $mode = $this->getMode();
+        $this
+            ->setName("background:$mode")
+            ->setDescription("Use $mode to run background jobs");
+    }
 
-	/**
-	* Executing this command will set the background job mode for owncloud.
-	* The mode to set is specified by the concrete sub class by implementing the
-	* getMode() function.
-	*
-	* @param InputInterface $input
-	* @param OutputInterface $output
-	*/
-	protected function execute(InputInterface $input, OutputInterface $output) {
-		$mode = $this->getMode();
-		$this->config->setAppValue( 'core', 'backgroundjobs_mode', $mode );
-		$output->writeln("Set mode for background jobs to '$mode'");
-	}
+    /**
+     * Executing this command will set the background job mode for owncloud.
+     * The mode to set is specified by the concrete sub class by implementing the
+     * getMode() function.
+     *
+     * @param InputInterface $input
+     * @param OutputInterface $output
+     */
+    protected function execute(InputInterface $input, OutputInterface $output) {
+        $mode = $this->getMode();
+        $this->config->setAppValue( 'core', 'backgroundjobs_mode', $mode );
+        $output->writeln("Set mode for background jobs to '$mode'");
+    }
 }

Spacing +1 added lines, -1 removed lines

@@ -71,7 +71,7 @@
 	*/
 	protected function execute(InputInterface $input, OutputInterface $output) {
 		$mode = $this->getMode();
-		$this->config->setAppValue( 'core', 'backgroundjobs_mode', $mode );
+		$this->config->setAppValue('core', 'backgroundjobs_mode', $mode);
 		$output->writeln("Set mode for background jobs to '$mode'");
 	}
 }

core/Command/Background/Cron.php

Indentation +3 added lines, -3 removed lines

@@ -27,7 +27,7 @@
 
 class Cron extends Base {
 
-	protected function getMode() {
-		return 'cron';
-	}
+    protected function getMode() {
+        return 'cron';
+    }
 }

core/Command/Background/Ajax.php

Indentation +3 added lines, -3 removed lines

@@ -27,7 +27,7 @@
 
 class Ajax extends Base {
 
-	protected function getMode() {
-		return 'ajax';
-	}
+    protected function getMode() {
+        return 'ajax';
+    }
 }

core/Command/Config/ListConfigs.php

Indentation +123 added lines, -123 removed lines

@@ -32,127 +32,127 @@
 use Symfony\Component\Console\Output\OutputInterface;
 
 class ListConfigs extends Base {
-	protected $defaultOutputFormat = self::OUTPUT_FORMAT_JSON_PRETTY;
-
-	/** * @var SystemConfig */
-	protected $systemConfig;
-
-	/** @var IAppConfig */
-	protected $appConfig;
-
-	/**
-	 * @param SystemConfig $systemConfig
-	 * @param IAppConfig $appConfig
-	 */
-	public function __construct(SystemConfig $systemConfig, IAppConfig $appConfig) {
-		parent::__construct();
-		$this->systemConfig = $systemConfig;
-		$this->appConfig = $appConfig;
-	}
-
-	protected function configure() {
-		parent::configure();
-
-		$this
-			->setName('config:list')
-			->setDescription('List all configs')
-			->addArgument(
-				'app',
-				InputArgument::OPTIONAL,
-				'Name of the app ("system" to get the config.php values, "all" for all apps and system)',
-				'all'
-			)
-			->addOption(
-				'private',
-				null,
-				InputOption::VALUE_NONE,
-				'Use this option when you want to include sensitive configs like passwords, salts, ...'
-			)
-		;
-	}
-
-	protected function execute(InputInterface $input, OutputInterface $output) {
-		$app = $input->getArgument('app');
-		$noSensitiveValues = !$input->getOption('private');
-
-		switch ($app) {
-			case 'system':
-				$configs = [
-					'system' => $this->getSystemConfigs($noSensitiveValues),
-				];
-			break;
-
-			case 'all':
-				$apps = $this->appConfig->getApps();
-				$configs = [
-					'system' => $this->getSystemConfigs($noSensitiveValues),
-					'apps' => [],
-				];
-				foreach ($apps as $appName) {
-					$configs['apps'][$appName] = $this->getAppConfigs($appName, $noSensitiveValues);
-				}
-			break;
-
-			default:
-				$configs = [
-					'apps' => [
-						$app => $this->getAppConfigs($app, $noSensitiveValues),
-					],
-				];
-		}
-
-		$this->writeArrayInOutputFormat($input, $output, $configs);
-	}
-
-	/**
-	 * Get the system configs
-	 *
-	 * @param bool $noSensitiveValues
-	 * @return array
-	 */
-	protected function getSystemConfigs($noSensitiveValues) {
-		$keys = $this->systemConfig->getKeys();
-
-		$configs = [];
-		foreach ($keys as $key) {
-			if ($noSensitiveValues) {
-				$value = $this->systemConfig->getFilteredValue($key, serialize(null));
-			} else {
-				$value = $this->systemConfig->getValue($key, serialize(null));
-			}
-
-			if ($value !== 'N;') {
-				$configs[$key] = $value;
-			}
-		}
-
-		return $configs;
-	}
-
-	/**
-	 * Get the app configs
-	 *
-	 * @param string $app
-	 * @param bool $noSensitiveValues
-	 * @return array
-	 */
-	protected function getAppConfigs($app, $noSensitiveValues) {
-		if ($noSensitiveValues) {
-			return $this->appConfig->getFilteredValues($app, false);
-		} else {
-			return $this->appConfig->getValues($app, false);
-		}
-	}
-
-	/**
-	 * @param string $argumentName
-	 * @param CompletionContext $context
-	 * @return string[]
-	 */
-	public function completeArgumentValues($argumentName, CompletionContext $context) {
-		if ($argumentName === 'app') {
-			return array_merge(['all', 'system'], \OC_App::getAllApps());
-		}
-		return [];
-	}
+    protected $defaultOutputFormat = self::OUTPUT_FORMAT_JSON_PRETTY;
+
+    /** * @var SystemConfig */
+    protected $systemConfig;
+
+    /** @var IAppConfig */
+    protected $appConfig;
+
+    /**
+     * @param SystemConfig $systemConfig
+     * @param IAppConfig $appConfig
+     */
+    public function __construct(SystemConfig $systemConfig, IAppConfig $appConfig) {
+        parent::__construct();
+        $this->systemConfig = $systemConfig;
+        $this->appConfig = $appConfig;
+    }
+
+    protected function configure() {
+        parent::configure();
+
+        $this
+            ->setName('config:list')
+            ->setDescription('List all configs')
+            ->addArgument(
+                'app',
+                InputArgument::OPTIONAL,
+                'Name of the app ("system" to get the config.php values, "all" for all apps and system)',
+                'all'
+            )
+            ->addOption(
+                'private',
+                null,
+                InputOption::VALUE_NONE,
+                'Use this option when you want to include sensitive configs like passwords, salts, ...'
+            )
+        ;
+    }
+
+    protected function execute(InputInterface $input, OutputInterface $output) {
+        $app = $input->getArgument('app');
+        $noSensitiveValues = !$input->getOption('private');
+
+        switch ($app) {
+            case 'system':
+                $configs = [
+                    'system' => $this->getSystemConfigs($noSensitiveValues),
+                ];
+            break;
+
+            case 'all':
+                $apps = $this->appConfig->getApps();
+                $configs = [
+                    'system' => $this->getSystemConfigs($noSensitiveValues),
+                    'apps' => [],
+                ];
+                foreach ($apps as $appName) {
+                    $configs['apps'][$appName] = $this->getAppConfigs($appName, $noSensitiveValues);
+                }
+            break;
+
+            default:
+                $configs = [
+                    'apps' => [
+                        $app => $this->getAppConfigs($app, $noSensitiveValues),
+                    ],
+                ];
+        }
+
+        $this->writeArrayInOutputFormat($input, $output, $configs);
+    }
+
+    /**
+     * Get the system configs
+     *
+     * @param bool $noSensitiveValues
+     * @return array
+     */
+    protected function getSystemConfigs($noSensitiveValues) {
+        $keys = $this->systemConfig->getKeys();
+
+        $configs = [];
+        foreach ($keys as $key) {
+            if ($noSensitiveValues) {
+                $value = $this->systemConfig->getFilteredValue($key, serialize(null));
+            } else {
+                $value = $this->systemConfig->getValue($key, serialize(null));
+            }
+
+            if ($value !== 'N;') {
+                $configs[$key] = $value;
+            }
+        }
+
+        return $configs;
+    }
+
+    /**
+     * Get the app configs
+     *
+     * @param string $app
+     * @param bool $noSensitiveValues
+     * @return array
+     */
+    protected function getAppConfigs($app, $noSensitiveValues) {
+        if ($noSensitiveValues) {
+            return $this->appConfig->getFilteredValues($app, false);
+        } else {
+            return $this->appConfig->getValues($app, false);
+        }
+    }
+
+    /**
+     * @param string $argumentName
+     * @param CompletionContext $context
+     * @return string[]
+     */
+    public function completeArgumentValues($argumentName, CompletionContext $context) {
+        if ($argumentName === 'app') {
+            return array_merge(['all', 'system'], \OC_App::getAllApps());
+        }
+        return [];
+    }
 }

core/Command/Config/System/DeleteConfig.php

Braces +1 added lines, -2 removed lines

@@ -74,8 +74,7 @@
 
 			try {
 				$value = $this->removeSubValue(array_slice($configNames, 1), $value, $input->hasParameterOption('--error-if-not-exists'));
-			}
-			catch (\UnexpectedValueException $e) {
+			} catch (\UnexpectedValueException $e) {
 				$output->writeln('<error>System config ' . implode(' => ', $configNames) . ' could not be deleted because it did not exist</error>');
 				return 1;
 			}

Indentation +73 added lines, -73 removed lines

@@ -29,89 +29,89 @@
 use Symfony\Component\Console\Output\OutputInterface;
 
 class DeleteConfig extends Base {
-	/** * @var SystemConfig */
-	protected $systemConfig;
+    /** * @var SystemConfig */
+    protected $systemConfig;
 
-	/**
-	 * @param SystemConfig $systemConfig
-	 */
-	public function __construct(SystemConfig $systemConfig) {
-		parent::__construct();
-		$this->systemConfig = $systemConfig;
-	}
+    /**
+     * @param SystemConfig $systemConfig
+     */
+    public function __construct(SystemConfig $systemConfig) {
+        parent::__construct();
+        $this->systemConfig = $systemConfig;
+    }
 
-	protected function configure() {
-		parent::configure();
+    protected function configure() {
+        parent::configure();
 
-		$this
-			->setName('config:system:delete')
-			->setDescription('Delete a system config value')
-			->addArgument(
-				'name',
-				InputArgument::REQUIRED | InputArgument::IS_ARRAY,
-				'Name of the config to delete, specify multiple for array parameter'
-			)
-			->addOption(
-				'error-if-not-exists',
-				null,
-				InputOption::VALUE_NONE,
-				'Checks whether the config exists before deleting it'
-			)
-		;
-	}
+        $this
+            ->setName('config:system:delete')
+            ->setDescription('Delete a system config value')
+            ->addArgument(
+                'name',
+                InputArgument::REQUIRED | InputArgument::IS_ARRAY,
+                'Name of the config to delete, specify multiple for array parameter'
+            )
+            ->addOption(
+                'error-if-not-exists',
+                null,
+                InputOption::VALUE_NONE,
+                'Checks whether the config exists before deleting it'
+            )
+        ;
+    }
 
-	protected function execute(InputInterface $input, OutputInterface $output) {
-		$configNames = $input->getArgument('name');
-		$configName = $configNames[0];
+    protected function execute(InputInterface $input, OutputInterface $output) {
+        $configNames = $input->getArgument('name');
+        $configName = $configNames[0];
 
-		if (count($configNames) > 1) {
-			if ($input->hasParameterOption('--error-if-not-exists') && !in_array($configName, $this->systemConfig->getKeys())) {
-				$output->writeln('<error>System config ' . implode(' => ', $configNames) . ' could not be deleted because it did not exist</error>');
-				return 1;
-			}
+        if (count($configNames) > 1) {
+            if ($input->hasParameterOption('--error-if-not-exists') && !in_array($configName, $this->systemConfig->getKeys())) {
+                $output->writeln('<error>System config ' . implode(' => ', $configNames) . ' could not be deleted because it did not exist</error>');
+                return 1;
+            }
 
-			$value = $this->systemConfig->getValue($configName);
+            $value = $this->systemConfig->getValue($configName);
 
-			try {
-				$value = $this->removeSubValue(array_slice($configNames, 1), $value, $input->hasParameterOption('--error-if-not-exists'));
-			}
-			catch (\UnexpectedValueException $e) {
-				$output->writeln('<error>System config ' . implode(' => ', $configNames) . ' could not be deleted because it did not exist</error>');
-				return 1;
-			}
+            try {
+                $value = $this->removeSubValue(array_slice($configNames, 1), $value, $input->hasParameterOption('--error-if-not-exists'));
+            }
+            catch (\UnexpectedValueException $e) {
+                $output->writeln('<error>System config ' . implode(' => ', $configNames) . ' could not be deleted because it did not exist</error>');
+                return 1;
+            }
 
-			$this->systemConfig->setValue($configName, $value);
-			$output->writeln('<info>System config value ' . implode(' => ', $configNames) . ' deleted</info>');
-			return 0;
-		} else {
-			if ($input->hasParameterOption('--error-if-not-exists') && !in_array($configName, $this->systemConfig->getKeys())) {
-				$output->writeln('<error>System config ' . $configName . ' could not be deleted because it did not exist</error>');
-				return 1;
-			}
+            $this->systemConfig->setValue($configName, $value);
+            $output->writeln('<info>System config value ' . implode(' => ', $configNames) . ' deleted</info>');
+            return 0;
+        } else {
+            if ($input->hasParameterOption('--error-if-not-exists') && !in_array($configName, $this->systemConfig->getKeys())) {
+                $output->writeln('<error>System config ' . $configName . ' could not be deleted because it did not exist</error>');
+                return 1;
+            }
 
-			$this->systemConfig->deleteValue($configName);
-			$output->writeln('<info>System config value ' . $configName . ' deleted</info>');
-			return 0;
-		}
-	}
+            $this->systemConfig->deleteValue($configName);
+            $output->writeln('<info>System config value ' . $configName . ' deleted</info>');
+            return 0;
+        }
+    }
 
-	protected function removeSubValue($keys, $currentValue, $throwError) {
-		$nextKey = array_shift($keys);
+    protected function removeSubValue($keys, $currentValue, $throwError) {
+        $nextKey = array_shift($keys);
 
-		if (is_array($currentValue)) {
-			if (isset($currentValue[$nextKey])) {
-				if (empty($keys)) {
-					unset($currentValue[$nextKey]);
-				} else {
-					$currentValue[$nextKey] = $this->removeSubValue($keys, $currentValue[$nextKey], $throwError);
-				}
-			} else if ($throwError) {
-				throw new \UnexpectedValueException('Config parameter does not exist');
-			}
-		} else if ($throwError) {
-			throw new \UnexpectedValueException('Config parameter does not exist');
-		}
+        if (is_array($currentValue)) {
+            if (isset($currentValue[$nextKey])) {
+                if (empty($keys)) {
+                    unset($currentValue[$nextKey]);
+                } else {
+                    $currentValue[$nextKey] = $this->removeSubValue($keys, $currentValue[$nextKey], $throwError);
+                }
+            } else if ($throwError) {
+                throw new \UnexpectedValueException('Config parameter does not exist');
+            }
+        } else if ($throwError) {
+            throw new \UnexpectedValueException('Config parameter does not exist');
+        }
 
-		return $currentValue;
-	}
+        return $currentValue;
+    }
 }

Spacing +5 added lines, -5 removed lines

@@ -66,7 +66,7 @@ 
 
 		if (count($configNames) > 1) {
 			if ($input->hasParameterOption('--error-if-not-exists') && !in_array($configName, $this->systemConfig->getKeys())) {
-				$output->writeln('<error>System config ' . implode(' => ', $configNames) . ' could not be deleted because it did not exist</error>');
+				$output->writeln('<error>System config '.implode(' => ', $configNames).' could not be deleted because it did not exist</error>');
 				return 1;
 			}
 
@@ -76,21 +76,21 @@ 
 				$value = $this->removeSubValue(array_slice($configNames, 1), $value, $input->hasParameterOption('--error-if-not-exists'));
 			}
 			catch (\UnexpectedValueException $e) {
-				$output->writeln('<error>System config ' . implode(' => ', $configNames) . ' could not be deleted because it did not exist</error>');
+				$output->writeln('<error>System config '.implode(' => ', $configNames).' could not be deleted because it did not exist</error>');
 				return 1;
 			}
 
 			$this->systemConfig->setValue($configName, $value);
-			$output->writeln('<info>System config value ' . implode(' => ', $configNames) . ' deleted</info>');
+			$output->writeln('<info>System config value '.implode(' => ', $configNames).' deleted</info>');
 			return 0;
 		} else {
 			if ($input->hasParameterOption('--error-if-not-exists') && !in_array($configName, $this->systemConfig->getKeys())) {
-				$output->writeln('<error>System config ' . $configName . ' could not be deleted because it did not exist</error>');
+				$output->writeln('<error>System config '.$configName.' could not be deleted because it did not exist</error>');
 				return 1;
 			}
 
 			$this->systemConfig->deleteValue($configName);
-			$output->writeln('<info>System config value ' . $configName . ' deleted</info>');
+			$output->writeln('<info>System config value '.$configName.' deleted</info>');
 			return 0;
 		}
 	}

core/Command/Config/System/Base.php

Indentation +43 added lines, -43 removed lines

@@ -26,53 +26,53 @@
 
 abstract class Base extends \OC\Core\Command\Base {
 
-	/** @var SystemConfig */
-	protected $systemConfig;
+    /** @var SystemConfig */
+    protected $systemConfig;
 
-	/**
-	 * @param string $argumentName
-	 * @param CompletionContext $context
-	 * @return string[]
-	 */
-	public function completeArgumentValues($argumentName, CompletionContext $context) {
-		if ($argumentName === 'name') {
-			$words = $this->getPreviousNames($context, $context->getWordIndex());
-			if (empty($words)) {
-				$completions = $this->systemConfig->getKeys();
-			} else {
-				$key = array_shift($words);
-				$value = $this->systemConfig->getValue($key);
-				$completions = array_keys($value);
+    /**
+     * @param string $argumentName
+     * @param CompletionContext $context
+     * @return string[]
+     */
+    public function completeArgumentValues($argumentName, CompletionContext $context) {
+        if ($argumentName === 'name') {
+            $words = $this->getPreviousNames($context, $context->getWordIndex());
+            if (empty($words)) {
+                $completions = $this->systemConfig->getKeys();
+            } else {
+                $key = array_shift($words);
+                $value = $this->systemConfig->getValue($key);
+                $completions = array_keys($value);
 
-				while (!empty($words) && is_array($value)) {
-					$key = array_shift($words);
-					if (!isset($value[$key]) || !is_array($value[$key])) {
-						break;
-					}
+                while (!empty($words) && is_array($value)) {
+                    $key = array_shift($words);
+                    if (!isset($value[$key]) || !is_array($value[$key])) {
+                        break;
+                    }
 
-					$value = $value[$key];
-					$completions = array_keys($value);
-				}
-			}
+                    $value = $value[$key];
+                    $completions = array_keys($value);
+                }
+            }
 
-			return $completions;
-		}
-		return parent::completeArgumentValues($argumentName, $context);
-	}
+            return $completions;
+        }
+        return parent::completeArgumentValues($argumentName, $context);
+    }
 
-	/**
-	 * @param CompletionContext $context
-	 * @param int $currentIndex
-	 * @return string[]
-	 */
-	protected function getPreviousNames(CompletionContext $context, $currentIndex) {
-		$word = $context->getWordAtIndex($currentIndex - 1);
-		if ($word === $this->getName() || $currentIndex <= 0) {
-			return [];
-		}
+    /**
+     * @param CompletionContext $context
+     * @param int $currentIndex
+     * @return string[]
+     */
+    protected function getPreviousNames(CompletionContext $context, $currentIndex) {
+        $word = $context->getWordAtIndex($currentIndex - 1);
+        if ($word === $this->getName() || $currentIndex <= 0) {
+            return [];
+        }
 
-		$words = $this->getPreviousNames($context, $currentIndex - 1);
-		$words[] = $word;
-		return $words;
-	}
+        $words = $this->getPreviousNames($context, $currentIndex - 1);
+        $words[] = $word;
+        return $words;
+    }
 }