Completed
Pull Request — stable10 (#1186)
by Julius
149:03 queued 135:59
created
lib/private/User/User.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -413,6 +413,10 @@
 block discarded – undo
413 413
 		return $url;
414 414
 	}
415 415
 
416
+	/**
417
+	 * @param string $feature
418
+	 * @param string $value
419
+	 */
416 420
 	public function triggerChange($feature, $value = null) {
417 421
 		if ($this->emitter) {
418 422
 			$this->emitter->emit('\OC\User', 'changeUser', array($this, $feature, $value));
Please login to merge, or discard this patch.
lib/private/AllConfig.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -116,8 +116,8 @@
 block discarded – undo
116 116
 	 * Looks up a system wide defined value
117 117
 	 *
118 118
 	 * @param string $key the key of the value, under which it was saved
119
-	 * @param mixed $default the default value to be returned if the value isn't set
120
-	 * @return mixed the value or $default
119
+	 * @param string|false $default the default value to be returned if the value isn't set
120
+	 * @return string the value or $default
121 121
 	 */
122 122
 	public function getSystemValue($key, $default = '') {
123 123
 		return $this->systemConfig->getValue($key, $default);
Please login to merge, or discard this patch.
lib/public/AppFramework/Http/OCSResponse.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -50,8 +50,8 @@
 block discarded – undo
50 50
 	 * @param int $statuscode
51 51
 	 * @param string $message
52 52
 	 * @param array $data
53
-	 * @param int|string $itemscount
54
-	 * @param int|string $itemsperpage
53
+	 * @param string $itemscount
54
+	 * @param string $itemsperpage
55 55
 	 * @since 8.1.0
56 56
 	 */
57 57
 	public function __construct($format, $statuscode, $message,
Please login to merge, or discard this patch.
lib/private/legacy/files.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -334,7 +334,7 @@
 block discarded – undo
334 334
 	 *
335 335
 	 * @param int $size file size in bytes
336 336
 	 * @param array $files override '.htaccess' and '.user.ini' locations
337
-	 * @return bool false on failure, size on success
337
+	 * @return integer false on failure, size on success
338 338
 	 */
339 339
 	public static function setUploadLimit($size, $files = []) {
340 340
 		//don't allow user to break his config
Please login to merge, or discard this patch.
lib/private/Settings/Manager.php 1 patch
Doc Comments   +13 added lines, -2 removed lines patch added patch discarded remove patch
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
 	/**
130 130
 	 * returns the registerd classes in the given table
131 131
 	 *
132
-	 * @param $table
132
+	 * @param string $table
133 133
 	 * @return string[]
134 134
 	 */
135 135
 	private function getClasses($table) {
@@ -225,6 +225,11 @@  discard block
 block discarded – undo
225 225
 		);
226 226
 	}
227 227
 
228
+	/**
229
+	 * @param string $table
230
+	 * @param string $idCol
231
+	 * @param string $id
232
+	 */
228 233
 	private function update($table, $idCol, $id, $values) {
229 234
 		$query = $this->dbc->getQueryBuilder();
230 235
 		$query->update($table);
@@ -275,7 +280,7 @@  discard block
 block discarded – undo
275 280
 	/**
276 281
 	 * deletes an settings or admin entry from the given table
277 282
 	 *
278
-	 * @param $table
283
+	 * @param string $table
279 284
 	 * @param $className
280 285
 	 */
281 286
 	private function remove($table, $className) {
@@ -358,6 +363,9 @@  discard block
 block discarded – undo
358 363
 		return $sections;
359 364
 	}
360 365
 
366
+	/**
367
+	 * @param string $section
368
+	 */
361 369
 	private function getBuiltInAdminSettings($section) {
362 370
 		$forms = [];
363 371
 		try {
@@ -397,6 +405,9 @@  discard block
 block discarded – undo
397 405
 		return $forms;
398 406
 	}
399 407
 
408
+	/**
409
+	 * @param string $section
410
+	 */
400 411
 	private function getAdminSettingsFromDB($section, &$settings) {
401 412
 		$query = $this->dbc->getQueryBuilder();
402 413
 		$query->select(['class', 'priority'])
Please login to merge, or discard this patch.