Passed
Push — master ( 13c7a9...8fcc0e )
by Christoph
15:42 queued 11s
created
apps/files/ajax/download.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -32,8 +32,8 @@  discard block
 block discarded – undo
32 32
 OCP\User::checkLoggedIn();
33 33
 \OC::$server->getSession()->close();
34 34
 
35
-$files = isset($_GET['files']) ? (string)$_GET['files'] : '';
36
-$dir = isset($_GET['dir']) ? (string)$_GET['dir'] : '';
35
+$files = isset($_GET['files']) ? (string) $_GET['files'] : '';
36
+$dir = isset($_GET['dir']) ? (string) $_GET['dir'] : '';
37 37
 
38 38
 $files_list = json_decode($files);
39 39
 // in case we get only a single file
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 	setcookie('ocDownloadStarted', $_GET['downloadStartSecret'], time() + 20, '/');
53 53
 }
54 54
 
55
-$server_params = [ 'head' => \OC::$server->getRequest()->getMethod() === 'HEAD' ];
55
+$server_params = ['head' => \OC::$server->getRequest()->getMethod() === 'HEAD'];
56 56
 
57 57
 /**
58 58
  * Http range requests support
Please login to merge, or discard this patch.
apps/dav/lib/DAV/CustomPropertiesBackend.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 	 * @return void
145 145
 	 */
146 146
 	public function propPatch($path, PropPatch $propPatch) {
147
-		$propPatch->handleRemaining(function ($changedProps) use ($path) {
147
+		$propPatch->handleRemaining(function($changedProps) use ($path) {
148 148
 			return $this->updateProperties($path, $changedProps);
149 149
 		});
150 150
 	}
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
 	 */
175 175
 	public function move($source, $destination) {
176 176
 		$statement = $this->connection->prepare(
177
-			'UPDATE `*PREFIX*properties` SET `propertypath` = ?' .
177
+			'UPDATE `*PREFIX*properties` SET `propertypath` = ?'.
178 178
 			' WHERE `userid` = ? AND `propertypath` = ?'
179 179
 		);
180 180
 		$statement->execute([$this->formatPath($destination), $this->user->getUID(), $this->formatPath($source)]);
@@ -236,13 +236,13 @@  discard block
 block discarded – undo
236 236
 	 * @return bool
237 237
 	 */
238 238
 	private function updateProperties(string $path, array $properties) {
239
-		$deleteStatement = 'DELETE FROM `*PREFIX*properties`' .
239
+		$deleteStatement = 'DELETE FROM `*PREFIX*properties`'.
240 240
 			' WHERE `userid` = ? AND `propertypath` = ? AND `propertyname` = ?';
241 241
 
242
-		$insertStatement = 'INSERT INTO `*PREFIX*properties`' .
242
+		$insertStatement = 'INSERT INTO `*PREFIX*properties`'.
243 243
 			' (`userid`,`propertypath`,`propertyname`,`propertyvalue`) VALUES(?,?,?,?)';
244 244
 
245
-		$updateStatement = 'UPDATE `*PREFIX*properties` SET `propertyvalue` = ?' .
245
+		$updateStatement = 'UPDATE `*PREFIX*properties` SET `propertyvalue` = ?'.
246 246
 			' WHERE `userid` = ? AND `propertypath` = ? AND `propertyname` = ?';
247 247
 
248 248
 		// TODO: use "insert or update" strategy ?
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/Exception/InvalidPath.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -49,17 +49,17 @@
 block discarded – undo
49 49
 	 * @param \DOMElement $errorNode
50 50
 	 * @return void
51 51
 	 */
52
-	public function serialize(\Sabre\DAV\Server $server,\DOMElement $errorNode) {
52
+	public function serialize(\Sabre\DAV\Server $server, \DOMElement $errorNode) {
53 53
 
54 54
 		// set ownCloud namespace
55 55
 		$errorNode->setAttribute('xmlns:o', self::NS_OWNCLOUD);
56 56
 
57 57
 		// adding the retry node
58
-		$error = $errorNode->ownerDocument->createElementNS('o:','o:retry', var_export($this->retry, true));
58
+		$error = $errorNode->ownerDocument->createElementNS('o:', 'o:retry', var_export($this->retry, true));
59 59
 		$errorNode->appendChild($error);
60 60
 
61 61
 		// adding the message node
62
-		$error = $errorNode->ownerDocument->createElementNS('o:','o:reason', $this->getMessage());
62
+		$error = $errorNode->ownerDocument->createElementNS('o:', 'o:reason', $this->getMessage());
63 63
 		$errorNode->appendChild($error);
64 64
 	}
65 65
 }
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/Node.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -137,10 +137,10 @@  discard block
 block discarded – undo
137 137
 		// verify path of the target
138 138
 		$this->verifyPath();
139 139
 
140
-		$newPath = $parentPath . '/' . $newName;
140
+		$newPath = $parentPath.'/'.$newName;
141 141
 
142 142
 		if (!$this->fileView->rename($this->path, $newPath)) {
143
-			throw new \Sabre\DAV\Exception('Failed to rename '. $this->path . ' to ' . $newPath);
143
+			throw new \Sabre\DAV\Exception('Failed to rename '.$this->path.' to '.$newPath);
144 144
 		}
145 145
 
146 146
 		$this->path = $newPath;
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
 	public function getLastModified() {
161 161
 		$timestamp = $this->info->getMtime();
162 162
 		if (!empty($timestamp)) {
163
-			return (int)$timestamp;
163
+			return (int) $timestamp;
164 164
 		}
165 165
 		return $timestamp;
166 166
 	}
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
 	 * @return string
189 189
 	 */
190 190
 	public function getETag() {
191
-		return '"' . $this->info->getEtag() . '"';
191
+		return '"'.$this->info->getEtag().'"';
192 192
 	}
193 193
 
194 194
 	/**
@@ -235,7 +235,7 @@  discard block
 block discarded – undo
235 235
 		if ($this->info->getId()) {
236 236
 			$instanceId = \OC_Util::getInstanceId();
237 237
 			$id = sprintf('%08d', $this->info->getId());
238
-			return $id . $instanceId;
238
+			return $id.$instanceId;
239 239
 		}
240 240
 
241 241
 		return null;
@@ -272,7 +272,7 @@  discard block
 block discarded – undo
272 272
 
273 273
 		if ($storage && $storage->instanceOfStorage('\OCA\Files_Sharing\SharedStorage')) {
274 274
 			/** @var \OCA\Files_Sharing\SharedStorage $storage */
275
-			$permissions = (int)$storage->getShare()->getPermissions();
275
+			$permissions = (int) $storage->getShare()->getPermissions();
276 276
 		} else {
277 277
 			$permissions = $this->info->getPermissions();
278 278
 		}
@@ -414,6 +414,6 @@  discard block
 block discarded – undo
414 414
 			throw new \InvalidArgumentException('X-OC-MTime header must be an integer (unix timestamp).');
415 415
 		}
416 416
 
417
-		return (int)$mtimeFromRequest;
417
+		return (int) $mtimeFromRequest;
418 418
 	}
419 419
 }
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/QuotaPlugin.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
 			return;
93 93
 		}
94 94
 
95
-		return $this->checkQuota($parent->getPath() . '/' . basename($uri));
95
+		return $this->checkQuota($parent->getPath().'/'.basename($uri));
96 96
 	}
97 97
 
98 98
 	/**
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
 				// there is still enough space for the remaining chunks
164 164
 				$length -= $chunkHandler->getCurrentSize();
165 165
 				// use target file name for free space check in case of shared files
166
-				$path = rtrim($parentPath, '/') . '/' . $info['name'];
166
+				$path = rtrim($parentPath, '/').'/'.$info['name'];
167 167
 			}
168 168
 			$freeSpace = $this->getFreeSpace($path);
169 169
 			if ($freeSpace >= 0 && $length > $freeSpace) {
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/FilesReportPlugin.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -186,14 +186,14 @@  discard block
 block discarded – undo
186 186
 			return;
187 187
 		}
188 188
 
189
-		$ns = '{' . $this::NS_OWNCLOUD . '}';
189
+		$ns = '{'.$this::NS_OWNCLOUD.'}';
190 190
 		$requestedProps = [];
191 191
 		$filterRules = [];
192 192
 
193 193
 		// parse report properties and gather filter info
194 194
 		foreach ($report as $reportProps) {
195 195
 			$name = $reportProps['name'];
196
-			if ($name === $ns . 'filter-rules') {
196
+			if ($name === $ns.'filter-rules') {
197 197
 				$filterRules = $reportProps['value'];
198 198
 			} elseif ($name === '{DAV:}prop') {
199 199
 				// propfind properties
@@ -254,7 +254,7 @@  discard block
 block discarded – undo
254 254
 		if (empty($filesUri)) {
255 255
 			return '';
256 256
 		}
257
-		return '/' . $filesUri;
257
+		return '/'.$filesUri;
258 258
 	}
259 259
 
260 260
 	/**
@@ -266,19 +266,19 @@  discard block
 block discarded – undo
266 266
 	 * @throws TagNotFoundException whenever a tag was not found
267 267
 	 */
268 268
 	protected function processFilterRules($filterRules) {
269
-		$ns = '{' . $this::NS_OWNCLOUD . '}';
269
+		$ns = '{'.$this::NS_OWNCLOUD.'}';
270 270
 		$resultFileIds = null;
271 271
 		$systemTagIds = [];
272 272
 		$circlesIds = [];
273 273
 		$favoriteFilter = null;
274 274
 		foreach ($filterRules as $filterRule) {
275
-			if ($filterRule['name'] === $ns . 'systemtag') {
275
+			if ($filterRule['name'] === $ns.'systemtag') {
276 276
 				$systemTagIds[] = $filterRule['value'];
277 277
 			}
278 278
 			if ($filterRule['name'] === self::CIRCLE_PROPERTYNAME) {
279 279
 				$circlesIds[] = $filterRule['value'];
280 280
 			}
281
-			if ($filterRule['name'] === $ns . 'favorite') {
281
+			if ($filterRule['name'] === $ns.'favorite') {
282 282
 				$favoriteFilter = true;
283 283
 			}
284 284
 		}
@@ -326,7 +326,7 @@  discard block
 block discarded – undo
326 326
 			}
327 327
 
328 328
 			if (!empty($unknownTagIds)) {
329
-				throw new TagNotFoundException('Tag with ids ' . implode(', ', $unknownTagIds) . ' not found');
329
+				throw new TagNotFoundException('Tag with ids '.implode(', ', $unknownTagIds).' not found');
330 330
 			}
331 331
 		}
332 332
 
@@ -379,7 +379,7 @@  discard block
 block discarded – undo
379 379
 	public function prepareResponses($filesUri, $requestedProps, $nodes) {
380 380
 		$responses = [];
381 381
 		foreach ($nodes as $node) {
382
-			$propFind = new PropFind($filesUri . $node->getPath(), $requestedProps);
382
+			$propFind = new PropFind($filesUri.$node->getPath(), $requestedProps);
383 383
 
384 384
 			$this->server->getPropertiesByNode($propFind, $node);
385 385
 			// copied from Sabre Server's getPropertiesForPath
@@ -392,7 +392,7 @@  discard block
 block discarded – undo
392 392
 			}
393 393
 
394 394
 			$responses[] = new Response(
395
-				rtrim($this->server->getBaseUri(), '/') . $filesUri . $node->getPath(),
395
+				rtrim($this->server->getBaseUri(), '/').$filesUri.$node->getPath(),
396 396
 				$result,
397 397
 				200
398 398
 			);
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/ServerFactory.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -141,7 +141,7 @@
 block discarded – undo
141 141
 		}
142 142
 
143 143
 		// wait with registering these until auth is handled and the filesystem is setup
144
-		$server->on('beforeMethod:*', function () use ($server, $objectTree, $viewCallBack) {
144
+		$server->on('beforeMethod:*', function() use ($server, $objectTree, $viewCallBack) {
145 145
 			// ensure the skeleton is copied
146 146
 			$userFolder = \OC::$server->getUserFolder();
147 147
 
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/Auth.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -240,13 +240,13 @@
 block discarded – undo
240 240
 				\OC_Util::setupFS($user);
241 241
 				$this->currentUser = $user;
242 242
 				$this->session->close();
243
-				return [true, $this->principalPrefix . $user];
243
+				return [true, $this->principalPrefix.$user];
244 244
 			}
245 245
 		}
246 246
 
247 247
 		if (!$this->userSession->isLoggedIn() && in_array('XMLHttpRequest', explode(',', $request->getHeader('X-Requested-With')))) {
248 248
 			// do not re-authenticate over ajax, use dummy auth name to prevent browser popup
249
-			$response->addHeader('WWW-Authenticate','DummyBasic realm="' . $this->realm . '"');
249
+			$response->addHeader('WWW-Authenticate', 'DummyBasic realm="'.$this->realm.'"');
250 250
 			$response->setStatus(401);
251 251
 			throw new \Sabre\DAV\Exception\NotAuthenticated('Cannot authenticate over ajax calls');
252 252
 		}
Please login to merge, or discard this patch.
apps/dav/lib/Provisioning/Apple/AppleProvisioningPlugin.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
 	 * @return boolean
107 107
 	 */
108 108
 	public function httpGet(RequestInterface $request, ResponseInterface $response):bool {
109
-		if ($request->getPath() !== 'provisioning/' . AppleProvisioningNode::FILENAME) {
109
+		if ($request->getPath() !== 'provisioning/'.AppleProvisioningNode::FILENAME) {
110 110
 			return true;
111 111
 		}
112 112
 
@@ -144,19 +144,19 @@  discard block
 block discarded – undo
144 144
 		$carddavUUID = call_user_func($this->uuidClosure);
145 145
 		$profileUUID = call_user_func($this->uuidClosure);
146 146
 
147
-		$caldavIdentifier = $reverseDomain . '.' . $caldavUUID;
148
-		$carddavIdentifier = $reverseDomain . '.' . $carddavUUID;
149
-		$profileIdentifier = $reverseDomain . '.' . $profileUUID;
147
+		$caldavIdentifier = $reverseDomain.'.'.$caldavUUID;
148
+		$carddavIdentifier = $reverseDomain.'.'.$carddavUUID;
149
+		$profileIdentifier = $reverseDomain.'.'.$profileUUID;
150 150
 
151 151
 		$caldavDescription = $this->l10n->t('Configures a CalDAV account');
152
-		$caldavDisplayname = $description . ' CalDAV';
152
+		$caldavDisplayname = $description.' CalDAV';
153 153
 		$carddavDescription = $this->l10n->t('Configures a CardDAV account');
154
-		$carddavDisplayname = $description . ' CardDAV';
154
+		$carddavDisplayname = $description.' CardDAV';
155 155
 
156
-		$filename = $userId . '-' . AppleProvisioningNode::FILENAME;
156
+		$filename = $userId.'-'.AppleProvisioningNode::FILENAME;
157 157
 
158 158
 		$xmlSkeleton = $this->getTemplate();
159
-		$body = vsprintf($xmlSkeleton, array_map(function ($v) {
159
+		$body = vsprintf($xmlSkeleton, array_map(function($v) {
160 160
 			return \htmlspecialchars($v, ENT_XML1, 'UTF-8');
161 161
 		}, [
162 162
 			$description,
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
 		));
183 183
 
184 184
 		$response->setStatus(200);
185
-		$response->setHeader('Content-Disposition', 'attachment; filename="' . $filename . '"');
185
+		$response->setHeader('Content-Disposition', 'attachment; filename="'.$filename.'"');
186 186
 		$response->setHeader('Content-Type', 'application/xml; charset=utf-8');
187 187
 		$response->setBody($body);
188 188
 
Please login to merge, or discard this patch.