@@ -36,66 +36,66 @@ |
||
36 | 36 | * altered in order to retrigger SQL schema generation through OCSqlitePlatform. |
37 | 37 | */ |
38 | 38 | class SqliteAutoincrement implements IRepairStep { |
39 | - /** |
|
40 | - * @var \OC\DB\Connection |
|
41 | - */ |
|
42 | - protected $connection; |
|
39 | + /** |
|
40 | + * @var \OC\DB\Connection |
|
41 | + */ |
|
42 | + protected $connection; |
|
43 | 43 | |
44 | - /** |
|
45 | - * @param \OC\DB\Connection $connection |
|
46 | - */ |
|
47 | - public function __construct($connection) { |
|
48 | - $this->connection = $connection; |
|
49 | - } |
|
44 | + /** |
|
45 | + * @param \OC\DB\Connection $connection |
|
46 | + */ |
|
47 | + public function __construct($connection) { |
|
48 | + $this->connection = $connection; |
|
49 | + } |
|
50 | 50 | |
51 | - public function getName() { |
|
52 | - return 'Repair SQLite autoincrement'; |
|
53 | - } |
|
51 | + public function getName() { |
|
52 | + return 'Repair SQLite autoincrement'; |
|
53 | + } |
|
54 | 54 | |
55 | - /** |
|
56 | - * Fix mime types |
|
57 | - */ |
|
58 | - public function run(IOutput $out) { |
|
59 | - if (!$this->connection->getDatabasePlatform() instanceof SqlitePlatform) { |
|
60 | - return; |
|
61 | - } |
|
55 | + /** |
|
56 | + * Fix mime types |
|
57 | + */ |
|
58 | + public function run(IOutput $out) { |
|
59 | + if (!$this->connection->getDatabasePlatform() instanceof SqlitePlatform) { |
|
60 | + return; |
|
61 | + } |
|
62 | 62 | |
63 | - $sourceSchema = $this->connection->getSchemaManager()->createSchema(); |
|
63 | + $sourceSchema = $this->connection->getSchemaManager()->createSchema(); |
|
64 | 64 | |
65 | - $schemaDiff = new SchemaDiff(); |
|
65 | + $schemaDiff = new SchemaDiff(); |
|
66 | 66 | |
67 | - foreach ($sourceSchema->getTables() as $tableSchema) { |
|
68 | - $primaryKey = $tableSchema->getPrimaryKey(); |
|
69 | - if (!$primaryKey) { |
|
70 | - continue; |
|
71 | - } |
|
67 | + foreach ($sourceSchema->getTables() as $tableSchema) { |
|
68 | + $primaryKey = $tableSchema->getPrimaryKey(); |
|
69 | + if (!$primaryKey) { |
|
70 | + continue; |
|
71 | + } |
|
72 | 72 | |
73 | - $columnNames = $primaryKey->getColumns(); |
|
73 | + $columnNames = $primaryKey->getColumns(); |
|
74 | 74 | |
75 | - // add a column diff for every primary key column, |
|
76 | - // but do not actually change anything, this will |
|
77 | - // force the generation of SQL statements to alter |
|
78 | - // those tables, which will then trigger the |
|
79 | - // specific SQL code from OCSqlitePlatform |
|
80 | - try { |
|
81 | - $tableDiff = new TableDiff($tableSchema->getName()); |
|
82 | - $tableDiff->fromTable = $tableSchema; |
|
83 | - foreach ($columnNames as $columnName) { |
|
84 | - $columnSchema = $tableSchema->getColumn($columnName); |
|
85 | - $columnDiff = new ColumnDiff($columnSchema->getName(), $columnSchema); |
|
86 | - $tableDiff->changedColumns[] = $columnDiff; |
|
87 | - $schemaDiff->changedTables[] = $tableDiff; |
|
88 | - } |
|
89 | - } catch (SchemaException $e) { |
|
90 | - // ignore |
|
91 | - } |
|
92 | - } |
|
75 | + // add a column diff for every primary key column, |
|
76 | + // but do not actually change anything, this will |
|
77 | + // force the generation of SQL statements to alter |
|
78 | + // those tables, which will then trigger the |
|
79 | + // specific SQL code from OCSqlitePlatform |
|
80 | + try { |
|
81 | + $tableDiff = new TableDiff($tableSchema->getName()); |
|
82 | + $tableDiff->fromTable = $tableSchema; |
|
83 | + foreach ($columnNames as $columnName) { |
|
84 | + $columnSchema = $tableSchema->getColumn($columnName); |
|
85 | + $columnDiff = new ColumnDiff($columnSchema->getName(), $columnSchema); |
|
86 | + $tableDiff->changedColumns[] = $columnDiff; |
|
87 | + $schemaDiff->changedTables[] = $tableDiff; |
|
88 | + } |
|
89 | + } catch (SchemaException $e) { |
|
90 | + // ignore |
|
91 | + } |
|
92 | + } |
|
93 | 93 | |
94 | - $this->connection->beginTransaction(); |
|
95 | - foreach ($schemaDiff->toSql($this->connection->getDatabasePlatform()) as $sql) { |
|
96 | - $this->connection->query($sql); |
|
97 | - } |
|
98 | - $this->connection->commit(); |
|
99 | - } |
|
94 | + $this->connection->beginTransaction(); |
|
95 | + foreach ($schemaDiff->toSql($this->connection->getDatabasePlatform()) as $sql) { |
|
96 | + $this->connection->query($sql); |
|
97 | + } |
|
98 | + $this->connection->commit(); |
|
99 | + } |
|
100 | 100 | } |
101 | 101 |
@@ -25,17 +25,17 @@ |
||
25 | 25 | use OCP\DB\QueryBuilder\IQueryFunction; |
26 | 26 | |
27 | 27 | class QueryFunction implements IQueryFunction { |
28 | - /** @var string */ |
|
29 | - protected $function; |
|
28 | + /** @var string */ |
|
29 | + protected $function; |
|
30 | 30 | |
31 | - public function __construct($function) { |
|
32 | - $this->function = $function; |
|
33 | - } |
|
31 | + public function __construct($function) { |
|
32 | + $this->function = $function; |
|
33 | + } |
|
34 | 34 | |
35 | - /** |
|
36 | - * @return string |
|
37 | - */ |
|
38 | - public function __toString() { |
|
39 | - return (string) $this->function; |
|
40 | - } |
|
35 | + /** |
|
36 | + * @return string |
|
37 | + */ |
|
38 | + public function __toString() { |
|
39 | + return (string) $this->function; |
|
40 | + } |
|
41 | 41 | } |
@@ -25,17 +25,17 @@ |
||
25 | 25 | use OCP\DB\QueryBuilder\IParameter; |
26 | 26 | |
27 | 27 | class Parameter implements IParameter { |
28 | - /** @var mixed */ |
|
29 | - protected $name; |
|
28 | + /** @var mixed */ |
|
29 | + protected $name; |
|
30 | 30 | |
31 | - public function __construct($name) { |
|
32 | - $this->name = $name; |
|
33 | - } |
|
31 | + public function __construct($name) { |
|
32 | + $this->name = $name; |
|
33 | + } |
|
34 | 34 | |
35 | - /** |
|
36 | - * @return string |
|
37 | - */ |
|
38 | - public function __toString() { |
|
39 | - return (string) $this->name; |
|
40 | - } |
|
35 | + /** |
|
36 | + * @return string |
|
37 | + */ |
|
38 | + public function __toString() { |
|
39 | + return (string) $this->name; |
|
40 | + } |
|
41 | 41 | } |
@@ -25,32 +25,32 @@ |
||
25 | 25 | use Doctrine\DBAL\Schema\Schema; |
26 | 26 | |
27 | 27 | class PostgreSqlMigrator extends Migrator { |
28 | - /** |
|
29 | - * @param Schema $targetSchema |
|
30 | - * @param \Doctrine\DBAL\Connection $connection |
|
31 | - * @return \Doctrine\DBAL\Schema\SchemaDiff |
|
32 | - */ |
|
33 | - protected function getDiff(Schema $targetSchema, \Doctrine\DBAL\Connection $connection) { |
|
34 | - $schemaDiff = parent::getDiff($targetSchema, $connection); |
|
28 | + /** |
|
29 | + * @param Schema $targetSchema |
|
30 | + * @param \Doctrine\DBAL\Connection $connection |
|
31 | + * @return \Doctrine\DBAL\Schema\SchemaDiff |
|
32 | + */ |
|
33 | + protected function getDiff(Schema $targetSchema, \Doctrine\DBAL\Connection $connection) { |
|
34 | + $schemaDiff = parent::getDiff($targetSchema, $connection); |
|
35 | 35 | |
36 | - foreach ($schemaDiff->changedTables as $tableDiff) { |
|
37 | - // fix default value in brackets - pg 9.4 is returning a negative default value in () |
|
38 | - // see https://github.com/doctrine/dbal/issues/2427 |
|
39 | - foreach ($tableDiff->changedColumns as $column) { |
|
40 | - $column->changedProperties = array_filter($column->changedProperties, function ($changedProperties) use ($column) { |
|
41 | - if ($changedProperties !== 'default') { |
|
42 | - return true; |
|
43 | - } |
|
44 | - $fromDefault = $column->fromColumn->getDefault(); |
|
45 | - $toDefault = $column->column->getDefault(); |
|
46 | - $fromDefault = trim($fromDefault, "()"); |
|
36 | + foreach ($schemaDiff->changedTables as $tableDiff) { |
|
37 | + // fix default value in brackets - pg 9.4 is returning a negative default value in () |
|
38 | + // see https://github.com/doctrine/dbal/issues/2427 |
|
39 | + foreach ($tableDiff->changedColumns as $column) { |
|
40 | + $column->changedProperties = array_filter($column->changedProperties, function ($changedProperties) use ($column) { |
|
41 | + if ($changedProperties !== 'default') { |
|
42 | + return true; |
|
43 | + } |
|
44 | + $fromDefault = $column->fromColumn->getDefault(); |
|
45 | + $toDefault = $column->column->getDefault(); |
|
46 | + $fromDefault = trim($fromDefault, "()"); |
|
47 | 47 | |
48 | - // by intention usage of != |
|
49 | - return $fromDefault != $toDefault; |
|
50 | - }); |
|
51 | - } |
|
52 | - } |
|
48 | + // by intention usage of != |
|
49 | + return $fromDefault != $toDefault; |
|
50 | + }); |
|
51 | + } |
|
52 | + } |
|
53 | 53 | |
54 | - return $schemaDiff; |
|
55 | - } |
|
54 | + return $schemaDiff; |
|
55 | + } |
|
56 | 56 | } |
@@ -27,31 +27,31 @@ |
||
27 | 27 | |
28 | 28 | class AdapterMySQL extends Adapter { |
29 | 29 | |
30 | - /** @var string */ |
|
31 | - protected $charset; |
|
32 | - |
|
33 | - /** |
|
34 | - * @param string $tableName |
|
35 | - */ |
|
36 | - public function lockTable($tableName) { |
|
37 | - $this->conn->executeUpdate('LOCK TABLES `' .$tableName . '` WRITE'); |
|
38 | - } |
|
39 | - |
|
40 | - public function unlockTable() { |
|
41 | - $this->conn->executeUpdate('UNLOCK TABLES'); |
|
42 | - } |
|
43 | - |
|
44 | - public function fixupStatement($statement) { |
|
45 | - $statement = str_replace(' ILIKE ', ' COLLATE ' . $this->getCharset() . '_general_ci LIKE ', $statement); |
|
46 | - return $statement; |
|
47 | - } |
|
48 | - |
|
49 | - protected function getCharset() { |
|
50 | - if (!$this->charset) { |
|
51 | - $params = $this->conn->getParams(); |
|
52 | - $this->charset = isset($params['charset']) ? $params['charset'] : 'utf8'; |
|
53 | - } |
|
54 | - |
|
55 | - return $this->charset; |
|
56 | - } |
|
30 | + /** @var string */ |
|
31 | + protected $charset; |
|
32 | + |
|
33 | + /** |
|
34 | + * @param string $tableName |
|
35 | + */ |
|
36 | + public function lockTable($tableName) { |
|
37 | + $this->conn->executeUpdate('LOCK TABLES `' .$tableName . '` WRITE'); |
|
38 | + } |
|
39 | + |
|
40 | + public function unlockTable() { |
|
41 | + $this->conn->executeUpdate('UNLOCK TABLES'); |
|
42 | + } |
|
43 | + |
|
44 | + public function fixupStatement($statement) { |
|
45 | + $statement = str_replace(' ILIKE ', ' COLLATE ' . $this->getCharset() . '_general_ci LIKE ', $statement); |
|
46 | + return $statement; |
|
47 | + } |
|
48 | + |
|
49 | + protected function getCharset() { |
|
50 | + if (!$this->charset) { |
|
51 | + $params = $this->conn->getParams(); |
|
52 | + $this->charset = isset($params['charset']) ? $params['charset'] : 'utf8'; |
|
53 | + } |
|
54 | + |
|
55 | + return $this->charset; |
|
56 | + } |
|
57 | 57 | } |
@@ -22,31 +22,31 @@ |
||
22 | 22 | namespace OC\App\AppStore\Version; |
23 | 23 | |
24 | 24 | class Version { |
25 | - /** @var string */ |
|
26 | - private $minVersion; |
|
27 | - /** @var string */ |
|
28 | - private $maxVersion; |
|
25 | + /** @var string */ |
|
26 | + private $minVersion; |
|
27 | + /** @var string */ |
|
28 | + private $maxVersion; |
|
29 | 29 | |
30 | - /** |
|
31 | - * @param string $minVersion |
|
32 | - * @param string $maxVersion |
|
33 | - */ |
|
34 | - public function __construct($minVersion, $maxVersion) { |
|
35 | - $this->minVersion = $minVersion; |
|
36 | - $this->maxVersion = $maxVersion; |
|
37 | - } |
|
30 | + /** |
|
31 | + * @param string $minVersion |
|
32 | + * @param string $maxVersion |
|
33 | + */ |
|
34 | + public function __construct($minVersion, $maxVersion) { |
|
35 | + $this->minVersion = $minVersion; |
|
36 | + $this->maxVersion = $maxVersion; |
|
37 | + } |
|
38 | 38 | |
39 | - /** |
|
40 | - * @return string |
|
41 | - */ |
|
42 | - public function getMinimumVersion() { |
|
43 | - return $this->minVersion; |
|
44 | - } |
|
39 | + /** |
|
40 | + * @return string |
|
41 | + */ |
|
42 | + public function getMinimumVersion() { |
|
43 | + return $this->minVersion; |
|
44 | + } |
|
45 | 45 | |
46 | - /** |
|
47 | - * @return string |
|
48 | - */ |
|
49 | - public function getMaximumVersion() { |
|
50 | - return $this->maxVersion; |
|
51 | - } |
|
46 | + /** |
|
47 | + * @return string |
|
48 | + */ |
|
49 | + public function getMaximumVersion() { |
|
50 | + return $this->maxVersion; |
|
51 | + } |
|
52 | 52 | } |
@@ -23,118 +23,118 @@ |
||
23 | 23 | namespace OC\App\CodeChecker; |
24 | 24 | |
25 | 25 | abstract class AbstractCheck implements ICheck { |
26 | - /** @var ICheck */ |
|
27 | - protected $check; |
|
28 | - |
|
29 | - /** |
|
30 | - * @param ICheck $check |
|
31 | - */ |
|
32 | - public function __construct(ICheck $check) { |
|
33 | - $this->check = $check; |
|
34 | - } |
|
35 | - |
|
36 | - /** |
|
37 | - * @param int $errorCode |
|
38 | - * @param string $errorObject |
|
39 | - * @return string |
|
40 | - */ |
|
41 | - public function getDescription($errorCode, $errorObject) { |
|
42 | - switch ($errorCode) { |
|
43 | - case CodeChecker::STATIC_CALL_NOT_ALLOWED: |
|
44 | - $functions = $this->getLocalFunctions(); |
|
45 | - $functions = array_change_key_case($functions, CASE_LOWER); |
|
46 | - if (isset($functions[$errorObject])) { |
|
47 | - return $this->getLocalDescription(); |
|
48 | - } |
|
49 | - // no break; |
|
50 | - case CodeChecker::CLASS_EXTENDS_NOT_ALLOWED: |
|
51 | - case CodeChecker::CLASS_IMPLEMENTS_NOT_ALLOWED: |
|
52 | - case CodeChecker::CLASS_NEW_NOT_ALLOWED: |
|
53 | - case CodeChecker::CLASS_USE_NOT_ALLOWED: |
|
54 | - $classes = $this->getLocalClasses(); |
|
55 | - $classes = array_change_key_case($classes, CASE_LOWER); |
|
56 | - if (isset($classes[$errorObject])) { |
|
57 | - return $this->getLocalDescription(); |
|
58 | - } |
|
59 | - break; |
|
60 | - |
|
61 | - case CodeChecker::CLASS_CONST_FETCH_NOT_ALLOWED: |
|
62 | - $constants = $this->getLocalConstants(); |
|
63 | - $constants = array_change_key_case($constants, CASE_LOWER); |
|
64 | - if (isset($constants[$errorObject])) { |
|
65 | - return $this->getLocalDescription(); |
|
66 | - } |
|
67 | - break; |
|
68 | - |
|
69 | - case CodeChecker::CLASS_METHOD_CALL_NOT_ALLOWED: |
|
70 | - $methods = $this->getLocalMethods(); |
|
71 | - $methods = array_change_key_case($methods, CASE_LOWER); |
|
72 | - if (isset($methods[$errorObject])) { |
|
73 | - return $this->getLocalDescription(); |
|
74 | - } |
|
75 | - break; |
|
76 | - } |
|
77 | - |
|
78 | - return $this->check->getDescription($errorCode, $errorObject); |
|
79 | - } |
|
80 | - |
|
81 | - /** |
|
82 | - * @return string |
|
83 | - */ |
|
84 | - abstract protected function getLocalDescription(); |
|
85 | - |
|
86 | - /** |
|
87 | - * @return array |
|
88 | - */ |
|
89 | - abstract protected function getLocalClasses(); |
|
90 | - |
|
91 | - /** |
|
92 | - * @return array |
|
93 | - */ |
|
94 | - abstract protected function getLocalConstants(); |
|
95 | - |
|
96 | - /** |
|
97 | - * @return array |
|
98 | - */ |
|
99 | - abstract protected function getLocalFunctions(); |
|
100 | - |
|
101 | - /** |
|
102 | - * @return array |
|
103 | - */ |
|
104 | - abstract protected function getLocalMethods(); |
|
105 | - |
|
106 | - /** |
|
107 | - * @return array E.g.: `'ClassName' => 'oc version',` |
|
108 | - */ |
|
109 | - public function getClasses() { |
|
110 | - return array_merge($this->getLocalClasses(), $this->check->getClasses()); |
|
111 | - } |
|
112 | - |
|
113 | - /** |
|
114 | - * @return array E.g.: `'ClassName::CONSTANT_NAME' => 'oc version',` |
|
115 | - */ |
|
116 | - public function getConstants() { |
|
117 | - return array_merge($this->getLocalConstants(), $this->check->getConstants()); |
|
118 | - } |
|
119 | - |
|
120 | - /** |
|
121 | - * @return array E.g.: `'functionName' => 'oc version',` |
|
122 | - */ |
|
123 | - public function getFunctions() { |
|
124 | - return array_merge($this->getLocalFunctions(), $this->check->getFunctions()); |
|
125 | - } |
|
126 | - |
|
127 | - /** |
|
128 | - * @return array E.g.: `'ClassName::methodName' => 'oc version',` |
|
129 | - */ |
|
130 | - public function getMethods() { |
|
131 | - return array_merge($this->getLocalMethods(), $this->check->getMethods()); |
|
132 | - } |
|
133 | - |
|
134 | - /** |
|
135 | - * @return bool |
|
136 | - */ |
|
137 | - public function checkStrongComparisons() { |
|
138 | - return $this->check->checkStrongComparisons(); |
|
139 | - } |
|
26 | + /** @var ICheck */ |
|
27 | + protected $check; |
|
28 | + |
|
29 | + /** |
|
30 | + * @param ICheck $check |
|
31 | + */ |
|
32 | + public function __construct(ICheck $check) { |
|
33 | + $this->check = $check; |
|
34 | + } |
|
35 | + |
|
36 | + /** |
|
37 | + * @param int $errorCode |
|
38 | + * @param string $errorObject |
|
39 | + * @return string |
|
40 | + */ |
|
41 | + public function getDescription($errorCode, $errorObject) { |
|
42 | + switch ($errorCode) { |
|
43 | + case CodeChecker::STATIC_CALL_NOT_ALLOWED: |
|
44 | + $functions = $this->getLocalFunctions(); |
|
45 | + $functions = array_change_key_case($functions, CASE_LOWER); |
|
46 | + if (isset($functions[$errorObject])) { |
|
47 | + return $this->getLocalDescription(); |
|
48 | + } |
|
49 | + // no break; |
|
50 | + case CodeChecker::CLASS_EXTENDS_NOT_ALLOWED: |
|
51 | + case CodeChecker::CLASS_IMPLEMENTS_NOT_ALLOWED: |
|
52 | + case CodeChecker::CLASS_NEW_NOT_ALLOWED: |
|
53 | + case CodeChecker::CLASS_USE_NOT_ALLOWED: |
|
54 | + $classes = $this->getLocalClasses(); |
|
55 | + $classes = array_change_key_case($classes, CASE_LOWER); |
|
56 | + if (isset($classes[$errorObject])) { |
|
57 | + return $this->getLocalDescription(); |
|
58 | + } |
|
59 | + break; |
|
60 | + |
|
61 | + case CodeChecker::CLASS_CONST_FETCH_NOT_ALLOWED: |
|
62 | + $constants = $this->getLocalConstants(); |
|
63 | + $constants = array_change_key_case($constants, CASE_LOWER); |
|
64 | + if (isset($constants[$errorObject])) { |
|
65 | + return $this->getLocalDescription(); |
|
66 | + } |
|
67 | + break; |
|
68 | + |
|
69 | + case CodeChecker::CLASS_METHOD_CALL_NOT_ALLOWED: |
|
70 | + $methods = $this->getLocalMethods(); |
|
71 | + $methods = array_change_key_case($methods, CASE_LOWER); |
|
72 | + if (isset($methods[$errorObject])) { |
|
73 | + return $this->getLocalDescription(); |
|
74 | + } |
|
75 | + break; |
|
76 | + } |
|
77 | + |
|
78 | + return $this->check->getDescription($errorCode, $errorObject); |
|
79 | + } |
|
80 | + |
|
81 | + /** |
|
82 | + * @return string |
|
83 | + */ |
|
84 | + abstract protected function getLocalDescription(); |
|
85 | + |
|
86 | + /** |
|
87 | + * @return array |
|
88 | + */ |
|
89 | + abstract protected function getLocalClasses(); |
|
90 | + |
|
91 | + /** |
|
92 | + * @return array |
|
93 | + */ |
|
94 | + abstract protected function getLocalConstants(); |
|
95 | + |
|
96 | + /** |
|
97 | + * @return array |
|
98 | + */ |
|
99 | + abstract protected function getLocalFunctions(); |
|
100 | + |
|
101 | + /** |
|
102 | + * @return array |
|
103 | + */ |
|
104 | + abstract protected function getLocalMethods(); |
|
105 | + |
|
106 | + /** |
|
107 | + * @return array E.g.: `'ClassName' => 'oc version',` |
|
108 | + */ |
|
109 | + public function getClasses() { |
|
110 | + return array_merge($this->getLocalClasses(), $this->check->getClasses()); |
|
111 | + } |
|
112 | + |
|
113 | + /** |
|
114 | + * @return array E.g.: `'ClassName::CONSTANT_NAME' => 'oc version',` |
|
115 | + */ |
|
116 | + public function getConstants() { |
|
117 | + return array_merge($this->getLocalConstants(), $this->check->getConstants()); |
|
118 | + } |
|
119 | + |
|
120 | + /** |
|
121 | + * @return array E.g.: `'functionName' => 'oc version',` |
|
122 | + */ |
|
123 | + public function getFunctions() { |
|
124 | + return array_merge($this->getLocalFunctions(), $this->check->getFunctions()); |
|
125 | + } |
|
126 | + |
|
127 | + /** |
|
128 | + * @return array E.g.: `'ClassName::methodName' => 'oc version',` |
|
129 | + */ |
|
130 | + public function getMethods() { |
|
131 | + return array_merge($this->getLocalMethods(), $this->check->getMethods()); |
|
132 | + } |
|
133 | + |
|
134 | + /** |
|
135 | + * @return bool |
|
136 | + */ |
|
137 | + public function checkStrongComparisons() { |
|
138 | + return $this->check->checkStrongComparisons(); |
|
139 | + } |
|
140 | 140 | } |
@@ -22,47 +22,47 @@ |
||
22 | 22 | namespace OC\App\CodeChecker; |
23 | 23 | |
24 | 24 | class EmptyCheck implements ICheck { |
25 | - /** |
|
26 | - * @param int $errorCode |
|
27 | - * @param string $errorObject |
|
28 | - * @return string |
|
29 | - */ |
|
30 | - public function getDescription($errorCode, $errorObject) { |
|
31 | - return ''; |
|
32 | - } |
|
25 | + /** |
|
26 | + * @param int $errorCode |
|
27 | + * @param string $errorObject |
|
28 | + * @return string |
|
29 | + */ |
|
30 | + public function getDescription($errorCode, $errorObject) { |
|
31 | + return ''; |
|
32 | + } |
|
33 | 33 | |
34 | - /** |
|
35 | - * @return array E.g.: `'ClassName' => 'oc version',` |
|
36 | - */ |
|
37 | - public function getClasses() { |
|
38 | - return []; |
|
39 | - } |
|
34 | + /** |
|
35 | + * @return array E.g.: `'ClassName' => 'oc version',` |
|
36 | + */ |
|
37 | + public function getClasses() { |
|
38 | + return []; |
|
39 | + } |
|
40 | 40 | |
41 | - /** |
|
42 | - * @return array E.g.: `'ClassName::CONSTANT_NAME' => 'oc version',` |
|
43 | - */ |
|
44 | - public function getConstants() { |
|
45 | - return []; |
|
46 | - } |
|
41 | + /** |
|
42 | + * @return array E.g.: `'ClassName::CONSTANT_NAME' => 'oc version',` |
|
43 | + */ |
|
44 | + public function getConstants() { |
|
45 | + return []; |
|
46 | + } |
|
47 | 47 | |
48 | - /** |
|
49 | - * @return array E.g.: `'functionName' => 'oc version',` |
|
50 | - */ |
|
51 | - public function getFunctions() { |
|
52 | - return []; |
|
53 | - } |
|
48 | + /** |
|
49 | + * @return array E.g.: `'functionName' => 'oc version',` |
|
50 | + */ |
|
51 | + public function getFunctions() { |
|
52 | + return []; |
|
53 | + } |
|
54 | 54 | |
55 | - /** |
|
56 | - * @return array E.g.: `'ClassName::methodName' => 'oc version',` |
|
57 | - */ |
|
58 | - public function getMethods() { |
|
59 | - return []; |
|
60 | - } |
|
55 | + /** |
|
56 | + * @return array E.g.: `'ClassName::methodName' => 'oc version',` |
|
57 | + */ |
|
58 | + public function getMethods() { |
|
59 | + return []; |
|
60 | + } |
|
61 | 61 | |
62 | - /** |
|
63 | - * @return bool |
|
64 | - */ |
|
65 | - public function checkStrongComparisons() { |
|
66 | - return false; |
|
67 | - } |
|
62 | + /** |
|
63 | + * @return bool |
|
64 | + */ |
|
65 | + public function checkStrongComparisons() { |
|
66 | + return false; |
|
67 | + } |
|
68 | 68 | } |
@@ -23,57 +23,57 @@ |
||
23 | 23 | namespace OC\App\CodeChecker; |
24 | 24 | |
25 | 25 | class StrongComparisonCheck implements ICheck { |
26 | - /** @var ICheck */ |
|
27 | - protected $check; |
|
26 | + /** @var ICheck */ |
|
27 | + protected $check; |
|
28 | 28 | |
29 | - /** |
|
30 | - * @param ICheck $check |
|
31 | - */ |
|
32 | - public function __construct(ICheck $check) { |
|
33 | - $this->check = $check; |
|
34 | - } |
|
29 | + /** |
|
30 | + * @param ICheck $check |
|
31 | + */ |
|
32 | + public function __construct(ICheck $check) { |
|
33 | + $this->check = $check; |
|
34 | + } |
|
35 | 35 | |
36 | - /** |
|
37 | - * @param int $errorCode |
|
38 | - * @param string $errorObject |
|
39 | - * @return string |
|
40 | - */ |
|
41 | - public function getDescription($errorCode, $errorObject) { |
|
42 | - return $this->check->getDescription($errorCode, $errorObject); |
|
43 | - } |
|
36 | + /** |
|
37 | + * @param int $errorCode |
|
38 | + * @param string $errorObject |
|
39 | + * @return string |
|
40 | + */ |
|
41 | + public function getDescription($errorCode, $errorObject) { |
|
42 | + return $this->check->getDescription($errorCode, $errorObject); |
|
43 | + } |
|
44 | 44 | |
45 | - /** |
|
46 | - * @return array |
|
47 | - */ |
|
48 | - public function getClasses() { |
|
49 | - return $this->check->getClasses(); |
|
50 | - } |
|
45 | + /** |
|
46 | + * @return array |
|
47 | + */ |
|
48 | + public function getClasses() { |
|
49 | + return $this->check->getClasses(); |
|
50 | + } |
|
51 | 51 | |
52 | - /** |
|
53 | - * @return array |
|
54 | - */ |
|
55 | - public function getConstants() { |
|
56 | - return $this->check->getConstants(); |
|
57 | - } |
|
52 | + /** |
|
53 | + * @return array |
|
54 | + */ |
|
55 | + public function getConstants() { |
|
56 | + return $this->check->getConstants(); |
|
57 | + } |
|
58 | 58 | |
59 | - /** |
|
60 | - * @return array |
|
61 | - */ |
|
62 | - public function getFunctions() { |
|
63 | - return $this->check->getFunctions(); |
|
64 | - } |
|
59 | + /** |
|
60 | + * @return array |
|
61 | + */ |
|
62 | + public function getFunctions() { |
|
63 | + return $this->check->getFunctions(); |
|
64 | + } |
|
65 | 65 | |
66 | - /** |
|
67 | - * @return array |
|
68 | - */ |
|
69 | - public function getMethods() { |
|
70 | - return $this->check->getMethods(); |
|
71 | - } |
|
66 | + /** |
|
67 | + * @return array |
|
68 | + */ |
|
69 | + public function getMethods() { |
|
70 | + return $this->check->getMethods(); |
|
71 | + } |
|
72 | 72 | |
73 | - /** |
|
74 | - * @return bool |
|
75 | - */ |
|
76 | - public function checkStrongComparisons() { |
|
77 | - return true; |
|
78 | - } |
|
73 | + /** |
|
74 | + * @return bool |
|
75 | + */ |
|
76 | + public function checkStrongComparisons() { |
|
77 | + return true; |
|
78 | + } |
|
79 | 79 | } |