Passed
Push — master ( d0cf20...c1d359 )
by John
14:05 queued 12s
created
core/Command/Upgrade.php 1 patch
Spacing   +32 added lines, -32 removed lines patch added patch discarded remove patch
@@ -100,14 +100,14 @@  discard block
 block discarded – undo
100 100
 			$dispatcher = \OC::$server->getEventDispatcher();
101 101
 			$progress = new ProgressBar($output);
102 102
 			$progress->setFormat(" %message%\n %current%/%max% [%bar%] %percent:3s%%");
103
-			$listener = function ($event) use ($progress, $output) {
103
+			$listener = function($event) use ($progress, $output) {
104 104
 				if ($event instanceof GenericEvent) {
105 105
 					$message = $event->getSubject();
106 106
 					if (OutputInterface::VERBOSITY_NORMAL < $output->getVerbosity()) {
107
-						$output->writeln(' Checking table ' . $message);
107
+						$output->writeln(' Checking table '.$message);
108 108
 					} else {
109 109
 						if (strlen($message) > 60) {
110
-							$message = substr($message, 0, 57) . '...';
110
+							$message = substr($message, 0, 57).'...';
111 111
 						}
112 112
 						$progress->setMessage($message);
113 113
 						if ($event[0] === 1) {
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
 					}
124 124
 				}
125 125
 			};
126
-			$repairListener = function ($event) use ($progress, $output) {
126
+			$repairListener = function($event) use ($progress, $output) {
127 127
 				if (!$event instanceof GenericEvent) {
128 128
 					return;
129 129
 				}
@@ -149,19 +149,19 @@  discard block
 block discarded – undo
149 149
 						break;
150 150
 					case '\OC\Repair::step':
151 151
 						if (OutputInterface::VERBOSITY_NORMAL < $output->getVerbosity()) {
152
-							$output->writeln('<info>Repair step: ' . $event->getArgument(0) . '</info>');
152
+							$output->writeln('<info>Repair step: '.$event->getArgument(0).'</info>');
153 153
 						}
154 154
 						break;
155 155
 					case '\OC\Repair::info':
156 156
 						if (OutputInterface::VERBOSITY_NORMAL < $output->getVerbosity()) {
157
-							$output->writeln('<info>Repair info: ' . $event->getArgument(0) . '</info>');
157
+							$output->writeln('<info>Repair info: '.$event->getArgument(0).'</info>');
158 158
 						}
159 159
 						break;
160 160
 					case '\OC\Repair::warning':
161
-						$output->writeln('<error>Repair warning: ' . $event->getArgument(0) . '</error>');
161
+						$output->writeln('<error>Repair warning: '.$event->getArgument(0).'</error>');
162 162
 						break;
163 163
 					case '\OC\Repair::error':
164
-						$output->writeln('<error>Repair error: ' . $event->getArgument(0) . '</error>');
164
+						$output->writeln('<error>Repair error: '.$event->getArgument(0).'</error>');
165 165
 						break;
166 166
 				}
167 167
 			};
@@ -177,17 +177,17 @@  discard block
 block discarded – undo
177 177
 			$dispatcher->addListener('\OC\Repair::error', $repairListener);
178 178
 
179 179
 
180
-			$updater->listen('\OC\Updater', 'maintenanceEnabled', function () use ($output) {
180
+			$updater->listen('\OC\Updater', 'maintenanceEnabled', function() use ($output) {
181 181
 				$output->writeln('<info>Turned on maintenance mode</info>');
182 182
 			});
183
-			$updater->listen('\OC\Updater', 'maintenanceDisabled', function () use ($output) {
183
+			$updater->listen('\OC\Updater', 'maintenanceDisabled', function() use ($output) {
184 184
 				$output->writeln('<info>Turned off maintenance mode</info>');
185 185
 			});
186
-			$updater->listen('\OC\Updater', 'maintenanceActive', function () use ($output) {
186
+			$updater->listen('\OC\Updater', 'maintenanceActive', function() use ($output) {
187 187
 				$output->writeln('<info>Maintenance mode is kept active</info>');
188 188
 			});
189 189
 			$updater->listen('\OC\Updater', 'updateEnd',
190
-				function ($success) use ($output, $self) {
190
+				function($success) use ($output, $self) {
191 191
 					if ($success) {
192 192
 						$message = "<info>Update successful</info>";
193 193
 					} else {
@@ -195,46 +195,46 @@  discard block
 block discarded – undo
195 195
 					}
196 196
 					$output->writeln($message);
197 197
 				});
198
-			$updater->listen('\OC\Updater', 'dbUpgradeBefore', function () use ($output) {
198
+			$updater->listen('\OC\Updater', 'dbUpgradeBefore', function() use ($output) {
199 199
 				$output->writeln('<info>Updating database schema</info>');
200 200
 			});
201
-			$updater->listen('\OC\Updater', 'dbUpgrade', function () use ($output) {
201
+			$updater->listen('\OC\Updater', 'dbUpgrade', function() use ($output) {
202 202
 				$output->writeln('<info>Updated database</info>');
203 203
 			});
204
-			$updater->listen('\OC\Updater', 'incompatibleAppDisabled', function ($app) use ($output) {
205
-				$output->writeln('<comment>Disabled incompatible app: ' . $app . '</comment>');
204
+			$updater->listen('\OC\Updater', 'incompatibleAppDisabled', function($app) use ($output) {
205
+				$output->writeln('<comment>Disabled incompatible app: '.$app.'</comment>');
206 206
 			});
207
-			$updater->listen('\OC\Updater', 'checkAppStoreAppBefore', function ($app) use ($output) {
208
-				$output->writeln('<info>Checking for update of app ' . $app . ' in appstore</info>');
207
+			$updater->listen('\OC\Updater', 'checkAppStoreAppBefore', function($app) use ($output) {
208
+				$output->writeln('<info>Checking for update of app '.$app.' in appstore</info>');
209 209
 			});
210
-			$updater->listen('\OC\Updater', 'upgradeAppStoreApp', function ($app) use ($output) {
211
-				$output->writeln('<info>Update app ' . $app . ' from App Store</info>');
210
+			$updater->listen('\OC\Updater', 'upgradeAppStoreApp', function($app) use ($output) {
211
+				$output->writeln('<info>Update app '.$app.' from App Store</info>');
212 212
 			});
213
-			$updater->listen('\OC\Updater', 'checkAppStoreApp', function ($app) use ($output) {
214
-				$output->writeln('<info>Checked for update of app "' . $app . '" in App Store </info>');
213
+			$updater->listen('\OC\Updater', 'checkAppStoreApp', function($app) use ($output) {
214
+				$output->writeln('<info>Checked for update of app "'.$app.'" in App Store </info>');
215 215
 			});
216
-			$updater->listen('\OC\Updater', 'appSimulateUpdate', function ($app) use ($output) {
216
+			$updater->listen('\OC\Updater', 'appSimulateUpdate', function($app) use ($output) {
217 217
 				$output->writeln("<info>Checking whether the database schema for <$app> can be updated (this can take a long time depending on the database size)</info>");
218 218
 			});
219
-			$updater->listen('\OC\Updater', 'appUpgradeStarted', function ($app, $version) use ($output) {
219
+			$updater->listen('\OC\Updater', 'appUpgradeStarted', function($app, $version) use ($output) {
220 220
 				$output->writeln("<info>Updating <$app> ...</info>");
221 221
 			});
222
-			$updater->listen('\OC\Updater', 'appUpgrade', function ($app, $version) use ($output) {
222
+			$updater->listen('\OC\Updater', 'appUpgrade', function($app, $version) use ($output) {
223 223
 				$output->writeln("<info>Updated <$app> to $version</info>");
224 224
 			});
225
-			$updater->listen('\OC\Updater', 'failure', function ($message) use ($output, $self) {
225
+			$updater->listen('\OC\Updater', 'failure', function($message) use ($output, $self) {
226 226
 				$output->writeln("<error>$message</error>");
227 227
 			});
228
-			$updater->listen('\OC\Updater', 'setDebugLogLevel', function ($logLevel, $logLevelName) use ($output) {
228
+			$updater->listen('\OC\Updater', 'setDebugLogLevel', function($logLevel, $logLevelName) use ($output) {
229 229
 				$output->writeln("<info>Setting log level to debug</info>");
230 230
 			});
231
-			$updater->listen('\OC\Updater', 'resetLogLevel', function ($logLevel, $logLevelName) use ($output) {
231
+			$updater->listen('\OC\Updater', 'resetLogLevel', function($logLevel, $logLevelName) use ($output) {
232 232
 				$output->writeln("<info>Resetting log level</info>");
233 233
 			});
234
-			$updater->listen('\OC\Updater', 'startCheckCodeIntegrity', function () use ($output) {
234
+			$updater->listen('\OC\Updater', 'startCheckCodeIntegrity', function() use ($output) {
235 235
 				$output->writeln("<info>Starting code integrity check...</info>");
236 236
 			});
237
-			$updater->listen('\OC\Updater', 'finishedCheckCodeIntegrity', function () use ($output) {
237
+			$updater->listen('\OC\Updater', 'finishedCheckCodeIntegrity', function() use ($output) {
238 238
 				$output->writeln("<info>Finished code integrity check</info>");
239 239
 			});
240 240
 
@@ -272,8 +272,8 @@  discard block
 block discarded – undo
272 272
 		$trustedDomains = $this->config->getSystemValue('trusted_domains', []);
273 273
 		if (empty($trustedDomains)) {
274 274
 			$output->write(
275
-				'<warning>The setting "trusted_domains" could not be ' .
276
-				'set automatically by the upgrade script, ' .
275
+				'<warning>The setting "trusted_domains" could not be '.
276
+				'set automatically by the upgrade script, '.
277 277
 				'please set it manually</warning>'
278 278
 			);
279 279
 		}
Please login to merge, or discard this patch.
core/ajax/update.php 1 patch
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -90,16 +90,16 @@  discard block
 block discarded – undo
90 90
 				$this->eventSource->send('success', $this->l10n->t('[%d / %d]: %s', [$this->progressStateStep, $this->progressStateMax, $this->currentStep]));
91 91
 				break;
92 92
 			case '\OC\Repair::step':
93
-				$this->eventSource->send('success', $this->l10n->t('Repair step:') . ' ' . $event->getArgument(0));
93
+				$this->eventSource->send('success', $this->l10n->t('Repair step:').' '.$event->getArgument(0));
94 94
 				break;
95 95
 			case '\OC\Repair::info':
96
-				$this->eventSource->send('success', $this->l10n->t('Repair info:') . ' ' . $event->getArgument(0));
96
+				$this->eventSource->send('success', $this->l10n->t('Repair info:').' '.$event->getArgument(0));
97 97
 				break;
98 98
 			case '\OC\Repair::warning':
99
-				$this->eventSource->send('notice', $this->l10n->t('Repair warning:') . ' ' . $event->getArgument(0));
99
+				$this->eventSource->send('notice', $this->l10n->t('Repair warning:').' '.$event->getArgument(0));
100 100
 				break;
101 101
 			case '\OC\Repair::error':
102
-				$this->eventSource->send('notice', $this->l10n->t('Repair error:') . ' ' . $event->getArgument(0));
102
+				$this->eventSource->send('notice', $this->l10n->t('Repair error:').' '.$event->getArgument(0));
103 103
 				break;
104 104
 		}
105 105
 	}
@@ -128,12 +128,12 @@  discard block
 block discarded – undo
128 128
 	$incompatibleApps = [];
129 129
 
130 130
 	$dispatcher = \OC::$server->getEventDispatcher();
131
-	$dispatcher->addListener('\OC\DB\Migrator::executeSql', function ($event) use ($eventSource, $l) {
131
+	$dispatcher->addListener('\OC\DB\Migrator::executeSql', function($event) use ($eventSource, $l) {
132 132
 		if ($event instanceof GenericEvent) {
133 133
 			$eventSource->send('success', $l->t('[%d / %d]: %s', [$event[0], $event[1], $event->getSubject()]));
134 134
 		}
135 135
 	});
136
-	$dispatcher->addListener('\OC\DB\Migrator::checkTable', function ($event) use ($eventSource, $l) {
136
+	$dispatcher->addListener('\OC\DB\Migrator::checkTable', function($event) use ($eventSource, $l) {
137 137
 		if ($event instanceof GenericEvent) {
138 138
 			$eventSource->send('success', $l->t('[%d / %d]: Checking table %s', [$event[0], $event[1], $event->getSubject()]));
139 139
 		}
@@ -147,54 +147,54 @@  discard block
 block discarded – undo
147 147
 	$dispatcher->addListener('\OC\Repair::warning', [$feedBack, 'handleRepairFeedback']);
148 148
 	$dispatcher->addListener('\OC\Repair::error', [$feedBack, 'handleRepairFeedback']);
149 149
 
150
-	$updater->listen('\OC\Updater', 'maintenanceEnabled', function () use ($eventSource, $l) {
150
+	$updater->listen('\OC\Updater', 'maintenanceEnabled', function() use ($eventSource, $l) {
151 151
 		$eventSource->send('success', $l->t('Turned on maintenance mode'));
152 152
 	});
153
-	$updater->listen('\OC\Updater', 'maintenanceDisabled', function () use ($eventSource, $l) {
153
+	$updater->listen('\OC\Updater', 'maintenanceDisabled', function() use ($eventSource, $l) {
154 154
 		$eventSource->send('success', $l->t('Turned off maintenance mode'));
155 155
 	});
156
-	$updater->listen('\OC\Updater', 'maintenanceActive', function () use ($eventSource, $l) {
156
+	$updater->listen('\OC\Updater', 'maintenanceActive', function() use ($eventSource, $l) {
157 157
 		$eventSource->send('success', $l->t('Maintenance mode is kept active'));
158 158
 	});
159
-	$updater->listen('\OC\Updater', 'dbUpgradeBefore', function () use ($eventSource, $l) {
159
+	$updater->listen('\OC\Updater', 'dbUpgradeBefore', function() use ($eventSource, $l) {
160 160
 		$eventSource->send('success', $l->t('Updating database schema'));
161 161
 	});
162
-	$updater->listen('\OC\Updater', 'dbUpgrade', function () use ($eventSource, $l) {
162
+	$updater->listen('\OC\Updater', 'dbUpgrade', function() use ($eventSource, $l) {
163 163
 		$eventSource->send('success', $l->t('Updated database'));
164 164
 	});
165
-	$updater->listen('\OC\Updater', 'checkAppStoreAppBefore', function ($app) use ($eventSource, $l) {
165
+	$updater->listen('\OC\Updater', 'checkAppStoreAppBefore', function($app) use ($eventSource, $l) {
166 166
 		$eventSource->send('success', $l->t('Checking for update of app "%s" in App Store', [$app]));
167 167
 	});
168
-	$updater->listen('\OC\Updater', 'upgradeAppStoreApp', function ($app) use ($eventSource, $l) {
168
+	$updater->listen('\OC\Updater', 'upgradeAppStoreApp', function($app) use ($eventSource, $l) {
169 169
 		$eventSource->send('success', $l->t('Update app "%s" from App Store', [$app]));
170 170
 	});
171
-	$updater->listen('\OC\Updater', 'checkAppStoreApp', function ($app) use ($eventSource, $l) {
171
+	$updater->listen('\OC\Updater', 'checkAppStoreApp', function($app) use ($eventSource, $l) {
172 172
 		$eventSource->send('success', $l->t('Checked for update of app "%s" in App Store', [$app]));
173 173
 	});
174
-	$updater->listen('\OC\Updater', 'appSimulateUpdate', function ($app) use ($eventSource, $l) {
174
+	$updater->listen('\OC\Updater', 'appSimulateUpdate', function($app) use ($eventSource, $l) {
175 175
 		$eventSource->send('success', $l->t('Checking whether the database schema for %s can be updated (this can take a long time depending on the database size)', [$app]));
176 176
 	});
177
-	$updater->listen('\OC\Updater', 'appUpgrade', function ($app, $version) use ($eventSource, $l) {
177
+	$updater->listen('\OC\Updater', 'appUpgrade', function($app, $version) use ($eventSource, $l) {
178 178
 		$eventSource->send('success', $l->t('Updated "%1$s" to %2$s', [$app, $version]));
179 179
 	});
180
-	$updater->listen('\OC\Updater', 'incompatibleAppDisabled', function ($app) use (&$incompatibleApps) {
180
+	$updater->listen('\OC\Updater', 'incompatibleAppDisabled', function($app) use (&$incompatibleApps) {
181 181
 		$incompatibleApps[] = $app;
182 182
 	});
183
-	$updater->listen('\OC\Updater', 'failure', function ($message) use ($eventSource, $config) {
183
+	$updater->listen('\OC\Updater', 'failure', function($message) use ($eventSource, $config) {
184 184
 		$eventSource->send('failure', $message);
185 185
 		$eventSource->close();
186 186
 		$config->setSystemValue('maintenance', false);
187 187
 	});
188
-	$updater->listen('\OC\Updater', 'setDebugLogLevel', function ($logLevel, $logLevelName) use ($eventSource, $l) {
188
+	$updater->listen('\OC\Updater', 'setDebugLogLevel', function($logLevel, $logLevelName) use ($eventSource, $l) {
189 189
 		$eventSource->send('success', $l->t('Set log level to debug'));
190 190
 	});
191
-	$updater->listen('\OC\Updater', 'resetLogLevel', function ($logLevel, $logLevelName) use ($eventSource, $l) {
191
+	$updater->listen('\OC\Updater', 'resetLogLevel', function($logLevel, $logLevelName) use ($eventSource, $l) {
192 192
 		$eventSource->send('success', $l->t('Reset log level'));
193 193
 	});
194
-	$updater->listen('\OC\Updater', 'startCheckCodeIntegrity', function () use ($eventSource, $l) {
194
+	$updater->listen('\OC\Updater', 'startCheckCodeIntegrity', function() use ($eventSource, $l) {
195 195
 		$eventSource->send('success', $l->t('Starting code integrity check'));
196 196
 	});
197
-	$updater->listen('\OC\Updater', 'finishedCheckCodeIntegrity', function () use ($eventSource, $l) {
197
+	$updater->listen('\OC\Updater', 'finishedCheckCodeIntegrity', function() use ($eventSource, $l) {
198 198
 		$eventSource->send('success', $l->t('Finished code integrity check'));
199 199
 	});
200 200
 
@@ -205,7 +205,7 @@  discard block
 block discarded – undo
205 205
 			'level' => ILogger::ERROR,
206 206
 			'app' => 'update',
207 207
 		]);
208
-		$eventSource->send('failure', get_class($e) . ': ' . $e->getMessage());
208
+		$eventSource->send('failure', get_class($e).': '.$e->getMessage());
209 209
 		$eventSource->close();
210 210
 		exit();
211 211
 	}
Please login to merge, or discard this patch.