Completed
Push — master ( 39468f...49d871 )
by Björn
14:59
created
apps/user_ldap/lib/Access.php 1 patch
Doc Comments   +8 added lines, -6 removed lines patch added patch discarded remove patch
@@ -490,7 +490,7 @@  discard block
 block discarded – undo
490 490
 
491 491
 	/**
492 492
 	 * returns the internal Nextcloud name for the given LDAP DN of the user, false on DN outside of search DN or failure
493
-	 * @param string $dn the dn of the user object
493
+	 * @param string $fdn the dn of the user object
494 494
 	 * @param string $ldapName optional, the display name of the object
495 495
 	 * @return string|false with with the name to use in Nextcloud
496 496
 	 */
@@ -507,7 +507,7 @@  discard block
 block discarded – undo
507 507
 
508 508
 	/**
509 509
 	 * returns an internal Nextcloud name for the given LDAP DN, false on DN outside of search DN
510
-	 * @param string $dn the dn of the user object
510
+	 * @param string $fdn the dn of the user object
511 511
 	 * @param string $ldapName optional, the display name of the object
512 512
 	 * @param bool $isUser optional, whether it is a user object (otherwise group assumed)
513 513
 	 * @return string|false with with the name to use in Nextcloud
@@ -770,7 +770,7 @@  discard block
 block discarded – undo
770 770
 	 * the login filter.
771 771
 	 *
772 772
 	 * @param string $loginName
773
-	 * @param array $attributes optional, list of attributes to read
773
+	 * @param string[] $attributes optional, list of attributes to read
774 774
 	 * @return array
775 775
 	 */
776 776
 	public function fetchUsersByLoginName($loginName, $attributes = array('dn')) {
@@ -843,7 +843,7 @@  discard block
 block discarded – undo
843 843
 
844 844
 	/**
845 845
 	 * @param string $filter
846
-	 * @param string|string[] $attr
846
+	 * @param string[] $attr
847 847
 	 * @param int $limit
848 848
 	 * @param int $offset
849 849
 	 * @return array
@@ -891,7 +891,7 @@  discard block
 block discarded – undo
891 891
 
892 892
 	/**
893 893
 	 * @param string $filter
894
-	 * @param string|string[] $attr
894
+	 * @param string[] $attr
895 895
 	 * @param int $limit
896 896
 	 * @param int $offset
897 897
 	 * @return false|int
@@ -941,6 +941,7 @@  discard block
 block discarded – undo
941 941
 	 * retrieved. Results will according to the order in the array.
942 942
 	 * @param int $limit optional, maximum results to be counted
943 943
 	 * @param int $offset optional, a starting point
944
+	 * @param string $filter
944 945
 	 * @return array|false array with the search result as first value and pagedSearchOK as
945 946
 	 * second | false if not successful
946 947
 	 */
@@ -1191,7 +1192,7 @@  discard block
 block discarded – undo
1191 1192
 
1192 1193
 	/**
1193 1194
 	 * @param string $name
1194
-	 * @return bool|mixed|string
1195
+	 * @return string
1195 1196
 	 */
1196 1197
 	public function sanitizeUsername($name) {
1197 1198
 		if($this->connection->ldapIgnoreNamingRules) {
@@ -1215,6 +1216,7 @@  discard block
 block discarded – undo
1215 1216
 	* escapes (user provided) parts for LDAP filter
1216 1217
 	* @param string $input, the provided value
1217 1218
 	* @param bool $allowAsterisk whether in * at the beginning should be preserved
1219
+	* @param string $input
1218 1220
 	* @return string the escaped string
1219 1221
 	*/
1220 1222
 	public function escapeFilterPart($input, $allowAsterisk = false) {
Please login to merge, or discard this patch.